Skip to content

A
angle
Switch branch/tag
  1. 28 Sep, 2016 3 commits
    • Workaround isnan() on Intel drivers · 6f0a0dca
      Shao authored 
      On some Intel drivers, calling function isnan() on highp float will get wrong
answer. This patch work arounds this bug by using an expression to emulate
this function.

BUG=chromium:650547

Change-Id: I5bc5e0352c434f42cd2c55103a74f9f7ba51a72c
Reviewed-on: https://chromium-review.googlesource.com/389834
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    • Handle negation of minimum representable integer · 42fad76d
      Olli Etuaho authored 
      Negating the minimum representable integer overflows, so it
has undefined behavior in C++. Handle this as a special case in the
code.

BUG=chromium:637050
TEST=angle_unittests

Change-Id: Ic6e6d638faddad9b70b5d1637bb4b42ef4f43784
Reviewed-on: https://chromium-review.googlesource.com/390551Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
    • Fix handling integer overflow in constant folding · 1be4d493
      Olli Etuaho authored 
      Integer operations that overflow are defined to wrap in the ESSL
3.00.6 spec. Constant folding that happens inside the shader
translator should also follow the wrapping rules.

The new implementations of wrapping integer addition and subtraction
use unsigned integers to perform calculations. Unsigned integers are
defined to implement arithmetic in modulo 2^n in the C++ spec. This
behavior is also leveraged to implement wrapping unsigned integer
multiplication.

The implementation of wrapping signed integer multiplication is
slightly trickier. The operands are casted to a wider type to perform
the multiplication in a way that doesn't overflow, and then the result
is truncated and casted back to the narrower integer type.

Incorrect tests that expected errors to be generated from integer
overflow in constant folding are removed.

BUG=chromium:637050
TEST=angle_unittests

Change-Id: I0de7e25881d254803455fbf22907c192f49d09ff
Reviewed-on: https://chromium-review.googlesource.com/390252
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
  3. 27 Sep, 2016 5 commits
  5. 26 Sep, 2016 2 commits
  7. 23 Sep, 2016 5 commits
  9. 22 Sep, 2016 10 commits
  11. 21 Sep, 2016 3 commits
  13. 20 Sep, 2016 3 commits
  15. 19 Sep, 2016 3 commits
  17. 16 Sep, 2016 3 commits
  19. 15 Sep, 2016 3 commits