Commits · 775caee1acece88fc68bccc3056f5a65efcbfcac · Chen Yisong / angle

24 Mar, 2021 5 commits

Scripts: Ignore robin_hood headers in VVL · 775caee1

authored Mar 24, 2021

Needed to unblock vulkan-deps roll.

Example bad roll:
https://chromium-review.googlesource.com/c/angle/angle/+/2784701

Fallout from upstream changes:
https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/2639

TBR: jmadill@google.com
Bug: angleproject:5791
Change-Id: Idf4a0f6b4a7ef04e48d84110cd9d30887ebff9cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2784712Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

775caee1

Roll Chromium from f1617b736428 to bda1e3894abc (469 revisions) · 0c9f22d3

authored Mar 24, 2021

https://chromium.googlesource.com/chromium/src.git/+log/f1617b736428..bda1e3894abc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/b43166a3d1..cb055e229d
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/4e078437d0..731dd85349
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a9cb74b2b5..ada28b558f
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..25699ba498
* tools/luci-go: git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2
* tools/luci-go: git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2
* tools/luci-go: git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c94714a14b..772ad67f2e
* tools/skia_goldctl/linux: PgXVrZeDk45E9Zzaj8KYvPhJb728_zgB29afUe44XnUC..siMs1o8b-ON1wWPwvSA4NKhGMBXPWhkMQ3HHr7-yDqQC
* tools/skia_goldctl/mac: rhgkxpA8BkPWwXXCTUidbcE5xtFpN2UVjTfya2r4YJAC..77UQ9Zx-irz8MxBwN3CtYielGQtPthCIaWzlOONC8_MC
* tools/skia_goldctl/win: bMHjBq4De--lL7_Tr4K31mN6LR7hkSStHG_W34ogifYC..rLRz9NhcZkVWiGMr_kp9C1L_1QOynKyxdh-eu6REt4MC
No update to Clang.

Bug: None
Tbr: cnorthrop@google.com
Change-Id: If48fd51ba96e71909d3be086667bfc73fdd32a0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2782377
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0c9f22d3

Compression of the data from vkGetPipelineCacheData. · 1fb7f648

authored Mar 18, 2021

The size of pipelineCacheData sometimes is greater than
64k which cannot be saved because of the Android blob cache
limitation (single cache data size should be < 64k).
Implement the compression to store more cache data.

Re-land this patch before fixing the performance regression
of big pipeline cache.

Bug: angleproject:4722
Change-Id: I4bc05a88334c3e7e9e945d1a0877429db1750422
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2771840
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

1fb7f648

Vulkan: Fix gl_SamplePosition XY-flip and rotation. · 9f796506

authored Mar 23, 2021

In multi sample scenario, gl_SamplePosition is not
handled with XY-flip and rotation, add codes for
flip and rotation.

Bug: angleproject:5637
Test: dEQP-GLES31.functional.shaders.multisample_interpolation.
      interpolate_at_offset.at_sample_position.default_framebuffer
      --deqp-gl-config-name=rgba8888d24s8ms4
Test: dEQP-GLES31.functional.shaders.sample_variables.sample_pos.
      correctness.default_framebuffer
      --deqp-gl-config-name=rgba8888d24s8ms4
Change-Id: I7ba2227e85c62d2ca7bf534a841a1c3a5c9beb5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2781124Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

9f796506

[Fuchsia] Add ifndefs to vulkan_fuchsia_ext.h · 3fd439c2

authored Mar 23, 2021

This allows chromium to build with upstream headers that
include these extension. The old TEMP enums and structure
types are used until drivers have been updated to support
upstream header values.

Bug: chromium:1191605
Change-Id: I25d2991204ca34956298013138af8f48e0aaefaf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2782765
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

3fd439c2

23 Mar, 2021 11 commits

Vulkan: Use VK_EXT_multisampled_render_to_single_sampled · d1462228

authored Mar 09, 2021

Additionally, makes the emulation path not require
independentResolveNone.  This was only used to select the NONE resolve
mode when the attachment format doesn't have either of depth or stencil
aspects, but it's ok to specify the same resolve mode for both aspects
even if one aspect is missing.

Bug: chromium:1088005
Change-Id: Ifc37cbf5331145179c5927853b996a0d62b871ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743666Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

d1462228

Update ANGLEWrangling.md with Hotlist-Wrangler · c4da42e1

authored Mar 22, 2021

Bug: angleproject:5782
Change-Id: I6f808e6ece97dbc0166ba8f60b0cc31e783165a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779393
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

c4da42e1

Enable D3D11 debug names in ANGLE release builds · d809147f

authored Mar 22, 2021

Previously, D3D11 debug names were only output in debug builds. This
change enables them in release builds so we can debug GPU memory
consumption given traces or full memory dumps.

Where it made sense, existing names were shortened for brevity.
A future CL can shorten the names further by removing the words
texture, SRV, DSV, etc since D3D already outputs this type
information.

Bug: chromium:1164111
Change-Id: Iadd6222c29dd945115e844ec28ee395ce16c139f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780564
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d809147f

Disable timestamp queries for Mali-G31 and older GPUs · 90e3d86c

authored Mar 22, 2021

Bug: chromium:1178333
Change-Id: I8f21cd1c8f815a5cd7344778d2d1b28710dc6763
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779211Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>

90e3d86c

Revert "Save/Load missing members" · 2a43f43a

authored Mar 23, 2021

This reverts commit b2e76cf5.

Reason for revert: Causing MSan failures on Linux. See bug.

Bug: chromium:1191344

Original change's description:
> Save/Load missing members
>
> There are several class/struct members that are missing when a program
> is serialized/deserialized. This leads to errors when attempting to link
> programs that have been deserialized. For example, when drawing with a
> PPO that contains programs which were created with glProgramBinary().
>
> This CL adds saving/loading the missing members.
>
> Bug: b/182409935
> Change-Id: I637c6cd8c174acd6da8d51433893323a32e5d7c0
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770683
> Commit-Queue: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Cody Northrop <cnorthrop@google.com>

Bug: b/182409935
Change-Id: I1209257ed6bb55ba2d01d92bd3305d5e3ad6ee28
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780015Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2a43f43a

Vulkan: Rename Uniforms/XFB descriptor desc. · 572fd801

authored Mar 22, 2021

The new name is more consistent with the other names.

Refactoring change only.

Bug: angleproject:5736
Change-Id: Idc47fef29040e3a422267795c4536163a6f8eb4e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779953Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

572fd801

Roll Chromium from 3eced2421f5a to f1617b736428 (473 revisions) · e6ca472b

authored Mar 23, 2021

https://chromium.googlesource.com/chromium/src.git/+log/3eced2421f5a..f1617b736428

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/120a8d610c..b43166a3d1
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f13f2e366c..a9cb74b2b5
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..de74236cf7
* tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e
* tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e
* tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e
* tools/skia_goldctl/linux: PFAC9ipfkYe6ZljRb8758leyPy7Jw6Dhl2dtHp0IsMYC..PgXVrZeDk45E9Zzaj8KYvPhJb728_zgB29afUe44XnUC
* tools/skia_goldctl/mac: Ht0L_bool7JJxm1K8Y4MzgKRlPhoIYiVaHruwzqROMEC..rhgkxpA8BkPWwXXCTUidbcE5xtFpN2UVjTfya2r4YJAC
* tools/skia_goldctl/win: 3Z3zEAwtATXaw6OCunrkLRtBDiMoKW34b_yeMZ82eocC..bMHjBq4De--lL7_Tr4K31mN6LR7hkSStHG_W34ogifYC
No update to Clang.

Bug: angleproject:5768
Tbr: cnorthrop@google.com
Change-Id: I82f74de7812ba075f6c3cd9fa0b4d724df876669
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779806
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e6ca472b

Tests: Add Real Cricket 20 trace · 48560f67

authored Mar 19, 2021

Test: angle_perftests --gtest_filter="*real_cricket_20*"
Bug: b/183165790
Bug: angleproject:5777
Change-Id: I1f350e3ea458a599396412e2c5ca80d6c7887d73
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776554
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

48560f67

Fix copyright dates of new test files per Shabi · c4b1f366

authored Mar 22, 2021

Bug: b/181711029
Change-Id: Ie619ba90f699dd8234cf185198cb6eeac9142758
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780560Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

c4b1f366

Vulkan: Add test for filament gltf usage case · ef17c650

authored Mar 08, 2021

filament gltf sample code is rendering to a level that is excluded from
[base_level, max_level]. This is allowed by OpenGL spec. We are crashing
right not. This CL adds tests for the exact usage pattern for filament.

Bug: b/181800403
Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBeyondMaxLevel
Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithSubImageWithBeyondMaxLevel
Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBellowBaseLevelLOD
Change-Id: I69bab8bc3961bbc2dcc78ba2db3c8759f277416b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752897
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

ef17c650

Save/Load missing members · b2e76cf5

authored Mar 17, 2021

There are several class/struct members that are missing when a program
is serialized/deserialized. This leads to errors when attempting to link
programs that have been deserialized. For example, when drawing with a
PPO that contains programs which were created with glProgramBinary().

This CL adds saving/loading the missing members.

Bug: b/182409935
Change-Id: I637c6cd8c174acd6da8d51433893323a32e5d7c0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770683
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

b2e76cf5

22 Mar, 2021 10 commits

Tests: Add android log library to traces · 4386840c

authored Mar 19, 2021

This is required in order to call __android_log_print, which can
be sprinkled into the trace for debugging.

Bug: b/183165790
Change-Id: I717f2ac7809172f22b7badee6f1096394a02bc14
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776553Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

4386840c

Reorder ShaderVariable functions and members · 34e28778

authored Mar 17, 2021

ShaderVariable's functions and members are all mixed up. This CL
reorders things to move the functions before the members, to better
match ANGLE's coding style.

This also adds a note that any new members that are added need to be
added to gl::WriteShaderVar() and gl::LoadShaderVar(), which are
actually implemented in Program.cpp, since ShaderVars.h/cpp can't
include libANGLE/BinaryStream.h. There are currently several members
that are missing, leading to save/load errors, which are fixed in a
follow-on CL in this chain.

Bug: b/182409935
Change-Id: I1381a5efffb56c0989961bbcfd405b95d59d6396
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770682
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

34e28778

Handle inactive structure type varyings correctly · 2be71410

authored Mar 19, 2021

Correctly handle inactive varyings of structure type when collecting
transform feedback varyings. Previously, all varyings of structure type
were marked as active by mistake.

Bug: angleproject:5557
Test: TransformFeedbackTest.InactiveStructureVarying*
Change-Id: Ica1cbce5c551cdbb97999eeac59d09a961937615
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770680
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

2be71410

Vulkan: Handle compilation error involving gl_InvocationID · 570970f9

authored Mar 19, 2021

We need to generate a compiler error only when the vertex index
of an output variable as an l-value, in a tessellation control shader,
is not the indentifier gl_InvocationID.

Bug: angleproject:5557
Tests: dEQP-GLES31.functional.tessellation.shader_input_output.barrier
Change-Id: Ica075b8d85916caa228f057b203ae81b27f65e2d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2758915Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

570970f9

Vulkan: Rename onImageHelperRelease to finalizeImageLayout · 81432c24

authored Mar 19, 2021

Make the API name reflect what it does. With recent changes, this get
called from places that are not releasing ImageHelper object, but is try
to reference the current layout. This new name makes more sense than
onImageHelperRelease (at that time when this API was introduced, it was
only called when ImageHelper is being released).

Bug: b/175584609
Change-Id: Ie5f5fcdbd97436724d7eb016374d8b4178e7ba1d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776261
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

81432c24

Vulkan: More cleanups to perf counters. · 02acc5ee

authored Mar 18, 2021

This refactors the pipeline type in the ContextVk class to also use
a packed enum map. It also expands the object perf counters to store
both a specific and cumulative version for use in different cases.

Bug: angleproject:5736
Change-Id: I6ff78e38065eb577f2b95b1d9c4f9cc31d7f325f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774184Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

02acc5ee

Tests: Add Avakin Life - 3D Virtual World trace · ecbd870f

authored Mar 21, 2021

Test: angle_perftest --gtest_filter="*avakin_life*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/183344915
Bug: angleproject:5779
Change-Id: Iaf2d8341055d5b7c6f3c8a7a7a1fb3d1399fabc5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776746Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

ecbd870f

Skip ResizeWindow test on Linux. · 0380f115

authored Mar 18, 2021

ARM Linux doesn't support window surface resize.

Bug: angleproject:4453
Change-Id: Ia8631f5191c2b3ebd822766cc7f92275aa62dff3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2777578
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

0380f115

Vulkan: Don't acquire new BufferHelper for external buffers · 7fe44a53

authored Mar 20, 2021

EXT_external_buffer spec -
    This extension allows the data store for an immutable buffer to be
    sourced from an external EGLClientBuffer, allowing sharing of EGL
    client buffers across APIs, across processes, and across different
    processing cores such as the GPU, CPU, and DSP.

The intent is for a single backing memory to be reused across various
processes and processors. Ensure that a glBuffer backed by external
memory does not orphan the memory when glBuffer APIs like
glBufferSubData or glMapBufferRangeEXT modify the glBuffer.

Bug: angleproject:4380
Bug: angleproject:5073
Tests: ExternalBufferTestES31.*DoesNotCauseOrphaning*Vulkan
Change-Id: I4e88f80d93ee1ba1208378121412926351d10af8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776192
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7fe44a53

Roll Chromium from c33e21cce932 to 3eced2421f5a (477 revisions) · 7e9b497c

authored Mar 22, 2021

https://chromium.googlesource.com/chromium/src.git/+log/c33e21cce932..3eced2421f5a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/ba8be7fd2f..120a8d610c
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/55b74c093b..f13f2e366c
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..999f35f30e
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9629038820..24cecabb89
* tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb
* tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb
* tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df4e23350e..c94714a14b
* tools/skia_goldctl/linux: GNchtrcB6qbKJwI4p-GTx1VGkCUsAWxKyn2kIXkyMZcC..PFAC9ipfkYe6ZljRb8758leyPy7Jw6Dhl2dtHp0IsMYC
* tools/skia_goldctl/mac: 0r4l0jSQ08UrxS6-MUtgrn6DegnbVTPg-1I_HWxO3JsC..Ht0L_bool7JJxm1K8Y4MzgKRlPhoIYiVaHruwzqROMEC
* tools/skia_goldctl/win: _LtAsLqSVwpOUShHDIbQWgtPXUO4xbpf1MDMcloIAdQC..3Z3zEAwtATXaw6OCunrkLRtBDiMoKW34b_yeMZ82eocC
No update to Clang.

Bug: None
Tbr: timvp@google.com
Change-Id: Ia49b1a9a909ceea201b65fd2f8d823e967a90ffa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776747
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7e9b497c

21 Mar, 2021 1 commit

Add multi-thread/context test for compute shaders · 90cf278c

authored Mar 19, 2021

The "Ragnarok M: Eternal Love" game uncovered a bug where 2 contexts
shared a VkCommandBuffer.  The one context was used by one thread for
rendering, and the other context/thread dispatched compute shaders.
When the rendering thread destroyed a VkCommandBuffer, future compute
dispatches crashed because the new VkCommandBuffer didn't have a
compute pipeline bound.

Bug: b/181711029
Change-Id: I8bc85150c1c6202e02feb84a7ccc0ad7b9c39258
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770681
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

90cf278c

20 Mar, 2021 1 commit

Disable EGL_EXT_buffer_age for SwiftShader Vulkan · 135385a1

authored Mar 19, 2021

Cuttlefish with SwANGLE failed to pass the android.graphics.cts.
BitmapTest#testDrawingHardwareBitmapNotLeaking test, due to a timeout in
dequeueBuffer (error = -110) during an EGL_BUFFER_AGE_EXT surface query.

This change conservatively works around the issue by leaving
EGL_EXT_buffer_age support disabled for SwiftShader.

Further investigation is required to check whether this timeout can also
occur with other Vulkan drivers, and if it can be addressed robustly.

Bug: b/182521420
Bug: angleproject:3529
Change-Id: I54e3767e74bf922f273d8860f9f4cfc8b6589536
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774030Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>

135385a1

19 Mar, 2021 9 commits

Vulkan: Add VUID-vkCmdDraw-None-04584 validation error to ignore list · d5bc8a27

authored Mar 17, 2021

Aztec ruins is using the same texture (but different level controlled by
a uniform variable) for textureLod and rendering. This triggers vulkan
validation error. This CL put it in the ignore list so that it can pass.

Bug: b/175584609
Change-Id: I7623e7b448514b3c12268aa5fe154f4c2f59b059
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770686
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d5bc8a27

Vulkan: Track images used for both attachment and sampler · 867411a4

authored Mar 08, 2021

This CL adds a new layout ImageLayout::ColorAttachmentAndShaderRead. We
detect that the same ImageHelper object is used for both sampler and
attachment and will pick this new layout instead of ColorAttachment.

Bug: b/175584609
Change-Id: I2089f59d4dc1ad4de7edab0e067797adcfa9b020
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2749479
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

867411a4

Add isYUV to angle::Format · 5163cd0c

authored Mar 18, 2021

In preparation for adding support for more YUV formats
add an 'isYUV' field that tracks whether a format is a
YUV format. For now it is set if the format string contains
the substring 'PLANE'. This is not the case for all known YUV
formats but the condition can be expanded when required.

Bug: angleproject:5773
Change-Id: Icb574037dc8105584931835dab0b60e8bafa3262
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774762Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

5163cd0c

Vulkan: Defer color image layout changes at endRenderPass time · da437f26

authored Mar 08, 2021

Right now color render target's image's layout change are done at
beginRenderPass time. The problem is that the layout also depends on
whether texture is also being used as a sampler or not. That information
is not known when renderpass starts. We did some special treatment for
depth stencil attachment so that its layout determination is deferred
until endRenderPass time. This CL expands that same mechanism to color
attachment as well. Right now the color attachment will still pick the
same ImageLayout::ColorAttachment layout since the logic to detect it is
also used for texture sampling is not there yet.

Bug: b/175584609
Change-Id: Id7486174d475f894461578b31d0d40fdd90e808a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2744121Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>

da437f26

D3D: Mark images dirty after recovering from storage · 0a80f2e1

authored Mar 15, 2021

When images are recovered from storage due to resizing storage, they
were marked as clean and not always re-copied to the new storage.

Bug: angleproject:5757
Bug: chromium:1188854
Change-Id: Idd11025820433ab74ff769cd9508efcec4575c32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2763282Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

0a80f2e1

Roll vulkan-deps from 6ea3512e6349 to 91a2a0b15f23 (6 revisions) · 5067fccf

authored Mar 19, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/6ea3512e6349..91a2a0b15f23

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/d18bcd64fa..979319b9b1
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4f498774db..a732e4c03c
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d5bf0be344..309d9bea09

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ifb1845a82a8ae3c3cd19e7023bb20048a6486ff3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774761
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5067fccf

Roll Chromium from e7ef5f7d0368 to c33e21cce932 (451 revisions) · 15a1e735

authored Mar 19, 2021

https://chromium.googlesource.com/chromium/src.git/+log/e7ef5f7d0368..c33e21cce932

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/17a38f4bb2..ba8be7fd2f
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c93be42a40..4e078437d0
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3b69bfd940..55b74c093b
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8e820e32d0..74cb518d98
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c730daef75
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/168ccba7af..9629038820
* tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6
* tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6
* tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c98db359fc..df4e23350e
* tools/skia_goldctl/linux: NQmBkXHpEXJthTy0c6iuXDk1UgYDyQ7Fm649E7P38bAC..GNchtrcB6qbKJwI4p-GTx1VGkCUsAWxKyn2kIXkyMZcC
* tools/skia_goldctl/mac: Rbel_7KQuxv_-SIkB3oT43MBYgKlr3AUwFystGNHKJ8C..0r4l0jSQ08UrxS6-MUtgrn6DegnbVTPg-1I_HWxO3JsC
* tools/skia_goldctl/win: 3sDKbIeT1dc4BYnE_uMfW71xbKa-b75KWLUwVEIJF-QC.._LtAsLqSVwpOUShHDIbQWgtPXUO4xbpf1MDMcloIAdQC
No update to Clang.

Bug: None
Tbr: timvp@google.com
Change-Id: I36906d996c7474ebf61c329ad7622f32c00ec960
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774452
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

15a1e735

Tests: Add Ragnarok M: Eternal Love trace · 9b3b5733

authored Mar 17, 2021

Test: angle_perftests --gtest_filter="*ragnarok_m_eternal_love*"
TBR: timvp@google.com,jmadill@google.com
Bug: b/181800519
Bug: angleproject:5772
Change-Id: I1dcde486e909f7c2b5d59132e5f673c7e8ab1d01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774264Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

9b3b5733

Fix the assert error and inbalence parens for SSBO · ba0bd785

authored Mar 15, 2021

This PR strengthens below two cases:
1. Support calculate unsized array size for any type. Previously,
it reported error when the type was a structure.
2. Correctly add the right paren for store function when any
load/length functions are nested in it.

Bug: angleproject:5734
Change-Id: I3428fa35f1481275e1d193094ceddb011f747cf1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762655Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

ba0bd785

18 Mar, 2021 3 commits

Vulkan: Use packed enum map for descriptor set index. · b717952e

authored Mar 18, 2021

This simplifies a lot of the data structure indexing in the program
executable class. Also renames the "DriverUniforms" and
"InternalShader" index into a single "Internal" index.

Bug: angleproject:5736
Change-Id: I2a51d8b14d5b16b438dbe636f77b11bbc045ba9a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773321
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

b717952e

Vulkan: Clean up shader buffer DS allocation. · 1b08cfcb

authored Mar 18, 2021

We were using repeated code patterns in several places.

Bug: angleproject:5736
Change-Id: I206783dd792c3b0f9d38027235445ec600a60d88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773320Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1b08cfcb

Vulkan: Move CommandBufferHelper::reset() closer to constructor · 378b3261

authored Mar 08, 2021

This is a mechanical change. Similar to constructor, the reset()
function is doing initialization of data members. Move them next to each
other helps adding a new data members which requires modifications to
both functions.

Bug: b/175584609
Change-Id: I11386677bc5c9838104025d6a4ecf6f2b58fa92c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745842Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

378b3261