- 21 Jul, 2020 2 commits
-
-
Ian Elliott authored
Split FramebufferVk::getCompleteRenderArea() into 2, [non-]rotated, explicitly-named methods. Simplify the uses of these methods, and fix some rotation cases. Also explicitly-name FramebufferVk::getScissoredRenderArea(). Bug: b/151111296 Change-Id: I1754ec2796fd8625b916a2dba2e723e70ecba419 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305389Reviewed-by:
Charlie Lao <cclao@google.com> Reviewed-by:
Ian Elliott <ianelliott@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Charlie Lao authored
This is follow up to https://chromium-review.googlesource.com/c/angle/angle/+/2288325. There is no need to add current buffer to mResourceUseList for the per context dynamic buffers. These dynamic buffers always shut down after we call finishImpl. Bug: b/160777679 Change-Id: I013cb3c30b4d31804cee13ce9e42da381fd1ae1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300208 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com>
-
- 20 Jul, 2020 12 commits
-
-
Shahbaz Youssefi authored
Objects of this class are used as keys to a hash map and contain 10 serials. Prior to this change, operator== would compare all 10 serials. This change tracks the maximum index set and only compares up to that many serials. To make sure this maximum index stays low in the presence of depth/stencil attachment, this class stores the depth/stencil attachment's serial before the color attachments. The update API of the class is improved so this implementation detail is not leaked. This is in preparation for supporting resolve attachments, which would add another 8 serials to the class. With this change, the performance of cases that don't use resolve attachments won't be affected. Bug: angleproject:4836 Change-Id: Ia4874ab79163901fb86f5bee4120e9f19babdc09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306514 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Charlie Lao authored
And merge that with TheNUllBuffer as well so that you only have one dummy buffer per context. Bug: b/161391337 Change-Id: I75fddb5c48393876e745ff237e11d9c5672ae10e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300707 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Ian Elliott authored
For applications that frequently change the texture max level, to a value that is a subset of the texture's maximum levels, just recreate the VkImageView's. Test: NBA 2K20 game play Bug: b/160976091 Change-Id: I62a05a90cdb90147056ba8cec960c2114479ec37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300532Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Geoff Lang authored
Bug: chromium:1100599 Change-Id: I7bc2c2e35490e28e9f6fe8f2e0c26cdea50650b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2275731Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
-
Cody Northrop authored
While debugging NBA2K20 MEC, fixed the following issues: * Don't bind built-in attributes locations. * Don't emit glGenBuffers for the default VAO. * Include element array buffer in MEC. Test: NBA2K20 MEC Bug: b/160014453 Change-Id: I1b809946d67b6748b0670814be8dd090278dc38f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307276Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Manh Nguyen <nguyenmh@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Jamie Madill authored
Noticed when working on a related feature. Bug: angleproject:3630 Change-Id: I82638d37ee6d27dc824d5782c96387f0d000d585 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305040Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/412b1b7dd18c..b1346703979e 2020-07-17 40687079+rumblehhh@users.noreply.github.com corechecks: Default init ACCELERATION_STRUCTURE_STATE members 2020-07-17 locke@lunarg.com syval: Get sub extent by aspect 2020-07-17 locke@lunarg.com tests: Add comment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I72073f78cd0df32d9695b84222dfb96174dd3f51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307057Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/858b13a1220a..83825d55c7d5 2020-07-20 oddhack@sonic.net Update for Vulkan-Docs 1.2.148 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: I8963f84e3fac3b06974e23843617c9014ba0f39f Bug: None Tbr: timvp@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307169Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0a8f44c514ce..ea6f21a052c9 2020-07-18 capn@google.com Fix GN UBSanVPtr build of LLVM 10 JIT 2020-07-17 amaiorano@google.com Fix Win32 Chromium and ANGLE builds 2020-07-17 capn@google.com Remove Travis CI and AppVeyor build badges 2020-07-17 capn@google.com Update Kokoro's clang-format to version 10 2020-07-17 amaiorano@google.com Fix MacOS Chromium build (source_set dupe) 2020-07-16 amaiorano@google.com Fix MacOS (darwin) Chromium build on LLVM 10 2020-07-16 amaiorano@google.com Added Fuchsia support to LLVM 10 update script and updated configs 2020-07-16 amaiorano@google.com Use LLVM 10 instead of 7 for GN builds 2020-07-16 cwallez@chromium.org Fix B<->T copies of multiple array layers and unpacked rowpitch If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:4851 Tbr: jonahr@google.com Change-Id: I516b970e7a306734cd85238c405e9ba7a87c68bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307061Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/d093d9723b7c..50e737c82347 2020-07-17 tony@lunarg.com cube: Add option to select phys device If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I6e85f604ceb2b24bd27a649ff3c7a6abdf4c478b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307060Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/680c77fa6c81..717e7877cac1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I9f0c0fb29bed6084993c482c1061346a3da18e54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307059Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f3cb1896971f..9eef54b2513c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I6b0a7504f58c6d6b51c8f4438ca9389a038b399e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307058Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 18 Jul, 2020 1 commit
-
-
Kenneth Russell authored
Emulate GL_PACK_SKIP_PIXELS and GL_PACK_SKIP_ROWS on macOS, where it appears the OpenGL driver ignores these parameters. Add WebGL 2.0-specific validation constraints for pixel pack and unpack parameters. Bug: angleproject:4849 Change-Id: Iab566299223e05484a009817acb1ed2816023823 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2303905 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
- 17 Jul, 2020 11 commits
-
-
Courtney Goeltzenleuchter authored
Cleared confusion between GL level indices and VK level indices by adding the corresponding suffix to variables and function arguments. A handful of places that sent one index and expected the other are fixed. A couple more places needed this adjustment that were missed in the first CL. Also included a test to provoke those situations. The conversion between the two is given by: levelIndexGL = levelIndexVk + baseLevel; Bug: angleproject:4695 Change-Id: I3b8e5699abee1b011e52b666e6e245f44cb8ad6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2302549Reviewed-by:Cody Northrop <cnorthrop@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
-
Ian Elliott authored
FramebufferVk::clearImpl() needs to potentially rotate the results of getCompleteRenderArea(), so that it can be compared with the results of getScissoredRenderArea(). Bug: b/151111296 Change-Id: Iad1fbdcb1943bae00835d31863d32ee85dbc7c2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2303606Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Le Hoang Quyen authored
The tests are disabled on Intel & NVIDIA for now. Bug: angleproject:4235 Change-Id: I06f7f8ba332edf308b7209f0ca6e6a6503aa1981 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2176814Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
-
Jamie Madill authored
This will let us use it in the trace perf tests. Bug: angleproject:4845 Change-Id: I6188a0765c6f482bb38842faa4c58209c70b0153 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300206Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Xinyi He authored
Reset notification behavior is defined in the GL_EXT_robustness extension, and the resulting context must support the extension and the specified reset strategy. So if the ext is not supported, it should disable delivery of reset notifications. Bug: angleproject:4823 Change-Id: I49b9364a83eab9ebc0fdca3b1dc075c1a43070cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2302874 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
Bug: b/159712754 Change-Id: I5dc26726072ddadc3104561606cd425755679a83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304173Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/8726fda3f865..30aa06f22718 2020-07-17 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master 2020-07-17 rgarcia@igalia.com Test pipeline layout lifetime after ending cmd buffer 2020-07-17 dcastagna@google.com Add export/import drm modifier test 2020-07-17 rgarcia@igalia.com Test frag shader side effects are not removed by optimizations 2020-07-17 jbolz@nvidia.com VK_EXT_robustness2 tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jonahr@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com,angle-bots+autoroll-info@google.com Change-Id: Id48ef26916cdd755b73512b15c6fca921c59a1fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304442Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7221ccf85e26..680c77fa6c81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ibccb8cb205986112774a2ba1c7489edf3662ee10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304358Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4f72970ed3e0..f3cb1896971f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I5c2d1f93bcfccda9fe2876765247673167d05ad9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304357Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7548cbeabfa7..412b1b7dd18c 2020-07-16 tony@lunarg.com practices: Make copies of createInfos 2020-07-16 jan-harald.fredriksen@arm.com tests: Add tests for VK_EXT_fragment_density_map2 2020-07-16 jan-harald.fredriksen@arm.com layers: Validate VK_EXT_fragment_density_map2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Icbab820f849123ace5a0308012a2d0b4c4005f2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304356Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Charlie Lao authored
Instead of free and allocate a descriptor set whenever buffer changes, add it into the descriptorset cache. Every time you get the buffer, we also look in the cache first to see if there is a descriptorset for that buffer or not. If yes, we use the cached descriptor set instead of allocate one. Bug: b/159457348 Change-Id: I64c252dfe22db66ea8188415e1b384af371b82ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2273698 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
- 16 Jul, 2020 13 commits
-
-
Charlie Lao authored
In a few places we need a unique ID to represent that object and use that to compute hash key. Right now we are using Serial for that purpose but it creates confusion with QueueSerial which we are using Serial to track GPU progress. This CL changes these usage of Serial to TextureSerial, SamplerSerial, ImageViewSerial type so that compiler can perform type checking. It also adds BufferSerial in preparation for next CL. Bug: b/159457348 Change-Id: I8e2da69c2029e4ddbcf163981ae46f85e19f751b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287426 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Tim Van Patten authored
The member ProgramPipelineState::mHasBeenBound is unused and should be removed. Bug: angleproject:3570 Test: CQ Change-Id: Idc41574f79e665ac36bef5b206704c667c49dadb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301101Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Charlie Lao <cclao@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
-
Charlie Lao authored
Right now each shader stage has its own vk::DynamicBuffer for default uniform storage. This is less efficient than just share one buffer. This CL moves the storage from per shader stage into its ProgramVk object. Bug: b/159457348 Change-Id: If47248ea23c4e48407d3b211583ae2b048d4d10f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2265281 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
The trace tests were including the startup time in their calibration calculations. Then was forcing them to always render one step. This fixes the calibration to attempt to get a more consistent measurement. The trace tests now render many more steps than they did before. It should increase the stability and decrease variance in our measurements as they will be runnnig many more frames than before. Also adds a verbose logging flag to help debugging. Noticed this bug when working on the trace test offscreen mode. Bug: angleproject:4845 Change-Id: Iff0c987008a935e7051fca34ef12f4433eb46092 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300205Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Xinyi He authored
Vulkan is able to capture the whole array when using transform feedback extension. Add a new end2end test for it. Due to the outdated nv bots, khr_gles31 tests are faild. Add these suppressions in the khr_gles31 expectations file in order to unblock the commit. Bug: angleproject:4723 Change-Id: I929f99544a01cf5fc781dc31c2c041c851976676 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2247952 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Le Hoang Quyen authored
- Max point size is set to 64, since this is the max size observed. It is not 511 as https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf claims. - RGB565 is emulated on macOS by RGBA, needs to disable alpha write for this format. This was already done for TextureMtl, but wasn't for RenderBufferMtl. - Also enable true non-power-of-two textures support (OES_texture_npot). This was technically already supported, just that the extension wasn't advertised yet. - New Test: FramebufferFormatsTest.RGB565Renderbuffer Bug: angleproject:4816 Bug: angleproject:2634 Change-Id: Ie7e3efb4cb29bb9a3fd706c26e2b50b42ff3f6be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281797 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Le Hoang Quyen authored
If vertex shader declares a varying but doesn't use it, and this varying is being used in fragment shader, linking will fail because the varying would be removed by spirv-cross. Fix: initilize the unused varying with zero(s). New test: GLSLTest.InactiveVaryingInVertexActiveInFragment. Bug: angleproject:2634 Change-Id: Ia37acd8eea85d5da4ddbca6457d6cddb1b41662c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2281796 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4c33fb0d3dba..7221ccf85e26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I2a8920fc337b444d2036d7410be3fa6066f16239 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301353Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1de497cc50ab..0a8f44c514ce 2020-07-15 bclayton@google.com Regres: Collate and add new documentation for Regres If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Icc753a1ac3871ebfaf3a30c6aa999b3fb24c49f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301354Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b481744aea1e..4f72970ed3e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: If2f1140131bd5ce6052491dbff763935502a44bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301350Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/521eaacef67a..d093d9723b7c 2020-07-16 bob@lunarg.com scripts: fix update_deps retry clone 2020-07-15 shannon@lunarg.com build: Update known-good files for 1.2.147 header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I9ca9134800e9ad27340fd43348f6ca389be2b187 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301352Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/d8f34456c819..dd3511549b18 2020-07-16 bob@lunarg.com scripts: fix update_deps retry clone If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Idc84db0de207a83f25c798899bc4e5a66958529a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301351Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/04c82ec6f36f..7548cbeabfa7 2020-07-15 bob@lunarg.com scripts: fix update_deps retry clone 2020-07-15 tony@lunarg.com tests: Add ShieldTV rev b to skiplist 2020-07-15 tony@lunarg.com gpu: Report errors when shader instrumentation fails 2020-07-15 shannon@lunarg.com build: Address VUID inconsistencies for 1.2.147 2020-07-15 shannon@lunarg.com build: Update known-good files for 1.2.147 header 2020-07-14 jzulauf@lunarg.com tests: Add test for attachment final layout tran 2020-07-14 8729214+jonahryandavis@users.noreply.github.com Fix -Wrange-loop-construct range var copy warning 2020-07-14 jzulauf@lunarg.com syval: Correct assert during final layout record 2020-07-14 tksuoran@gmail.com lifetimes: Fix GetPhysDeviceDisplayProp2 null derefs 2020-07-13 pdaniell@nvidia.com tests: Add VK_EXT_extended_dynamic_state tests 2020-07-13 pdaniell@nvidia.com layers: Add VK_EXT_extended_dynamic_state validation 2020-07-13 bob@lunarg.com scripts: update copyright notice for update_deps 2020-07-13 bob@lunarg.com scripts: update_deps retry on clone or fetch failure 2020-07-13 jzulauf@lunarg.com docs: Add synchronization design doc 2020-07-13 locke@lunarg.com tests: Layout Transition error test 2020-07-13 jzulauf@lunarg.com syncval: Add stage/access info to hazard messages 2020-07-13 jzulauf@lunarg.com syncval: Add input attachment state tracking 2020-07-13 jzulauf@lunarg.com syncval: Fixes for attachment detection/update 2020-07-13 locke@lunarg.com layers: Fix sub extents 2020-07-13 locke@lunarg.com syncval: Add Prior access 2020-07-13 locke@lunarg.com syncval: Fix for 3D image 2020-07-13 jzulauf@lunarg.com syncval: Correct order for syval end rendpass calls 2020-07-13 locke@lunarg.com syncval: Fix wrong mip count in encoder 2020-07-13 jzulauf@lunarg.com syncval: Bound access resolve to range. 2020-07-13 locke@lunarg.com syncval: Check for no current renderpass 2020-07-13 locke@lunarg.com syncval: Fix blitImage offset and extent error 2020-07-13 jzulauf@lunarg.com syncval: Add command name to harzard reports 2020-07-13 jzulauf@lunarg.com layers: Refactor Command name lookup to function 2020-07-13 jzulauf@lunarg.com syncval: Add tag information to hazard log messages 2020-07-13 locke@lunarg.com syncval: Record in StateTracker 2020-07-13 locke@lunarg.com tests: Test syval depth/stencil speparately 2020-07-13 locke@lunarg.com syncval: Test depth/stencil separately 2020-07-13 locke@lunarg.com syncval: Skip FS validation w/rasterizerDiscardEnable 2020-07-13 locke@lunarg.com syncval: Check fs writable output 2020-07-13 locke@lunarg.com syncval: Remove dupl. input attachment validation 2020-07-13 locke@lunarg.com syncval: Refactor detect/update for draw/dispatch 2020-07-13 locke@lunarg.com layers: Catch if shader use store function 2020-07-13 locke@lunarg.com syncval: Check every shader stages 2020-07-13 locke@lunarg.com scripts: Add shader stage map 2020-07-13 locke@lunarg.com tests: More syval test in Cmd 2020-07-13 locke@lunarg.com syncval: Refactor get pipeline 2020-07-13 locke@lunarg.com syncval: More syval in cmd 2020-07-13 locke@lunarg.com syncval: Detect/Update Subpass attachments 2020-07-13 locke@lunarg.com syncval: shared_ptr renderpass/framebuffer 2020-07-13 locke@lunarg.com syncval: Syval vertex and index 2020-07-13 locke@lunarg.com syncval: Syval more cmd 2020-07-13 locke@lunarg.com tests: Fix fail 2020-07-13 locke@lunarg.com tests: Syval CmdDispatch 2020-07-13 locke@lunarg.com syncval: Syval descriptorSets in CmdDispatch 2020-07-13 jzulauf@lunarg.com syncval: Add renderpass store sync validation 2020-07-13 locke@lunarg.com layers: D24 depth pixel size is 3, not 4 2020-07-13 locke@lunarg.com scripts: Deal with MEMORY_READ/WRITE_BIT 2020-07-13 jzulauf@lunarg.com syncval: Add additional resolve att. val/update 2020-07-13 jzulauf@lunarg.com syncval: Add resolve validations NextSubpass only 2020-07-13 jzulauf@lunarg.com syncval: Add hazard detection with ordering checks 2020-07-13 jzulauf@lunarg.com syncval: Add loadOp validation to renderpass 2020-07-13 jzulauf@lunarg.com syncval: Synch Val bugfixes from design review 2020-07-13 locke@lunarg.com syncval: Deal with whole size and remaining 2020-07-13 jzulauf@lunarg.com tests: Add begin renderpass hazard test 2020-07-13 jzulauf@lunarg.com syncval: Convert all sync tagging to new style 2020-07-13 jzulauf@lunarg.com syncval: Add renderpass image layout sync checks 2020-07-13 jzulauf@lunarg.com layers: Add additional attachment info 2020-07-13 jzulauf@lunarg.com layers: Add hinted invalidation to parallel iter 2020-07-13 jzulauf@lunarg.com tests: Fix access mask logic for SetLayout 2020-07-13 locke@lunarg.com syncval: Merge contiguous ranges during encode 2020-07-13 locke@lunarg.com syncval: Fix texel size in ImageRangeEncoder 2020-07-13 locke@lunarg.com syncval: Encode linear image as optimal in MockICD 2020-07-13 locke@lunarg.com syncval: Move image encoder init to BindMemory 2020-07-13 jzulauf@lunarg.com syncval: Add FreeCommandBuffer callback support 2020-07-13 locke@lunarg.com scripts: Sort syncval output for consistency 2020-07-13 jzulauf@lunarg.com syncval: Remove per-handle maps for AccessState 2020-07-13 jzulauf@lunarg.com layers: Add support for fake device memory address 2020-07-13 locke@lunarg.com syncval: Refactor Image encoder/generator 2020-07-13 jzulauf@lunarg.com syncval: Cleanup/Refactor AccessContext 2020-07-13 jzulauf@lunarg.com layers: Add range operator + and copy constructor 2020-07-13 jzulauf@lunarg.com layers: Add subpass transition info to RP state 2020-07-13 jzulauf@lunarg.com syncval: Clean up and bugfix Access state resolve 2020-07-13 locke@lunarg.com syncval: Change offset generator to image generator 2020-07-13 locke@lunarg.com syncval: Add default constructors for Encoders 2020-07-13 jzulauf@lunarg.com syncval: Clean attachment first/last for RP creation 2020-07-13 jzulauf@lunarg.com syncval: Add end renderpass access context resolve 2020-07-13 jzulauf@lunarg.com syncval: Change hazard check to use resolved map. 2020-07-13 locke@lunarg.com syncval: Add function name to hazard log messages 2020-07-13 locke@lunarg.com tests: Test copy buffer image and blit hazards 2020-07-13 locke@lunarg.com syncval: Add copy buffer image and blit entry points 2020-07-13 locke@lunarg.com syncval: Use new generator in synchronization 2020-07-13 locke@lunarg.com tests: Fix test synchronization errors 2020-07-13 locke@lunarg.com syncval: Add dest image adjustment for compressed 2020-07-13 locke@lunarg.com syncval: Add new RangeEncoder and RangeGenerator 2020-07-13 jzulauf@lunarg.com syncval: Add context interface for detect/update 2020-07-13 jzulauf@lunarg.com layers: Enhance Subpass DAG tree information 2020-07-13 jzulauf@lunarg.com syncval: Adding race hazard support 2020-07-13 jzulauf@lunarg.com syncval: Add logical stage extension to exec scope 2020-07-13 jzulauf@lunarg.com sync: Add earlier/later stage maps to codegen 2020-07-13 jzulauf@lunarg.com syncval: Add image layout transition hazard checks 2020-07-13 jzulauf@lunarg.com tests: Add first image sync tests 2020-07-13 jzulauf@lunarg.com syncval: Add image sync validation for CopyImage 2020-07-13 jzulauf@lunarg.com tests: Add more flexible interface to VkImageObj 2020-07-13 jzulauf@lunarg.com tests: Add testcases for buffer region copies 2020-07-13 jzulauf@lunarg.com syncval: Init Sync Val Resource Hazard If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ib945290815d94bdff93297daa0f3f700772e90fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2301349Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 15 Jul, 2020 1 commit
-
-
Cody Northrop authored
This CL adds a reverse JNI call to our Android Native Activity that sets the orientation of the screen based on width and height. To achieve this we: * Attach to the java thread once at the beginning to grab JNI env. * Detach from the thread once when platform sends APP_CMD_DESTROY * Set the orientation during test init Bug: angleproject:4327 Change-Id: Ifbe31a6a84dd60a0dfe7d7032962c99b290d8b81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289054Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-