Commits · 8eb3ec7e40f772ccae28607c5bc696ecbef213ac · Chen Yisong / angle

30 Mar, 2020 2 commits

Roll third_party/vulkan-loader/src cc481ef27631..b0c27ce32864 (2 commits) · 8eb3ec7e

authored Mar 30, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/cc481ef27631..b0c27ce32864

git log cc481ef27631..b0c27ce32864 --date=short --first-parent --format='%ad %ae %s'
2020-03-27 mikew@lunarg.com tests: Use complete version from header
2020-03-27 mikew@lunarg.com loader: Use complete version from header

Created with:
  gclient setdep -r third_party/vulkan-loader/src@b0c27ce32864

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I4d3d4af2ac995fb18150c03942b4cb3969fef2b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2126482Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8eb3ec7e

Roll third_party/glslang/src 99508c1ce389..344bd0889ac9 (4 commits) · 47e3be4e

authored Mar 30, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/99508c1ce389..344bd0889ac9


Created with:
  gclient setdep -r third_party/glslang/src@344bd0889ac9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Id2316c86a9281d419b78fe8f8e48fb601ef6e0a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2126478Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

47e3be4e

28 Mar, 2020 7 commits

Vulkan: Refactor varying validation for separable programs · 1b2dd6f9

authored Mar 02, 2020

The varying validation is being refactored to better handle separable
programs. Some additional validation is being added as well regarding:
- Number of varyings (inputs vs outputs)
- Precision

This refactor will also allow ProgramPipelines to validate varyings
between shaders that are in different Programs.

Bug: angleproject:3570
Change-Id: I13f324da2ffea039e696962d6971a54f7a7b6f77
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2083847
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

1b2dd6f9

Vulkan: Move ProgramInfo/ShaderInfo to ProgramExecutableVk · b387ce93

authored Feb 21, 2020

The classes ProgramInfo and ShaderInfo are being moved into
ProgramExecutableVk along with the ProgramVk members mDefaultProgramInfo
and mLineRasterProgramInfo.   This refactor is necessary since these
members are common between ProgramVks and ProgramPipelineVks.

Bug: angleproject:3570
Change-Id: I94cdb1096c6a0c007d858135af694da58d7897ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068901
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

b387ce93

Vulkan: Create TransformSpirvCode() · f47dccab

authored Feb 21, 2020

To support Program Pipeline Objects, the SPIR-V transformations must be
completed at draw time once all of the variable locations are known. To
achieve this, the transformation work is being refactored into
TransformSpirvCode() which can be called separately from
GlslangGetShaderSpirvCode().

Bug: angleproject:3570
Change-Id: Ia479cb2e4b4201e37acd0859c70081cecb80d0bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068900
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

f47dccab

Vulkan: Make mVariableInfoMap a gl::ShaderMap<> · 85c076ee

authored Feb 20, 2020

The ShaderInterfaceVariableInfoMap information is specific to each
shader stage, since the locations are determined for each shader stage.
This change makes mVariableInfoMap a gl::ShaderMap<> to handle this,
which will make it easier to compile separable programs, determine the
variable locations, and transform the SPIR-V.

Bug: angleproject:3570
Change-Id: I28b71a37efe54bbcfe1dcd445fa03ee71e74f0a6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062741
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

85c076ee

Vulkan: Only calculate variable locations once · abaa3573

authored Feb 20, 2020

Variable locations and descriptor set/binding values are calculated
multiple times:
- Compiling GLSL->SPIR-V
- Creating the Vulkan pipeline layout
- Updating descriptor sets

These values should instead be calculated once and reused throughout
since they won't change without recompiling the shader program.

Bug: angleproject:3570
Change-Id: I5d8767b3b2e2f741aade7fec9991eea53ee2eb98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2067101
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

abaa3573

Create the ProgramExecutableVk Class · 10ade024

authored Feb 13, 2020

The ProgramExecutableVk class is being created to collect data
structures that are common to both ProgramVks and ProgramPipelineVks,
as well as any shared functions. This allows callers to make
Program-/ProgramPipeline- specific queries without needing to know
exactly which responded by querying the current ProgramExecutableVk.
This will also allow the necessary data structures to only be
populated and stored within the ProgramExecutableVk when necessary
and reused as often as necessary.

A few things are being moved into this class:
- mVariableInfoMap
This information will be required to defer translating the SPIR-V
until when the vulkan pipeline layout is determined and the actual
locations are known.   This will also allow removing determining
these locations twice (during GLSL->SPIR-V compilation and pipeline
layout).
- createPipelineLayout()
- update*DescriptorSet()
- Descriptor Set Layout lists
- Pipeline Layout
- Various other functions/members related to pipeplines, descriptor
sets, etc.

Bug: angleproject:3570
Change-Id: I4b5ababeafec865148783c8ffd4c15f659f4856d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055656
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

10ade024

Skip KHR-GLES31.core.shader_image_load_store.advanced-allMips-* tests · b19000f3

authored Mar 27, 2020

Were previosly FAIL, but crash on Windows SwANGLE.

Bug: angleproject:4414
Change-Id: Iefe1625f7ad3eec8ba091ec3543e8cb699c62c65
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2125370Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

b19000f3

27 Mar, 2020 11 commits

Vulkan: Mask out Depth/Stencil RTs in feedback loops. · d03b15b2

authored Mar 26, 2020

This should enable some cases of limited support for feedback loops
with depth/stencil buffers. For example with Manhattan and the Vulkan
back-end.

Increases the number of RenderPasses in Manhattan slightly. This will
regress performance slightly until we can work out a better solution
that is also conformant with the spec.

Bug: angleproject:4517
Change-Id: I2758e6b4c2a930474c09cdc0950f3b6c34541089
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2106670
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

d03b15b2

Vulkan: Move cached samplers/images and has*() to ProgramExecutable · 68083e89

authored Mar 04, 2020

The active samplers and images are being moved from Program into
ProgramExecutable to unify interacting with them for Programs and
ProgramPipelines

Also, create some helper functions for gl::Program that ProgramExecutable can
call to make it easier for ProgramPipeline to respond to similar
queries for each of the Programs in the ProgramPipeline.

Bug: angleproject:3570
Change-Id: I0b37f1a379e56b9659d82d92f6d7a546beee11cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2087648
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

68083e89

Fix feedback loop clearing detection. · bd2bdf9f

authored Mar 26, 2020

Bug: angleproject:4517
Change-Id: I3231b129718019f83495843404cd011eb2cd480d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2122689
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

bd2bdf9f

Update OWNERS information. · 0bba1100

authored Mar 27, 2020

Also includes some documentation maintenance.

Bug: angleproject:4511
Change-Id: I7ecce494909f06387875ff85a10004d0c446bbaf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2124597Reviewed-by: Geoff Lang <geofflang@chromium.org>

0bba1100

Support masking out DS feedback loops in RenderTargetCache. · 13c139e7

authored Mar 21, 2020

Currently this is a pure refactor and doesn't change any functionality.
In a follow-up we can us this bit to mask out DS RTs when Manhattan and
other apps render with feedback loops.

Bug: angleproject:4517
Change-Id: I80ccd022d90a781506791110d11be195db8cd3e9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112936Reviewed-by: Cody Northrop <cnorthrop@google.com>

13c139e7

D3D11: Serialize and deserialze mImage2DUniforms. · 0e65abea

authored Mar 27, 2020

mImage2DUniforms was not saved with the program binary causing shaders with
images to fail compilation when loaded from binary.

BUG: angleproject:4519
BUG: b:152292873
Change-Id: I51581031ae1f9d4b4d986057ef3f876d809c7f24
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2124587Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

0e65abea

Create the ProgramExecutable Class · 7e0699a2

authored Feb 05, 2020

The ProgramExecutable class is being created to collect data structures
that are common to both Programs and ProgramPipelines, as well as any
shared functions. This allows callers to request the current
ProgramExecutable from the State and make
Program-/ProgramPipeline-specific queries without needing to know
exactly which responded. This will also allow the necessary data
structures to only be populated and stored within the ProgramExecutable
when necessary and reused as often as necessary.

Bug: angleproject:3570
Change-Id: I101f08ab03421894667b4a426a04d2147489f0e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2040512
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7e0699a2

Roll third_party/vulkan-loader/src acbf316040c3..cc481ef27631 (1 commits) · fd3480d2

authored Mar 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/acbf316040c3..cc481ef27631

git log acbf316040c3..cc481ef27631 --date=short --first-parent --format='%ad %ae %s'
2020-03-26 udknight@gmail.com docs: Fix wrong type name in InterceptFunctionName prototype

Created with:
gclient setdep -r third_party/vulkan-loader/src@cc481ef27631

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I8ba7480037117cce4e2ba8f5f851fa1cce890b88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123983Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

fd3480d2

Roll third_party/glslang/src 2df8c71258de..99508c1ce389 (1 commits) · 651fc45d

authored Mar 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2df8c71258de..99508c1ce389


Created with:
  gclient setdep -r third_party/glslang/src@99508c1ce389

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I9ddd9b7cfdee4b54da8e1a36a8c46283ef09e75d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123981Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

651fc45d

Roll third_party/vulkan-validation-layers/src 443c2caa1714..55f01953d6e9 (1 commits) · 6431673e

authored Mar 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/443c2caa1714..55f01953d6e9

git log 443c2caa1714..55f01953d6e9 --date=short --first-parent --format='%ad %ae %s'
2020-03-26 s.fricke@samsung.com layers: Fix renderpass2 VUID

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@55f01953d6e9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ib8b7160e7c1691cec71a50509676fa739919d520
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123982Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

6431673e

Roll third_party/SwiftShader 77090261dabc..02e15b249b12 (8 commits) · c1f94204

authored Mar 27, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/77090261dabc..02e15b249b12

git log 77090261dabc..02e15b249b12 --date=short --first-parent --format='%ad %ae %s'
2020-03-26 bclayton@google.com third_party: Create scripts for updating spirv-[tools|headers]
2020-03-26 capn@google.com Fix taking aspect into account for image view identifiers
2020-03-26 bclayton@google.com Kokoro: Move llvm configs into 7.0 subdirectory, create 10.0 copies.
2020-03-26 bclayton@google.com Regres: Add support for generating collated coverage info
2020-03-26 bclayton@google.com CMake: Emit coverage-toolchain.txt file next to ICD json
2020-03-26 bclayton@google.com CMake: Add SWIFTSHADER_EMIT_COVERAGE option
2020-03-26 bclayton@google.com CMake: Add option for selecting LLVM version.
2020-03-26 bclayton@google.com Merge "Initial drop of LLVM 10 to third_party/llvm-10.0"

Created with:
gclient setdep -r third_party/SwiftShader@02e15b249b12

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I6250b123e1feed7defddeeb0197b03f7182d43e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123980Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c1f94204

26 Mar, 2020 7 commits

Capture/Replay: Implement more GLES entrypoints · f2bee304

authored Mar 25, 2020

Tested with several apps that can't be captured otherwise.

Bug: angleproject:3611
Change-Id: I2ad18c3bfcab48b0b385b2a868f57369c292b602
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1998838Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

f2bee304

Roll glslang and Vulkan validation layers · d8c1b03c

authored Mar 26, 2020

Autoroller for glslang was paused, breaking layer build.

Replaces: https://crrev/c//2119884

TBR: courtneygo@google.com

Bug: b:152298150
Bug: angleproject:4510
Change-Id: I6c431a76455c991cbbb8621050dbf74acf8eea41
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2121903Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

d8c1b03c

Roll third_party/vulkan-headers/src fb7f9c9bcd1d..0e78ffd1dcfc (1 commits) · bf6b8d4a

authored Mar 26, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/fb7f9c9bcd1d..0e78ffd1dcfc

git log fb7f9c9bcd1d..0e78ffd1dcfc --date=short --first-parent --format='%ad %ae %s'
2020-03-24 oddhack@sonic.net Update for Vulkan-Docs 1.2.136

Created with:
  gclient setdep -r third_party/vulkan-headers/src@0e78ffd1dcfc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=cnorthrop@google.com

Bug: None
Change-Id: I17d7b9ba8e96fa1e3dab15260436b71887d55536
Tbr: cnorthrop@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2121708Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

bf6b8d4a

Roll third_party/vulkan-loader/src ff44f21a0178..acbf316040c3 (1 commits) · da984675

authored Mar 26, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ff44f21a0178..acbf316040c3

git log ff44f21a0178..acbf316040c3 --date=short --first-parent --format='%ad %ae %s'
2020-03-23 charles@lunarg.com scripts: stubs in dispatch table lacked matching return types

Created with:
gclient setdep -r third_party/vulkan-loader/src@acbf316040c3

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I5505867022ca850e4b94e1bf4454c03ec93850a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119885Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

da984675

Roll third_party/SwiftShader 540bdf92531d..77090261dabc (10 commits) · 0ee5eb6d

authored Mar 26, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/540bdf92531d..77090261dabc

git log 540bdf92531d..77090261dabc --date=short --first-parent --format='%ad %ae %s'
2020-03-25 capn@google.com Identify image views based on their state
2020-03-25 capn@google.com Provide packed VkFormat to uint8_t mapping
2020-03-25 capn@google.com Uniquely identify sampler state
2020-03-25 capn@google.com Split vk::Sampler state off into a structure
2020-03-25 capn@google.com Fix handling Memset<> assignment and comparison
2020-03-25 bclayton@google.com Add script for updating llvm 10
2020-03-25 amaiorano@google.com regres: add daily run against SwiftShader/Subzero
2020-03-25 bclayton@google.com CMake: Don't export LLVM_INCLUDE_DIR to PARENT_SCOPE
2020-03-25 bclayton@google.com CMake: Move LLVM rules out to third_party/llvm-7.0
2020-03-25 bclayton@google.com Add missing copyright header to CMakeLists.txt

Created with:
gclient setdep -r third_party/SwiftShader@77090261dabc

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ie880cfbad88061a571bedcf2b41a2876275fdd81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119882Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0ee5eb6d

Roll third_party/spirv-tools/src 1346dd5de119..fd773eb50d62 (4 commits) · 7a58e5b7

authored Mar 26, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1346dd5de119..fd773eb50d62


Created with:
  gclient setdep -r third_party/spirv-tools/src@fd773eb50d62

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I6349d641ed962bb159f0659054055896eaa3b9c2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119883Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7a58e5b7

Update Vulkan header and related repos · 6719f54a

authored Mar 24, 2020

Vulkan header was updated with non-backward compatible change so need
to update all dependencies simultaneously.

Bug: b:152298150
Bug: angleproject:4510
Change-Id: I46ac9a3a0ccb52184fd183df617804c866b63453
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2118151Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

6719f54a

25 Mar, 2020 6 commits

Capture/Replay: Update CaptureReplay sample for compression · b69c4e14

authored Mar 24, 2020

* Move DecompressBinaryData to a shared helper
* Start using it in CaptureReplay sample
* Error out if decompress callback isn't set correctly

Test: AngryBirds and CandyCrush captures replay on desktop
Test: angle_perftests --gtest_filter="*Trace*"
Bug: angleproject:4484
Change-Id: I0432004fdb0cfb0fd61f9a66f792591c9aa40d9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2118790
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

b69c4e14

Perf: Add a single Manhattan trace · 78c77361

authored Mar 20, 2020

Now that TRex is up and working and Manhattan runs cleanly:
* Add a single compressed Manhattan trace.
* Allow errors from tests to fail the test
* Restore the working directory between each trace test

Test: angle_perftest --gtest_filter=TracePerfTest*
Bug: b:151349786
Bug: angleproject:3630
Bug: angleproject:4496
Change-Id: I9e9d9342efb23431380f484befb9a19915c4bd0a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2113230
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

78c77361

Re-enable angle_end2end_tests on 32-bit Windows SwiftShader · a7510f06

authored Mar 04, 2020

In order to add angle_end2end_tests on Win 32-bit SwANGLE bots.

Bug: angleproject:4421, angleproject:4092
Change-Id: I6923ca461492469f05503aebf2256763ea7061aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2088654Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

a7510f06

No-op draw calls with rendering feedback loops. · c77cb596

authored Mar 24, 2020

This is quite within spec and protects our various back-ends from FB
loops. Also makes the check more cached for optimization purposes.

Bug: angleproject:4490
Change-Id: Ia82ec88244d07670d68ce53495b5893b8a75ac42
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2118153
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

c77cb596

Roll third_party/SwiftShader 6c11cf2ad9ca..540bdf92531d (2 commits) · 38152bda

authored Mar 25, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/6c11cf2ad9ca..540bdf92531d

git log 6c11cf2ad9ca..540bdf92531d --date=short --first-parent --format='%ad %ae %s'
2020-03-24 bclayton@google.com Regres: Add new run_testlist flags
2020-03-24 bclayton@google.com Merge changes I9862d8e2,Ie1024655

Created with:
  gclient setdep -r third_party/SwiftShader@540bdf92531d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I9c4fb01c33c816001c65959bf14c33c09d1e3070
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119920Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

38152bda

Lift SwANGLE dEQP-GLES3.functional.fbo.blit.conversion.* suppression · 107e4e98

authored Mar 24, 2020

Fixed by
https://swiftshader-review.googlesource.com/c/SwiftShader/+/42548/

Bug: angleproject:4416
Change-Id: I703608d7d3fa15f2428a832896a68893efbb35ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119234Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

107e4e98

24 Mar, 2020 6 commits

Vulkan: Fix crashes/failures in array-of-struct uniforms · d0800d29

authored Mar 24, 2020

When array-of-struct support was added to ANGLE, it was not added to
the shader cache serialize/deserialize functions.

This affects many GLES 2/3/3.1 dEQP tests, such as:

  dEQP-GLES2.functional.uniform_api.value.assigned.by_value.render.struct_in_array.sampler2D_samplerCube_vertex

Bug: angleproject:4475
Bug: b:151387995
Change-Id: I159f6340db255ec50c16b59fec23a61ed05aa8f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2118152
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d0800d29

Speculative fix for assertion failure with samplers. · b91d2630

authored Mar 24, 2020

This was crashing for example here:

https://chromium-swarm.appspot.com/task?id=4b174a9710848410
https://chromium-swarm.appspot.com/task?id=4b214baec2ee7e10

With this stack:

libglesv2!gl::TextureState::isBoundAsSamplerTexture
libglesv2!gl::Texture::onUnbindAsSamplerTexture
libglesv2!gl::State::unsetActiveTexture+0x9
libglesv2!gl::State::updateActiveTextureState+0x2d2
libglesv2!gl::State::updateActiveTexture+0x3aa
libglesv2!gl::State::setSamplerTexture+0x4a1
libglesv2!gl::Context::bindTexture+0x1ab
libglesv2!gl::BindTexture+0x99
chrome!GrGLFunction+0x1f
chrome!GrGLGpu::bindTexture+0x1a0
chrome!GrGLProgram::bindTextures+0x1b9
chrome!GrGLOpsRenderPass::onBindTextures+0x50
chrome!GrOpsRenderPass::bindTextures+0x106
chrome!GrOpFlushState::bindTextures+0xf
chrome!`anonymous namespace'::FillRectOp::onExecute+0xd3

It's unclear how we could end up with a Texture bound that doesn't go
through the normal setter functions. I did see a potential hole where
textures might not get an unbind call when a Context is torn down. This
could lead to bugs in multi-context situations.

This protects the set/unset functions in a helper class to ensure we
always call onBind/onUnbind and forces the destructor to call unbind.

Bug: angleproject:4490
Change-Id: Ied64e02bbe3a37efcab6cbdd4bf2d1b6dcb8b3ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2118254
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

b91d2630

Fix robust resource initialization with clipped CopyTexSubImage2D. · e39d055d

authored Mar 23, 2020

When CopyTexSubImage2D calls were clipped against the bounds of the
read framebuffer by the underlying renderer backends, the robust
resource initialization code assumed that the original destination
area would be overwritten by the renderer, which was not the case.

Add new tests which were previously failing on macOS with the
ES2_OpenGL and ES3_OpenGL backends. The Metal backend is still failing
and a follow-on bug has been filed.

Bug: angleproject:4504
Change-Id: I34821dd90597f31b3cbf0921b94756556e485c91
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2116873Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

e39d055d

Supress test failing with new Intel driver. · ed0e932c

authored Mar 23, 2020

EGLDirectCompositionTest.RenderSolidColor/ES2_D3D11_NoFixture failing
with the 26.20.100.7870 driver.

Bug: chromium:1063962
Change-Id: I48ef5915c67e05cc86a568c28115dae26dc78db2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2116871
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

ed0e932c

Roll third_party/spirv-tools/src 60104cd97446..1346dd5de119 (4 commits) · 954f3d83

authored Mar 24, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/60104cd97446..1346dd5de119


Created with:
  gclient setdep -r third_party/spirv-tools/src@1346dd5de119

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ic133e60c657d4f9b2eaf8f28dfa26a3527bffe37
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2117477Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

954f3d83

Roll third_party/SwiftShader 22d73d15e778..6c11cf2ad9ca (5 commits) · 20983e35

authored Mar 24, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/22d73d15e778..6c11cf2ad9ca

git log 22d73d15e778..6c11cf2ad9ca --date=short --first-parent --format='%ad %ae %s'
2020-03-24 capn@google.com Remove unused sampler parameter
2020-03-24 capn@google.com Specialize sampling routine for immutable sampler data
2020-03-23 amaiorano@google.com CMake: make SWIFTSHADER_DCHECK_ALWAYS_ON work on Windows
2020-03-23 chrisforbes@google.com Refactor vertex fetch to use VkFormat more aggressively
2020-03-23 bclayton@google.com Merge changes I2b7adc3c,I5873dfa8

Created with:
gclient setdep -r third_party/SwiftShader@6c11cf2ad9ca

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I301e41b5044c90f43228d8b01fb6d26ae249fee6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2117476Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

20983e35

23 Mar, 2020 1 commit

Vulkan: No-op redundant FB state changes. · 6fead375

authored Mar 21, 2020

This uses a trick by comparing the prior to the updated FB description
to filter out rendundant changes. Will allow the front-end syncState to
sometimes noisily report state changes when there aren't any in the
back-end. Ideally we wouldn't generate any updates when there aren't
real changes. However because Manhattan often transitons between a few
zero states it gets a bit difficult to determine in the front-end.

Also adds a no-op for redundant samples changes in the front-end.

Fixes a regression in the number of RenderPasses in Manhattan from work
to support rendering feedback loops.

Bug: angleproject:4490
Change-Id: Ibf83d584107a4561da7ad47a2d3fb543e63e31f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112935Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

6fead375