Commits · 95bfb3e5de6880d46b29894a2629b3994d7f5b43 · Chen Yisong / angle

14 Jul, 2020 1 commit

Vulkan: Fix resolve draw path · 95bfb3e5

authored Jul 08, 2020

If the draw path is taken for resolve, the internal shader previously
calculated (1+sum(sample.a))/sampleCount instead of
sum(sample.a)/sampleCount.  Additionally, due to a typo, the result was
rounded.

This change also fixes a number of off-by-one errors when calculating
src/dst offsets in blit/resolve path.

Tests are added to resolve from default to FBO and vice versa to
exercise the draw path which was otherwise never invoked for color
buffers.

Bug: angleproject:4746
BUg: angleproject:4092
Change-Id: I4b9c181339b89af44b27d61d27a6b3d88cde2eea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2288224
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

95bfb3e5

13 Jul, 2020 10 commits

Vulkan: Enable VK_KHR_get_memory_requirements2 extension · d98afb78

authored Jul 10, 2020

1. Don't assume support for VK_KHR_get_memory_requirements2.
   Enable the extension, if supported, during device creation.
2. Also let VMA fill in the function pointers for these commands
   based on Vulkan API version -
   1. vkGetBufferMemoryRequirements2KHR
   2. vkGetImageMemoryRequirements2KHR

Bug: angleproject:4830
Change-Id: Icd0b3baf56732b5f5f49f320c1feb996204169ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2293633Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

d98afb78

Revert "Refactor DisplayGbm::generateConfigs" · 66d85686

authored Jul 13, 2020

This reverts commit 7d82d293.

Reason for revert: Suspect CL failing on Linux FYI Ozone

Original change's description:
> Refactor DisplayGbm::generateConfigs
>
> Bug: angleproject:4809
> Change-Id: I5f352f737bbd53c78d9e01055c17eabd17d5fb8a
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2278667
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

TBR=geofflang@chromium.org,jiajia.qin@intel.com,jmadill@chromium.org

Change-Id: I62c8a6a78d1ccfe8aa63bea7a9409229cd0059ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4809, chromium:1105208
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2296041
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>

66d85686

Multi-frames serialization + comparision for capture replay test · e5c18475

authored Jul 06, 2020

Changes how context states are serialized during capture run. Now,
context states are serialized after each frame until the end frame
is reached, or context is destroyed.

Adds an api to the trace files to query serialization results of
multiple frames. Makes change to CaptureReplayTest to serialize
multiple frames then compares the serialization results with the ones
retrieved from said api.

Adds to capture replay the ability to produce working, compilable trace
files even when end frame is not reached.

Adds to the generated trace files config information and makes
CaptureReplayTest utilize said config information to reproduce the exact
environment of the captured application.

Bug: angleproject:4817
Change-Id: Ie3d487af2bacf349dc3ff6f6b1b5f89e1169dc84
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2282885
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e5c18475

Vulkan: Disable GL_EXT_robustness extension on Mali · 92ffd40e

authored Jul 08, 2020

Vulkan doesn't have a mapping extension to
GL_EXT_robustness, so we need to disable it.

Bug: angleproject:4823
Change-Id: If7b66c0eb7ba14b9349925af64ec2efcec9985a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287092
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

92ffd40e

Roll VK-GL-CTS from 44ef9e08c459 to 8726fda3f865 (8 revisions) · 5263d5e1

authored Jul 13, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/44ef9e08c459..8726fda3f865

2020-07-13 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master
2020-07-12 ilkka.saarelainen@siru.fi Add support for comments in amber index files
2020-07-12 ari.suonpaa@siru.fi Test texelfetch on uniform texel buffer with packed format
2020-07-08 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master
2020-07-06 piotr.byszewski@mobica.com Test transitions between command buffer states
2020-07-04 alexander.galazin@arm.com Update SPIR-V Tools/Headers and glslang
2020-07-04 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master
2020-07-04 alexander.galazin@arm.com Update Vulkan headers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC jonahr@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com,angle-bots+autoroll-info@google.com
Change-Id: I48bc03267af2f66bb3794f31b060d74f4d4e1343
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2294915Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5263d5e1

Roll Vulkan-ValidationLayers from 94f1ce331e85 to 04c82ec6f36f (9 revisions) · f3f891c5

authored Jul 13, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/94f1ce331e85..04c82ec6f36f

2020-07-13 s.fricke@samsung.com tests: Add Protected Resource VUIDs
2020-07-13 s.fricke@samsung.com layers: Add Protected Resource VUIDs
2020-07-10 timvp@google.com build: Add a virtual dtor to AspectParameters
2020-07-10 jan-harald.fredriksen@arm.com tests: Add VUID 04059
2020-07-10 jan-harald.fredriksen@arm.com layers: Add VUID 04059
2020-07-10 s.fricke@samsung.com tests: Add YCbCr Swizzle VUIDs
2020-07-10 s.fricke@samsung.com layers: Add YCbCr Swizzle VUIDs
2020-07-10 tony@lunarg.com layers: Remove leftover enum
2020-07-10 liyl@google.com chassis: Fix memory leaks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ia30720d58d1b8f3c9cc5030da5c95576ec82519d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2294696Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f3f891c5

Roll glslang from 5aaa0c2bc821 to 4e13c90944e9 (7 revisions) · 4eecfef6

authored Jul 13, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5aaa0c2bc821..4e13c90944e9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: If6061829acf7eae6187c947bea573c854e851df9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2294693Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4eecfef6

Roll Vulkan-Loader from 145050bf2b98 to d704d1bc0e11 (2 revisions) · 5e3f8512

authored Jul 13, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/145050bf2b98..d704d1bc0e11

2020-07-10 charles@lunarg.com loader: Make RTLD_DEEPBIND conditional on ASAN
2020-07-10 mikes@lunarg.com build: Roll GN DEPS file

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ibce2967c04d1a0451122ccdac45acf4daba8be70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2294694Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5e3f8512

Roll SwiftShader from 6cd27bab06f4 to ad65826a2ab1 (7 revisions) · 1a3a2b6a

authored Jul 13, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/6cd27bab06f4..ad65826a2ab1

2020-07-11 capn@google.com Fix copying of multiple image layers
2020-07-11 capn@google.com Fix copying of multisample images
2020-07-11 capn@google.com Fix image slice / plane name usage
2020-07-10 amaiorano@google.com Android: add llvm-10 build file and fix build
2020-07-10 amaiorano@google.com Add llvm-10 configs for Android
2020-07-10 amaiorano@google.com Add arm64 support for Darwin to llvm-10 configs
2020-07-10 amaiorano@google.com Add validation and platform restrictions to LLVM-10 update script

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I2abcda8faa3538971eb17e1ceee81602987cec98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2294691Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1a3a2b6a

Refactor DisplayGbm::generateConfigs · 7d82d293

authored Jul 02, 2020

Bug: angleproject:4809
Change-Id: I5f352f737bbd53c78d9e01055c17eabd17d5fb8a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2278667Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

7d82d293

11 Jul, 2020 1 commit

Vulkan: Set the wideLines features when available · 120e1d66

authored Jul 09, 2020

Bug: angleproject:4827
Change-Id: I40fc893fdaf7135e2ad782a489b59c518346db9c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2290582Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

120e1d66

10 Jul, 2020 7 commits

Vulkan: Fully enable pre-rotation for Android · 73b6b3a8

authored Jun 03, 2020

Bug: b/157667116
Change-Id: I3e5d41eed9b27eb2b49db853d85ec5c867dd2409
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2228366Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

73b6b3a8

Vulkan: Force flush staged updates for external textures · 2a2b4b13

authored Jul 09, 2020

For textures that are backed by external memory,
immediately flush sub image updates instead of
staging them.

Bug: angleproject:4828
Tests: angle_end2end_tests --gtest_filter=ImageTest.UpdatedExternalTexture*
Change-Id: I51e5bd0cb5df7df3af21f0cdb3007eebc1be29cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2290490Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

2a2b4b13

Roll Vulkan-ValidationLayers from 3bae90706d26 to 94f1ce331e85 (10 revisions) · 0a768f24

authored Jul 10, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3bae90706d26..94f1ce331e85

2020-07-09 lionel.g.landwerlin@intel.com layers: fix image/view with modifier format feature storage
2020-07-09 shannon@lunarg.com build: Fix VUID inconsistencies for 1.2.146 header
2020-07-09 shannon@lunarg.com build: Update known-good files for 1.2.146 header
2020-07-09 tony@lunarg.com layers: Fix log message
2020-07-09 tony@lunarg.com gpu: Fix enabling of required features
2020-07-09 tony@lunarg.com tests: Add PhysicalDeviceFeatures to device profile api
2020-07-09 s.fricke@samsung.com layers: Move some sparse VU to stateless
2020-07-09 40687079+rumblehhh@users.noreply.github.com Update BUILD.md to use correct helper.cmake path
2020-07-08 s.fricke@samsung.com tests: Add VUID 02711
2020-07-08 s.fricke@samsung.com layers: Add VUID 02711

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ie785c2a96631396eddff2a3af035d32de99d572d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2291930Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0a768f24

Roll glslang from 29c9135d06f1 to 5aaa0c2bc821 (1 revision) · 1d8240d8

authored Jul 10, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/29c9135d06f1..5aaa0c2bc821

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I56a48b5a6caf96b3d83106b447b017bd8d18dca6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2290809Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1d8240d8

Roll SPIRV-Tools from 7afbc0c8be3f to 94667fbf66ee (6 revisions) · fc9a340e

authored Jul 10, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7afbc0c8be3f..94667fbf66ee

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I4c5b033f8d38beef39a5b0f4ddd1b06e8d478fa1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2290808Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

fc9a340e

Roll SwiftShader from 28159ee9c8e3 to 6cd27bab06f4 (7 revisions) · eb0f83b8

authored Jul 10, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/28159ee9c8e3..6cd27bab06f4

2020-07-09 capn@google.com Remove unsupported formats
2020-07-09 sdefresne@chromium.org Convert GN libs lists to frameworks
2020-07-08 amaiorano@google.com Update llvm 10 Darwin config
2020-07-08 amaiorano@google.com Update llvm 10 Linux config
2020-07-08 amaiorano@google.com Enable Kokoro LLVM 10 builds on Windows
2020-07-08 amaiorano@google.com Add llvm-10 configs for Windows
2020-07-08 amaiorano@google.com Copy and modify update.py for LLVM 10

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I3f97ac0bad1677af046422230e01dc5059ec9bb9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2290807Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

eb0f83b8

Vulkan: Add driverUniform's buffer to mResourceUseList · fe36a647

authored Jul 08, 2020

There is a bug with mDriverUniforms' dynamicBuffer that we never add it
to context's mResourceUseList to let it hold onto it until GPU
completes. This causes old buffer gets recycled prematurely and gets
overwritten, result in rendering corruption. This CL adds current buffer
to the mResourceUseList so that it will be waited properly before gets
recycled.

Bug: b/160777679
Change-Id: I7707442e0f5ba408f5f28337422274e0c23b6bfb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2288325
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

fe36a647

09 Jul, 2020 5 commits

Add support for VK_KHR_sampler_ycbcr_conversion · f61272fb

authored Jun 17, 2020

This adds ability for applications to import Android Hardware Buffers
(AHBs) as OpenGL images which in turn can be sampled from and/or
written.

This was specifically tested with the common use case of importing a
buffer created by an media decoder and using that as a texture source to
include that video content on the screen. Tested with:
- Angry Birds 2 video player (for ads) requires YUV conversion.
- Basic Media Decoder example:
    https://github.com/android/media-samples/tree/master/BasicMediaDecoder

Bug: b/155487768
Change-Id: I9255450f81aa4daa2aace7205d4f6c3f225abcca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2175103
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

f61272fb

Vulkan: Warm up glslang on startup · b549be96

authored Jul 02, 2020

As soon as glslang is initialized (which is done when EGL is
initialized), try to compile a simple shader.  This will warm up
glslang's internals to avoid hitches on first shader compilation when a
WebGL application starts.

Potential future optimization is to use a worker thread to do this.

Bug: chromium:1091440
Change-Id: I6ac22e982d748af52a6e8b61239889425edc2edb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2280401Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

b549be96

Don't build vulkan_validation_layers on macOS. · fac68170

authored Jul 08, 2020

angle_enable_vulkan_validation_layers is false on is_mac,
so it looks like they were built by accident. Guard the dep
on $angle_root/src/common/vulkan:vulkan_validation_layers by
angle_enable_vulkan_validation_layers instead of angle_enable_vulkan,
and only define the target if angle_enable_vulkan_validation_layers
is true (because src/common/vulkan/BUILD.gn gets loaded due to deps
on other targets in it, and when a .gn file is loaded all the
targets in it get defined).

Since vulkan_validation_layers doesn't currently build on
arm macs, this happens to fix a build problem there, but it
also makes the build on intel macs a bit smaller.

This sidesteps comment 13 on the bug. If we ever want to use
the validation layers on mac, we'll have to do a real fix then.

Bug: chromium:1098741
Change-Id: I8164ff13de98d34ed875c6e6d0550eae64b2d0dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289042
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

fac68170

Vulkan: Rotate damage rects for 90/270 rotation · a740b193

authored Jul 08, 2020

ANGLE supports the EGL_KHR_swap_buffers_with_damage extension by using
the Vulkan-equivalent VK_KHR_incremental_present extension.  The
damage rectangles need to be rotated for 90/270-degree rotations.

Test: Aztec Ruins with VVL
Bug: b/157667116
Change-Id: I9a43594b30bc67ca80aeff7705b4350659207d09
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289035Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

a740b193

Remove angle_libjpeg_turbo_dir fallback after Chromium side fix · 58afe4cb

authored Jul 08, 2020

This is a follow up of crrev.com/c/2282277. To avoid ANGLE roll failure,
crrev.com/c/2285839 should be landed first.

Bug: None
Change-Id: I41ece21af4b689150d82b0b1bc7eaae21ce23fed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2286811Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jiajie Hu <jiajie.hu@intel.com>

58afe4cb

08 Jul, 2020 10 commits

Capture/Replay: Fix default uniform array capture · 13859945

authored Jun 26, 2020

The pointer from vector::data() already reflects the size of the
underlying type, so no need to include sizeof.  This caused us to
write beyond the vector bounds when reading multiple values.

We were also missing component count.

Test: MEC of NBA2K20
Bug: b/160014453
Change-Id: I51fc3f5f80c732221d6ea4b4bd1afde635e410a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2270909Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

13859945

Serialize d/s buffers + use color buffers' impl format for readPixels · 900c7e87

authored Jul 07, 2020

Adds serialization of depth/stencil buffer contents

Currently, readPixels on color buffers uses the gles front-end format,
which can be different from the implementation format used in the
backend. This can cause seg fault crashes when the number of bytes in
a pixel differs between the two format. Changes so that readPixels for
color buffers always use the backend format.

Bug: angleproject:4817
Change-Id: I62d5deb1320ea38ee46143b2aa97f372ba01baeb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2284451Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Manh Nguyen <nguyenmh@google.com>

900c7e87

Skip MultithreadingTest.MultiCreateContext on Ozone · 514c8f64

authored Jul 08, 2020

This tests crashes on Ozone, skip for now.

Bug: chromium:1103009
Change-Id: Ie686e69d937710b43b615372251801e83b7bde20
TBR=geofflang@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2288334Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

514c8f64

Roll Vulkan-Headers from db06fce926b0 to 2a164e9680a5 (3 revisions) · a3f6dc2f

authored Jul 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/db06fce926b0..2a164e9680a5

2020-07-07 caramelli.devel@gmail.com Update vk_icd.h for VK_EXT_directfb_surface extension
2020-07-07 oddhack@sonic.net Updates from @mark-lunarg
2020-07-07 oddhack@sonic.net Enumerate originating repository for all files in this repo.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I21ad8c0e57af9f5642bac17218d3726578e1411b
Bug: None
Tbr: syoussefi@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287289Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a3f6dc2f

Roll Vulkan-ValidationLayers from e8b96e86fe2e to 3bae90706d26 (2 revisions) · eb34cb96

authored Jul 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e8b96e86fe2e..3bae90706d26

2020-07-07 mark@lunarg.com objtracker: Don't report undestroyable objects
2020-07-07 mark@lunarg.com threading: Audit VkDisplay, VkDisplayMode object handling

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I3b5b36cd8cbdc0d3e77602491f61e1dca1840e00
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287269Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

eb34cb96

Roll glslang from f5ed7a69d5d6 to 29c9135d06f1 (3 revisions) · de19f275

authored Jul 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f5ed7a69d5d6..29c9135d06f1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I7bc2229226ae522a81a4eef168037d00c15c3606
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287272Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

de19f275

Roll Vulkan-Tools from abc9dff824c3 to 68bfbc219497 (1 revision) · ae681217

authored Jul 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/abc9dff824c3..68bfbc219497

2020-07-06 shannon@lunarg.com build: Update known-good files for 1.2.146 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I0b017b35dc432e12e2a20f11be715537171facfc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287271Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ae681217

Roll SwiftShader from f6f11215cd93 to 28159ee9c8e3 (1 revision) · d6e12133

authored Jul 08, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/f6f11215cd93..28159ee9c8e3

2020-07-07 swiftshader.regress@gmail.com Regres: Update test lists @ f6f11215

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I24efee8e954996c8f3048afa7cf6921e16da85de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2286777Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d6e12133

Roll SPIRV-Tools from 6a4da9da4215 to 7afbc0c8be3f (3 revisions) · 6783c53e

authored Jul 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6a4da9da4215..7afbc0c8be3f

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ic409e40ee92fee5ba96190130052e2921f355162
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2287270Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

6783c53e

Roll Vulkan-Loader from 4c6019a855e9 to 145050bf2b98 (3 revisions) · e6a6e45f

authored Jul 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/4c6019a855e9..145050bf2b98

2020-07-07 caramelli.devel@gmail.com Remove duplicate key / value in scripts/common_codegen.py
2020-07-07 shannon@lunarg.com build: Update known-good files for 1.2.146 header
2020-07-07 caramelli.devel@gmail.com loader: Add support for directfb surface extension

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I91524416216eddd12582a0254dc88accf188a2f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2286776Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e6a6e45f

07 Jul, 2020 6 commits

Fix bugs in angle_end2end_tests and frame capture · 3688cb36

authored Jun 28, 2020

1. CaptureGetShaderInfoLog_infoLog method should not require shader
object to be compiled
2. glCompressedTexImage3D's parameter locations are off by 1
3. EGLContextSharingTest.DisplayShareGroupObjectSharing test should not
delete buffers it has no access to since it will crash when running
capture replay

Bug: angleproject:4801
Change-Id: I0d407cdb44eb41eea4209eebab0996d3dd8ae5f5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2272862
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

3688cb36

Remove a few hardcoded path to libjpeg_turbo · 9b8ee0ff

authored Jul 06, 2020

Use the predefined GN override instead.

Also sort the predefined override alphabetically.

Bug: None
Change-Id: I92d0dda5ab416389398d0e88f8b3b9636752486d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2282277Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9b8ee0ff

Enable the use of chromium worker pool · 75b59e7d

authored Jun 30, 2020

This CL is a revert of:
  https://chromium-review.googlesource.com/c/chromium/src/+/2276245

The issue with CFI was fixed here:
  https://chromium-review.googlesource.com/c/chromium/src/+/2276245

Bug: chromium:1091259
Change-Id: I601112b106e63a96144191263ac6a867d77154d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2277099
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

75b59e7d

Fix typos in comment · 6fc53fdb

authored Jun 30, 2020

This CL fix typo in a comment introduced recently.
There is no functional change.

Bug: chromium:1091259
Change-Id: I56f1963514b87b2a93859a6db707be093e865e28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2276748
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6fc53fdb

Roll Vulkan-Headers from 8188e3fbbc10 to db06fce926b0 (1 revision) · dcd57068

authored Jul 07, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/8188e3fbbc10..db06fce926b0

2020-07-04 oddhack@sonic.net Update for Vulkan-Docs 1.2.146

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I399b1bccafada63ed83d384501747ba63aa80544
Bug: None
Tbr: syoussefi@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2284423Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

dcd57068

Roll Vulkan-ValidationLayers from 5c38b18ab460 to e8b96e86fe2e (2 revisions) · f74d3418

authored Jul 07, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5c38b18ab460..e8b96e86fe2e

2020-07-06 sam.walls@arm.com tests: Add test for Arm perfdoc check 23
2020-07-06 sam.walls@arm.com practices: Add passing implementation of Arm perfdoc check 23

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ia6ca63cca036eadaeda25a039a1ad432b06d80e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2284622Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f74d3418