Commits · 98553e374aa20f4d8019b5bcc98faab97fd4fd62 · Chen Yisong / angle

30 Sep, 2014 8 commits

Remove copyToRenderTarget methods. · 98553e37

authored Sep 30, 2014

These Renderer methods can be replaced with virtual TextureStorage
methods, now that we do not have TextureStorageInterface to
complicate matters. This reduces the number of stubs in Renderer
as well as allowing cleaner code re-use.

BUG=angle:729

Change-Id: I6d2004d4f1abdb1041420144cee1c173e5ab199e
Reviewed-on: https://chromium-review.googlesource.com/219839Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

98553e37

Moved the responsibility for releasing the dest surface out of copyToSurface. · 3a612876

authored Sep 29, 2014

BUG=angle:520

Change-Id: I4c6c39462b43eeb0a202f731c4a54007ef16445c
Reviewed-on: https://chromium-review.googlesource.com/219866Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

3a612876

Refactor Texture::compressed*Image methods to use gl::Error objects. · b5348331

authored Sep 02, 2014

BUG=angle:520

Change-Id: I8fd7ebf3edb3edef06e77b79776c363672931a61
Reviewed-on: https://chromium-review.googlesource.com/216646Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

b5348331

Merge the various TextureCube::setImage* methods. · 8376ceae

authored Sep 02, 2014

BUG=angle:520

Change-Id: I4e8191dd827744ef380348a31dce7181d99fbf30
Reviewed-on: https://chromium-review.googlesource.com/216645Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

8376ceae

Refactor Texture::setImage and subImage to use gl::Error objects. · 1ba6b8db

authored Aug 28, 2014

BUG=angle:520

Change-Id: Ib43ace0fbdab59086ae4314cce139636d9045e65
Reviewed-on: https://chromium-review.googlesource.com/216644Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1ba6b8db

Fix the ANGLE_ENABLE_TRACE build. · b60fe31f

authored Sep 26, 2014

We needed to include angleutils.cpp in libtranslator for this to
compile. Also allow the event helpers to record API calls even
if ANGLE_ENABLE_PERF is off.

BUG=angle:513

Change-Id: I2646d5ebeae536a4a7f1cd7ecaf0ce019ce5ff76
Reviewed-on: https://chromium-review.googlesource.com/219756Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

b60fe31f

Updated the PixelTransfer class to use Error objects. · ae5122c4

authored Aug 27, 2014

BUG=angle:520

Change-Id: I7e21acbfd5726607ea62c8fcf64d76bbf5877860
Reviewed-on: https://chromium-review.googlesource.com/216643Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

ae5122c4

Add a centralized workarounds module. · 7acae0a1

authored Sep 24, 2014

This is a temporary home for the various workarounds we use
for performance or to solve driver issues. Eventually we will
want a standalone library we can use as part of Chromium or
in ANGLE standalone.

Re-land with member variable initialized.

BUG=angle:729

Change-Id: If7f8f9596a39b2855366d9a67caebf6dd4197b55
Reviewed-on: https://chromium-review.googlesource.com/219868Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

7acae0a1

29 Sep, 2014 7 commits

Revert "Add a centralized workarounds module." · 57f20894

authored Sep 29, 2014

Was missing an initialization in Renderer.cpp.

This reverts commit 815a1dc3.

Change-Id: Ia4666911c2ff58660e0ab5c7cec4431b1c30a1e1
Reviewed-on: https://chromium-review.googlesource.com/220420Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

57f20894

Add a centralized workarounds module. · 815a1dc3

authored Sep 24, 2014

This is a temporary home for the various workarounds we use
for performance or to solve driver issues. Eventually we will
want a standalone library we can use as part of Chromium or
in ANGLE standalone.

BUG=angle:729

Change-Id: Ib0254262cad9f8fb779886dacb967be646ea96ae
Reviewed-on: https://chromium-review.googlesource.com/219838Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

815a1dc3

Reduce code duplication in generateMipmap. · 4aa79e11

authored Sep 29, 2014

Using the newly introduced image index struct, we can simplify
our code somewhat in TextureStorage.

BUG=angle:729

Change-Id: Iff274fd1df7a0dc36dd34e0cb31ad42831b4f5d5
Reviewed-on: https://chromium-review.googlesource.com/219836Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

4aa79e11

Add TextureD3D::getIndex. · cb83dc16

authored Sep 29, 2014

This is a simple virtual method which gives an ImageIndex at a
particular level and layer. It's useful for handling all the texture
types uniformly, which all treat levels and layers differently.

BUG=angle:729

Change-Id: I72db560287272c195b1ff8555f99ab2258ac7e6d
Reviewed-on: https://chromium-review.googlesource.com/219835Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

cb83dc16

Add ImageIndexIterator. · ef4ac5b1

authored Sep 29, 2014

We can use image index iterators to iterate over all images in a
Texture. This allows us to do some operations in TextureD3D rather
than in the typed subclasses and save on some repeated code.

BUG=angle:729

Change-Id: I3ba47b2eebad2cfca313117fd501ff76d5107044
Reviewed-on: https://chromium-review.googlesource.com/219834Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

ef4ac5b1

Fix gyp linux build. · e611b064

authored Sep 29, 2014

ANGLE implementation unit tests was enabled by mistake on Linux.

BUG=angle:761

Change-Id: Ibdca214466a6177aa50bdb3a3f55031dc0957b90
Reviewed-on: https://chromium-review.googlesource.com/220272Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

e611b064

Remove include of util.gyp from all.gyp. · a1a7492b

authored Sep 29, 2014

Since util.gyp doesn't have any executables, there isn't any need to
include it from all.gyp.  It should only be included by targets that
depend upon it.

BUG=angle:761

Change-Id: Iabad2da7bca0f161d092c044ab0021568f9b6f59
Reviewed-on: https://chromium-review.googlesource.com/219759Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

a1a7492b

26 Sep, 2014 3 commits

Moving Shader Executables into ProgramD3D · eb99436e

authored Sep 24, 2014

BUG=angle:731
Change-Id: I677fc9773914307184bcdd9ab7ac564956d77f6a
Reviewed-on: https://chromium-review.googlesource.com/219814Tested-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

eb99436e

Added SurfaceHost to enable additional hosts and abstract access for EGLNativeWindowType. · eeb1f537

authored Sep 23, 2014

Change-Id: I590b52925c6b9127d08eaf0e5ba2a0bde30505c3
Reviewed-on: https://chromium-review.googlesource.com/219488Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

eeb1f537

Update Renderer::copyToRenderTarget to return Error objects. · 9e3f24f6

authored Aug 27, 2014

BUG=angle:520

Change-Id: Ieab2d031d638056676e07d80aa024b6c6f12f3d6
Reviewed-on: https://chromium-review.googlesource.com/216642Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

9e3f24f6

25 Sep, 2014 6 commits

Benchmark point sprites test with several varyings. · 431cbc8e

authored Sep 24, 2014

A potential performance slowdown could be our geometry shader using
extra logic in packing varyings. Test this by adding a variable
number of varyings to the point sprites benchmark.

Initial tests show it could slow down the test by about 30-40% or so,
stil not catastrophic compared to D3D9.

BUG=angle:705

Change-Id: Ia815f0ee28e2af2d3dc4d9f5675c27bbeb4cb119
Reviewed-on: https://chromium-review.googlesource.com/216468Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

431cbc8e

Add a point sprite benchmark. · ea0e8733

authored Sep 24, 2014

This benchmark will attempt to reproduce the slowdown we see
in D3D11 on the turbulenz GPU particles demo.

BUG=angle:705

Change-Id: I9c4c2f09d4282feae30f448fd374cdbb6bceae9b
Reviewed-on: https://chromium-review.googlesource.com/216467Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ea0e8733

Update Renderer::copyImage to return Error objects. · e8356bb0

authored Aug 26, 2014

BUG=angle:520

Change-Id: I1bb7a53bc75ebb8bf324935b673ea636bdff6931
Reviewed-on: https://chromium-review.googlesource.com/216641Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

e8356bb0

Update blit calls to return Error objects instead of calling gl::error. · 64839155

authored Aug 26, 2014

BUG=angle:520

Change-Id: I94c3ad327433cf275744e98be6cb2ba91be49c0f
Reviewed-on: https://chromium-review.googlesource.com/216640Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

64839155

Move the code that writes the temporary shader file to the shader compiler. · f7ed7054

authored Sep 23, 2014

BUG=angle:755

Change-Id: I5fdc3ae112ea3f59694a22da6199b99a568ed0a1
Reviewed-on: https://chromium-review.googlesource.com/219530Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

f7ed7054

Refactor HLSLCompiler to use stl objects and encapulate workarounds. · 3935e51d

authored Sep 23, 2014

 * Pass std::strings for the source and profile.
 * Create a wrapper struct for storing the compile configurations and pass
   them to the compiler with an std::vector.
 * Remove function typedefs, they're available from the platform.h header.

BUG=angle:755

Change-Id: I19dd2be1655a12f76fc5718450db974a7ec324ec
Reviewed-on: https://chromium-review.googlesource.com/219287Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

3935e51d

24 Sep, 2014 2 commits

Removed the last references to Renderer from ProgramBinary. · 18bd4100

authored Sep 22, 2014

BUG=angle:731
Change-Id: I8829a434e59279b1b9c37e9a1922ae05d467b376
Reviewed-on: https://chromium-review.googlesource.com/219421Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Brandon Jones <bajones@chromium.org>

18bd4100

Rename GN public variables. · 10ac4043

authored Sep 24, 2014

forward_dependent_configs_from => public_deps
direct_dependent_configs => public_configs

Change-Id: I93beca2109181a2aac8d5793c3464b3af8b6ab9b
Reviewed-on: https://chromium-review.googlesource.com/219695Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Brett Wilson <brettw@chromium.org>

10ac4043

23 Sep, 2014 5 commits

Removed the last references to DynamicHLSL from ProgramBinary. · 44151a97

authored Sep 10, 2014

Migrated several more non-generic values from ProgramBinary the D3D impl.

BUG=angle:731
Change-Id: Ic043dd75328cffbc6bef6556da801c382b4138bc
Reviewed-on: https://chromium-review.googlesource.com/219390Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Brandon Jones <bajones@chromium.org>

44151a97

Fix some texture support queries ORing extensions instead of ANDing. · abce7620

authored Sep 19, 2014

A couple of formats that required two extensions would OR the checks
together when they should have ANDed them and allowed the validation to be
too permissive.

Fixed the checks and added a new one that needs to OR the extension checks
together to verify GL_DEPTH24_STENCIL8_OES support.

BUG=angle:752

Change-Id: I2e1e12fd428358e975cd22eb685b9a8fb797161f
Reviewed-on: https://chromium-review.googlesource.com/219094Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

abce7620

Remove the requirement that a format must be texturable to be renderable. · d87878e3

authored Sep 19, 2014

Previously, to determine if a texture format was renderable, the
texturable and renderable fields had to be and-ed together.  This caused
issues for formats such as D24S8 which can be renderable but not
texturable depending on available extensions.

Made the renderable flag a complete check that may be different than the
textureable flag and removed assumptions that a format is texturable if
renderable from the code.

GL_DEPTH24_STENCIL8 now checks for ANGLE_depth_textures for texturability
and ANGLE_depth_textures or OES_packed_depth_stencil for renderability.

BUG=angle:752

Change-Id: I6d197cee72cc249e5996fa395303bdf43d246a87
Reviewed-on: https://chromium-review.googlesource.com/219093Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

d87878e3

Update the draw calls to return Error objects. · c77e8c39

authored Sep 08, 2014

BUG=angle:520

Change-Id: I3330ba2dbe095fc9460789822a938420a80a149f
Reviewed-on: https://chromium-review.googlesource.com/213823Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

c77e8c39

Updated the swizzle generation functions to use Error objects. · 3110ffdc

authored Sep 08, 2014

BUG=angle:520

Change-Id: I01b3cdb7d6719582fa8a57f21218705f6743a7b0
Reviewed-on: https://chromium-review.googlesource.com/217103Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

3110ffdc

22 Sep, 2014 2 commits

Create test configuration include guards · 950cb606

authored Sep 18, 2014

BUG=angle:501

Change-Id: I0281cf6de4fbf8ddd142b7af4ea2917f0a0a1569
Reviewed-on: https://chromium-review.googlesource.com/218840Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

950cb606

Use a D24S8 format to back GL_DEPTH_COMPONENT32_OES in D3D9. · df647a2a

authored Sep 19, 2014

Looks like the D3D9 D32 format isn't available on most GPUs (and doesn't
exist in D3D11) so back GL_DEPTH_COMPONENT32_OES with D24S8 instead to
match D3D11.

BUG=angle:750

Change-Id: I0f7a124544c1c14ba21db20fbf6765d07e244966
Reviewed-on: https://chromium-review.googlesource.com/219080Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

df647a2a

19 Sep, 2014 6 commits

Fix a NULL dereference on buffer initialization. · ee009b8e

authored Sep 19, 2014

In some cases, where the user would create a buffer with NULL (empty)
data, we would attempt to dereference NULL when drawing with the
buffer as a vertex attribute.

BUG=angle:749

Change-Id: Ied5ecbab4608c85890cdf7cc32a8dae46989e33b
Reviewed-on: https://chromium-review.googlesource.com/219090Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

ee009b8e

Remove rx::TextureStorageInterface entirely. · 2f06dbfb

authored Sep 18, 2014

This class provides no added benefit now that we've scrapped the
type-specialized classes. We can squash it's functionality into
TextureStorage instead.

BUG=angle:741

Change-Id: I04984806719a01f299986265fe09b3cccf04dca5
Reviewed-on: https://chromium-review.googlesource.com/218316Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2f06dbfb

Squash the TextureStorageInterface heirarchy. · 856d9d4b

authored Sep 18, 2014

Since there are no longer any significant differences in the child
classes of TextureStorageInterface, we can scrap the different
implementations. This involves changing the function names of some
Renderer functions which relied on overloading.

BUG=angle:741

Change-Id: I074797e4ac0bf3ecf8fe4bddf84eaed28b1a2c23
Reviewed-on: https://chromium-review.googlesource.com/218315Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

856d9d4b

Move generateMipmap to storage interface base class. · 5e48c034

authored Sep 18, 2014

Using a little bit more of code repetition allows us to move the
implementation of the mipmaps to a simple virtual interface in
TextureStorage.

BUG=angle:741

Change-Id: I7661d0cc3bdb02b646da0802cba285650d7832b2
Reviewed-on: https://chromium-review.googlesource.com/218314Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

5e48c034

Use ImageIndex in getRenderTargetSerial. · c483326b

authored Sep 18, 2014

Also move getRenderTargetSerial to the TextureStorageInterface
base class, since it shares a common interface.

BUG=angle:741

Change-Id: I1bc1cfac6426e241ac91d373884a7dd8a1c5b188
Reviewed-on: https://chromium-review.googlesource.com/218313Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

c483326b

Updated the vertex buffer classes to use Error objects. · f7100b98

authored Sep 08, 2014

BUG=angle:520

Change-Id: Id003e66b2acbf37dbbe66aaca2fa336c3c884be2
Reviewed-on: https://chromium-review.googlesource.com/217102Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

f7100b98

18 Sep, 2014 1 commit

Fix Renderer11 signed/unsigned warning in 32-bit. · d5a796ca

authored Sep 18, 2014

Change-Id: I1e11f54b0ae245cdd7e090ab0748821738ad6314
Reviewed-on: https://chromium-review.googlesource.com/218761Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

d5a796ca