- 13 Jan, 2020 5 commits
-
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/110236f3ce70..b0ca2a89e255 git log 110236f3ce70..b0ca2a89e255 --date=short --first-parent --format='%ad %ae %s' 2020-01-11 bclayton@google.com Pipeline: Implement the SpirvShader debugger. 2020-01-11 swiftshader.regress@gmail.com Regres: Update test lists @ 0f8f361a 2020-01-10 swiftshader.regress@gmail.com Regres: Update test lists @ 110236f3 2020-01-10 sugoi@google.com Removed a few parentheses for slightly better clang formatting 2020-01-10 sugoi@google.com A2R10G10B10 Support 2020-01-10 ianelliott@google.com Change sampledImageIntegerSampleCounts to sampleCounts 2020-01-10 srisser@google.com Add the PowerVR SDK as a git submodule Created with: gclient setdep -r third_party/SwiftShader@b0ca2a89e255 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I598844bc14cd0c3654a6ace7f17bd2040cc80a36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993886Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c17344df6cca..b96d6528883e git log c17344df6cca..b96d6528883e --date=short --first-parent --format='%ad %ae %s' 2020-01-10 mark@lunarg.com tests: Fix YCbCr sampler test 2020-01-10 pdaniell@nvidia.com corechecks: Fix issues with separate depth/stencil layouts 2020-01-10 petr_kraus@email.cz layers: Report valid spec links on error 2020-01-10 petr_kraus@email.cz tests: Test vkCmdExecuteCommands into a Secondary 2020-01-10 s.fricke@samsung.com tests: Added test for VUID 01618 2020-01-10 s.fricke@samsung.com tests: Added test for VUID 01608 2020-01-10 s.fricke@samsung.com tests: Added test for VUID 01588 2020-01-10 s.fricke@samsung.com layers: Added VK_IMAGE_CREATE_DISJOINT_BIT validation 2020-01-10 s.fricke@samsung.com tests: Added 01564 test to DSAspectBitsErrors 2020-01-10 s.fricke@samsung.com layers: Added support for VUID 01564 2020-01-10 s.fricke@samsung.com tests: Added test for VUID 01648 2020-01-10 s.fricke@samsung.com layers: Added support for VUID 01648 2020-01-10 s.fricke@samsung.com tests: Added 01560 test to ImageBufferCopyTests 2020-01-10 s.fricke@samsung.com layers: Added support for VUID 01560 Created with: gclient setdep -r third_party/vulkan-validation-layers/src@b96d6528883e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I7b9edbae8b42a41042e8adec7a5c3b12dd8be724 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993887Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fb2e819819ef..18b3b94567a9 Created with: gclient setdep -r third_party/spirv-tools/src@18b3b94567a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ied4595d3d1b2ea5d7352f719c441c9b2d8baa75f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993889Reviewed-by:
-
Yan, Shaobo authored
For current WEBGL_video_image implementation, VideoImage texture type translates to its native texture type in blink layer. A refactory for this implementation is required but is complicated and need much time. Currently, we need a workaround in ANGLE to support this extension. Current end2end tests can monitor this workaround well. BUG=chromium:776222, angleproject:3889 Change-Id: I864bc2734cfffc8c5aea6166466767e3fb31c1c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989864 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
Bind the driver uniforms set only when actually updating them. Bug: angleproject:4261 Change-Id: Ie1f1ab61eef58c5e0c713d285050c79c4cfccb32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986928 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Mohan Maiya <m.maiya@samsung.com>
-
- 11 Jan, 2020 6 commits
-
-
Shahbaz Youssefi authored
The programs have a different shader interface, to force rebinding descriptor sets in the Vulkan backend. Bug: angleproject:4261 Change-Id: I7a18a441483dfe34bd40b5a30ca34b7fd0dc3219 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990085 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
The test had two array sizes swapped, causing failure on vendors that statically verified index-out-of-bound accesses. Bug: angleproject:3831 Change-Id: I8ec32e9c11b38b69f03b1a22e60dfb6c6e82c2a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947123Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
-
Shahbaz Youssefi authored
This function was unconditionally calling finishImpl(). This is changed to finishToSerial() to only wait until the serial that actually used the buffer. Bug: angleproject:3072 Change-Id: Ida89bb119b4ba6420f12404b911af0e3b4583a51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993407 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
Under robustBufferAccess, Vulkan states that: Vertex input attributes are considered out of bounds if the offset of the attribute in the bound vertex buffer range plus the size of the attribute is greater than either: - vertexBufferRangeSize, if bindingStride == 0; or - (vertexBufferRangeSize - (vertexBufferRangeSize % bindingStride)) The latter implies that if the buffer size is not a multiple of the vertex attribute stride, what lies beyond the last multiple of stride is considered out of bounds. It also says: Out-of-bounds buffer loads will return any of the following values: - Values from anywhere within the memory range(s) bound to the buffer (possibly including bytes of memory past the end of the buffer, up to the end of the bound range). - Zero values, or (0,0,0,x) vectors for vector reads where x is a valid value represented in the type of the vector components and may be any of ... The first bullet point indicates that the driver is allowed to load the attribute values from the buffer if its range still lies within the buffer size. Take the following example: - Buffer size = 12 - Attribute stride = 8 - Attribute offset = 0 - Attribute size = 4 Basically the buffer is thus laid out as follows: attr stride _________/\_________ / \ +----------+----------+----------+ | vertex 0 | padding | vertex 1 | +----------+----------+----------+ \___ ____/ V attr size In the above example, the attribute for vertex 1 is considered out of bounds, but the driver is allowed to either read it correctly, or return (0, 0, 0, 1) for it. Most drivers implement the former, while AMD implements the latter. This change introduces a workaround for AMD where GL_MAX_VERTEX_ATTRIB_STRIDE is limited to 2048 (the common value for it according to gpuinfo.org) and conservatively rounds up every buffer allocation to that size. While technically, this workaround should be applied on any device with the robustBufferAccess feature enabled, it is currently limited to AMD to avoid the inefficiency. A possible future revision of Vulkan may relax the above restrictions. Bug: angleproject:2848 Change-Id: Ida5ae5d777da10f22ce8be5a09a7644b5bbd778e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1991709Reviewed-by:Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
When the program binding changes, we set the descriptor sets binding dirty bit if the program had any textures, UBOs, SSBOs, images or atomic counters. The check for default uniforms was missing. So if the two programs had no resources and were only using default uniforms, then drawing with one after the other didn't update the descriptor set binding of the default uniforms for the second draw. Bug: angleproject:4277 Change-Id: I631a1619658ee713484cfaee99fe1e39987e16e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993408 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
Eric Binet authored
Bug: angleproject:2970 Change-Id: Ie14725b0cf30738d394320c24a72bc947135f5cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993204Reviewed-by:
-
- 10 Jan, 2020 7 commits
-
-
Eric Binet authored
Added a small helper function (LimitVersionTo) to prevent future mistakes. Bug: angleproject:4168 Change-Id: Ia19312459540adbc2788ad0a5cb3d19ef1ff784f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1992185 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com> Reviewed-by:
-
Eric Binet authored
Also added a few assertions to ensure that timestamp queries aren't attempted when support is missing. Bug: angleproject:4114 Change-Id: Ie6d7d5face59f9bc137aebd86c9d0e965773e6e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1992184 Commit-Queue: Eric Binet <ericbinet@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Courtney Goeltzenleuchter authored
Swiftshader does not have support for D24_S8 (typical fallback for 32bit DEPTH_COMPONENTS) but does have D32_FLOAT, so add fallback to that format. This then allows ANGLE to support OES_depth_texture extension when using Swiftshader which is needed to allow Vulkan swiftshader to replace GL swiftshader. Bug: angleproject:4232 Change-Id: Iaf04fcf0bea8d9cca0b9e7a18e3351ce8c704355 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986413 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Tobin Ehlis <tobine@google.com> Reviewed-by:
-
Yuly Novikov authored
winuwp-x64-dbg and winuwp-x64-rel CI and Try bots. Bug: angleproject:3928 Change-Id: Ifc54f6daae1090f9c68be6edcd8b1a069f0c5fc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993691 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ac72777ef763..c17344df6cca git log ac72777ef763..c17344df6cca --date=short --first-parent --format='%ad %ae %s' 2020-01-09 petr_kraus@email.cz scripts: Report unassigned VUIDs in stats 2020-01-09 petr_kraus@email.cz scripts: Add best practices tests to stats Created with: gclient setdep -r third_party/vulkan-validation-layers/src@c17344df6cca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I670cc25dee3714a451636bfa1e66145d8f77181f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1994252Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/77c89ff847b6..110236f3ce70 git log 77c89ff847b6..110236f3ce70 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 sugoi@google.com Enable filtering depth+stencil formats 2020-01-09 bclayton@google.com Kokoro: Disable ASAN for debug mac builds 2020-01-09 bclayton@google.com SpirvShader: Move extension list out of for loop. 2020-01-09 bclayton@google.com C++14: Use std::make_unique where possible. 2020-01-09 swiftshader.regress@gmail.com Regres: Update test lists @ 77c89ff8 Created with: gclient setdep -r third_party/SwiftShader@110236f3ce70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ibe4bccbad9c9f306953164aa7c0faf8c778ba68c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1994251Reviewed-by:
-
Kenneth Russell authored
Added the EAGL backend authored by Dean Jackson from Apple, and the refactoring changes needed to support it side-by-side with the macOS backend. Ran "git cl format" against these diffs. Defined the EGL_ANGLE_device_eagl extension and allocated an enum out of ANGLE's reserved range. The iOS backend is not yet included in any of the GN files. Bug: angleproject:4263 Change-Id: I631c32930433c03bb16a242955ffedf55174bb29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987278Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
-
- 09 Jan, 2020 7 commits
-
-
Kenneth Russell authored
Dependencies seem to be incorrectly tracked in some Intel OpenGL drivers (on macOS specifically), causing crashes in glDeleteTextures if a GL command buffer is being constructed where those textures are destinations of CopyTexImage2D/CopyTexSubImage2D. Work around this bug by flushing before texture deletion if CopyTex{Sub}Image have been called recently. The tracking is only done on a per-context rather than a per-device basis, but seems sufficient to work around the problem as identified. Tested both with new ANGLE test on affected hardware, and in WebKit's ANGLE backend for WebGL. Works around the crash reported in https://bugs.webkit.org/show_bug.cgi?id=205707 . Bug: angleproject:4267 Change-Id: I2266a5590759f6a3f19080def08710ef4b66d463 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987932 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:Geoff Lang <geofflang@chromium.org> Reviewed-by:
-
Tobin Ehlis authored
Need to explicitly specifly volk LICENSE.md filename in README.chromium file. Bug: angleproject:4225 Change-Id: I5d71ef0c28063f6e036f94ddb7d2c9e289fe79d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993397Reviewed-by:
-
James Darpinian authored
In https://crrev.com/c/1838418 I added the ability to disable ARB_texture_rectangle so that we can use it in the WebGL implementation but disable it when compiling user shaders. Unfortunately disabling and re-enabling the extension causes the shader translator to be reinitialized which turns out to be more expensive than the actual work of shader translation, at least for small shaders. It's slow enough to cause timeouts in WebKit's WebGL conformance test runs. This introduces an alternate method of disabling ARB_texture_rectangle in the translator which is much faster because it avoids reinitializing the translator. Bug: angleproject:3956 Change-Id: I5d31b683ff19a59bdfd289cfd3c609f64ef5e25b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1991969Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e70b009b0f1e..fb2e819819ef Created with: gclient setdep -r third_party/spirv-tools/src@fb2e819819ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC cwallez@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com,jmadill@google.com Change-Id: Ife103b6f2c902c3ec357ab5058c1afe0c5648119 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993380Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/45a4d0f36bd6..77c89ff847b6 git log 45a4d0f36bd6..77c89ff847b6 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 bclayton@google.com Build: Verify that we're compiling with C++14. 2020-01-08 bclayton@google.com Build: Move from using C++11 to C++14. 2020-01-08 bclayton@google.com Kokoro: Update from GCC 4.8 to GCC 7. 2020-01-08 bclayton@google.com Pipeline/SpirvShader: Move setActiveLaneMask() 2020-01-08 bclayton@google.com Pipeline/SpirvShader: Support more OpExtInsts 2020-01-08 bclayton@google.com Pipeline/SpirvShader: Process OpString instructions 2020-01-08 bclayton@google.com Pipeline/SpirvShader: Add Impl struct 2020-01-08 bclayton@google.com Vulkan/Debug: Expose Frames from Thread 2020-01-08 sugoi@google.com Enable B10G11R11_UFLOAT blending 2020-01-08 bclayton@google.com Vulkan/Debug: Add Reference value type. 2020-01-08 chrisforbes@google.com Add storage image support for R16G16_{UINT,SINT,SFLOAT} 2020-01-08 bclayton@google.com Vulkan: Plumb the debug context down to SpirvShader 2020-01-08 bclayton@google.com Vulkan: Add debugging of the command buffer. Created with: gclient setdep -r third_party/SwiftShader@77c89ff847b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I9f7014f2de23f3f9411f07a4b95c0cc48ab5e6ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993043Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/258b887827ab..ac72777ef763 git log 258b887827ab..ac72777ef763 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 mark@lunarg.com corechecks: Fix immutable sampler write fall-through case Created with: gclient setdep -r third_party/vulkan-validation-layers/src@ac72777ef763 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Id7c2391bdd232852542eb65a5d8372f73cf6d4d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993044Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1642ca11282a..51813670627c Created with: gclient setdep -r third_party/glslang/src@51813670627c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Id259094225cc9d58472153114d5836bddb4b6aaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1993045Reviewed-by:
-
- 08 Jan, 2020 7 commits
-
-
Jamie Madill authored
The Serial will help track active resources for filtering out inactive setup calls in capture/replay. Bug: angleproject:4223 Change-Id: I64ba50f27d656c12d45155dc735e9b6f9c04528f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969062 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Tobin Ehlis authored
All ANGLE volk changes have been upstreamed to volk repo so rolling volk to sync with latest. Going forward we can just roll when/if we need newer versions of Vulkan Header supported by volk. Bug: angleproject:4225 Change-Id: I6132a94010bbc5f3356ebb0b7e2b2b661ecc68b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1991722Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
-
Eric Binet authored
In the previous version, the IndexedPointsTestUInt tests named VertexWithColorUnsignedIntOffset* were redundant with UnsignedIntOffset*. Bug: angleproject:3923 Change-Id: I6b9b8f2bd78882bcac7c3b89e798291ee94eea70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1988998 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b416ed86e4b2..258b887827ab git log b416ed86e4b2..258b887827ab --date=short --first-parent --format='%ad %ae %s' 2020-01-07 mark@lunarg.com tests: Add test for a write update to an immutable sampler 2020-01-07 mark@lunarg.com tests: Add test for copying to immutable samplers 2020-01-07 mark@lunarg.com corechecks: Add validation for writing to immutable samplers Created with: gclient setdep -r third_party/vulkan-validation-layers/src@258b887827ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I4fdaffd02584138c7d4e9d6f0c69221d628cf8ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990983Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/068dd89cab31..45a4d0f36bd6 git log 068dd89cab31..45a4d0f36bd6 --date=short --first-parent --format='%ad %ae %s' 2020-01-08 capn@google.com Disable unused function warning 2020-01-07 bclayton@google.com Regres: Apply fix for invalid SPIR-V in 12 tests. 2020-01-07 capn@google.com Disable LLVM & Subzero stack traces and crash handling 2020-01-07 digit@google.com vulkan: use a marl::Event in the VkSemaphore implementation. 2020-01-07 digit@google.com [vulkan] Simplify vk::Semaphore implementation. Created with: gclient setdep -r third_party/SwiftShader@45a4d0f36bd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I5b338a33ea57117912e019075c52f09351badea7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990982Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1d258ac34698..1642ca11282a Created with: gclient setdep -r third_party/glslang/src@1642ca11282a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I6a686ddc411f6e2087b146fbd146c6a63675bf34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990984Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/55333361f9a1..2c436960d2c0 git log 55333361f9a1..2c436960d2c0 --date=short --first-parent --format='%ad %ae %s' 2020-01-07 charles@lunarg.com vulkaninfo: Make presentation surface names a set Created with: gclient setdep -r third_party/vulkan-tools/src@2c436960d2c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: If653af60cbc98b72138c4e1768ec7ccae4f6543c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1990981Reviewed-by:
-
- 07 Jan, 2020 8 commits
-
-
Tobin Ehlis authored
Roll volk to the latest version which supports Vulkan 1.1.130. I'm attempting to upstream our customizations to that version so this roll is in preparation of those changes hopefully landing. Bug: angleproject:4225 Change-Id: I02f3bd3808f812c0ec8196b6c815a781e7ab5eeb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989479Reviewed-by:
-
Ian Elliott authored
This fixes a crash (preceeded by Vulkan validation errors) when running the following test: --gtest_filter=dEQP.KHR_GLES31/core_texture_storage_multisample_FunctionalTests_blitting_multisampled_depth_attachment* --use-angle=vulkan The problem is that GraphicsPipelineDesc::updateRasterizationSamples() is rarely called (e.g. glBindFramebuffer). The above dEQP test changes between draw attachments that do and don't have multisampling enabled. The number of samples is set (the first time) to have multisampling enabled, and never changed, even though other attachments don't have multisampling. FramebufferVk::syncState() now calls updateRasterizationSamples(). That fix uncovered a latent problem: when an application destroys all framebuffers (including the draw framebuffer), the ContextVk still points at the old draw framebuffer's FramebufferVk (now freed). This is fixed with new plubming to clean-up ContextVk::mDrawFramebuffer. Bug: angleproject:4240 Change-Id: I151ec40ab821efc07c26323c34275c9165ad2ed5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1983393Reviewed-by:
-
Tobin Ehlis authored
Enable DebugUtils Vulkan extension for Android. This rolls VK Validation Layer dep forward to include a fix that allows this extension to work correctly with Android loader. Here's the Validation layer fix: https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/1464 Bug: angleproject:3852 Change-Id: I74c55c0a66a7ee4db3b623221c8fb6c4433a39af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1985175 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by:
-
Corentin Wallez authored
The test fails with the following at a very low flake rate: ../../third_party/angle/src/tests/gl_tests/VertexAttributeTest.cpp:230: Failure Expected equality of these values: angle::MakeGLColor(255, 255, 255, 255) Which is: White angle::ReadColor((midPixelX + viewportSize[2]) / 2, midPixelY) Which is: Transparent Black TBR=jmadill@chromium.org Bug: angleproject:4269 Change-Id: I82752acfbcb2a067ccb35a7a456def03299c359f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1987258Reviewed-by:Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/10a900e5ffaf..068dd89cab31 git log 10a900e5ffaf..068dd89cab31 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 bclayton@google.com SPIRV-Tools: Update Android.bp to fix build. 2020-01-06 capn@google.com Limit Vulkan memory allocation size to 1 GiB 2020-01-06 bclayton@google.com IDs: Move inline impls below class. 2020-01-06 bclayton@google.com Pipeline: Store builtins on SpirvRoutine... 2020-01-06 bclayton@google.com Style: clang-format the tests source too 2020-01-06 bclayton@google.com Merge changes Id1120acb,Ifc6afcda,I8b5da04a,I9389ad9e,I35d60f68 2020-01-06 sugoi@google.com Improve 1010102 blend precision Created with: gclient setdep -r third_party/SwiftShader@068dd89cab31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I9df3cbc0059453193adfbee90f767d06c0149fa2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989339Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6334d594f68c..1d258ac34698 Created with: gclient setdep -r third_party/glslang/src@1d258ac34698 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: If27787415b62ecdeee7192fdb6663e8b80cdec79 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989337Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2be3fe0f8471..b416ed86e4b2 git log 2be3fe0f8471..b416ed86e4b2 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 mark@lunarg.com layers: Added stub functions for instance exts and funcs Created with: gclient setdep -r third_party/vulkan-validation-layers/src@b416ed86e4b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I1b8ae6d289e25c34c731c4acd42c30dead3ea6d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1989338Reviewed-by:
-
Shahbaz Youssefi authored
This change moves driver uniforms to a set with a lower id than the one that includes (emulation) transform feedback buffers. Imagine the following: - Program 1 with xfb: UniformsSet: 1 VS uniforms buffer, 1 FS uniforms buffer, 1 xfb buffer - Program 2 without xfb: UniformsSet: 1 VS uniforms bufer, 1 FS uniforms buffer. Previously, UniformsSet was index 0, and DriverUniformsSet was index 3. When switching from Program 1 to Program 2, the layout of UniformsSet changes, which means every subsequent set needs to be rebound. This is a Vulkan pipeline layout compatibility rule. This is done with invalidateCurrentTextures() and invalidateCurrentShaderResources() already when handling gl::State::DIRTY_BIT_PROGRAM_EXECUTABLE. The bug is that the driver uniforms are not invalidated. This is normally not an issue, because usually when switching from Program 1 to Program 2, transform feedback is paused, and this state change does invalidate driver uniforms. However, the following scenario doesn't do this: - Begin Xfb - Pause Xfb - Use Program 1 - Draw - Use Program 2 - Draw - End Xfb There is no driver state change between the two draw calls, which means the second draw will attempt to draw using the driver uniforms bound for the first draw call. There is a Vulkan validation error here due to the above pipeline layout validation rule. The issue manifests itself only when the second draw call actually uses driver uniforms, as otherwise that set is inactive and not validated; i.e. when line raster emulation is used. In summary, the validation error manifests itself when: - Transform feedback and line raster both use emulation - Transform feedback is paused - A draw with an xfb program is followed by a non-xfb program - The second draw is a line draw A test is added for this. The solution is to reorder the sets so that DriverUniformsSet is placed before UniformsSet. This way, changes to the layout of UniformsSet don't invalidate DriverUniformsSet. In fact, based on the above, any change in the layout of the program should have required an invalidation of the driver uniforms. This bug is probably masked by the fact that ContextVk::handleDirtyDescriptorSetsImpl() always rebinds the graphics driver every time any descriptor set needs rebinding. That should be removed in a follow up change. Bug: angleproject:4261 Change-Id: I21ad4152b454a1fe70554be02e18a9c94fb3e7a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1986927Reviewed-by:
-
