Commits · a26ad58dab8300070ba8dba152b99611cfe6e2aa · Chen Yisong / angle

10 Aug, 2015 1 commit

Track where l-values are required in AST traversal · a26ad58d

authored Aug 04, 2015

This functionality is refactored out of EmulatePrecision to be a common
feature of TIntermTraverser. This is done since tracking where l-values
are required will be useful for other traversers. For example, it will
be needed for converting dynamic indexing of matrices and vectors to
function calls. This change adds some overhead to all tree traversers,
but the overhead is expected to be small for typical shaders which don't
contain too many user-defined functions.

BUG=angleproject:1116
TEST=angle_unittests

Change-Id: I54d34c2b5093ef028f2b24d854c11c0195dc1dbb
Reviewed-on: https://chromium-review.googlesource.com/290514Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

a26ad58d

07 Aug, 2015 8 commits

Use WGL_ARB_pixel_format to choose the pixel format when available. · 45808a17

authored Aug 07, 2015

BUG=angleproject:890

Change-Id: If10ea7e1cb670bb3cd6fdcf40344d1c1e0acd862
Reviewed-on: https://chromium-review.googlesource.com/291650Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

45808a17

Implement dirty bits for RendererGL's basic state. · 1b94d432

authored Aug 07, 2015

BUG=angleproject:1040
TEST=angle_end2end_tests,angle_perftests,WebGL

Change-Id: I72beaf7e178e042440337fbb8b9669638c5ad016
Reviewed-on: https://chromium-review.googlesource.com/289558Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

1b94d432

Update ANGLE's GPU test expectations code. · 519a5be2

authored Jul 23, 2015

Pull over the more recent changes from Chromium which include the
graphics API, which we can use for specific API suppressions for
the dEQP tests.

Also update the docs with detailed steps for updating from Chrome.

BUG=None

Change-Id: I0cb7d8268fbb2778c0160a58f1a10ef4a92c9c61
Reviewed-on: https://chromium-review.googlesource.com/287810Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

519a5be2

Implement ES 2,3 parts of EXT_blend_func_extended for shader translation · b18609b9

authored Jul 16, 2015

Exposes gl_SecondaryFragColor, glSecondaryFragData[] and
gl_MaxDualSourceDrawBuffers to GLES SL 1.0.

Relaxes rules for undefined output locations for GLES SL 3.0
and exposes gl_MaxDualSourceDrawBuffers.

If the output GL context is GL ES 2.0 or 3.0:
The emulation layer is expected to turn on EXT_blend_func_extended
if the output GL context supports it.

If the output GL context is GL:
The emulation layer is expected to turn on EXT_blend_func_extended
if the output GL context supports ARB_blend_func_extended or if GL
context is 3.2 or later.

If the source shader spec is GLES SL 2.0: The emulation layer is
expected to inspect the shader compilation output variables upon
linking. If output target is GL SL, the emulation layer should bind
color location 0, index 1 to "angle_SecondaryFragColor" if variable
"gl_SecondaryFragColorEXT" is used. Alternatively, emulation layer
should bind "angle_SecondaryFragData" to locations 0,1,2,3,..., all
color index 1, if "gl_SecondaryFragData" array is used.
(The caller can not bind the locations or specify output variables.)

If the source shader spec is GLES SL 3.0:
The emulation layer is expected to do location auto-resolve of the
the output variables that have undefined output locations that have
not been bound by the caller.
(The caller can not use gl_ built-ins, so nothing to do with those.)

BUG=angleproject:1085
TEST=angle_unittest

Change-Id: I5cafe205b0c29478b0dcd24aa89a7b0000f5d046
Reviewed-on: https://chromium-review.googlesource.com/287580Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Kimmo Kinnunen <kkinnunen@nvidia.com>

b18609b9

Fix warnings caused by gmock on linux · 3574c614

authored Aug 07, 2015

When mocking functions gmock uses the keyword virtual instead of
override and this conflicted with our usage of override for the
destructor (there is a warning for using all one or the other).

BUG=

Change-Id: I9dd9204d5755dd3a588a32d438de3c1018ba07cd
Reviewed-on: https://chromium-review.googlesource.com/291630Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

3574c614

ANGLETest::SetUp: resize the window only if needed. · b44440d8

authored Jul 22, 2015

This avoids a flickering of the window at the start of every test.

Reland with a speculative fix for ViewportTest

BUG=angleproject:1105

Change-Id: I83e89881de5b6f58cfb3e14cbe324fd9547f2836
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/288533Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

b44440d8

ViewportTest::SetUp set the scissor to the default value · b4191c3e

authored Aug 06, 2015

Previously ViewportTest would rely on the scissor being set to the
size of the window by default, which is a fragile assumption as the
scissor is set to the size of the window only on the first makeCurrent.

BUG=angleproject:1105

Change-Id: I088565c7032fe817eb5c48a5351cc678fe42b376
Reviewed-on: https://chromium-review.googlesource.com/291310Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

b4191c3e

Refactor input layout & vertex signatures. · f8dd7b10

authored Aug 05, 2015

Always size input layouts to gl::MAX_VERTEX_ATTRIBS, and use '1' bits
to signal where we have a GPU conversion. The simplification allows us
to more cleanly match the vertex executable signatures and makes our
default VertexExecutable hit much more often.

BUG=510151
TEST=angle_end2end_tests,Canary WebGL, manual testing with Chromium

Change-Id: I5009323c4e7e208e7a2595be46658c344517a4ff
Reviewed-on: https://chromium-review.googlesource.com/290740Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

f8dd7b10

06 Aug, 2015 1 commit

Implement the egl and gl layers of EGL Image. · a840617a

authored Jul 21, 2015

Add end2end tests and unittests.

BUG=angleproject:970

Change-Id: Ie8306971730a793f08dfd09ead1bfd6ff3e4623d
Reviewed-on: https://chromium-review.googlesource.com/291260Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

a840617a

05 Aug, 2015 6 commits

Revert "Implement the egl and gl layers of EGL Image." · 4274f7d2

authored Aug 05, 2015

This reverts commit 22a4f38c.

Change-Id: I07acbfe28d11675236de2ea7f6b050c25f80579a
Reviewed-on: https://chromium-review.googlesource.com/290960Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

4274f7d2

Revert "Fix warnings on gcc builds in ImageTest.cpp." · 35ab4299

authored Aug 05, 2015

This reverts commit 52ff4ac9.

Change-Id: I11ec6e7e343dd6579f7aa13106facc65b05eb795
Reviewed-on: https://chromium-review.googlesource.com/290940Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

35ab4299

Fix warnings on gcc builds in ImageTest.cpp. · 52ff4ac9

authored Aug 05, 2015

BUG=angleproject:970

Change-Id: Ic7f451fb4c2378c7574ede7c513a5bb9d903c908
Reviewed-on: https://chromium-review.googlesource.com/290920Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

52ff4ac9

Implement the egl and gl layers of EGL Image. · 22a4f38c

authored Jul 21, 2015

Add end2end tests and unittests.

BUG=angleproject:970

Change-Id: I13fc501b24c3f11bfedc810c1ff80fcf1318877c
Reviewed-on: https://chromium-review.googlesource.com/287343Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

22a4f38c

Reland of "Add Iterable bitset class." · 6b2a0b0c

authored Aug 03, 2015

This helper allows us to quickly iterate state bits from the
Impl/Renderer layers.

Re-land with no C++11 usage.

BUG=angleproject:1040
TEST=angle_unittests (Mac/Win/Linux)

Change-Id: I3b6d5beb2bcff7fa3d45c9220d7c026c64c45d2e
Reviewed-on: https://chromium-review.googlesource.com/290153Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

6b2a0b0c

Make sure that the AST root is always a sequence node · 43613b03

authored Aug 04, 2015

This enables inserting helper functions as an AST transformation.

BUG=angleproject:1116
TEST=angle_unittests

Change-Id: I169d4d3a726d0e389cb3444fe9dfb4c6c5d80155
Reviewed-on: https://chromium-review.googlesource.com/290513Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

43613b03

04 Aug, 2015 4 commits

DisplayGLX: factor redundant getFBConfigAttribs · ef1eb273

authored Aug 03, 2015

This is very tiny code cleanup and is a noop behavior change.

BUG=

Change-Id: Ib850ff88eafa0bd45bb389de1b74b1e9fe4c6d8b
Reviewed-on: https://chromium-review.googlesource.com/290146Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

ef1eb273

FramebufferGL: Add a member to know if we are the default FBO · 6ab01b9a

authored Aug 03, 2015

On CGL, the default framebuffer will have a name different than 0 and
without this change it wouldn't get special-cased as on the other
platforms. It is assumed that the default framebuffer will get
initialized directly by the driver or other parts of the code.

BUG=angleproject:891

Change-Id: Ifbe4ada58f27ad9ddb5b43697c234cb17e7504f0
Reviewed-on: https://chromium-review.googlesource.com/290147Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

6ab01b9a

Add the tryserver properties to the codereview.settings file. · c384d2a3

authored Jul 31, 2015

BUG=504872

Change-Id: I44b619f15e46cb3a6a3d95fd81c999d612d60184
Reviewed-on: https://chromium-review.googlesource.com/290090Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

c384d2a3

Implement ESSL 3.00 shader input/output variable type rules · cc36b983

authored Jul 10, 2015

ESSL 3.00 allows a wider variety of types of input/output variables
than ESSL 1.00, but there are still specific restrictions on structs,
matrices and arrays.

Some of the checks need to be implemented twice: once for array syntax
where the brackets are after the type, and another time for array syntax
where the brackets are after the variable name.

This requires fixes to constant folding unit tests which were previously
incorrectly using matrix outputs in fragment shaders.

New unit tests are added for several of the rules introduced, but some
cases are also covered by dEQP.

TEST=angle_unittests, dEQP-GLES.functional.shaders.linkage.varying.rules.*
BUG=angleproject:1061

Change-Id: I655b054cfe56d376db775b96a2bb41b3ac5740b0
Reviewed-on: https://chromium-review.googlesource.com/285482Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

cc36b983

03 Aug, 2015 6 commits

Surface: query swapBehavior from the Impl · 5d65cd56

authored Jul 30, 2015

All the previously implemented surfaces used to preserve the content of
the surface on a swap but this is no longer the case with CGL.

BUG=angleproject:891

Change-Id: I264c579bcbbd22b4eeb09e78aa95751d223694fc
Reviewed-on: https://chromium-review.googlesource.com/289871Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

5d65cd56

D3D: Add timer histogram for D3DCompile. · afe44c41

authored Jul 31, 2015

BUG=516027

Change-Id: Ibbf45c863570581ea79e198604cd4c5cc1836620
Reviewed-on: https://chromium-review.googlesource.com/289996Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

afe44c41

Add scoped timer histogram helper macros. · ef41279c

authored Jul 31, 2015

These macros replace a lot of repeated timing code, and mirror how
Chromium operates.

BUG=516027

Change-Id: Ib03e35d0f3b8638b9b0e8785c397c8381f16b041
Reviewed-on: https://chromium-review.googlesource.com/289995Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

ef41279c

Change the NSGL skeleton to be a CGL skeleton · ea1be878

authored Jul 30, 2015

The previous skeleton was name NSGL because it seemed the easier route
to go, however Chrome uses CGL internally, which we want to match.

BUG=angleproject:891

Change-Id: I00eb597080c8b735545750dfcd6ad80dcea79300
Reviewed-on: https://chromium-review.googlesource.com/289870Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

ea1be878

Revert "Add Iterable bitset class." · 9988a028

authored Aug 03, 2015

std::to_ullong is c++11, failing on Mac.

BUG=angleproject:1040

This reverts commit 37a9e712.

Change-Id: I5cecd1fe95b889feffb556f67d082cec585256f4
Reviewed-on: https://chromium-review.googlesource.com/290211Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

9988a028

Add Iterable bitset class. · 37a9e712

authored Jul 30, 2015

This class allows us to quickly notify Impl/Renderer layers of
which state changed.

BUG=angleproject:1040
TEST=angle_unittests (Mac/Win/Linux)

Change-Id: I2f27bc65b4f627a261e94e3e3b7095b169986cc6
Reviewed-on: https://chromium-review.googlesource.com/289557Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

37a9e712

31 Jul, 2015 3 commits

Add trace event for D3DCompile. · b70b63e8

authored Jul 30, 2015

Adds more profiling help for startup shader compiles in Chrome.

BUG=510151

Change-Id: I550b55b1280542d1eaab9ed6166387b663cafffe
Reviewed-on: https://chromium-review.googlesource.com/290091Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

b70b63e8

Add support for RESOURCE_MISC_SHARED_KEYEDMUTEX · d17c016b

authored Oct 27, 2014

Change-Id: I225f38b4616ac47e690dccbcb67074fedc571d61
Reviewed-on: https://chromium-review.googlesource.com/225642Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

d17c016b

Log EGL initialize errors to the platform. · 2e5797e3

authored Jul 29, 2015

This will allow us to show more extended error info in about:gpu
in Chromium.

BUG=angleproject:966
BUG=515229

Change-Id: I24c8f33ac3576395ff13dbf7f4664c649af18e33
Reviewed-on: https://chromium-review.googlesource.com/289590Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

2e5797e3

30 Jul, 2015 3 commits

Revert "Store the applied element array buffer as a binding pointer." · 2e5b500c

authored Jul 30, 2015

This reverts commit 0018c85e.

Change-Id: Ieab61c0a4cd1b24d606263e9bf2bae31ea2e8ac4
Reviewed-on: https://chromium-review.googlesource.com/289486Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

2e5b500c

Store the applied element array buffer as a binding pointer. · 0018c85e

authored Jul 30, 2015

to be consistent with how we start vertex attributes. A null pointer
indicates we're using the streaming buffer.

Will also aid the dirty state bits refactor.

BUG=angleproject:1040
TEST=WebGL CTS, end2end_tests, unittests

Change-Id: I7a9167282b60dbe0cbb9f0e5d9e3770890ffeb71
Reviewed-on: https://chromium-review.googlesource.com/284619Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

0018c85e

Revert "Names of built-in functions cannot be redeclared as functions" · 13e7c7e6

authored Jul 30, 2015

Causing failures in the WebGL1 test: conformance/glsl/misc/shader-with-non-reserved-words.html

This reverts commit b5f88853.

Change-Id: I2105c8040057665abda00435e8c0ff8a83af3645
Reviewed-on: https://chromium-review.googlesource.com/289192Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

13e7c7e6

29 Jul, 2015 7 commits

Fix reference leak in Blit9. · 385a1d31

authored Jul 29, 2015

BUG=angleproject:1111

Change-Id: I0c71b765e8589a7387f4fd40f9dc453ed06c05b9
Reviewed-on: https://chromium-review.googlesource.com/289591Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

385a1d31

dEQP-GLES2: Reland of "Skip flush/finish test on Windows." · cce24e9c

authored Jul 29, 2015

This test is having flaky timeouts on the bots. Disable it for now.
The re-land fixes the test syntax, and ensures we will see any errors
in test config as test failures on the bots.

BUG=angleproject:1107
TEST=angle_deqp_gles2_tests runs

Change-Id: Ia4fa8affb70e4474d8e43ff87ee86328aa47ebeb
Reviewed-on: https://chromium-review.googlesource.com/289580Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

cce24e9c

Fix uniform array handling in ProgramGL. · 79d059f8

authored Jul 28, 2015

Our validation wouldn't correctly handle single-element arrays because it
was checking size > 1 instead of isArray().  This caused issues in
ProgramGL on some drivers that optimized the array size (AMD) if some elements
were unused.

BUG=angleproject:882

Change-Id: I417d13cd86380e2c6caa688f6398709a74692e21
Reviewed-on: https://chromium-review.googlesource.com/289201Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

79d059f8

Names of built-in functions cannot be redeclared as functions · b5f88853

authored Jul 23, 2015

With ESSL 3.00, names of built-in functions cannot be redeclared as
functions and therefore overloading or redefining builtin functions
is an error.
This is fixed by inserting unmangled built-ins into the symbol table
and then checking if the new function declaration matches any of the
built-in in symbol table.

BUG=angleproject:1066
TEST=angle_unittests(new: ParseESSLFunctionsTest), dEQP Tests
dEQP-GLES3.functional.shaders.functions.invalid.overload_builtin_function*
(2 tests started passing with this change)

Change-Id: I0e027e588664e604f29c130028178315c3e21631
Reviewed-on: https://chromium-review.googlesource.com/287801Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b5f88853

Revert "dEQP-GLES2: Skip flush/finish test on Windows." · 6db9adac

authored Jul 29, 2015

Incorrect syntax is making the bots skip all tests.

BUG=angleproject:1107

This reverts commit e8c8de2d.

Change-Id: I4469b6b320f8754af576875128e4e3fb210c67b6
Reviewed-on: https://chromium-review.googlesource.com/289501Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

6db9adac

Remove compiler_tests.gypi and preprocessor_tests.gypi. · 1747603e

authored Jul 29, 2015

These files were a relic of a previous structure, we can safely
remove them now that chrome uses angle_unittests.gypi.

BUG=None
TEST=compiles standalone and with chromium

Change-Id: If9a09122f664b740099b4270f5acc5627fc5ac35
Reviewed-on: https://chromium-review.googlesource.com/289343Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

1747603e

Fix incorrect extension check. · aadf5117

authored Jul 29, 2015

BUG=angleproject:884

Change-Id: Ia201ac60e337fd45ef72cc254bcb36d333418613
Reviewed-on: https://chromium-review.googlesource.com/289333Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

aadf5117

28 Jul, 2015 1 commit

EGLContextCompatibility: remove suppression · ac319fcc

authored Jul 28, 2015

BUG=angleproject:1109

Change-Id: I551dbf79b98798f06fd5cbe1b005dc2410daaa6b
Reviewed-on: https://chromium-review.googlesource.com/289274Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

ac319fcc