Commits · a6b16d299ef9fd69271eb18f9c4d760885149263 · Chen Yisong / angle

04 Mar, 2021 8 commits

Suppress UNINSTANTIATED_PARAMETERIZED_TEST failures on Ozone · a6b16d29

authored Mar 02, 2021

We only support ES2 on Ozone, so tests that depend on ES3 or ES31
support are not instantiated there.

Bug: chromium:1183147
Change-Id: Id58bcd9b44a5b9a70b5ae8115e27c44f5dc81226
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726550Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

a6b16d29

Add support for Linux GPU info with Vulkan backend · 5c09c1f8

authored Mar 03, 2021

1. Add support for Linux GPU info with vulkan backend: for
dev board without PCI support, try vulkan backend to get
GPU info.
2. Fix getVulkanInstance() issue when loading non-exist lib:
return NULL instance if open lib failed.

Bug: angleproject:5717
Change-Id: I03c11da25a8787496d098f6c9d6b4c53701383e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734375Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

5c09c1f8

Partially upgrade codegen to Python 3 · 54294c9a

authored Mar 02, 2021

Bug: angleproject:5707
Change-Id: I4e26c2c7ba4a36185b28ecd6e87be1161b60431a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729567
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

54294c9a

Replace Win x64 dEQP GPU.FYI bots with chromium.angle bots · 8b55a3e5

authored Mar 03, 2021

Bug: angleproject:4483
Change-Id: I6b09f2c97e07eca90c71211e23ddd931637e7dda
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733270Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

8b55a3e5

Roll SwiftShader from 106e01583a3a to 084529f3a9b9 (1 revision) · d0c8d6a9

authored Mar 04, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/106e01583a3a..084529f3a9b9

2021-03-03 venni.ihanakangas@siru.fi Add support for internal error status checking in regres

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I7c91c5c9be050ba22d351e0cde05814054007cc6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734636
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d0c8d6a9

Roll vulkan-deps from 6c3f8d8c39b9 to c0db6ae3d87d (6 revisions) · 2429e065

authored Mar 04, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/6c3f8d8c39b9..c0db6ae3d87d

Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/939bc02603..f7043c0de6
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/88ea55de92..461b33cfa2
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b95891b0b1..a4cb494bee

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I6ef4cbfc43b39c97bcd683600501ca3cd8b9318a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734694
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2429e065

Vulkan: Fix overlay graph widgets · 0224e848

authored Mar 03, 2021

Bug: angleproject:5690
Change-Id: I9a63fd91c7403f8bf1ee6ef25fc636aecfbe6ea0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2732533Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

0224e848

Vulkan: Fix Overlay for prerotation · 49211c31

authored Mar 02, 2021

Bug: angleproject:5690
Change-Id: I906a259767c54e3ac9f3ac822b6d5ed5dcaa0bd5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725768
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

49211c31

03 Mar, 2021 11 commits

Vulkan: Workaround Overlay draw issue on Android · 90db6049

authored Mar 02, 2021

On Android vector[n] translates to vector[0] likely due to a driver bug.
This resulted in text such as:

    12345678abcdefghijklmnopqrstuvwx

to render as:

    1234123412341234ijklijklijklijkl

It also made graph data flicker.  As a workaround, the shader now does
an if-else on the value of n and uses a constant to load the appropriate
component of the vector.

Bug: angleproject:5690
Change-Id: Idb891e726fafa896a1064ef7b2941b8fd1c41ed1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725769
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

90db6049

Fix for readPixels() to PBO fast path. · d8557cc8

authored Mar 03, 2021

Include the "pixels" (data) pointer as offset.

Bug: angleproject:5702
Change-Id: Idc9f3ee4c0dbb1cc9308393bbf877d6137598486
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2732789Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>

d8557cc8

Tests: Add Rope Hero: Vice Town trace · 71c7e346

authored Mar 02, 2021

Test: angle_perftests --gtest_filter="*rope_hero_vice_town*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181727986
Bug: angleproject:5711
Change-Id: I11021ae91f968bd453b98a35c60cab90d71e5ed6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2731288Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

71c7e346

Workaround a GL_OES_depth32 bug on Android emulator · a73818aa

authored Mar 03, 2021

Bug: chromium:1184261
Change-Id: I7aac7c696ff2d08dc2aaac86abc1c3b0e54cda1c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733287
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

a73818aa

Update DEP actions for Python 3 · e44595f2

authored Mar 03, 2021

build/mac_toolchain.py was fixed for Python 3 in
https://crrev.com/c/2727724

Bug: angleproject:5707
Change-Id: I2f233157bedc3cc298250b8efc9bd68ac45cdc28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2731707Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e44595f2

Tests: Skip car_parking_multiplayer on Nvidia · 18314bce

authored Mar 03, 2021

The trace doesn't cause any errors, which would have blocked
landing it. But it does spew undefined behavior warnings which
fills the log. See the bug for details, skipping for now.

Test: angle_perftests --gtest_filter="*car_parking_multiplayer*"
Bug: angleproject:5613
Change-Id: I54bf63eeb7c5212b6ce40cf2b45354822e8456e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733089
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

18314bce

Overlay: Widget for vk::DynamicBuffer allocations · 07025aa3

authored Mar 02, 2021

Bug: angleproject:5690
Change-Id: Idfa591903627bbebffe306b387e95cbec1195338
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725767Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

07025aa3

Roll Chromium from 2a5fa9108962 to 143c12daa39f (878 revisions) · 9946051a

authored Mar 03, 2021

https://chromium.googlesource.com/chromium/src.git/+log/2a5fa9108962..143c12daa39f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/ed3af53eea..122de421bd
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/aa09fa7659..b60d41f762
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/6918862bfc..8f03866f94
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/4138b13c16..33e44690c0
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9b6e926feb
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b3546dc126..ee85ae1c83
* tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/0bdacc0246..4d4e1824fc
No update to Clang.

Bug: None
Tbr: jonahr@google.com,jmadill@google.com
Change-Id: I8401b1ba1a585527879f4cd8f0e5b90cfc896b72
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2732747
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9946051a

Skip TransformFeedbackTest.MultiContext on Metal · cdef22a5

authored Mar 03, 2021

This test is flaky on the metal backend.

Bug: angleproject:5713
Change-Id: I1d789825e0322f00b017a60f8fd1cef02b5b3088
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2732787
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

cdef22a5

Tests: Add Talking Tom Hero Dash trace · fbbd143b

authored Feb 27, 2021

Test: angle_perftests --gtest_filter="*talking_tom_hero_dash*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181415750
Bug: angleproject:5614
Change-Id: I6110f5e3e6bbc60706c448ad3643de73b3c2eca2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726134Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

fbbd143b

Roll vulkan-deps from 64e40ae7572f to 6c3f8d8c39b9 (7 revisions) · 159d600e

authored Mar 03, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/64e40ae7572f..6c3f8d8c39b9

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/42ddfbd3d5..159b057080
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0bd920eb9d..939bc02603
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/c428484bc8..4fe5828a02
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/c5678a03db..237d3dcb5c
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bbe724bcf1..b95891b0b1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: I834954df829eeebd64666c56b1e105f0f499d84b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2730671
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

159d600e

02 Mar, 2021 10 commits

Tests: Add Car Parking Multiplayer trace · 1de8b5a6

authored Mar 02, 2021

Test: angle_perftests --gtest_filter="*car_parking_multiplayer*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181696940
Bug: angleproject:5710
Change-Id: I50366e0bb993c1f19906aa5d96f47a00247a24f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729605Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

1de8b5a6

Pull buildtools DEPS directly instead of via recursedeps · 95b086b4

authored Mar 02, 2021

libc++abi will be required after http://crrev.com/c/2729355
Switching others preemptively

Bug: chromium:1177288
Change-Id: I4d6dd8415b63de21bef8c750b9cf5c7cf23c9022
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727647Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

95b086b4

Test: Add Standoff 2 trace · 210a464e

authored Mar 02, 2021

Test: angle_perftests --gtest_filter="*standoff_2*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181681788
Bug: angleproject:5708
Change-Id: I36314d1addc880cc4fb0dc321cda4ba3eabab000
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2728662Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

210a464e

EGL: implement EGL_EXT_buffer_age · 22fc9523

authored Feb 03, 2021

Add extension flag.
Add Validation check to surface query.
Enable extension for vulkan.
Modify AcquireNextImage to ++frame count and tag images
with frame number.
Buffer age is the difference between current frame count
and the tagged frame number on the buffer.
getBuffeAge may need to trigger AcquireNextImage to be current.
Pass through egl extension and query.
Add EGLBufferAgeTest

Test: angle_end2end_test --gtest_filter=EGLBufferAgeTest
Test: angle_deqp_egl_tests
--deqp-case=dEQP-EGL.functional.buffer_age.*

Bug: angleproject:3529
Change-Id: I0cb94be1c3e85d6f33e82a6a1ccdc9731b6a7f23
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2684724
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

22fc9523

capture_replay_tests: Fix MemoryObjectTest. · c11186c2

authored Mar 02, 2021

Add gles_ext_params Capture functions for MemoryObjectsEXT.
Add case for GLCreateMemoryObjectsEXT to MaybeCaptureUpdateResourceIDs.
Don't skip MemoryObjectTest, as it passes now on SwiftShader ES2.

Bug: angleproject:5703
Change-Id: I930fab675cf0848f46a846388955a6bd3274a587
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729004
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

c11186c2

Add Chrome Canary ANGLE injection steps · 9d091b66

authored Feb 25, 2021

Bug: angleproject:1944
Change-Id: I89ade8230271378cd8b2a5a7cb58ad6c0e4f1fde
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2724271Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9d091b66

VK: Suppress VUID-vkCmdBindDescriptorSets-pDescriptorSets-01979 · 6edba641

authored Mar 02, 2021

This validation is blocking the vulkan-deps roll. Suppressing until
we fix the issue.

Bug: chromium:1183542
Change-Id: I05ca95af8bcf77ddb70f01049e5cb07967420c25
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727645
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6edba641

Tests: Add Among Us trace · 87b1875c

authored Mar 01, 2021

Test: angle_perftests --gtest_filter="*among_us*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181616715
Bug: angleproject:5698
Change-Id: If52ee0e989c6b4a3c21b4a2bc0b77dbbea2a3d6d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2728564Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

87b1875c

Include a Makefile which contains some useful command lines · 6b6da203

authored Mar 02, 2021

Bug: angleproject:5697
Change-Id: I48c487d218183aa10823127beb40384f4debd6db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727921
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

6b6da203

Tests: Use context version from trace · 3e017cfe

authored Feb 26, 2021

Test: Capture and replay ES 3.2 apps
Bug: angleproject:5652
Change-Id: Ib46250acd8a50390f0cbd40853623cdf31bd0203
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2698392
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

3e017cfe

01 Mar, 2021 7 commits

Roll vulkan-deps from 3ca55e802f5b to 64e40ae7572f (14 revisions) · 264eab21

authored Mar 01, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/3ca55e802f5b..64e40ae7572f

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/51d672b8a8..42ddfbd3d5
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/621884d709..d57ab68a21
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ef3290bbea..0bd920eb9d
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/1d99b835ec..c428484bc8
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4fdcd0eebf..bbe724bcf1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com,ynovikov@google.com
Change-Id: I368f58c35d7407301ec33dda1360549c618dcb73
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727870
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

264eab21

Vulkan: Always write to swapchain alpha channel · 6af0c03f

authored Feb 25, 2021

This fixes an issue with the "Ragnarok M: Eternal Love" game, which
uses a GL_RGB8 format for its window, which is actually backed by a
GL_RGBA8 format (a.k.a. "emulated alpha"). The game does no explicit
clear per frame. Therefore, ANGLE selects a render pass
loadOp=DONT_CARE, which leaves the alpha channel undefined (0.0 on a
Pixel 4 XL). That causes SurfaceFlinger to show (blend or alternate
vsyncs) what should have been covered up by the game (e.g. the Android
launcher and live wallpaper).

The solution is to prevent loadOp=DONT_CARE for emulated alpha.

Test: ClearTest.ChangeFramebufferAttachmentFromRGBAtoRGB
Test: dEQP-GLES2.functional.fbo.render.stencil_clear.tex2d_rgb_stencil_index8
Bug: b/180139027
Change-Id: Ied97b57c93d41326cb3294ff246691e09f316791
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2704949Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

6af0c03f

build: Add -Wdeprecated-copy to the C++ build flags · 79f24110

authored Feb 12, 2021

Define is_gcc and enable the warning flag if it is true.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>

Bug: angleproject:4486
Change-Id: Ie3271cad5cd7de7b45a48d520eeadfe85e742254
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690954
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

79f24110

Suppress UNINSTANTIATED_PARAMETERIZED_TEST failures on Win AMD · 5b82fa2e

authored Feb 28, 2021

GTest complains that we don't run some tests on D3D/Vulkan backends.
They only run on GL backend, which is disabled on Win AMD
per http://anglebug.com/5123

Bug: chromium:1183147
Change-Id: I95fdd9a24aff69aa60e2f60613d8300ae1019a27
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726576Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

5b82fa2e

libANGLE: Declare copy operator if copy constructor is defined · fb7a2445

authored Feb 12, 2021

If the copy constructor is defined then the copy assignment
must also be defined, but we can use the default here.

v2: Don't inline because the chromium-style errors out on this

Bug: angleproject:4486
Change-Id: Iec0f63342244249da32b455b49a0b89b6558cab9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690953Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

fb7a2445

Roll SwiftShader from 349abccec8f7 to 106e01583a3a (2 revisions) · 0e11e49d

authored Mar 01, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/349abccec8f7..106e01583a3a

2021-02-26 noreply@google.com Support LLVM 11+ atomic instruction alignment change
2021-02-26 natsu@google.com Update PhysicalDevice::getProperties(<AHB properties>)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I5f83ed06d32f6e702e63ce8f4195b05697a1c7be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726141
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0e11e49d

Roll Chromium from 61aec087e2f8 to 2a5fa9108962 (430 revisions) · 5030228a

authored Mar 01, 2021

https://chromium.googlesource.com/chromium/src.git/+log/61aec087e2f8..2a5fa9108962

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3232c09f5a..ed3af53eea
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fd1ca3e65e..aa09fa7659
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/284ae5fcab..4138b13c16
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..df7850dcfe
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3f5eed8e80..b3546dc126
No update to Clang.

Bug: None
Tbr: ynovikov@google.com
Change-Id: Idb69c5794799d96f0d21b672d0c6bb443bd0cae1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727178
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5030228a

28 Feb, 2021 2 commits

Capture/Replay: Support CaptureGetQueryObject · a6d46239

authored Jan 25, 2021

Test: Fortnite MEC
Bug: b/180418810
Bug: angleproject:5658
Change-Id: Icc95faeebbe1fa850f25252c90a5ef8b68634ea0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2702153Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

a6d46239

Fix Ozone backend build flags. · 4f639a7e

authored Feb 27, 2021

Broken by http://crrev.com/c/2405806
ANGLE_USE_GBM must be defined in Display.cpp, not just GL backend.
This also requires depending on libdrm for its headers.

Bug: angleproject:3943, chromium:1181952
Change-Id: I4650d7806435413184b36c820cc6d06992f7f5cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726575Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

4f639a7e

27 Feb, 2021 2 commits

Add EGL_WINDOW_BIT to all Ozone configs' EGL_SURFACE_TYPE · 73afaf1e

authored Feb 26, 2021

Ozone's EGL windows are emulated, so we can always create one,
thus setting EGL_WINDOW_BIT in all configs is safe.

This is now required because in http://crrev.com/c/2378922
EGL_WINDOW_BIT becomes a requirement to be able to run tests.

Previously Ozone's configs copied native EGL_SURFACE_TYPE,
which was either 0 or having just EGL_PBUFFER_BIT.

Bug: chromium:1181952, chromium:1034840
Change-Id: Ic2b14b43b3c32b47ea05d9d8da9fba7439f14d19
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725273Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

73afaf1e

Vulkan: Avoid using assign with BitSets · c508e707

authored Feb 25, 2021

FastIntegerSet::clear() now calls reset() instead of assign().
std::vector::assign(...) invokes the copy-constructor. For better
performance, especially with BitSet*, we can leverage the reset()
method.

This removes 1.2% CPU overhead from a Manhattan30 offscreen run

Bug: angleproject:5689
Change-Id: Ib1a760587ffe18341b8ed892a732c506fc50c82b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2723494
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

c508e707