Detected by the clang static analyzer.

Bug: angleproject:5008
Change-Id: I773c8219b0c7ff63a2a98edefc5bebab7a9aabd5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2416829Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

This will allow us to disable optimizations in the back-end. This can
be useful both for developers and for ANGLE to disable very slow
shader compilation on D3D11.

Also apply this pragma to VerifyMaxVertexUniformVectorsWithSamplers.
Reduces compilation time by half in local testing.

Bug: angleproject:5076
Change-Id: I64ad576e11b9cee5b41f8af0d3621570304d65c2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2420749
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Bug: angleproject:4090
Bug: b/168049670
Change-Id: Ie3a46d4689e40958460c1f26a228645d84b3305c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423211Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The prior check was incorrectly flagging index=0/count=2 as
invalid. It also missed a few cases like a shard count of 0.

Bug: angleproject:3162
Change-Id: Ida4c0f454ece15e4304d024d205475acf0f135e6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423207Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/fe878dedd5ad..6aadd31a5f98

2020-09-21 srisser@google.com Implement VK_KHR_image_format_list

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I1eec7e1f6d8f7291f6d7650fd31001a4b8a4a970
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423538Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a148cdd49041..8fdc21e4078d

2020-09-21 shannon@lunarg.com build: Update known-good files for 1.2.154 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I69990e0ca5dca2aabe692dc26db38353154ed854
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423537Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/60ce96e2ff10..125b64241909

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I4a10c5b8d742413ae3379394eb550acecbf3e91d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423535Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Happen when run in different orders. This time with a test variation
with 2 shards instead of 4.

ComputeShaderTest.DrawTexture1DispatchTexture2/ES3_1_OpenGL
ComputeShaderTest.UniformBuffer/ES3_1_OpenGL
ComputeShaderTest.BindImageTextureWithMixTextureTypes/ES3_1_OpenGL

Bug: angleproject:5072
Change-Id: Iddec2b795dc380e29a0124195491fcf6ec0520bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423208Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

If an attribute slot is unused and user enables it but doesn't bind any
buffer, Metal validation layer will complain that a buffer slot is
missing (even though the slot is not used inside shader).

Fix: if shader program doesn't use an attribute slot or there is no
buffer bound to it, then disable that attribute.

Bug: angleproject:2634
Change-Id: Ib56e0bf64bab13efce8b2972bfe386e26f45e50e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2392171
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

GL_EXT_multisampled_render_to_texture allows singlesampled textures to
be used with multisampled framebuffers in such a way that the final
resolve operation is automatically done.  In Vulkan terminology, the
render-to-texture GL attachment is used as a Vulkan subpass resolve
attachment with an implicit (ideally-)lazy-memory multisampled image as
the color attachment.

This extension expects that if the texture is drawn to after the
automatic resolve, the implicit multisampled image would take its
fragment colors from the singlesampled image.  In other words, the
opposite of a resolve operation should be automatically performed at the
start of the render pass.  This change refers to this operation as
"unresolve".

The goal of this extension is to allow tiling GPUs to always keep
multisampled data on tile memory and only ever load/store singlesampled
data.  The latter is achieved by using a subpass resolve attachment and
setting storeOp of the multisampled color attachment to DONT_CARE.  This
change achieves the former by using an initial subpass that uses the
resolve attachment as input attachment, draws into the multisampled
color attachment and sets loadOp of said attachment to DONT_CARE.

Bug: angleproject:4881
Change-Id: I99f410530365963567c77a7d62fc9db1500e5e3e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2397206
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The script reads the list of tests from the restricted traces JSON and
runs angle_perftests once for each test. Running the tests in a batch
seems unstable on some platfroms so running each test separately works
around that limitation. It does not yet interact with Skia Gold. The
Gold integration will come later once this basic skeleton is running
on the bots.

Also updates the perf tests to exit more quickly with --one-frame-only.
This will speed up the screenshots.

Example run with trigger.py:
https://chromium-swarm.appspot.com/task?id=4ecb985330a33910

Bug: angleproject:4090
Bug: b/168049670
Test: tested with trigger.py
Change-Id: I52820dfba2acfbc5d638673c37297877e8476adb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2417641
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

This was causing a replay state tracking error that could fail some
traces. For example, Mobile Legends.

Bug: angleproject:4090
Bug: b/168049670
Change-Id: Ia4c2db795bb861fba77c9c35217ab22c2004c492
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2422686
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

Bug: angleproject:5079
Change-Id: Idc732b1e6729b2776d66c63c3ae2bd94e11bdbb5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2422684Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

EXT_multisampled_render_buffer2 specifies that depth/stencil textures
are expected to be in a perpetual state of invalidated, except during
rendering.  This change makes sure that they never use loadOp=LOAD.

Additionally fixes a bug where clears applied to MSRTT depth/stencil
textures didn't take effect because they were applied to the
multisampled image (since the resolved image was not given to the render
target).

Bug: angleproject:4836
Bug: angleproject:5063
Change-Id: I4506f4de415dca6c222111a1ae62017d2fb1e2b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2412848
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

Bug: angleproject:2634
Change-Id: I77f085227298bf46361825d1886e04830dc9987a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336558
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

A previous CL had a copy-and-paste error in hasCopyImageView().  It
was calling getFetchImageView().valid() instead of
getCopyImageView().valid().

Bug: b/161993151
Change-Id: I40335ad51585735e9d68781557693ede67096e7d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2422085Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

Bug: angleproject:2634
Change-Id: If7ea09de384c8bc8727523f20fe17641127fcf9f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411982
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

This patch series optimizes programs that use the pattern:

for (;;) {
  glVertexAttribPointer(...)
  glDraw(...)
}

Change 5: Re-check fragment opts on necessary changes.

Check on a program binding change and on a sample coverage enabled
chagne. This likely could be optimized further for program binding
changes.

In total the patch series reduces test iteration time by 25%.

Test: DrawCallPerfBenchmark.Run/vulkan_attrib_change
Bug: angleproject:5045
Bug: b/168493024
Change-Id: I5116f228d5eeef6606136a9a0cc81a4545df9d33
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409177
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

The optimization should check of "alpha to coverage" is enabled, not
just sample coverage.

Bug: angleproject:4508
Bug: angleproject:5045
Bug: b/168493024
Change-Id: I0e52ddd4c92f9a6ea8a0e7cf56db71ce9ff3c5de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2422078Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Use autogen for setting compressed format caps.

Bug: angleproject:2634
Change-Id: I8cfb57390751615c08f798f223f4db3deed2fff6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2411979Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

Fails on 456.38 driver.

Bug: angleproject:5081
Change-Id: Ic92f4a9911d97209fd7240f5ba93ee6f81dd3ace
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2422083Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Running "angle_unittests" with --bot-mode would produce noisy
test groupings for each permutation of parameterized tests. Fix
this by only splitting configs that begin with "ES". e.g. ES2_Vulkan,
ES3_OpenGL, etc.

Bug: angleproject:3162
Change-Id: I0b0ebe1c9cef9cbbce0489a2bc3f62761d43a1c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419046
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Will help diagnose a timeout failure on Windows Intel.
Also reduce the significant digits in time output.

Bug: angleproject:3162
Change-Id: I6d6a852f572875f613dec8e4ab6e798dfde0ca9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2420331
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

FormatID_autogen.h's enums' order was altered by CL
https://chromium-review.googlesource.com/c/angle/angle/+/2413165
However, Metal default shaders relied on old order thus the result
PBO related computation based on enum value has become wrong.

This CL reuse gen_angle_format_table.gen_enum_string() function to
generate format enums for both
- src/libANGLE/renderer/FormatID_autogen.h (used by C++)
- src/libANGLE/renderer/metal/shaders/format_autogen.h (used by Metal
  default shaders)

Bug: angleproject:2634
Change-Id: I52fad168d1932e0386dcf789574f06d341dbd9c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418500
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

The prior check was incorrectly validating a shard index of zero
and a shard count of one as inconsistent.

Bug: angleproject:3162
Change-Id: I63184c16e82f08080b275672a43e6dacf291560d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419045Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

Note: contrib/optimizations/slide_hash_neon.h is inside zlib. It is
conditionally included which is why it needs to be in the exceptions.

Bug: chromium:1032721
Change-Id: I1da8bb2b12cfe44fca7ce8a423aa33c5e964f05f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419043
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

Bug: angleproject:3162
Change-Id: I4ebd0ccf397568aeaa62a033155e70024a806965
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2420333
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

ComputeShaderTest.AtomicFunctionsInNonInitializerSingleAssignment/ES3_1_OpenGL
ComputeShaderTest.AtomicFunctionsInitializerWithUnsigned/ES3_1_OpenGL
ComputeShaderTest.AtomicFunctionsNoReturnValue/ES3_1_OpenGL
ComputeShaderTest.AtomicFunctionsReturnWithMultipleTypes/ES3_1_OpenGL
ComputeShaderTest.AtomicFunctionsReturnWithUnsigned/ES3_1_OpenGL
ComputeShaderTest.DispatchDraw/ES3_1_OpenGL
ComputeShaderTest.DrawDispatchDispatchDraw/ES3_1_OpenGL
ComputeShaderTest.LoadImageThenStore/ES3_1_OpenGL
ComputeShaderTest.NonArraySharedVariable/ES3_1_OpenGL
ComputeShaderTest.NonStructArrayAsSharedVariable/ES3_1_OpenGL
ComputeShaderTest.StoreImageThenLoad/ES3_1_OpenGL
ComputeShaderTest.StructArrayAsSharedVariable/ES3_1_OpenGL
ComputeShaderTest.UniformDirty/ES3_1_OpenGL
ComputeShaderTest.groupMemoryBarrierAndBarrierTest/ES3_1_OpenGL
GLSLTest_ES31.ArraysOfArraysImage/ES3_1_OpenGL
GLSLTest_ES31.MixOfAllResources/ES3_1_OpenGL
LinkAndRelinkTestES31.RelinkProgramSucceedsFromRenderingToCompute/ES3_1_OpenGL

Bug: angleproject:5072
Change-Id: I506c931d7e8714e0393fb5a7b9671b2fc74caeee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2420332
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

Bug: angleproject:5076
Change-Id: I21fc0504513e092003e19fb845d6759eba0a3866
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2420750
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

Makes it consistent with the other back-end types.

Bug: angleproject:5076 
Change-Id: I7a54dd4a0a54e6dc05e257b7b2ac1ec21ceea700
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2420748
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d6935becabad..0a863bc36554

2020-09-18 tony@lunarg.com gpu: Move vma allocator destroy to after state tracker

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ic5703da73bc1fa6c9244da9e1e3728dcf73221a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2421271Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/f0e102e48197..7f9879b1b1fa

2020-09-21 oddhack@sonic.net Update for Vulkan-Docs 1.2.154

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: Ic66b570914960f1fcfbff89c8bcb5f26ccde539b
Bug: None
Tbr: syoussefi@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2421329Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9eaa69c21c45..4dcc12d1a441

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ibc5041023628ee57e351478fbf4757f3c5d78a9c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2421270Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/50ae4c5f4427..60ce96e2ff10

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ief4b7f0e41bc7888163dd923b43161f72b31fb93
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2421272Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Addition of just the entry points for GL_EXT_buffer_storage extension.

Bug: angleproject:5056
Change-Id: I7a3d7c151f004f89fd945d5d06dbe7afcd491578
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419951
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

When adding a Resource to the ResourceUseList of ContextVk
we constructed a new SharedResourceUse object for tracking
and update of the Resource's Serial. We would then delete
it after releasing the resource. This incurs repeated
memory operation costs.

Instead we now allocate a pool of SharedResourceUse objects
and acquire and release from this pool as needed.

VTune profile of the Manhattan 30 offscreen benchmark
shows the CPU occupancy of bufferRead decrease from an
average of 0.9% -> 0.6% and imageRead decreases from
an average of 0.4% -> 0.3%. The bottleneck for both
these methods is the retain() method that leverages
the new SharedResourceUse pool.

Bug: angleproject:4950
Change-Id: Ib4f67c6f101d4b2de118014546e6cc14ad108703
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2396597Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

The prior design didn't pass the correct flag to the subprocess.
Instead add a new --reuse-displays flag that forces display reuse
on in ANGLE tests. Pass the new flag to the child processes when
running with --bot-mode.

Bug: angleproject:3162
Change-Id: I5f62125d83d339b5e8b2506b4ca4656976f7398e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419638Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Previously the runner was returning "1" on success and "0" on failure.
Swap this so that it correctly returns "0" on success and "1" on fail.
This only affected "--bot-mode" which isn't yet enabled.

Bug: angleproject:3162
Change-Id: I1ee942223272d24eff137279d5a0638d3a65694e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419639Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Similarly to common test init, these specific tests init the Vulkan
resources with validation layers when they might not be available.
Fix this by checking for the appropriate define.

Bug: b/168744561
Change-Id: I93dd3bac839297ced07cb2c4cbbcf64db2e65a1f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2419041Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This patch series optimizes programs that use the pattern:

for (;;) {
  glVertexAttribPointer(...)
  glDraw(...)
}

Change 4: Inline ValidateProgramDrawStates.

A hotspot in most draw calls that change state.

In total the patch series reduces test iteration time by 25%. This
change reduces the listed "null" benchmark time from 295 -> 286 ns.

Test: DrawCallPerfBenchmark.Run/vulkan_null_attrib_change
Bug: angleproject:5045
Bug: b/168493024
Change-Id: I80959c9d06030709d7f4eba696e43614c33d5a8f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409176
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>