- 23 Jan, 2020 1 commit
-
-
Michael Spang authored
There's no dirty bit handler if VK_EXT_transform_feedback disabled, but we're setting that dirty bit in syncState. This results in calling a null method pointer. Skip the invalidate if the extension is not enabled. gl::LogMessage::~LogMessage() at ./../../third_party/angle/src/common/debug.cpp:0 rx::ContextVk::setupDraw(gl::Context const*, gl::PrimitiveMode, int, int, int, gl::DrawElementsType, void const*, angle::BitSetT<11ul, unsigned long, unsigned long>, rx::vk::priv::SecondaryCommandBuffer**) at ./../../third_party/angle/src/libANGLE/renderer/vulkan/ContextVk.cpp:844 rx::ContextVk::drawArrays(gl::Context const*, gl::PrimitiveMode, int, int) at ./../../third_party/angle/src/libANGLE/renderer/vulkan/ContextVk.cpp:1698 gl::Context::drawArrays(gl::PrimitiveMode, int, int) at ./../../third_party/angle/src/libANGLE/Context.inl.h:112 gl::DrawArrays(unsigned int, int, int) at ./../../third_party/angle/src/libGLESv2/entry_points_gles_2_0_autogen.cpp:926 (anonymous namespace)::AttributeLayoutNonIndexed::Draw(int, unsigned int, unsigned short const*) at ./../../third_party/angle/src/tests/gl_tests/AttributeLayoutTest.cpp:431 (anonymous namespace)::AttributeLayoutTest::Run(bool) at ./../../third_party/angle/src/tests/gl_tests/AttributeLayoutTest.cpp:305 [This stack is from the added assert; calling a null function pointer crashes without producing a useful stack trace.] Bug: angleproject:4326 Change-Id: I036ae322bddc4865229fa3fe7ea72a4344b99f83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2011408 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:Jamie Madill <jmadill@chromium.org>
-
- 22 Jan, 2020 14 commits
-
-
Courtney Goeltzenleuchter authored
ARM devices cast float to unsigned int differently than Intel devices. Need to do additional work to ensure consistent behavior. This was causing negative API tests to fail because the invalid parameter was being turned into a 0 which is valid, but not what was intended (should have been 0xffffffff). Bug: angleproject:4323 Change-Id: I7447842d0f56362d9eb2db4d04b5416c78e51d27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2012746 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Shahbaz Youssefi authored
In preparation for compiling shaders early at link time, this change reworks line raster emulation such that it uses specialization constants instead of a preprocessor condition. This means drawing both triangles and lines with this program will still result in a one-time shader compilation. The compilation is still done at draw time in this change. Bug: angleproject:3394 Change-Id: I0bf91398868d7f7147456533b728906b505192b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1992365 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Alexis Hetu authored
Implemented FenceNVVk, based on the existing vk::SyncHelper class. Bug: angleproject:4295 Change-Id: I3f44a66e27ce3bd24461894dae4757b25321a6a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2013880 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/af64a9e826bf..dc77030acc9c The spirv-tools autoroller didn't roll this repo. Bug: chromium:1044061 Change-Id: I5ad841e1957d48506f6b3c4a1a57e003b35b6f24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2014882Reviewed-by:
-
Shahbaz Youssefi authored
Bug: angleproject:4314 Change-Id: I37b228f37201cc4188834e68459cd7294727c3ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2014240Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
Bug: angleproject:3830 Change-Id: I5fa213927b609ef33c729ded5d42add8f148dcb1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2012622Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
The non-float variations of the mix builtin were conditioned to desktop GLSL, but they are present in ESSL 3.1+. This change also implements constant folding of these builtins as exercised by dEQP. Bug: angleproject:4300 Change-Id: Iec34de4cf370e00d67fd605148cd7848f9e122f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006809 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Courtney Goeltzenleuchter authored
Latest dEQP roll included some test fixes for GLES 3.1 Remove those exclusions from expectations file. Bug: angleproject:3590 Bug: angleproject:4323 Change-Id: If08c474490c24f63d2f8cc198ee7e3dc85d7f999 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2008128 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Tobin Ehlis <tobine@google.com>
-
Jamie Madill authored
Accidentally submitted a patch set without requested changes. This corrects the function names to 'hasRecordedCommands' and 'hasRunningCommands'. Bug: angleproject:4029 Change-Id: I1cf3046052ace304594ef939566b0b36bae822df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2013924Reviewed-by:
-
Anders Leino authored
There are still a subset of failing tests, but the failures mentioned in angle bug 2277 are no longer expected. Bug: angleproject:2277 Change-Id: I6c55283911bb7be4208b41e9bcd1a4960ed5fc5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2012948Reviewed-by:
-
Anders Leino authored
There is still a failing subset, which is partially investigated in angle bugs 4329 and 4330. Bug: angleproject:4329 Bug: angleproject:4330 Change-Id: I286bb42f521e00b3687bf327feaed47444deafc5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2010114 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Alexis Hetu authored
Added NV/OES suffixes to relevant Extensions members. Bug: angleproject:3104 Change-Id: Ia1798157086230bde8d11c6fcb4fe93211e996ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2013168Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/11cb891a01a2..b766e5e7fbf4 git log 11cb891a01a2..b766e5e7fbf4 --date=short --first-parent --format='%ad %ae %s' 2020-01-21 sugoi@google.com Support more 10_10_10_2 formats as vertex attributes Created with: gclient setdep -r third_party/SwiftShader@b766e5e7fbf4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I9f15f55b5079de0a236d5c0d135297b6d9cb94a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2013986Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/323a81fc5e30..ab7ac60f14ae Created with: gclient setdep -r third_party/spirv-tools/src@ab7ac60f14ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ib432214f5dad6afcecc6afbd7645641d3832f29f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2013985Reviewed-by:
-
- 21 Jan, 2020 5 commits
-
-
Ethan Lee authored
Bug: angleproject:4254 Change-Id: If551d96941bc4aa487514ba3d8f793dcf45131e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1982785 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
All device extension features and properties queries are now performed in a single call for each (i.e. one for features, one for properties), with all the extension structs chained. Then based on which feature is present (not just whether the extension is supported), the extensions and features are enabled. In the process, it fixes the following issues: - If VK_EXT_vertex_attribute_divisor is present, but the necessary vertexAttributeInstanceRateDivisor feature is not supported, that feature is not enabled and the emulation path is taken. Incidentally, this also fixes an issue with renderdoc that refuses to replay captures on such devices. - If VK_EXT_transform_feedback is present, but the necessary transformFeedback feature is not supported, similarly that feature is not enabled and the emulation path is taken. Bug: angleproject:4306 Bug: angleproject:4027 Change-Id: I0969064cba811d215c37dfe551b0ceedb334051c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2005111 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/2d6f74c6d431..af8c7e040f93 git log 2d6f74c6d431..af8c7e040f93 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 mikes@lunarg.com Fix GN build 2020-01-15 mikes@lunarg.com build: Header update for 1.2.131 2020-01-15 mikes@lunarg.com scripts: Tweak extension detection 2020-01-15 lenny@lunarg.com scripts: Add support for Vulkan 1.2 codegen 2020-01-15 lenny@lunarg.com loader: Add support for Vulkan 1.2 2020-01-13 charles@lunarg.com loader: Remove loader_platform_basename dead code 2019-12-12 lenny@lunarg.com loader: Add custom terminator to tool properties 2019-12-12 caio.oliveira@intel.com build: Fix Vulkan registry detection 2019-12-11 lenny@lunarg.com codegen: Fix crash in tooling info terminator 2019-12-10 mark@lunarg.com build: Update for 1.1.130 header version 2019-12-06 thakis@chromium.org Fix a bug found by clang's -Wsizeof-array-div. Created with: gclient setdep -r third_party/vulkan-loader/src@af8c7e040f93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC timvp@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1002945 Tbr: timvp@google.com,jmadill@google.com Change-Id: I45694ab38a99a7743ff19151ad8f1ab9376c3051 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2012822 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Ian Elliott authored
For some reason, this wasn't implemented when texture image load and store was implemented. Bug: angleproject:4311 Change-Id: I24c508660ad7eb3aa944601175803751b54ce0ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2011324Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/41a96d15fd99..ac02c61ffc63 git log 41a96d15fd99..ac02c61ffc63 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 mark@lunarg.com corechecks: Plumb api names through renderpass validation 2020-01-20 tony@lunarg.com layers: Pass api names to error messages 2020-01-20 tony@lunarg.com build: Update glslang to 1.2 version 2020-01-20 pdaniell@nvidia.com Add validation layer support for Vulkan 1.2 feature/prop structs 2020-01-20 tony@lunarg.com tests: Add tests for promoted extensions 2020-01-20 tony@lunarg.com layers: Account for Vulkan12Features enablement 2020-01-20 tony@lunarg.com layers: Update state tracker for v1.2 2020-01-20 tony@lunarg.com layers: Update validation for v1.2 2020-01-20 tony@lunarg.com layers: Make DeviceCreateInfo pNext copy more clear 2020-01-20 tony@lunarg.com layers: Generator changes for 1.2 2020-01-20 tony@lunarg.com layers: Update copyrights for 1.2 changes 2020-01-20 mikes@lunarg.com build: Header update for Vulkan 1.2 2020-01-20 mikes@lunarg.com layers: Drop suffixes for modified VUIDs 2020-01-20 mikes@lunarg.com layers: Drop suffixes for new core identifiers 2020-01-20 mikes@lunarg.com scripts: Tweak extension detection 2020-01-20 s.fricke@samsung.com tests: Fixed checking format against VK_IMAGE_USAGE Created with: gclient setdep -r third_party/vulkan-validation-layers/src@ac02c61ffc63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Iedfbc1b2f369e2d67092488b3d411d6e6a9eb90f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2010059Reviewed-by:
-
- 20 Jan, 2020 4 commits
-
-
Ian Elliott authored
The old code only unbound one image unit when a texture was deleted. The GLES specification is clear that the texture should be unbound from all units: If a texture object bound to one or more image units is deleted by DeleteTextures, it is detached from each such image unit, as though BindImageTexture were called with unit identifying the image unit and texture set to zero. Bug: angleproject:4310 Change-Id: I24c508660ad7eb3aa944601175803751b54ce0dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2011322Reviewed-by:
-
Jamie Madill authored
This uses the EGL_ANGLE_feature_control extension through the test harness to control feature selection via a test config. This obviates the need for the hacky platform methods table override. Also adds a command graph feature that will be used to prototype the command graph linearization for Vulkan. Bug: angleproject:4029 Change-Id: Id37fadd5d2c317c9d9dd90dfab1fdc8e4ac3701f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2007612 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/b6ac1e60cd3a..ca9b61a4455f git log b6ac1e60cd3a..ca9b61a4455f --date=short --first-parent --format='%ad %ae %s' 2020-01-17 charles@lunarg.com vulkaninfo: update readme for Windows SDK name change Created with: gclient setdep -r third_party/vulkan-tools/src@ca9b61a4455f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Iceccc533d628ebde94bd3a358a9dcd4d42c048ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2010491Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2cb1db08e5f1..11cb891a01a2 git log 2cb1db08e5f1..11cb891a01a2 --date=short --first-parent --format='%ad %ae %s' 2020-01-18 capn@google.com Rename multiSampledBresenham to enableMultiSampling 2020-01-18 capn@google.com Take advantage of return value optimization 2020-01-17 capn@google.com Enable filtering of YCbCr formats 2020-01-17 capn@google.com Rename createBlend4 to createShuffle4 Created with: gclient setdep -r third_party/SwiftShader@11cb891a01a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: I73bb1cd83295792565ba95f6bf8f43cb21984cc5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2010492Reviewed-by:
-
- 18 Jan, 2020 1 commit
-
-
Jamie Madill authored
Clarifies the function for the upcoming command graph linearization. Bug: angleproject:4029 Change-Id: Ib50997c007053757de533f69c155a92d7555e0b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003235 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
- 17 Jan, 2020 12 commits
-
-
Jamie Madill authored
Instead of referring to command graphs we can refer to if the resource is in use by "ANGLE" or the "Driver". This will make the methods more consistent when we switch away from the command graph. Bug: angleproject:4029 Change-Id: I3045a4eb2a38234ef331c0662694656065590ae1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003234 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
Fixed in https://chromium-review.googlesource.com/c/angle/angle/+/2006813, but suppression was not removed. Bug: angleproject:4309 Change-Id: I430501c0d977a8c5999390f2ad895290e2301dc5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2008129Reviewed-by:
-
Ian Elliott authored
Sorted by group (i.e. blocking conformance, desktop, general Vulkan, Android). Bug: angleproject:3520 Change-Id: I6f7c702460b3d1908838796d88e5448d4f83b242 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006018 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:
Ian Elliott <ianelliott@google.com>
-
Shahbaz Youssefi authored
dEQP queries resource limits in all formats, including float. When INT_MAX is queried as float, the resulting value is INT_MAX+1 due to floating point imprecision. dEQP casts this value back to int for verification, and trips up on the resulting negative number. This change limits every ridiculously-large limit to INT_MAX/2 instead of INT_MAX. Bug: angleproject:4309 Change-Id: I11018c2c5a0c8bfb410928b0a4c34c526fab2269 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006813 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5fc197dc7669..2cb1db08e5f1 git log 5fc197dc7669..2cb1db08e5f1 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 bclayton@google.com SpirvShaderDebugger: Implement OpenCL.Debug.100 2020-01-16 capn@google.com Remove the GL_NV_read_depth_stencil extension Created with: gclient setdep -r third_party/SwiftShader@2cb1db08e5f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ia3eec3b9c7cfc377451b8aa284f836fedbaa2c07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006716Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/ab883b9d257e..41a96d15fd99 git log ab883b9d257e..41a96d15fd99 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 rpalandri@fb.com tests: Add test for VUID 02531 2020-01-16 rpalandri@fb.com corechecks: Add val for FBCreateInfo non-zero viewmasks 2020-01-16 mikes@lunarg.com Fix GN build 2020-01-16 s.fricke@samsung.com tests: Added 01589/01590 to InvalidMemoryRequirements 2020-01-16 s.fricke@samsung.com layers: Added support for VUID 01589/01590 Created with: gclient setdep -r third_party/vulkan-validation-layers/src@41a96d15fd99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ic57a869b6b1a7578728900088d9f327674de49cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006717Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/4792a6854238..b6ac1e60cd3a git log 4792a6854238..b6ac1e60cd3a --date=short --first-parent --format='%ad %ae %s' 2020-01-16 jeremyk@lunarg.com build: Update glslang commit ID in known_good.json 2020-01-16 charles@lunarg.com vulkaninfo: Support VK_EXT_tooling_info 2020-01-16 mikes@lunarg.com Fix GN build Created with: gclient setdep -r third_party/vulkan-tools/src@b6ac1e60cd3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Id8b2bc19aabe281c5319ce3c080687d6570413d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006715Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3ed344dd784e..b0ada80356ca Created with: gclient setdep -r third_party/glslang/src@b0ada80356ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Id3affd6b1da4d58e350221c044dcb4172efaf4a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006719Reviewed-by:
-
Shahbaz Youssefi authored
Bug: angleproject:4309 Bug: angleproject:4310 Bug: angleproject:4311 Bug: angleproject:4312 Bug: angleproject:4313 Bug: angleproject:4314 Bug: angleproject:4315 Bug: angleproject:4316 Change-Id: Ibda4eac6a49ad7a8fcf0ec68b6dd199a3f66ebb0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2006812Reviewed-by:
-
Alexis Hetu authored
Implemented DetermineBGRAReadFormatSupport in order to allow enabling readFormat when possible with the Vulkan backend. While reading the spec, I realized that ANGLE only seems to care about BGRA8888 and not the new types mentioned in the extension. Logged a new issue (http://anglebug.com/4302) to track this. Bug: angleproject:4294 Change-Id: I071ed89574de9b4088df2301c317d3769cb31ce6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003237 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
-
Alexis Hetu authored
DetermineFloatBlendSupport was added to be able to set floatBlend to true if requirements are met. Essentially GL_EXT_float_blend complements GL_EXT_color_buffer_float by making any non-blendable formats blendable. Bug: angleproject:4291 Change-Id: I40d6bb7a93b8847a63de2d25c6a8dc411d6d8fbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001479 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
-
Alexis Hetu authored
Added stubs for these soon to be added extensions: - GL_OES_depth_texture_cube_map - GL_EXT_read_format_bgra - GL_NV_depth_buffer_float2 - GL_NV_read_depth - GL_NV_read_stencil Bug: angleproject:4293 Bug: angleproject:4294 Bug: angleproject:4295 Change-Id: I56cf1fda377e48521f30bd11f5776409bfb88701 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001480 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
-
- 16 Jan, 2020 3 commits
-
-
Alexis Hetu authored
The GL_EXT_color_buffer_float spec https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_color_buffer_float.txt mentions that some of the formats must be blendable: "Blending applies only if the color buffer has a fixed-point or floating-point format. If the color buffer has an integer format, proceed to the next operation. Furthermore, an INVALID_OPERATION error is generated by DrawArrays and the other drawing commands defined in section 2.8.3 (10.5 in ES 3.1) if blending is enabled and any draw buffer has 32-bit floating-point format components." So any non 32-bit floating-point must be blendable. Bug: angleproject:4291 Change-Id: I850fb13b71e4ad03fd07e2a265896c9106bc0ce1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2001478 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
-
Rafael Cintron authored
The last render-to-texture commit broke FL10_0 multisampling by unconditionally asking for D3D11_STANDARD_MULTISAMPLE_PATTERN quality setting. Per the documentation on https://docs.microsoft.com/en-us/windows/win32/api/d3d11/ne-d3d11-d3d11_standard_multisample_quality_levels applications can only request the standard multisample pattern on feature levels 10_1 and above. For feature levels 10_0 and below, we'll stick with asking for a quality level of 0 like the code previous did. Bug: chromium:1036367 Change-Id: I0dd7704cf144ebce952e1f7d5e148d3382891aed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003238 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
-
Jonah Ryan-Davis authored
Started failing on Jan 11, 2020 Bug: chromium:1041672 Change-Id: Ie51c0d363b49025c607c32a1858cdaf8c38ebf87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2003013Reviewed-by:
-
