Commits · abc8f277713384bc100ccdff213a0957efb33f85 · Chen Yisong / angle

20 Dec, 2019 6 commits

Vulkan: Disallow multisampling with a sample count of 1 · abc8f277

authored Dec 19, 2019

GLES uses a sample count of 0 to indicate non-multisampling, and a
sample count of 1 or greater to indicate multisampling.  While the
Vulkan specification seems to support multisampling with a sample count
of 1, the following spec language effectively disallows it (even when
the underlying Vulkan driver supports it):

    If the image was created with VkImageCreateInfo::samples equal to
    VK_SAMPLE_COUNT_1_BIT, the instruction must have MS = 0.

The following GLES 3.1 dEQP tests use shaders that look for the sample
position, with a sample count of 1:

    dEQP-GLES31.functional.texture.multisample.samples_1.*

For Vulkan drivers that fully support multisampling with a sample count
of 1, these tests pass, but get Vulkan validation errors because of the
above spec language.

This was discussed in the Khronos-private issue tracker (see:
https://gitlab.khronos.org/vulkan/vulkan/issues/1925).  The Vulkan
working group wondered if ANGLE could live with not supporting a sample
count of 1 (but upgrading such requests to the next-largest supported
sample count, per the GLES specification).  This change implements that
approach.

Bug: angleproject:4197
Bug: angleproject:4212
Change-Id: I009ba47b48efe5af464011c7c15022fc01f45e76
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1974842Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

abc8f277

Skip all Metal dEQP tests · 9d03c297

authored Dec 20, 2019

First step in running dEQP tests on the Metal backend on the bots

Bug: angleproject:4235
Change-Id: Ib191205179d98bc907cc7d48340744ea719a0bc2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1978577Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

9d03c297

Do not send attribute data for built-ins · 816132a3

authored Dec 17, 2019

Built-ins (e.g. gl_VertexID or gl_InstanceID) were settings dirty bits
in the driver's ActiveAttribLocationsMask which would later cause
the Vulkan back-end to issue bind commands on these built-in attributes
that don't have / need anything bound.

Test:
angle_deqp_khr_gles31_tests --use-angle=swiftshader --gtest_filter=dEQP.KHR_GLES31/core_shader_storage_buffer_object_advancedswitchBuffersvs

Bug: angleproject:4107
Change-Id: Id1f1c6699d512d0726b22d9bb0c16abad179950d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972200Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

816132a3

Roll third_party/SwiftShader 4fd7fccd6db5..6d29348ddb7e (3 commits) · 7f2930fc

authored Dec 20, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/4fd7fccd6db5..6d29348ddb7e

git log 4fd7fccd6db5..6d29348ddb7e --date=short --first-parent --format='%ad %ae %s'
2019-12-19 sugoi@google.com Enable filtering depth only formats
2019-12-19 bclayton@google.com Kokoro: Add style presubmit checks
2019-12-19 swiftshader.regress@gmail.com Regres: Update test lists @ 4fd7fccd

Created with:
  gclient setdep -r third_party/SwiftShader@6d29348ddb7e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I301672b05e9440fe89ebd115a95a5739b203dac8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1978599Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7f2930fc

Roll third_party/vulkan-tools/src 246503e9c085..37af49fa7b55 (1 commits) · 2303ff5b

authored Dec 20, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/246503e9c085..37af49fa7b55

git log 246503e9c085..37af49fa7b55 --date=short --first-parent --format='%ad %ae %s'
2019-12-19 tony@lunarg.com cube: Leave uniform memory mapped

Created with:
  gclient setdep -r third_party/vulkan-tools/src@37af49fa7b55

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I3f954505f6186b894d5515b1395f0e22960f183e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1978597Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2303ff5b

Roll third_party/vulkan-validation-layers/src e8e8f32d1b7a..6b71f08cc83e (4 commits) · 21e894d7

authored Dec 20, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e8e8f32d1b7a..6b71f08cc83e

git log e8e8f32d1b7a..6b71f08cc83e --date=short --first-parent --format='%ad %ae %s'
2019-12-19 locke@lunarg.com tests: Remove UnexpectedError
2019-12-19 locke@lunarg.com layers: Skip PARTIALLY_BOUND
2019-12-19 tony@lunarg.com gpu: Initialize report_data for instance
2019-12-19 petr_kraus@email.cz layers: Fix wrong version reported by tooling

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@6b71f08cc83e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I23c37bcf3db43fb582be4711c319e7ac353db5d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1978598Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

21e894d7

19 Dec, 2019 10 commits

Translator: Output memory qualifiers in OutputTree · fe2ed33a

authored Dec 19, 2019

Bug: angleproject:3602
Change-Id: I673d8080be874bea0a73a89f7499b652549c2f3d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1976498Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

fe2ed33a

Metal: correctly clamp stencil reference values · fbe6c1d2

authored Dec 14, 2019

According to GL spec:
- If stencil ref value is larger than max value the stencil buffer
can represent, clamp it to max value (2^bits - 1)
- The stencil clear value & mask will be truncated to stencil buffer's bits
instead of clamping.

Metal API is very vague on how it handles the stencil ref value larger than
the stencil bits can represent, so we need to handle it manually. In fact,
the Metal API seems to have bugs when dealing with large stencil ref value,
i.e. > 0xff for example.

Bug: angleproject:2634
Change-Id: I86f61f0bfd19dfc0fa459c84d98785a1af857a6b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966185
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

fbe6c1d2

Add Broadcom as a known vendor · 7b55aac3

authored Dec 12, 2019

Broadcom's vendor ID wasn't listed anywhere.

Fixed the sort order of vendor names in a number
of places also.

Bug: angleproject:4218
Change-Id: Iddc504fa35833ac14375cb77e7a2b1cc405f0e80
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972714Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

7b55aac3

Ignore nameless vim swap files · 9dec123f

authored Dec 19, 2019

Starting vim with no file name creates a swap file in the form of .swp,
.swo etc.  Add these files to .gitignore.

Bug: None
Change-Id: Id9639f626daebc993ccc9ab0a9049a18e0f80862
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1975612Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

9dec123f

Roll third_party/spirv-tools/src 38d7fbaad0a3..e70b009b0f1e (1 commits) · f321db9a

authored Dec 19, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/38d7fbaad0a3..e70b009b0f1e


Created with:
  gclient setdep -r third_party/spirv-tools/src@e70b009b0f1e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I8c577825cd88e3b8a502a36399a8988b0bba6020
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1974923Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f321db9a

Roll third_party/SwiftShader 21be09d8e699..4fd7fccd6db5 (4 commits) · f23d5401

authored Dec 19, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/21be09d8e699..4fd7fccd6db5

git log 21be09d8e699..4fd7fccd6db5 --date=short --first-parent --format='%ad %ae %s'
2019-12-18 chrisforbes@google.com Regres: Roll deqp forward to latest 1.1.6
2019-12-18 sugoi@google.com Allow 32F texture to use linear filtering
2019-12-18 capn@google.com Remove sw::Vector, Point, and Matrix
2019-12-18 swiftshader.regress@gmail.com Regres: Update test lists @ 21be09d8

Created with:
  gclient setdep -r third_party/SwiftShader@4fd7fccd6db5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I496b3ce51d50ec10f72ccc523027dff7c77a135e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1974922Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f23d5401

Roll third_party/vulkan-validation-layers/src 2b19f3916726..e8e8f32d1b7a (4 commits) · b0172d37

authored Dec 19, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2b19f3916726..e8e8f32d1b7a

git log 2b19f3916726..e8e8f32d1b7a --date=short --first-parent --format='%ad %ae %s'
2019-12-19 mark@lunarg.com tests: Add ClearColorImage SHARED_PRESENT layout check
2019-12-19 mark@lunarg.com corechecks: Fix CmdClear layout validation
2019-12-18 tony@lunarg.com layers: Guard against ATTACHMENT_UNUSED
2019-12-17 mark@lunarg.com objlifetimes: Fix undestroyed object reporting

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@e8e8f32d1b7a

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: Ice1e926ff24301c807b0acdf13d087e8b1242634
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1974921Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b0172d37

Roll third_party/vulkan-tools/src 9c5719ab7149..246503e9c085 (1 commits) · ecc96617

authored Dec 19, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/9c5719ab7149..246503e9c085

git log 9c5719ab7149..246503e9c085 --date=short --first-parent --format='%ad %ae %s'
2019-12-18 shannon@lunarg.com winrt: Update `VulkanRT-License.txt` text

Created with:
  gclient setdep -r third_party/vulkan-tools/src@246503e9c085

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I68bb42383831cbf9aebc75e3daeae17cba45219b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1974920Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ecc96617

Fix textureGatherOffsets classification · 4b80fbc8

authored Dec 18, 2019

sampler2DRect was placed under ESSL while sampler2DArrayShadow was
placed under desktop GLSL. They are swapped.

Bug: angleproject:3569
Change-Id: Ibf39868d4cd702d9d1da7fc286171bb70b80d6df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1975430Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

4b80fbc8

Return the correct location count for Matrices · 6423b7fc

authored Dec 04, 2019

GetLocationCount() is currently returning the number of rows in the
matrix, rather than the columns, which leads to shader validation
errors (and test failures).   This fix returns the number of columns
in a matrix.

Bug: angleproject:4200
Test: dEQP-GLES31.functional.separate_shader.random.63
Change-Id: I8d25eb3733c2ddbe53ff54794f480c1d43e22a88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1952173Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

6423b7fc

18 Dec, 2019 6 commits

Vulkan: Update GLES 3.1 expectations for now-passing tests. · 20432bf3

authored Dec 18, 2019

Bug: angleproject:4099
Bug: angleproject:4100
Bug: angleproject:4102
Change-Id: I975485baea3ff6ec8247cbb5c92efdb907974ebc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1974271Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

20432bf3

Reset binding offset & size when unbinding · cd129d17

authored Dec 16, 2019

Bug: angleproject:4147
Change-Id: I4ace1221d32631cdb14a95c71ee9a1617837a5ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1970495Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

cd129d17

Implement SamplerVideoWEBGL for WEBGL_video_texture extension on desktop · 17b3c2f3

authored Oct 14, 2019

WEBGL_video_texture is an extension that will improve uploading video frame to WebGL performance.
(https://www.khronos.org/registry/webgl/extensions/proposals/WEBGL_video_texture/)

This extension introduced a new texture type TEXTURE_VIDEO_IMAGE_WEBGL and a new sampler type
samplerVideoWEBGL to sample it.

In chromium implementation, TEXTURE_VIDEO_IMAGE_WEBGL maps to different native texture type
based on platform. On desktop, it maps to GL_TEXTURE2D(Currently supported). On Android, it
should map to GL_TEXTURE_EXTERNAL(TODO). SamplerVideoWEBGL needs to be mapped to sampler2D or
samplerExternalOES according to TEXTURE_VIDEO_IMAGE_WEBGL implementation.

This patch implements samplerVideoWEBGL in Angle to support WEBGL_video_texture on desktop. In
this case, samplerVideoWEBGL should map to sampler2D.

Bug: chromium:776222, angleproject:3889
Change-Id: Idb0a5fcde37ca75ccc1181226b91f257212e7500
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1866274
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

17b3c2f3

Roll third_party/SwiftShader fbbfeb700295..21be09d8e699 (17 commits) · 65e2f03b

authored Dec 18, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/fbbfeb700295..21be09d8e699

git log fbbfeb700295..21be09d8e699 --date=short --first-parent --format='%ad %ae %s'
2019-12-18 sugoi@google.com Enable samplerAnisotropy
2019-12-18 chrisforbes@google.com Advertise variableMultisampleRate feature
2019-12-17 bclayton@google.com clang-format the src/WSI directory
2019-12-17 bclayton@google.com clang-format the src/Vulkan directory
2019-12-17 bclayton@google.com clang-format the src/System directory
2019-12-17 bclayton@google.com clang-format the src/Reactor directory
2019-12-17 bclayton@google.com clang-format the src/Pipeline directory
2019-12-17 bclayton@google.com clang-format the src/Device directory
2019-12-17 bclayton@google.com Start a custom .clang-format rule
2019-12-17 capn@google.com Remove spaces after control statements keywords
2019-12-17 sugoi@google.com Enable blending for 32FP formats
2019-12-17 capn@google.com Make use of vec<T, N> vector broadcasts
2019-12-17 capn@google.com Replace vector() and replicate() with float4 constructors
2019-12-17 capn@google.com Create a generic vec<T, N> class
2019-12-17 capn@google.com Typedef int4/float4 from a vec4<T> template
2019-12-17 capn@google.com Prefer alignas() over ALIGN()
2019-12-17 sugoi@google.com R11G11B10F support

Created with:
gclient setdep -r third_party/SwiftShader@21be09d8e699

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: Iff5532b2838a657d66fc51751fd95036d35f3f30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1973467Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

65e2f03b

Roll third_party/vulkan-tools/src 0c2618b2c31e..9c5719ab7149 (1 commits) · e5c2e047

authored Dec 18, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/0c2618b2c31e..9c5719ab7149

git log 0c2618b2c31e..9c5719ab7149 --date=short --first-parent --format='%ad %ae %s'
2019-12-17 charles@lunarg.com vulkaninfo: safely handle device groups not supported

Created with:
  gclient setdep -r third_party/vulkan-tools/src@9c5719ab7149

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: Idca41eac95939e072b5e9317ffbfbcce57646ff6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1973466Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e5c2e047

Update with official gl.xml and re-sort added formats · 751e7888

authored Dec 16, 2019

Use latest Khronos gl.xml file and re-sort format
enums that angle had already added to this file

Bug: angleproject:4093
Change-Id: Ic5c1abc2a79fec14f3c53856a429c9b2489e3275
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972199
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

751e7888

17 Dec, 2019 12 commits

Vulkan: Update expectations for newly-passing tests · c3f833f3

authored Dec 17, 2019

Bug: angleproject:4101
Bug: angleproject:4105
Change-Id: Ida462f69660a55e13b48ebea22ffc2a6b6bfe867
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972202Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

c3f833f3

Vulkan: Fix layers being disabled in tests. · 17217c6e

authored Dec 17, 2019

The ANGLE_ENABLE_VULKAN_VALIDATION_LAYERS_BY_DEFAULT define shouldn't
be being checked in tests. Enable the debug layers by default.

Bug: angleproject:4227
Bug: angleproject:4229
Change-Id: I9717cb1c611ebd585a5c03ba2057036e1b086001
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972497
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

17217c6e

Pass GLImplFactory to Query constructor. · d205ee3a

authored Dec 16, 2019

This makes the code more consistent and allows for the Query
constructor to generate a Serial.

Bug: angleproject:4223
Change-Id: I6cc683b11ed364f13d303f97aa0984e63260953e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969061Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d205ee3a

Vulkan:Lazily link libvulkan · 545c6142

authored Dec 17, 2019

Move libvulkan to a data_dep as we no longer statically
link it.

Bug: angleproject:4225
Change-Id: I96458d4727d2d47d8c259ec51d91fd852067c059
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972192
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

545c6142

Move Serial utils to their own file. · d50151d3

authored Dec 17, 2019

This will let the front-end access them without pulling in the rest
of renderer_utils. The Serial class in particular will be useful for
capture/replay.

Also adds a very minimal unit test.

Bug: angleproject:4223
Change-Id: I9e63b8a8227a245b20a8f024b960fcf60c7840db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954611
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

d50151d3

Make Sync constructors take GLImplFactory. · e60d05b2

authored Dec 17, 2019

Makes them consistent with the rest of the code. Will allow
the Sync class to call methods in GLImplFactory to generate
a resource Serial.

Also updates the unit test to the new design.

Bug: angleproject:4223
Change-Id: Ic5ba69c3a6a51d4b51d876c3b5e7eb7bc44a9ae8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969060
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

e60d05b2

Vulkan: Enable inactive SSBO with unsized array tests · 44722daa

authored Dec 06, 2019

The change introduced in
https://chromium-review.googlesource.com/c/angle/angle/+/1951523
removes inactive shader interface declarations.  That automatically
resolves an issue where glslang wrapper doesn't handle inactive SSBO
declarations with unsized arrays, by removing those declarations at
translation time altogether.

Bug: angleproject:3714
Change-Id: I710d59546d716bfb5bc0112b5152fed20a810a52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954615
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

44722daa

Vulkan: Fix SwiftShader disabled build. · 7e19e25e

authored Dec 16, 2019

Disabling SwiftShader in the GN build led to a compile error
when trying to use ANGLE_VK_SWIFTSHADER_ICD_JSON.

Bug: angleproject:4223
Change-Id: I076a88e6bc58adf1e34bbb7286b1f46028cd021a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969059
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

7e19e25e

Vulkan: EXT_gpu_shader5: non-const offset in textureGatherOffset · d674e1e5

authored Dec 12, 2019

This change includes preparatory work for textureGatherOffsets as well,
though that requires special handling which is addressed in a follow-up
change. This special handling is due to the fact that this family of
functions is the only built-in with an array parameter, and our built-in
table generation doesn't handle it correctly.

Bug: angleproject:3569
Change-Id: Ic1c8dd03878a184be00f578ab9fc42af8f6e47ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965435Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

d674e1e5

Improve presubmit's Bug: tag check · 634ee434

authored Dec 16, 2019

Specifying the project name is now mandatory. This helps avoid
accidentally referring to chromium bugs by forgetting the project name.
At the same time, it ensures the project name is not misspelled.

Bug: angleproject:4184
Change-Id: I6bbfe1751e2fd0baf424be38018374cce360df5d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969067Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

634ee434

Vulkan: fix handling of inactive atomic counters · a5dd3888

authored Dec 04, 2019

The translator emulates atomic counters with a storage buffer array
during translation to Vulkan GLSL.  Glslang wrapper then should assign
set/binding to this buffer.  However, if the atomic counters are
actually unused in the shader, this assignment is never done.

This change adds a small tree transformation for Vulkan that removes any
uniform or interface block declaration that's not active.  In
particular, this makes atomic counter emulation a no-op if no atomic
counters are used.  It also has the benefit of not requiring glslang
wrapper to remove such inactive resources.

Bug: angleproject:4190
Change-Id: I286c199854ec2379558ad1ec48b4d2c4bf5544d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1951523
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

a5dd3888

Roll third_party/spirv-tools/src 96354f5047bf..38d7fbaad0a3 (2 commits) · 0c14e233

authored Dec 17, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/96354f5047bf..38d7fbaad0a3


Created with:
  gclient setdep -r third_party/spirv-tools/src@38d7fbaad0a3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I81d302d7aaf865489f50fa722791efdb5fbb6a05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1971254Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0c14e233

16 Dec, 2019 6 commits

Re-land "Add new test runner harness." (#2) · 5407aaa0

authored Dec 16, 2019

Re-land #2 changes:

 * export labels are fixed for the CFI build
 * crash test disabled because of flakiness and issues with asan

Re-land changes:

 * Unit test is suppressed in ASAN
 * --deqp-case is fixed
 * Debug layer errors should correctly work with failure expectations

Original message:

The ANGLE test harness is a harness around GoogleTest that provides
functionality similar to the Chromium test harness. It supports:

 * splitting a test set into shards
 * catching and reporting crashes and timeouts
 * outputting to the Chromium JSON test results format
 * multi-process execution

Unit tests are added in test_utils_unittest.cpp.

Bug: angleproject:3162
Bug: chromium:1030192
Change-Id: I71d66a407ea0e53d73cbe75b5b4bfb9e73791534
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965091
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

5407aaa0

Vulkan: Add test that logs supported texture formats · 5cfab195

authored Oct 28, 2019

Add a whitebox test to log all supported GLES formats
for the active Vulkan ICD. The test object is
dependent on libANGLE's gl_enum_util.* files as
we need it to print out human readable values in
the PrintAllFormatSupport test.

Test: angle_white_box_tests --gtest_filter=*PrintAllSupportedFormats*
Bug: angleproject:4093
Change-Id: I99d74935b705b2984f6320ed80a0e977c8fcd4be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1930607
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

5cfab195

GN: Make new angle_test_utils target. · 9190f49c

authored Dec 16, 2019

This source set target lets other targets import the test utils without
needing to export them. They get built into angle_util. They also get
compiled into the various tests and samples. The change also fixes
export issues.

Moves some of the GN logic into the util/ subfolder.

Bug: angleproject:3162
Bug: chromium:1030192
Change-Id: If99d201092ad8541c0de60b3bd893ac9b5875270
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1968259Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9190f49c

Adds missing extensions to registry_xml.py · 390c4952

authored Dec 10, 2019

Bug: angleproject:4093
Change-Id: I979b54e12c1e897ccfa116f332bf9146dcd00cae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965644
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

390c4952

Vulkan: Fix failed assert when unbinding texture · ce41a43c

authored Dec 16, 2019

We were hitting onImageStateChange with no texture active and hitting
the assert in that function for needing a texture.
There are times when we call onImageStateChange where there is no
texture bound, early exit in those cases.

Test:
  angle_deqp_khr_gles31_tests --user-angle=swiftshader --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_image2D_layout_binding_imageLoad_*
  also:
  --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_atomic_uint_layout_binding_atomic_ComputeShader
  --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_buffer_layout_binding_atomicAdd_ComputeShader
  --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_block_layout_binding_block_ComputeShader
  --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_sampler2D_layout_binding_texture_ComputeShader

Bug: angleproject:4124
Change-Id: I027cf4ecb6a5d6aea874c306bf3e67b95a75af62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965027
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

ce41a43c

Vulkan: Use volk to load vk* func ptrs · 5fd73782

authored Aug 09, 2019

Thanks to Jamie Madill for some fixes to get all CI test passing w/ volk.

This change updates all ANGLE targets that use Vulkan to dyanmically
link all of the VK entrypoints using the volk OSS library from
https://github.com/zeux/volk.

It's only two source files so baking them directly into ANGLE repo.
Also it's used in both the tests and libANGLE trees so added to
src/common/third_party/volk dir.

Updated volk and the renderer to track latest instance and device
that were loaded and renderer will refresh vk* function pointers if
the current and previous device and/or instance don't match. This
prevents errors in the test framework as we transition between
backends, especially between VK HW & SwiftShader ICDs.

This change rolls the Vulkan Loader forward to use the latest loader
version which no longer allows static linking but requires dynamic
linking.

Bug: angleproject:3740
Bug: angleproject:4092
Bug: angleproject:4162
Bug: angleproject:4210
Bug: angleproject:4225
Change-Id: I8a0b7d24c9545bbfdfaa4b9357a9bfe6793e0140
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965640
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5fd73782