When the render pass breaks while transform feedback is active, the
subsequent render passes didn't restart transform feedback because of a
missing dirty bit.

Bug: angleproject:5426
Change-Id: Icee79cbdabbceab96973cea124240ac7ced82d55
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2572878
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

Bug: angleproject:5406
Change-Id: Ifb7553e87164c204353e1ed94b8d64f5fb4b7206
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2574822Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

In order to be able to land SwANGLE in Chromium, this cl adds
suppressions for memory leaks detected by LSAN. Some of these should
be fixed and some are intentional leaks of global variables.

This cl should allow the linux_chromium_asan_rel_ng bot to pass while
using SwANGLE and shouldn't break the win-libfuzzer-asan-rel bot.

Bug: chromium:972686
Bug: angleproject:5377
Change-Id: I7e2336aba43fcfeb95716d6c0aa05caf855134aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2575200Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

Some apps (possibly those that use Skia) use the extension
GL_CHROMIUM_bind_uniform_location, which is implemented by ANGLE. This
leads to traces that contain calls to functions from this extension,
such as: glBindUniformLocationCHROMIUM. Such traces do not replay on
native GLES drivers, as the extension is not available.

The fix is to disable the GL_CHROMIUM_bind_uniform_location extension
when capturing, so that apps do not use this extension.

Bug: b/174256233
Change-Id: I8c6de9dc958147bcad053cbf89d8727b40f45fbe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2574836
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Allows shaders that use GS/TS to have input varying variables.

Bug: angleproject:5409
Change-Id: Idfbb725a4eef9e55fdde51d804a891b05dd1daee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2572879Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Dirtying the state unnecessarily was causing Vulkan backend to create
new framebuffer objects when it didn't need to.

Bug: b/174700581
Change-Id: I74e0ed51a2c6598ab3dca9a955c247ec97b6856f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2570201
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

This unifies the variable handling for IO blocks. Previously the
gl_in block we treated as an "in block" similar to an interface block.

Bug: angleproject:5423
Change-Id: Idf2db4c209055fa9ffca567dab39c89464eba156
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2571966Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This reverts commit 2ded93db.

Reason for revert: Appears to be breaking the ANGLE roll

Original change's description:
> Suppress memory leaks detected by LSAN
>
> In order to be able to land SwANGLE in Chromium, this cl adds
> suppressions for memory leaks detected by LSAN. Some of these
> should be fixed and some are intentional leaks of global
> variables.
>
> This cl should allow the linux_chromium_asan_rel_ng bot to pass
> while using SwANGLE.
>
> Bug: chromium:972686
> Bug: angleproject:5377
> Change-Id: I50a30e74a7d7c799c9dfa4d307792a56cb9d2017
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2562748
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Alexis Hétu <sugoi@chromium.org>

TBR=sugoi@chromium.org,syoussefi@chromium.org,jmadill@chromium.org,sugoi@google.com

Change-Id: I2ab53f3ab89143ea639424f108c404f884c3aaf9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:972686
Bug: angleproject:5377
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2574796Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/524e5bcfba33..41331850eb21

2020-12-03 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2020-12-03 ewerness@nvidia.com Shorten the ray so that it can't hit other cells
2020-12-03 ewerness@nvidia.com Only use AABBs for the shader record tests
2020-12-03 rgarcia@igalia.com Enable VK_KHR_ray_tracing_pipeline only if needed
2020-12-03 ewerness@nvidia.com Simplify geometry to reduce AABB precision issues
2020-12-03 rgarcia@igalia.com Test terminateInvocation with frag shader side effects
2020-12-03 michal.opalka@arm.com Fix test using protected features without creating a device with them enabled
2020-12-03 gleese@broadcom.com Fix image cube array tests support checks
2020-12-03 ryan.chen@arm.com Use shader to calculate sample point
2020-12-03 joshua@froggi.es Add tests for VK_EXT_4444_formats
2020-12-03 rgarcia@igalia.com Enable random writes for storage texel buffers
2020-12-03 rgarcia@igalia.com Test reading primitive id from frag shader after tessellation
2020-12-03 paulthomson@google.com Add a batch of GraphicsFuzz tests
2020-12-03 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests
2020-11-27 pdaniell@nvidia.com Update AccessInstance::verifyResult() to support 64-bit types
2020-11-26 Gregory.Grebe@amd.com Add dEQP-VK.pipeline.creation_cache_control.*
2020-11-26 joshua@froggi.es Add support for ABGR texture formats
2020-11-26 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/master
2020-11-26 rgarcia@igalia.com Force thread count in deferred host operations
2020-11-26 ewerness@nvidia.com Zero out the hit stride for miss SBT tests
2020-11-26 ari.suonpaa@siru.fi Fix validation errors in terminate invocation tests
2020-11-26 tomasz.owczarek@arm.com Add sliced 3D compressed texture test
2020-11-26 pdaniell@nvidia.com Initialize resourceImgLayout before use for all code paths
2020-11-26 marcin.kantoch@amd.com ExtensionUse variable not set for 1D and 3D images
2020-11-26 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/master
2020-11-26 rgarcia@igalia.com Test vkCmdBindVertexBuffers2EXT with size and offset
2020-11-26 rgarcia@igalia.com Test SPIR-V switch case jumping to the merge block
2020-11-25 gleese@broadcom.com Fixes for image format properties tests
2020-11-25 karolina.palka@mobica.com Add tests for YCbCr chromaFilter linear filtering
2020-11-24 gleese@broadcom.com Add ArrayStride decorations in TerminateInvocation tests
2020-11-24 boris.zanin@mobica.com Add ray tracing extensions to list of known extensions
2020-11-24 alexander.galazin@arm.com Merge vk-gl-cts/vk_khr_ray_tracing into vk-gl-cts/master
2020-11-24 alexander.galazin@arm.com Update glslang, SPIR-V headers, tools
2020-11-24 arkadiusz.sarwa@amd.com Add sparse tests shader_image_atomic_int64
2020-11-24 arkadiusz.sarwa@amd.com Add tests shader_image_atomic_int64 robustness2
2020-11-24 alexander.galazin@arm.com Switch spirv-binaries to Release build
2020-11-20 arkadiusz.sarwa@amd.com Add tests shader_image_atomic_int64 robustness
2020-11-20 arkadiusz.sarwa@amd.com Add tests for VK_EXT_shader_image_atomic_int64
2020-11-20 alexander.galazin@arm.com Update SPIR-V Tools/Headers, glslang

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC ianelliott@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com,angle-bots+autoroll-info@google.com
Change-Id: Ifb8d1402514edffbaccc84ee83ae288fad881c16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2574175Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/d76e39a75a7a..78187c025ba6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/796c41e4d2..b85da6c931
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/2a615b18c0..cd2895768d
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d1cf5db415
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8636efe70f..9ec0bb3220
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4ec098c279..58c3aa7c7b
* tools/skia_goldctl/linux: qmz8kJxTUN_Mt51qpFOU1gn2Es-tf5fUQbm_dwWR4WsC..U9IAKman_wN6alsQfNAUzIasErQFGDvx3wn9o0AQBlEC
* tools/skia_goldctl/mac: VNy9awCiFUEMvA_Yv0NaAUvTu5qcX1KK9w7RAp7kua8C..xF94ClStkjWlYHAlxYXSOCFYEGhzEgxZEwB4zirJIjUC
* tools/skia_goldctl/win: VR4k806B8ASaIGHP_wz13-mO3s-X-NxvU7dSULraOMEC..HYgBDvuNpEKiDYuVIssmP2wgCGe0FS-XKCe18wxZWKwC
No update to Clang.

Bug: angleproject:3354
Tbr: ianelliott@google.com
Change-Id: I29a7ddf57c3f28fc08360df936ae29584e0452f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2574157Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

In order to be able to land SwANGLE in Chromium, this cl adds
suppressions for memory leaks detected by LSAN. Some of these
should be fixed and some are intentional leaks of global
variables.

This cl should allow the linux_chromium_asan_rel_ng bot to pass
while using SwANGLE.

Bug: chromium:972686
Bug: angleproject:5377
Change-Id: I50a30e74a7d7c799c9dfa4d307792a56cb9d2017
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2562748Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

This reverts commit ff38106d.

Reason for revert: Suspect that this CL may be causing win-angle-rel-32 bot failures

Original change's description:
> Vulkan: Use specialization constant for halfRenderAreaWidth
>
> halfRenderArea is used by fragment shader to adjust gl_FragCoord for
> rotation and yflip compensation. This CL bakes halfRenderAreaWidth into
> shader via specialization constant, thus allow compiler to consolidate
> the calculation into one MAD instruction.
>
> Bug: b/173800146
> Change-Id: Id66301278e3389e2582369b695825e632bccecee
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551541
> Commit-Queue: Charlie Lao <cclao@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/173800146
Change-Id: I7bc9966ebbe949f3999d7927afa629dd2e3a4187
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2572801Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

Bug: chromium:1154759
Change-Id: If31ef7ebecdfa2a0cba91e917870ea0bdfd9b9db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2570464
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/bfb211914759..bae138de13ac

2020-12-02 amaiorano@google.com Reactor: add Type* member to Value and remove vtable
2020-12-02 amaiorano@google.com Fix crash from rr::Array with ENABLE_RR_DEBUG_INFO enabled
2020-12-02 natsu@google.com Guard VK_GOOGLE_SAMPLER_FILTERING_PRECISION
2020-12-02 amaiorano@google.com LLVM: add option to emit asm file to aid debugging
2020-12-02 amaiorano@google.com Coroutine: allow a name to be passed in for routine generation
2020-12-02 amaiorano@google.com ReactorUnitTests: use test name as Routine names
2020-12-02 amaiorano@google.com LLVM: store input name in JITRoutine
2020-12-02 amaiorano@google.com Fix FunctionT not forwarding its varargs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ic8144902a237feefdf7b8d841bbf411f08043ee5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2570399Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Add support for labeling of GL objects for debug purposes.

Tests: DebugTest.ObjectLabelsEXT*
Bug: angleproject:5337
Change-Id: I792a27c69395ed62da70c3f619bef71776fba432
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568711Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

This CL can enable and use the VK_EXT_device_memory_report extension.

This is disabled by default.  To enable, link with the required
extension, enable one or both of two features, AND build with the
following GN arg:

  angle_enable_trace = true

The two added  features are:

- logMemoryReportStats provides per-swap statistics
- logMemoryReportCallbacks provides per-callback logging

If either or both of the features are enabled, if the
VK_EXT_device_memory_report extension is available, it is enabled.

Bug: b/173636655
Change-Id: Ic5cf6c06efdb34f2313ef143853b3cc90f55faa5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2543506
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

Geometry shader inputs have an extra array dimension, which can be
unsized as it can be derived from the primitive type.  This change fixes
the grammar to support such arrays.

Additionally, it enables EXT_shader_io_blocks automatically with
EXT_geometry_shader and EXT_tessellation_shader per spec.

Bug: angleproject:3580
Change-Id: Ia7eb3e8be28c2eef2072dbe2a546fa34973104ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568242Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This is a reland of 0f083ab0

Original change's description:
> Reinitialize GL_VENDOR string when GPU switches
>
> We already update the GL_RENDERER string. We should do the same for
> GL_VENDOR so this information is passed along correctly.
>
> Bug: chromium:1152212
> Change-Id: I639700bfebdc9e77ec3c6b41fcd6516e8c32139d
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2560824
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

Bug: chromium:1152212
Change-Id: I044313366ce6ce7040e5c203a979b148dcb564dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2569364Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

In preparation for support of primitives generated queries.

Bug: angleproject:5404
Change-Id: Ic123aaff33f8903994ff8fcc9158954ac023ec13
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2562126
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

Bug: angleproject:5405
Change-Id: I652f2d6d3af4468b9662cdea5d2706d36e118239
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568550Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Enables OES/EXT_shader_io_blocks extensions in Vulkan backends.

With shader I/O blocks, the varyings can now be an array of struct (the
block itself) of struct (nested in the block).

This change is missing a number of features.  In particular, if the
shader I/O block has a location decoration in the middle of the block,
that is not handled yet.

Based on changes from m.maiya@samsung.com and jmadill@chromium.org.

Bug: angleproject:3580
Tests: dEQP-GLES31.functional.shaders.linkage.es31.io_block.*
 dEQP-GLES31.functional.separate_shader.validation.es31.io_blocks.*
 dEQP-GLES31.functional.program_interface_query.program_input.*
 dEQP-GLES31.functional.program_interface_query.program_output.*
Change-Id: I593840475d2365ff6c9ce7b2290f5ee462a30dfb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2567645Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

https://chromium.googlesource.com/chromium/src.git/+log/db49fa80f93d..d76e39a75a7a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/70bbe68c87..796c41e4d2
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/8a83254bed..2a615b18c0
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5d6094bfbc..1e294aea80
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5537c03942
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1e9edde7ad..4ec098c279
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/f685c086bd..71214b910d
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ie96b014526558dee4b12642f3bd00d61b97921f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568905Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

This reverts commit 0f083ab0.

Reason for revert: Seems to be blocking the ANGLE auto-roller (see: http://anglebug.com/5422)

Original change's description:
> Reinitialize GL_VENDOR string when GPU switches
>
> We already update the GL_RENDERER string. We should do the same for
> GL_VENDOR so this information is passed along correctly.
>
> Bug: chromium:1152212
> Change-Id: I639700bfebdc9e77ec3c6b41fcd6516e8c32139d
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2560824
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

TBR=geofflang@chromium.org,syoussefi@chromium.org,jonahr@google.com

Change-Id: I01bbb08946d16cf821f4fb1bfd8b1cade1ab70f1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1152212
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2567460Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

This document shows when and how shader code would hit the
optimization that translates the uniform block into
StructuredBuffer to resolve the slow fxc compiling performace
with dynamic uniform indexing.

Bug: angleproject:3682
Change-Id: I89d94a7e9d812318b9a6cbc470d39ed5ce3e47a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2561426Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

As ANGLE doesn't redeclare gl_PerVertex, glslang always defines it with:

    gl_Position
    gl_PointSize
    gl_ClipDistance
    gl_CullDistance

The unused members here contribute to varying component limits.  The
last two are unlikely to be used, and the second member is rarely used
as well.

This change keeps it simple and strips the trailing inactive members,
which for all intents and purposes accurately minimizes this struct.

Bug: angleproject:5405
Change-Id: I59c22af4988a3da7b1e428913d0ea13be9031cea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2562754
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

We already update the GL_RENDERER string. We should do the same for
GL_VENDOR so this information is passed along correctly.

Bug: chromium:1152212
Change-Id: I639700bfebdc9e77ec3c6b41fcd6516e8c32139d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2560824Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

This reverts commit b1917fe1.

Reason for revert: Not the root cause. See bug.

Original change's description:
> Revert "Vulkan: Use specialization constant for halfRenderAreaWidth"
>
> This reverts commit ff38106d.
>
> Reason for revert: Speculative revert to clear up AMD. See bug.
>
> Bug: chromium:1154356
>
> Original change's description:
> > Vulkan: Use specialization constant for halfRenderAreaWidth
> >
> > halfRenderArea is used by fragment shader to adjust gl_FragCoord for
> > rotation and yflip compensation. This CL bakes halfRenderAreaWidth into
> > shader via specialization constant, thus allow compiler to consolidate
> > the calculation into one MAD instruction.
> >
> > Bug: b/173800146
> > Change-Id: Id66301278e3389e2582369b695825e632bccecee
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551541
> > Commit-Queue: Charlie Lao <cclao@google.com>
> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> > Reviewed-by: Tim Van Patten <timvp@google.com>
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
>
> TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com
>
> Change-Id: Idab612bcad4f179857c41ffc4bf8fa2355fae946
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: b/173800146
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568244
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com

# Not skipping CQ checks because this is a reland.

Bug: chromium:1154356
Bug: b/173800146
Change-Id: I5b86bbee8600c6597620f31d8d7b08ca8b3d2d57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568246Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

MultithreadingTestES3.MultithreadFenceDraw
MultithreadingTestES3.MultithreadFenceTexImage

Fail with Mesa 20.0.8

Bug: angleproject:5418
Change-Id: Ie4254fe4a9c3f8b95fde30181065ddb31190fb99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568551Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This is a reland of abcabb47
only we continue to suppress the validation error

Original change's description:
> Vulkan: Fix incorrect exposure of sRGB extensions
>
> When we check to see what formats we can reinterpret for sRGB
> extensions, we need to make sure we can match the image usage
> flags as well. If the original format supports framebuffer
> attachment usage, we need to make sure that the reinterpreted
> format can support it as well.
>
> Bug: angleproject:5309
> Change-Id: I7e84d01004504f854a3e22227e99b1740ed1a2b2
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2549156
> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5309
Change-Id: I0efb6180b7be4e14d24b4bb339de01a2b9177e7e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2556571
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This reverts commit ff38106d.

Reason for revert: Speculative revert to clear up AMD. See bug.

Bug: chromium:1154356

Original change's description:
> Vulkan: Use specialization constant for halfRenderAreaWidth
>
> halfRenderArea is used by fragment shader to adjust gl_FragCoord for
> rotation and yflip compensation. This CL bakes halfRenderAreaWidth into
> shader via specialization constant, thus allow compiler to consolidate
> the calculation into one MAD instruction.
>
> Bug: b/173800146
> Change-Id: Id66301278e3389e2582369b695825e632bccecee
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551541
> Commit-Queue: Charlie Lao <cclao@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

TBR=timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com

Change-Id: Idab612bcad4f179857c41ffc4bf8fa2355fae946
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/173800146
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568244Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This will prevent symbol collision with X11. This fixes the
build integration with Skia.

Bug: angleproject:2621
Bug: angleproject:5416
Change-Id: I6949a375cf9fcdd790b4c40ffb82c7c25bc15315
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2567644
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

When a test mark as flaky fails consistently we need to avoid marking
the test as flaky. We treat is as a deterministic failure. This means
we output "PASS" as the expected result instead of "PASS FAIL". That
change will produce the correct behaviour with the test scripts.

Also adds missing test runner output when we retry a flaky test.

Bug: chromium:1152515
Change-Id: I9e3cbaf04ea57a198717ee81505b5d63a9183410
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2568231Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

We were leaking BufferHelper pointers in a couple cases. Fix these
systematically by using a unique_ptr template.

This leak was detected running ANGLE with LSAN enabled.

Bug: angleproject:5377
Change-Id: I30ab235105cf74fae2cfc62a22dde534e2d07e81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2567641Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This reduces the proliferation of small entry point files.

Bug: angleproject:2621
Change-Id: Ib882fd9e32e165279439d5d6cab7205eae0732ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2566592
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

This reduces code duplication in a few generator scripts. The version
lists are now located in registry_xml.

Bug: angleproject:2621
Change-Id: Ia1470f2863753d78d8def1132a20e81d3f8ec4a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2566591Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/9dff6a3bb595..bfb211914759

2020-11-30 aeubanks@google.com Fix swiftshader_reactor_llvm_unittests under UBSan Vptr
2020-11-30 srisser@google.com Accept Sign/Zero Extend operands in OpImageRead
2020-11-30 srisser@google.com Implement shaderSubgroupBroadcastDynamicId
2020-11-30 bclayton@google.com SpirvShaderDebugger: Fix crash when attempting to display nullptrs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I5fac2d07d616a3dc71651a69963d49e0125bfde8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2567669Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/2232da5cfdfa..db49fa80f93d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3328d0bdee..70bbe68c87
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/88c7098f26..8a83254bed
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5537c03942
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/20f5376c29..8636efe70f
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/212bc84e4e..1e9edde7ad
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: I9b263ae7702473b66663e53b7a46764a217e65c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2567712Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Expose OES_framebuffer_object extension for GLES1 contexts.

Bug: angleproject:5401
Test: FramebufferObjectTest*
Change-Id: I63b504f580cdab4655b4bfbd3438bcd807b422ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2561795
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

halfRenderArea is used by fragment shader to adjust gl_FragCoord for
rotation and yflip compensation. This CL bakes halfRenderAreaWidth into
shader via specialization constant, thus allow compiler to consolidate
the calculation into one MAD instruction.

Bug: b/173800146
Change-Id: Id66301278e3389e2582369b695825e632bccecee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2551541
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This adds two final auto-generated files for the EGL and EXT extension
entry points. It adds a new data file that stores a mapping between
object types and entry points for associating labeled objects with
certain methods. When we generate errors we record the associated
object in the debug message output.

This places the remainder of the hand-written code in "stub" files.
Going forward the work for implementing new extension entry points
for EGL will be to update the registry XML files and then implement
the corresponding stub methods. Event logging, parameter packing,
and validation are all handled by the auto-generated code.

Bug: angleproject:2621
Change-Id: I28153432802c37b929ff2ea1e1a3e3ce9de91605
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2562680
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>