The KHR GLES31 tests disabled and marked with Issue 4146 are passing,
likely due to the work for Issue 3570: Vulkan: Implement separate
shader objects or program pipeline objects. This CL re-enables the
tests.

Bug: angleproject:4146
Bug: angleproject:3570
Test: KHR-GLES31.core.shader_storage_buffer_object.basic-syntaxSSO
Test: KHR-GLES31.core.vertex_attrib_binding.advanced-bindingUpdate
Test: KHR-GLES31.core.vertex_attrib_binding.advanced-largeStrideAndOffsetsNewAndLegacyAPI
Change-Id: I4e42129c873604c937cf03412a105170755413e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2318265Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

Android builds are failing due to .git/HEAD being listed in the
Android.bp, which generate_android_bp.py is supposed to remove. The
problem is that the blacklist contains '//third_party/angle/.git/HEAD'
rather than '//.git/HEAD', due to generating the GN files from
chromium/src/ rather than angle/. This CL cleans this up.

Bug: b/160727922
Test: Manual script execution and building in AOSP
Change-Id: Ia1682605097791d20b28686f3043ddc08d49ca52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310960Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d92ddcef72ef..adf938680697

2020-07-22 jeremy@lunarg.com layers: Improve push constant error logging
2020-07-22 jzulauf@lunarg.com syncval: Cleanup of extraneous tags, user doc revs
2020-07-22 jzulauf@lunarg.com syncval: Style cleanup design/add user doc
2020-07-22 jakub@okonski.org Revert "Simplify the guard around ValidateMaxTimelineSemaphoreValueDifference"
2020-07-22 jakub@okonski.org Add a test for binary semaphore value difference checks
2020-07-22 jakub@okonski.org Simplify the guard around ValidateMaxTimelineSemaphoreValueDifference
2020-07-22 jakub@okonski.org Fix timeline semaphore value difference validations on binary semaphores
2020-07-22 christophe@lunarg.com doc: Add links to per-feature docs
2020-07-22 tony@lunarg.com tests: Skip test if limits are very large

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ie3197c42fb6e55018ec373f6851424596ba03252
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315295Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/11fa4d0d5694..3ee5f2f1d331

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I659c87076350acbd56ccbfdcb0751bb152fa72d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315294Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/f272427bda39..6a8a74986c35

2020-07-22 amaiorano@google.com Fix ReactorDebugInfo off by one line issues
2020-07-22 amaiorano@google.com Fix GN debug builds of SwiftShader on LLVM 10
2020-07-22 tommek@google.com Fix copying between images and buffers with padding

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: angleproject:4861
Tbr: timvp@google.com
Change-Id: I4a7da511bda78aa04b627cb3ba3ac79bc74a0c48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315293Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

We should explicitly set EGL_SURFACE_TYPE to EGL_DONT_CARE.
Otherwise, it's default value is EGL_WINDOW_BIT. However,
on some platforms, only EGL_PBUFFER_BIT is supported.
In this case, no matching config is found. So mWindowSurface
and mPbufferSurface will be nullptr. That's why we see
the bot failed.

Bug: chromium:1105208
Change-Id: I8ee2487fd24bab86a5ec22fbe7b8ff68081bc15c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304429
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Bug: chromium:1096442
Change-Id: I79722073bd1f2674b40e7eaa8d5311a09bc36416
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309636
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

Migrate from traces recorded on desktop to traces recorded
on a Pixel 4 XL. This impacts the resolution and framebuffer
config used for the tests. They now more accurately reflect
the numbers seen from running the benchmark directly.

Test: angle_perftests --gtest_filter=TracePerfTest.Run/*
Bug: angleproject:4048
Change-Id: Ib013dfb35c32c6f97bcae76a74cc16d9a5d1a369
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314896Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

Implemented parameter capture functions for:
    glGetActiveUniformsiv
    glGetActiveUniformBlockName
    glGetActiveUniformBlockiv

Added a check for bound unused locations when capturing glLinkProgram

Changed CaptureGetParameter to always request a gReadBuffer allocation
of the maximum reported possible array size needed to query
GL_COMPRESSED_TEXTURE_FORMATS. Recording the value on the capturing
device would previously have buffer overflow issues when the replaying
the capture on a device with more formats available.

Changed VertexAttribType::UnsignedInt2101010's string to reflect the
correct type

Bug: angleproject:4834
Change-Id: Icd1ff404369ae9f18cad7cd4f56fbcccc89e7e98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306735Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

This moves the trace header inclusion to the cpp file so that the
test itself doesn't need to look at the individual trace headers.
This fixes an include directory dependency. Also removes the FBO
change callback from the generated traces.

Bug: angleproject:4845
Change-Id: I019f0d347a62a81b92bf32110572911111212689
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314217Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This will let us override the util loader for all new traces. It will
also be easier to maintain going forward if we have to change the
header again.

The end goal is to run the trace tests with a custom GL layer that can
intercept certain API calls.

Bug: angleproject:4845
Change-Id: I028a1afdadf638998805d7b9a2cc6717cf5f0148
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2308029
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

Chrome still tends to use ES2 contexts for most rasterization. This is a
problem when trying to use FP16 IOSurfaces for rendering HDR because
GL_RGBA16F is not renderable in ES2. Since a surface is always
renderable, allow rendering to any textures with a bound surface.

Update the tests to verify that ES3 formats can be used with ES2
contexts.

Add tests for RGBA16F IOSurfaces.

BUG: chromium:1103112
Change-Id: I9e8c082fc97a0e072289b097e71fc944988d4872
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307454Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

A few files inside the D3D11 tree are used by D3D9 and WGL backends. We
add these files to the build system even when D3D11 is disabled.

Also, we fix the use the of ANGLE_DEFAULT_D3D11 symbol.

Bug: angleproject:4839
Change-Id: I981f4bfc60d973c02549caa737c5aed5ccf31282
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2298143Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b99a6a727318..11fa4d0d5694

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ic08523541b7efe21d00e2b410ca014cc18f6f661
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311940Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/50e737c82347..3b36fdc64014

2020-07-20 shannon@lunarg.com build: Update known-good files for 1.2.148 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I34c9270fdfc6581e546f7861cd7294e0213d45ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311941Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/97f9923235cf..f272427bda39

2020-07-21 capn@google.com Eliminate dead host/target feature code for Subzero
2020-07-21 amaiorano@google.com Fix ENABLE_RR_DEBUG_INFO on LLVM 10
2020-07-21 amaiorano@google.com Remove support for LLVM < 10
2020-07-21 amaiorano@google.com Delete LLVM 7 Kokoro configs
2020-07-21 amaiorano@google.com Fix LLVM-10 CMake build
2020-07-21 swiftshader.regress@gmail.com Regres: Update test lists @ 97f99232
2020-07-21 capn@google.com Regres: Don't test changes with negative scores

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I7a23451d6fef9da2f33b5d62b078ce9b0072ac27
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311730Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7cc0ead05174..d92ddcef72ef

2020-07-21 jzulauf@lunarg.com syncval: Cleanup document from autogeneration
2020-07-21 mark@lunarg.com tests: Add test for non-device concurrent buffer qfamily
2020-07-21 mark@lunarg.com corechecks: Check CONCURRENT_MODE against ALL pdev qfamilies

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Id0295628171dae6f3198bbe1dcb5fa55496ad115
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311731Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Imagine the following scenario:

1. Clear draw framebuffer
2. Invalidate draw framebuffer
3. Copy from read framebuffer into texture that is attached to draw
   framebuffer
4. Draw again into draw framebuffer

At step 2, FramebufferVk::syncState is called which extracts the clear
and stores it in mDeferredClears, but since the framebuffer description
hasn't changed, a new render pass is not started.

At step 3, the texture attached to the draw framebuffer is used as copy
destination, but its clear which is stored in the (apparently
irrelevant) draw framebuffer is not flushed.

At step 4, a new render pass is started which clears the draw
framebuffer, trampling the copy in step 3.

This change makes sure invalidate results in a flushDeferredClears().
With glInvalidateFramebuffer() (not glInvalidateSubFramebuffer()), the
deferred clears for invalidated framebuffers are discarded first.

It is unknown whether there are similar situations where syncState
gathers deferred clears, but they are not flushed before the attachments
are updated outside the framebuffer.  To catch similar bugs in the
future, assertions are added to FramebufferVk::syncState such that if a
dirty bit is set for the contents of an attachment, we can make sure
there are no prior deferred clears stored for that attachment.

Bug: angleproject:4862
Change-Id: Idb1a08b53e7f011f0fc9a54d478289030b6d77a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2308034Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Imagine the following situation:

1. Clear draw framebuffer
2. Noop operation on the framebuffer (Clear, ClearBuffer,
   BlitFramebuffer with flags specifying non-existing attachments)
3. Change framebuffer's attachment
4. Draw into framebuffer

At step 2, FramebufferVk::syncState was called before noop-ing the
operation.  During syncState, deferred clears were stored in the
framebuffer and weren't flushed because the actual operation was not
performed.

At step 4, the deferred clear meant for the prior attachment gets
applied to the new attachment.

Bug: angleproject:4865
Change-Id: I5b096bacf00356b4dccd4cbc9561b87b1bb557d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309224Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Some apps have a pattern where they clear the depth & stencil buffers
in the middle of the frame which causes the Vulkan backend to stop the
existing render pass and start a new one. This causes more loads &
stores of buffer contents than if we inline that clear with a draw.

Bug: b/159808300
Bug: angleproject:4695
Change-Id: I7a15af22f47a81051fa33fa19eaa123d8b66597c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289945
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

This variable tracks the index range of color attachments.  A previous
change (d8ce865b) made the range
inclusive so it can fit in 3 bits, but that's incorrect as it's no
longer possible to specify a range where no color attachments are
present.

This change partially reverts d8ce865b
to restore the previous semantics of
RenderPassDesc::mColorAttachmentRange.

Bug: chromium:1107884
Change-Id: I08da2568b5e63a48a672edd499a8b6653060eadb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310578Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This will facilitate intercepting the GL calls and implementing
emulation paths for offscreen redering. Or other EGL/GL features.
It does not yet override the GLES loader and uses the shared
'angle_util' loader as it did before.

Bug: angleproject:4845
Change-Id: I68806c307f59e1852999299e88dc358781817f12
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305042
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

This is a refactoring change only. It will facilitate moving these
functions to a shared library. A shared library will allow us to more
easily override GL functions with an interception layer. The intercept
layer will allow us to do emulation for features like offscreen tests.

Bug: angleproject:4845
Change-Id: I0e00c0c22a26f1bb8faec30a825c71953033f8a9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305039
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

Also updates a Vulkan back-end file to not return error.

Change log: https://chromium.googlesource.com/chromium/src/+log/b0410bba02..fb6cbaf6e5
Full diff: https://chromium.googlesource.com/chromium/src/+/b0410bba02..fb6cbaf6e5

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/45ab3c89af..1ee11394cf
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/204a35a2a6..9e121212d4
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3993ef1f52..f126fc6578
* third_party/Python-Markdown: https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/36657c103c..9c8566e047
* third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/217407c478..defbf92951
* third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/{chromium_..ec647b85b6
* third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/4fa54ca5f7..19f3fad68d
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/ae385786ed..89bddfee9c
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/04b99e7bf9..6412135b39
* tools/md_browser: https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/aae45d8d82..be8cf5a17d
DEPS diff: https://chromium.googlesource.com/chromium/src/+/b0410bba02..fb6cbaf6e5/DEPS

Clang version changed 4e0d9925d6a3561449bdd8def27fd3f3f1b3fb9f:04b9a46c842f793a2baedcad64de35fcbd3e93b7
Details: https://chromium.googlesource.com/chromium/src/+/b0410bba02..fb6cbaf6e5/tools/clang/scripts/update.py

Bug: angleproject:4867
Change-Id: I184945ad4d1fc39f4ad9b37cbf411b2c2b74a3ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309223
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This test makes sure the list of clear values given to the render pass
(for deferred clears) are correctly passed.

Bug: angleproject:4862
Change-Id: I4830a72a6f2b01570f6d4427ffb025429b5aa03c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309109
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

Bug: angleproject:2899,b/161716126
Change-Id: Ia850cbda948c8f6da9ced0bf46fd7f8371125032
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2288333Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Multiple tests are run in paralell to squeeze the most out of CPUs.
Tests are stored in a work queue. Whenever a CPU becomes available,
the next unrun test is grabbed and run on a spawn process on that CPU.

Each cpu gets their own environment and build folders and trace folders
so that tests don't overwrite each other.

Bug: angleproject:4817
Change-Id: Ifd35c9c75522e480b0257d090d5af70f2a3428ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2296040
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/30aa06f22718..4b40207be32d

2020-07-21 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/master
2020-07-21 alexander.galazin@arm.com Remove Amber example test
2020-07-20 slawomir.cygan@intel.com Reintroduce excluded dEQP-VK.binding_model.descriptorset_random tests
2020-07-20 alexander.galazin@arm.com Update Vulkan headers
2020-07-20 gary.sweet@broadcom.com VK_EXT_image_robustness tests
2020-07-20 alexander.galazin@arm.com Update glslang, SPIR-V Headers and tools

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-bots+autoroll-info@google.com,timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: angle-bots+autoroll-info@google.com,timvp@google.com
Change-Id: Ie3adac45f59f362fefc67f759356d26924e84d1f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309638Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/dd3511549b18..bfe4f378aee6

2020-07-20 shannon@lunarg.com build: Update known-good files for 1.2.148 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I71939d8fdd18bdf762eaa8f76106bdc801cd26cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309668Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/717e7877cac1..8b5ed4448dfe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I7d8f1390f84432f7f5409e869d1c4ecd4dca3653
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309789Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/ea6f21a052c9..97f9923235cf

2020-07-20 mark@chromium.org Fix macOS arm64 GN build by building llvm RWMutex.cpp
2020-07-20 ddorwin@google.com Update tests/presubmit.sh with modern syntax for Fuchsia bugs
2020-07-20 amaiorano@google.com Update to latest PowerVR to keep cmake source clean
2020-07-20 capn@google.com Support _PACK32 storage image formats and fix asserts

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I33b83dbecc68115347b146721180c628bfd3c998
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309790Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b1346703979e..7cc0ead05174

2020-07-20 locke@lunarg.com syncval: Add descriptor type and image layout
2020-07-20 jzulauf@lunarg.com syncval: Add heuristic to suppress safe WAW msg
2020-07-20 jzulauf@lunarg.com syncval: Add additional access info to hazard msg
2020-07-20 shannon@lunarg.com build: Update known-good files for 1.2.148 header
2020-07-20 tony@lunarg.com tests: Avoid "abort, retry, ignore" dialog boxes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I502f7d36f6e4aad6f3b51a93b8d69ec45461dea0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309666Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9eef54b2513c..b99a6a727318

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ib84d914c6ab19a88a93ea9662dc09ecae50e581d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309667Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Prior to this change, RenderTargetVk had getImage() and
getImageForWrite().  This change introduces getImageForCopy() and
renames getImage() to getImageForRenderPass().

Currently, all three functions do the same thing.  However, with
upcoming changes the semantics will be different:

- getImageForRenderPass(): This is the image used as the non-resolve
  attachment.  When resolve attachments are introduced, there will be a
  corresponding getResolveImageForRenderPass().
- getImageForCopy(): When GL_EXT_multisampled_render_to_texture is
  implemented, this will return the image that owns the data.
- getImageForWrite(): Similar to getImageForCopy(), but should set
  mContentDefined.  This is currently missing, and is a bug that will be
  resolved in a follow up.

This split change gets the mechanical rename out of the way to make
future changes simpler.

Bug: angleproject:4836
Bug: angleproject:4859
Change-Id: I5f7657cc049c0e1772a7c510e74289e685ba93c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306516
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

With the introduction of ABI-specific build targets (zlib), the script
generate_android_bp.py needs to be updated to consume ABI-specific gn
descriptions and generate ABI-specific build rules for each target.

The roll_aosp.sh script was updated to generate ABI-specific gn
descriptions for each:
    arm
    arm64
    x86
    x64

Bug: b/160727922
Test: Manual script execution and building in AOSP
Change-Id: I459b388176f8fcc010f9f5668535d941b931cdd4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2285272
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This CL updates the frontend to use the subject/observer pattern for
Programs and ProgramExecutables in PPOs.

This allows us to remove the hack that iterated through all PPOs and
marking them all dirty when a Program is re-linked. Instead, just the
PPOs the Program is bound to are signalled, and only when the Program
is in a PPO.

Additionally the necessary PPOs are signalled when an Executable's
textures are updated, rather than iterating through all PPOs and
signalling them.

Bug: angleproject:4559
Test: CQ
Change-Id: Iaefb88c64c13259e921c8dfe95cf640247d17f85
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300705
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

Data in RenderPassDesc is packed better to make room for resolve
attachments (9 bits made available; 8 for color and 1 for
depth/stencil).

mColorAttachmentRange contains values in [0, 8).  The right side of the
range is made inclusive (i.e. [0, 7]) so it will fit in 3 bits.

The number of samples is always a power of 2, and below 128 (for the
foreseeable future), so its log is stored instead in 3 bits.

This change doesn't add support for resolve attachments yet, but is
split off the one that does to simplify it.

Bug: angleproject:4836
Change-Id: I2856286d5239499d0ab0c78b8154881c003309bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306515
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

Split FramebufferVk::getCompleteRenderArea() into 2, [non-]rotated,
explicitly-named methods.  Simplify the uses of these methods, and fix
some rotation cases.  Also explicitly-name
FramebufferVk::getScissoredRenderArea().

Bug: b/151111296
Change-Id: I1754ec2796fd8625b916a2dba2e723e70ecba419
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305389Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

This is follow up to
https://chromium-review.googlesource.com/c/angle/angle/+/2288325. There
is no need to add current buffer to mResourceUseList for the per context
dynamic buffers. These dynamic buffers always shut down after we
call finishImpl.

Bug: b/160777679
Change-Id: I013cb3c30b4d31804cee13ce9e42da381fd1ae1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2300208
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

Objects of this class are used as keys to a hash map and contain 10
serials.  Prior to this change, operator== would compare all 10 serials.
This change tracks the maximum index set and only compares up to that
many serials.

To make sure this maximum index stays low in the presence of
depth/stencil attachment, this class stores the depth/stencil
attachment's serial before the color attachments.  The update API of the
class is improved so this implementation detail is not leaked.

This is in preparation for supporting resolve attachments, which would
add another 8 serials to the class.  With this change, the performance
of cases that don't use resolve attachments won't be affected.

Bug: angleproject:4836
Change-Id: Ia4874ab79163901fb86f5bee4120e9f19babdc09
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306514
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>