BUG=angleproject:916

Change-Id: I5be7460b737095eedb886be3e8978765c0940757
Reviewed-on: https://chromium-review.googlesource.com/286784Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Using that idiom on an empty vector results in an undefined behavior
that I have seen cause a vector to get length -1 with clang 3.6 on
Linux.

BUG=

Change-Id: I3bb8d8884efa29a17672b458263067644dbf0fec
Reviewed-on: https://chromium-review.googlesource.com/286740Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Cascades to remove serials from many objects.

BUG=angleproject:970

Change-Id: I0a74a14519da3203cd5df7ae0fa19f83393951ce
Reviewed-on: https://chromium-review.googlesource.com/286554Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:970

Change-Id: I33120ec8121dc1265360fbbe61103e03e593af3f
Reviewed-on: https://chromium-review.googlesource.com/286550Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:970

Change-Id: I63a7d8363f90018827c5d8482c9d98f3fa61c573
Reviewed-on: https://chromium-review.googlesource.com/286553Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:970

Change-Id: I1606df42e6423fe84d3ab69029a37224adb89a9b
Reviewed-on: https://chromium-review.googlesource.com/286552Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:970

Change-Id: I4fae29766ee76512375872535dbaf2d31a379de0
Reviewed-on: https://chromium-review.googlesource.com/286551Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1044

Change-Id: I0e7bee366398159ae6b87a820f36cb51c05cb064
Reviewed-on: https://chromium-review.googlesource.com/280362Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Change-Id: I24ea67f354191697d8a577c8b21ccc1689dd3536
Reviewed-on: https://chromium-review.googlesource.com/286016Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

This will help address a bug in glReadPixels performed after a resize.

BUG=angleproject:1050

Change-Id: Ie204dec229582ec0e990c6f7fa22cfd44048d46e
Reviewed-on: https://chromium-review.googlesource.com/286250Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

This reverts ac2582d3 which was a
speculative improvement. It turns out that resizing before the swap is
important as it lets the driver know that it should resize the default
framebuffer, making the following frame have a default framebuffer of
the right size.

BUG=angleproject:1050
BUG=angleproject:892

Change-Id: I84ec3728226fde9fb208f91c02a3d5a1ab71aef8
Reviewed-on: https://chromium-review.googlesource.com/286252Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

This was a typo that never had any effect but it could cause problems in
Debug but in release border_pixel could have contain garbage and cause
an X11 error.

BUG=angleproject:892

Change-Id: Id6dc24c726730d998b419101239b3a43d6675330
Reviewed-on: https://chromium-review.googlesource.com/286251Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

This allows the test code to assume that the framebuffer size is equal
to the window size.

BUG=angleproject:1050

Change-Id: Ia4928d7a1d6cddb1ae330846bb44576db6a37533
Reviewed-on: https://chromium-review.googlesource.com/286253Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

This will allow us to measure the impact of subsequent optimizations on
the memory consumption of Chrome.

BUG=angleproject:916

Change-Id: Ib57fdfcc2950917eff33080bfb3db574595ecb6d
Reviewed-on: https://chromium-review.googlesource.com/284637Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

This will make the code easier to edit and maintain.

BUG=none
TEST=angle_unittests,angle_end2end_tests

Change-Id: I955307d1209170fa99142103bc4d361c9eab1cc8
Reviewed-on: https://chromium-review.googlesource.com/286145Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

Improves draw call overhead of RendererGL.

DrawCallPerf_gl:
Before: 136973 score
After: 153317 score
Improvement: 11.932%

BUG=angleproject:959

Change-Id: Ib75f6fdd756648e4a07f6e970cda03abbdbcf009
Reviewed-on: https://chromium-review.googlesource.com/275409Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Improves draw call overhead of RendererGL.

DrawCallPerf_gl:
Before: 129779 score
After: 136973 score
Improvement: 5.543%

No noticeable difference in DLL size or draw call perf of the D3D
renderers.

BUG=angleproject:959

Change-Id: Id54d49e9e2cfb69431ee26d632c58fee2c42b82c
Reviewed-on: https://chromium-review.googlesource.com/275408Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Some intel drivers use seemingly arbitrary integers as uniform locations.
This causes the location vector to be resized to arbitrarily large sizes.

BUG=angleproject:882

Change-Id: I8db89178907dd6206eb8e646a0b426aa9bac0832
Reviewed-on: https://chromium-review.googlesource.com/274816Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1065

Change-Id: I1e396d1bd4d1c65edc3ad07bb32f895135d59474
Reviewed-on: https://chromium-review.googlesource.com/285180Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:891

Change-Id: If8aefa4a37ba7d1b6b08921bee61463bb20550af
Reviewed-on: https://chromium-review.googlesource.com/285834Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:891

Change-Id: Icb0dc3449db6982979a93a394fb9e0c58413a256
Reviewed-on: https://chromium-review.googlesource.com/285836Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

BUG=

Change-Id: I09ab785311ec0fa7f3eecb6484a965378a1fef0d
Reviewed-on: https://chromium-review.googlesource.com/285835Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Only happens with texture formats that require initialization.

BUG=angleproject:1069
TEST=dEQP-GLES3.functional.texture.format.sized.2d_array.* all pass

Change-Id: I215d1262cddcde4ed218b6f023e67747cbc3eeaf
Reviewed-on: https://chromium-review.googlesource.com/285347Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@google.com>

Some renderer configurations (e.g. D3D11 Feature Level 9_3) have
some limitations and aren't quite conformant. This change
generates errors when applications hit these limitations, and
informs developers that they must work around them.

BUG=angleproject:1055

Change-Id: I6a4a9e5cc71288ca366a54c769ca0eb82e79a7f7
Reviewed-on: https://chromium-review.googlesource.com/282814Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

*re-land with fix for matrix attributes*
*re-re-land with fix for attributes with BindAttribLocation*

Using the new vertex format type enum, we can shrink the size
of the input layout tables and reduce draw call overhead
further.

BUG=angleproject:959

Change-Id: I181acd3d7d519f5587cbe180fb1bca8530b7cfc2
Reviewed-on: https://chromium-review.googlesource.com/285348Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Add a test that checks that uniforms with an array type are allowed in
ESSL3.00.

TEST=angle_unittests
BUG=angleproject:1061

Change-Id: I6c9e8eeb3e8a6b81522c87039b93bcc0008ae317
Reviewed-on: https://chromium-review.googlesource.com/285481Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

Unset version requirements equate to UINT_MAX causing requirements checks
for fail for formats that only need extensions such as DXT formats.

Fixes tests that require compressed formats.

Passes conformance/extensions/webgl-compressed-texture-s3tc.html

BUG=angleproject:884

Change-Id: Id810c477a359bf9d35a886c60735a91b51d1e931
Reviewed-on: https://chromium-review.googlesource.com/275693Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Causing assertion failures in WebGL CTS in debug. Example build: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28NVIDIA%29/builds/10215

This reverts commit 2ee580f1.

Change-Id: Idffcd848adb6898f77b3c758b214eb31ca1f6e05
Reviewed-on: https://chromium-review.googlesource.com/285326Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

In the shading language grammar, layout qualifiers may appear in loop
conditions and function declarations, but this is not valid ESSL 3.00
according to section 4.3.8.

TEST=angle_unittests, dEQP-GLES3.functional.shaders.*layout*
BUG=angleproject:1064

Change-Id: I73f805247bf6678b953f2e1d45a23391e9eacb96
Reviewed-on: https://chromium-review.googlesource.com/285040Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

Seeing failures in the new tests on Chrome's Intel bot: http://build.chromium.org/p/chromium.gpu.fyi/waterfall?builder=Win7%20Release%20(Intel) 

Also seeing failures in the BlendMinMaxTest.RGBA16F test, may be related.

Reverting for now, can help diagnose the problems tomorrow if needed.

This reverts commit 61d46d87.

Change-Id: Id227f6ce8dafca24fbd2de92a2c4974e6a564c1f
Reviewed-on: https://chromium-review.googlesource.com/285227Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Change-Id: I3c96b0408d80be0f47c968566301637f49fe98c6
Reviewed-on: https://chromium-review.googlesource.com/285224Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Change-Id: Ie960cc00f136d86e5e3702a8f2e2f0f1930a5f47
Reviewed-on: https://chromium-review.googlesource.com/285230Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Change-Id: I2d62f410075385a87106f0c94ac1ff7cdd110655
Reviewed-on: https://chromium-review.googlesource.com/285185Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Change-Id: Ide6ef3d9995d1f3f66de4b340a60b4bf350a9ddb
Reviewed-on: https://chromium-review.googlesource.com/275479Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:884

Change-Id: I9e248e623f3b342f878bf65c9686768b90cf5ed8
Reviewed-on: https://chromium-review.googlesource.com/275692Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

Fixes conformance/reading/read-pixels-pack-alignment.html

BUG=angleproject:885

Change-Id: I48f1598d9a67f3980d2ff86307eb107ec7506776
Reviewed-on: https://chromium-review.googlesource.com/275691Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Fixes conformance/renderbuffers/framebuffer-object-attachment.html

BUG=angleproject:884

Change-Id: I421b563fa8549eb2edc42a9ac1c798fc457256ee
Reviewed-on: https://chromium-review.googlesource.com/275690Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1063

Change-Id: Id0772b5c8479150a1e736aa7cd35ec6444753278
Reviewed-on: https://chromium-review.googlesource.com/285126Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Change-Id: I87c363f68394d868d2a72e84bfdfd64db0c6e1d0
Reviewed-on: https://chromium-review.googlesource.com/284652Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Austin Kinross <aukinros@microsoft.com>

*re-land with fix for matrix attributes*

Using the new vertex format type enum, we can shrink the size
of the input layout tables and reduce draw call overhead
further.

BUG=angleproject:959

Change-Id: I6d8ad78a003c41f40e7e1caa5972838f8ff4fce8
Reviewed-on: https://chromium-review.googlesource.com/284811Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>