Skip to content

A
angle
Switch branch/tag
  1. 27 Oct, 2020 6 commits
  3. 26 Oct, 2020 16 commits
  5. 25 Oct, 2020 7 commits
  7. 24 Oct, 2020 10 commits
  9. 23 Oct, 2020 1 commit
    • Revert "Link C++ histogram support into angle_perftests." · 4953f03d
      Tim Van Patten authored 
      This reverts commit 7a026354.

Reason for revert: Breaks roll of ANGLE into AOSP:

ERROR at //testing/test.gni:76:5: Assertion failed.
    assert(_use_raw_android_executable || enable_java_templates)
    ^-----
See //third_party/catapult/tracing/tracing/BUILD.gn:35:1: whence it was called.
test("histogram_unittests") {
^----------------------------
See //src/tests/BUILD.gn:262:17: which caused the file to be included.
      deps += [ "//third_party/catapult/tracing/tracing:histogram" ]
                ^-------------------------------------------------

Original change's description:
> Link C++ histogram support into angle_perftests.
>
> This is the first step in uploading histogram data instead of a gtest
> special format. We  importing several new libraries:
>
> - tools/protoc_wrapper
> - third_party/protobuf
> - third_party/catapult (was already used for Android)
>
> No functional change. Only affects compilation. Protobuf support is
> disabled when not available.
>
> Bug: angleproject:5161
> Change-Id: Ie28d57d7e142c437ebd51463ce3e2cafd87468d1
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2482294
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=ynovikov@chromium.org,bsheedy@chromium.org,jmadill@chromium.org

Change-Id: I62c4b926cbe82d10e460b28b5f864521e2b1f8ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:5161
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495549Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>