Commits · c415283b2bcd786e1a8c55c19ef3511eb2b3928c · Chen Yisong / angle

20 Feb, 2015 2 commits

authored Feb 20, 2015

BUG=angle:882

Change-Id: I6fd426b19677b51f4df74d495acc9a6fde9822e8
Reviewed-on: https://chromium-review.googlesource.com/251540Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

c415283b

Make Angle code 40 KB smaller by using string literals directly. · 29190088

authored Feb 20, 2015

The implicit conversion of hundreds of string literals
to TString generated a lot of machine code. By keeping them
as string literals all the way the code will be smaller and faster.

This is the change with clang for x64 (note VisitUnary in particular):
Total change: -41392 bytes
==========================
  2 added, totalling +469 bytes across 1 sources
  2 removed, totalling -472 bytes across 1 sources
  5 shrunk, for a net change of -41389 bytes (54126 bytes before, 12737 bytes after) across 1 sources
  279692 unchanged, totalling 51433327 bytes

------------------------------------------------------------------------------------------------------------------------------------
 -41392 - Source: /home/bratell/src/chromium/src/third_party/angle/src/compiler/translator/OutputHLSL.cpp - (gained 469, lost 41861)
------------------------------------------------------------------------------------------------------------------------------------
  New symbols:
       +328: sh::OutputHLSL::outputConstructor(Visit, TType const&, char const*, TVector<TIntermNode*> const*) type=t, size=328 bytes
       +141: sh::OutputHLSL::outputTriplet(Visit, char const*, char const*, char const*) type=t, size=141 bytes
  Removed symbols:
       -133: sh::OutputHLSL::outputTriplet(Visit, std::basic_string<char, std::char_traits<char>, pool_allocator<char> > const&, std::basic_string<char, std::char_traits<char>, pool_allocator<char> > const&, std::basic_string<char, std::char_traits<char>, pool_allocator<char> > const&) type=t, size=133 bytes
       -339: sh::OutputHLSL::outputConstructor(Visit, TType const&, std::basic_string<char, std::char_traits<char>, pool_allocator<char> > const&, TVector<TIntermNode*> const*) type=t, size=339 bytes
  Shrunk symbols:
       -388: sh::OutputHLSL::writeEmulatedFunctionTriplet(Visit, char const*) type=t, (was 628 bytes, now 240 bytes)
       -714: sh::OutputHLSL::visitBranch(Visit, TIntermBranch*) type=t, (was 1017 bytes, now 303 bytes)
      -9738: sh::OutputHLSL::visitAggregate(Visit, TIntermAggregate*) type=t, (was 17609 bytes, now 7871 bytes)
     -14132: sh::OutputHLSL::visitBinary(Visit, TIntermBinary*) type=t, (was 17627 bytes, now 3495 bytes)
     -16417: sh::OutputHLSL::visitUnary(Visit, TIntermUnary*) type=t, (was 17245 bytes, now 828 bytes)

Change-Id: Id0f87d72f6d7f1ab7b543f0d28d5a8b7c7db9ec7
Reviewed-on: https://chromium-review.googlesource.com/251090Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: bratell at Opera <bratell@opera.com>

29190088

19 Feb, 2015 8 commits

Load all core WGL functions. · aff43af9

authored Feb 19, 2015

BUG=angle:879

Change-Id: If204156e69480cd7e1e7c43db8496dd150ac9e15
Reviewed-on: https://chromium-review.googlesource.com/251241Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

aff43af9

Expose FunctionsWGL::getProcAddress. · ea8ae897

authored Feb 19, 2015

Change-Id: I263f00e67eb3243c661de8f949933ea56e34d4b5
Reviewed-on: https://chromium-review.googlesource.com/251220Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

ea8ae897

Enable MSVS warning 4512. · 80d934bb

authored Feb 19, 2015

Fix up the missing DISALLOW_COPY_AND_ASSIGN macros and various small
problems preventing us from turning on this warning. This should
ensure we more often use the DISALLOW macro going forward.

Change-Id: I2e1a9d23a31a51279a577fad8dffb8c1530e2ee8
Reviewed-on: https://chromium-review.googlesource.com/251100Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cooper Partin <coopp@microsoft.com>
Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

80d934bb

Revert "Implement missing variants of abs/sign" · 7c1f6f19

authored Feb 19, 2015

This for some reason is failing angle_unittests:

http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NVIDIA%29/builds/13296

Happens across platforms.

This reverts commit 3e142e47.

Change-Id: Ideb20457546c0dec10c9584182cc8d5ead42309d
Reviewed-on: https://chromium-review.googlesource.com/251160Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

7c1f6f19

Implement the copy from a 3D texture to Image11. · 32334afe

authored Jan 30, 2015

Fixes the generation of 3D texture mipmaps.

BUG=angle:915

Change-Id: Icc0c91099f60713d511ebe1a2248a21b63efddaa
Reviewed-on: https://chromium-review.googlesource.com/244720Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Gregoire Payen de La Garanderie <Gregory.Payen@imgtec.com>

32334afe

Implement ESSL3 modf · b6e07a6a

authored Feb 16, 2015

This is the first built-in function that has an out parameter, so l-value
checks are added for built-ins.

BUG=angle:918

Change-Id: Ifd5befe955224f706f864e25107879c9cdce9e9f
Reviewed-on: https://chromium-review.googlesource.com/250780Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

b6e07a6a

Fix GetShaderPrecisionFormat to return correct values on DX11 · 481373d8

authored Feb 16, 2015

The integer precision is different on DirectX 9 and 11 backends. DirectX
11 guarantees native 32-bit integers.

BUG=angle:919

Change-Id: I7619e66f8aaa1177c32b6da185fe805ce8a19b71
Reviewed-on: https://chromium-review.googlesource.com/250280Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

481373d8

Implement missing variants of abs/sign · 3e142e47

authored Feb 19, 2015

This change adds ANGLE support for abs/sign variants introduced
in ESSL3.

BUG=angle:923
TEST=dEQP tests
Tests passing 100% because of this change:
dEQP-GLES3.functional.shaders.builtin_functions.common.abs
dEQP-GLES3.functional.shaders.builtin_functions.common.sign

Change-Id: If22032be2c1ed08451275262e311ef5ac613d45e
Reviewed-on: https://chromium-review.googlesource.com/251060Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

3e142e47

18 Feb, 2015 9 commits

Enable MSVS warning 4530. · ed6be7e6

authored Feb 18, 2015

This forces us to not use exceptions when they aren't enabled.

Change-Id: I6abaf08ca4c275bd2fa0625905fd1de3448237ce
Reviewed-on: https://chromium-review.googlesource.com/250901Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>

ed6be7e6

Revert "Re-resubmit "Compile the D3D11 VS and PS on separate threads at GL link time"" · 6df9b37d

authored Feb 18, 2015

Fails clang-win again. Apparently Clang mimics MSVS.

This reverts commit af1bdff6.

Change-Id: I48a503889a9e905fcdc9f101dbf98f7cb7912279
Reviewed-on: https://chromium-review.googlesource.com/250882Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

6df9b37d

Add ANGLE platform implementation template. · 5feea562

authored Feb 17, 2015

The platform implementation allows the app layer to pass in an
object, on which ANGLE can call virtual methods. Our current
platform will handle trace events, for app profiling, and
histogram records for statistics. The platform approach gives
a much more robust approach than using entry points for every
piece of functionality, and is based on the interop with Blink.

The default platform implementation does a no-op on every call.
The destructor is also private, to ensure we do not call the
destructor of the passed-in class.

BUG=436191

Change-Id: I05641b89a48a9cff81ced059518fceb5aa6c883b
Reviewed-on: https://chromium-review.googlesource.com/248631Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

5feea562

Fix loaded GL entry points using the wrong call type. · 32b5b147

authored Feb 18, 2015

BUG=angle:879

Change-Id: Ida65d67d2935480dfe584026d37fb68cd2ab39d6
Reviewed-on: https://chromium-review.googlesource.com/250823Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

32b5b147

Fix constant folding integer modulus · 3eab00a0

authored Feb 12, 2015

Constant folding % used to generate results from division instead of
results from modulus. Fix this and introduce a test for this and other
integer constant folding, that checks that the right constant values are
found in the IntermNode tree.

BUG=angle:916
TEST=angle_unittests

Change-Id: I75e59b7734eb206378a1b2957af0a5437a90097c
Reviewed-on: https://chromium-review.googlesource.com/249691Reviewed-by: Gregoire Payen de La Garanderie <Gregory.Payen@imgtec.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Nicolas Capens <capn@chromium.org>

3eab00a0

Implement isnan/isinf · 0c1726e6

authored Feb 18, 2015

This change adds ANGLE support for isnan/isinf.

BUG=angle:922
TEST=dEQP tests:
dEQP-GLES3.functional.shaders.builtin_functions.common.isnan.*
(high precision tests still fail)
Tests passing 100% because of this change:
dEQP-GLES3.functional.shaders.builtin_functions.common.isinf.*
Reduced number of errors in tests:
EQP-GLES3.functional.shaders.constant_expressions.builtin_functions.common.isnan.*
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.common.isinf_*

Change-Id: I52bf18b59365ea7031746ae840550162d7e6b96e
Reviewed-on: https://chromium-review.googlesource.com/250761Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Nicolas Capens <capn@chromium.org>

0c1726e6

Implement missing vector relational functions · 2b45573b

authored Feb 17, 2015

This change adds ANGLE support for following vector relational
function variants introduced in GLES3:
bvec lessThan(uvec x, uvec y)
bvec lessThanEqual(uvec x, uvec y)
bvec greaterThan(uvec x, uvec y)
bvec greaterThanEqual(uvec x, uvec y)
bvec equal(uvec x, uvec y)
bvec notEqual(uvec x, uvec y)

BUG=angle:920
TEST=dEQP tests
Reduced number of errors in tests:
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.vector_relational.*

Change-Id: Id45ce77b35f39403e587a577622271d8e9815225
Reviewed-on: https://chromium-review.googlesource.com/250377Reviewed-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

2b45573b

Expose the IntermNode tree generated in the compiler for testing · a3a5cc6a

authored Feb 13, 2015

This refactoring makes it possible for tests to access the IntermNode
tree produced by compilation by calling compileTree(). Removing
ParseContext usage from OutputHLSL has the additional benefit of better
separation between parsing and output.

BUG=angle:916

Change-Id: Ib40954832316328772a5c1dcbbe6b46b238e4e65
Reviewed-on: https://chromium-review.googlesource.com/249723Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

a3a5cc6a

Do not use std::set::at in Config.cpp. · 73edef0a

authored Feb 17, 2015

This is C++11 STL.

BUG=459399

Change-Id: I2e994e6b47535bcb38c193db2aaecc304e388772
Reviewed-on: https://chromium-review.googlesource.com/250581Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

73edef0a

17 Feb, 2015 8 commits

D3D11: Use system memory for dynamic buffer updates. · f25eb1d6

authored Feb 17, 2015

In our current code, we would use a staging texture as the working
copy for buffer updates. This would trigger very large memcpy calls
in some cases for large buffers with small updates. Instead, use
a CPU memory buffer storage, and work with this storage when the
user updates data. This plays much nicer with the VertexDataManager.

BUG=angle:912

Change-Id: I8c32d3d9bb321a06534556ce05b4b99dc3d1e961
Reviewed-on: https://chromium-review.googlesource.com/249183Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

f25eb1d6

Re-resubmit "Compile the D3D11 VS and PS on separate threads at GL link time" · af1bdff6

authored Feb 17, 2015

The latest version of this change disables multithreaded D3D shader
compilation with any C++ compiler other than VC (e.g. Clang).

Change-Id: If3ef5fd650055ae66397ea2c9121bfcf1792892a
Reviewed-on: https://chromium-review.googlesource.com/250328Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

af1bdff6

Add a FunctionsGL class for loading GL entry points. · 56cf9af2

authored Feb 17, 2015

BUG=angle:879

Change-Id: I35384f078d2ed86a6c72cc243753b56bc58617b0
Reviewed-on: https://chromium-review.googlesource.com/250390Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

56cf9af2

D3D: Re-init static buffer after invalidate. · 5b8b1087

authored Feb 13, 2015

This allows the Buffer class to always know if it's intended to
use static data vs dynamic. In some cases we would end up with
NULL pointers and not know if we started with static or dynamic
usage.

BUG=angle:912

Change-Id: I79ca62674543e0cf4b2ba9b31b6d8918723b31ce
Reviewed-on: https://chromium-review.googlesource.com/249460Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

5b8b1087

Generalize NativeBuffer11::setData. · 026b4188

authored Feb 13, 2015

We can replace this method with a base class method which uses our
implementation of "map". This allows us to reuse setData in other
mappable buffer storage types.

BUG=angle:912

Change-Id: I7848cb9440b806364d9b2a6e2251323e53206921
Reviewed-on: https://chromium-review.googlesource.com/249182Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

026b4188

Revert "Resubmit "Compile the D3D11 VS and PS on separate threads at GL link time"" · d2d21dca

authored Feb 17, 2015

Causes errors in Clang-Win. We can fix the error and then resubmit, but need to do a roll now.

This reverts commit 31018486.

Change-Id: I1c91b0a97031df33c2261089f6b54ccd3270306b
Reviewed-on: https://chromium-review.googlesource.com/250430Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

d2d21dca

Implement missing variants of min, max and clamp · 42077bb1

authored Feb 16, 2015

BUG=angle:914

TEST=dEQP tests
Tests passing 100% because of this change:
  dEQP-GLES3.functional.shaders.operator.common_functions.min.*
  dEQP-GLES3.functional.shaders.operator.common_functions.max.*
  dEQP-GLES3.functional.shaders.operator.common_functions.clamp.*
Reduced number of errors in tests:
  EQP-GLES3.functional.shaders.constant_expressions.builtin_functions.common.*
  These tests are not yet passing because of constant expressions
  bug (angle bug:913)

Change-Id: Ibccee47ed78e994e40a0effe9afa9cf9692492b0
Reviewed-on: https://chromium-review.googlesource.com/250330Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

42077bb1

Fixed variable shadowing warnings · f7b10164

authored Feb 12, 2015

Change-Id: I7cf9e09f4003991e44195bedfe58891288541f81
Reviewed-on: https://chromium-review.googlesource.com/249432Reviewed-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

f7b10164

16 Feb, 2015 2 commits

Make Buffer11.cpp build with clang. · d8d58301

authored Feb 13, 2015

Change-Id: If72bc38dbb484e56a0a26c3aa7ac38bbc319653a
Reviewed-on: https://chromium-review.googlesource.com/249921Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

d8d58301

Separate integer and float modulus · ff805cc3

authored Feb 13, 2015

Integer and float modulus are separated into Mod and IMod operator types
to make the code clearer and to make GetOperatorString return the correct
value for both.

Change-Id: Ibfbca2c558bf919b0eab6404d7349f87fe47a18c
Reviewed-on: https://chromium-review.googlesource.com/249692Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

ff805cc3

13 Feb, 2015 6 commits

Enable the OpenGL/WGL backend on Windows. · 23dcabad

authored Feb 13, 2015

BUG=angle:890

Change-Id: Ida58ecb9f3bcfd7ee9ae5c7cdbdff4aab9cca869
Reviewed-on: https://chromium-review.googlesource.com/249741Reviewed-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

23dcabad

Add the OpenGL renderer to the GN build. · c588ac73

authored Feb 13, 2015

BUG=angle:890

Change-Id: I097296c7125e203ba04eab1c179dc8c183ed4789
Reviewed-on: https://chromium-review.googlesource.com/249842Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

c588ac73

Fixed compressed texture support reporting for feature level 9_3 · d28f6113

authored Feb 12, 2015

Change-Id: If6e27db912711532e184a3a716728a19653c0471
Reviewed-on: https://chromium-review.googlesource.com/249550Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

d28f6113

Remove the dependency on OpenGL32.lib by loading all WGL functions. · 12892c91

authored Feb 13, 2015

BUG=angle:879

Change-Id: I1a10a86b710cb0c76be1907136345bcac078da4d
Reviewed-on: https://chromium-review.googlesource.com/249740Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

12892c91

Fix Buffer11 staging buffer revision update. · d12971af

authored Feb 12, 2015

This bug could trigger a potential extra copy when drawing with
a pack buffer (or possibly packing vertex/index data).

BUG=angle:912

Change-Id: Ifead6524322aac5bc0be79a05f4db08c8f5a3225
Reviewed-on: https://chromium-review.googlesource.com/249181Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

d12971af

Add a basic WGL implementation. · 398d8e6e

authored Jan 22, 2015

BUG=angle:890

Change-Id: I5202086990b4f4fbf455fd73c3e29e5e3e1f6160
Reviewed-on: https://chromium-review.googlesource.com/240092Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

398d8e6e

12 Feb, 2015 5 commits

Add addBinaryMath and addUnaryMath helpers to ParseContext · 09b22474

authored Feb 11, 2015

This refactoring reduces code duplication and moves functionality that is
not immediately related to the language grammar out of glslang.y.

BUG=angle:911

Change-Id: If5e225461890ed542dee01905829df1c9a6f5e27
Reviewed-on: https://chromium-review.googlesource.com/248570Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

09b22474

Disable warning 4530 in the libANGLE GN project · 40853472

authored Feb 12, 2015

Change-Id: I56b5428f40a294248305dff168b9b0bb7b0a9bcc
Reviewed-on: https://chromium-review.googlesource.com/249240Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

40853472

Clean up the style in Buffer11.cpp. · f03bcad6

authored Feb 11, 2015

Fix indentation, and simplify the naming scheme for the storage.
Also add some missing DISALLOW_COPY_AND_ASSIGN macros.

BUG=angle:912

Change-Id: I7ac36d8185ce926999501358cec222154d9a3492
Reviewed-on: https://chromium-review.googlesource.com/249180Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

f03bcad6

Move operator definitions to their own file · 1033e1d8

authored Feb 12, 2015

This generalizes GetOperatorString so that it can be used outside
ValidateLimitations.

BUG=angle:911

Change-Id: I43a160b3d7d60388ad529a72f1720d3171f67315
Reviewed-on: https://chromium-review.googlesource.com/249073Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

1033e1d8

Update WebGL failures list. · 10617310

authored Feb 11, 2015

Change-Id: I5cf9e873ddcb293f121a11bd620ce97ee718c049
Reviewed-on: https://chromium-review.googlesource.com/247760Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

10617310