Our GN was using the incorrect path for the new test sets. This was
showing up as an isolate_tests failure when running the new tests.

Also fixes incorrect search paths for the case list directory when used
in a Chromium checkout. And adds a few other missing data dependencies.

Bug: angleproject:3353
Change-Id: I602db1e5debdad88b6eace76416fc2c10c059f8b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1616021Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/4b0985f29277..9674a1a54754


Created with:
  gclient setdep -r ./third_party/spirv-headers/src@9674a1a54754

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=syoussefi@google.com

Change-Id: I23c59c0273df539d1a9c0649dd2608550dd9c9f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1617361Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Few features are already implemented but the suppressions were not
removed.

Bug: angleproject:2392
Bug: angleproject:2394
Bug: angleproject:3199
Bug: angleproject:3219
Bug: angleproject:3423
Change-Id: Iefd6c10f5ec774e174901114b35410c0d397085f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1614428
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

This adds a few simple system utility functions. We can check if a
debugger is attached and break into the debugger.

Most of the code is adapted from Chromium's base/debug.

Bug: angleproject:3162
Change-Id: I9cb39d42865a543fbf3201222dd8227318b32ad5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1615353Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Due to complex and slow process of upstreaming it's easier to disable
this warning than to fix it upstream. Only happens in a Chromium build
because Chromium uses a specialized standard library.

Bug: angleproject:3353
Change-Id: I01607a00e469110c87458458d3b205fd59ea3db3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1614426Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:1944
Change-Id: Ib0a9195ddaf5afc6f909631c859c7e0bd33d7a1a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1600050Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This reorganizes the dEQP build targets to allow for better reuse with
the new KHR test set. It also adds a single new test target called
"angle_deqp_khr_tests" that houses all the new test sets.

The new test targets can be compiled now but cannot yet be executed.
That new functionality will follow in a subsequent CL. Along with test
expectations and integration.

Uses a new template type in the build to conslidate GN customization.

Adds the GLES 2.0 and 3.0 tests for now. We can follow up with
additional work for the GLES 3.1+ tests. Also adds test expectations.

Bug: angleproject:3353
Change-Id: Ib0673e97f679c8aa46e27dfa616845a2014a75fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1604070
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Bug: angleproject:3199
Change-Id: I29fdf33ea5af37a66c2cfd5b3355d7ff32105d63
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1614781Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Some NVIDIA D3D11 drivers are buggy and interprets the level passed to
GetDimensions as being relative to 0, rather than the SRV's MostDetailedMip.
This affects integer cube maps because the dimensions are used for sample
position calculations, which leads to sampling outside the cube side textures
when the base level is non-zero.

Bug: angleproject:3441
Change-Id: I151f9336b9c6d8ec7012bf5010a2d45fb2951e73
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1595688
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f815e6fe51af..9dfd4b835807


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@9dfd4b835807

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=syoussefi@google.com

Change-Id: I036f558eed529ed640e0908e1fe30f50793646e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1614556Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Struct mapping consumes lots of time when the array lengh is very large.
And it's done unconditionally. This CL does struct mapping only if it's
a struct assignment or passing the struct to a function.

In the next step, we can use a function to do struct mapping instead of
struct array initialization.

Bug: angleproject:2967

Change-Id: Ie5a74fa05dbc0255ad664d6265dbb880a624f01e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1612978Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

Refactor and cleanup only.

Bug: angleproject:3353
Change-Id: I2a01ddf71ba44b8f1a1fc2c4ccbac9edc7c80174
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1613893Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This was previously a method in dEQP only. Cleanup change only.

Bug: angleproject:3353
Change-Id: I9ac58ab52516f75efbb08bddb39466a40c07cbb8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1613892
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

ESSL 1.00 spec allows for variable with same name to override outer variable
inside of a nested scope. This change adds new scope to symbol table inside
of a function defintion, but after function parameters for ESSL 1.00
shaders (but not webGL). This prevents an error while parsing.

This also includes some new code in translator to rename any vars that are
redefined between the function body and the function parameters. This
prevents an error later on when the translated shader is then parsed as
a desktop GLSL version.

Bug: angleproject:3287
Change-Id: I3f025805cf8d65bf912283bb15e6dad6e5e9b967
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1601553
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Update the logic to compress ANGLE's symbols for Android to correctly
include the necessary symbols.

Bug: angleproject:3448
Test: Build and install APK, verify symbols are present during crash
Change-Id: Ibb995aa775d47fb9921e4ab11b956c63ac474c30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1611750
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

This allows us to reuse it in our other BUILD.gn files.

Bug: angleproject:3353
Change-Id: Ic88f7781010d7319dfe3bb8f2f942fa08d37e4dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1614097
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

Texture2DIntegerTestES3.IntegerTextureNonZeroBaseLevel/ES3_OpenGL

Bug: chromium:963595
Change-Id: I6cdd845a5b7bc1a4b5a16029eaf170db40f1787c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1613894Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Templates make it easier to override parts of test configs. Instead
of if statements we can use forwarded variables to override specific
settings. This refactor makes it easier to integrate the "KHR" tests.

Bug: angleproject:3353
Change-Id: Ia6e9c6d01864e5253db5d28dc087bf954aee226c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1612297Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

dEQP only covers this behaviour in ES2.0 tests and they fail when running with
an ES3.1 context.

BUG=angleproject:3425

Change-Id: I339b83901434da92ae6dd6273460b0725644cdf5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1602177Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Note: Includes workaround for http://anglebug.com/3452 - some Android
devices do not indicate filtering support on VK_FORMAT_D16_UNORM.

Bug: angleproject:3103
Test: angle_end2end_tests --gtest_filter=DepthStencilFormatsTest.DepthTexture/*
angle_end2end_tests --gtest_filter=DepthStencilFormatsTest.PackedDepthStencil/*
angle_end2end_tests --gtest_filter=DepthStencilFormatsTest.DepthTextureRender/ES2_VULKAN

Change-Id: Ic325fb94ab0e619a17c2e149e0e0865fa4142f3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1575426
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e935dac9ef8a..f815e6fe51af


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@f815e6fe51af

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=syoussefi@google.com

Change-Id: I555803c6e26d7dc9f984437e79703452bdec7b47
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1612155Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Texture data corruption has been seen with this format, specifically
on AMD Radeon R7 240 cards with the 15.201.1301.0 driver.

BUG=941620

Change-Id: I42d0d86a8319afdfaf17b44e142c6414092c647d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610681Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Unlike fuchsia_x64, this trybot builds with angle_top_of_tree, and won't
cause random patch failures.

Bug: angleproject:3146

Change-Id: Iea8f93c7e3b6c4bf4514a9c0c6eacca9bd3228c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1611730
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2947e88f7938..e935dac9ef8a


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@e935dac9ef8a

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=syoussefi@google.com

Change-Id: I55a97cd577fd8ae45e0ba93cbf9a7dfaa6122700
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1611439Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

A piece of code shared with d3d was used to implement this feature.
However, we store the uniform data transposed and row-major in d3d to
accomodate the fact that matrix indexing in HLSL is the opposite of GLSL
(mat[row][col] in HLSL as opposed to mat[col][row] in GLSL).

There were two functions that copied the source matrix fields either as
column-major or source-major (corresponding to `transpose` false or true
respectively in glUniformMatrix*) into a row-major destination.  These
functions are refactored into one, which copies from any-major source to
any-major destination.  The HLSL backend uses the "to row-major" variant
and the Vulkan backend uses the "to column-major" variant.

Bug: angleproject:3198
Change-Id: I7254da4fbe6916af78c5906abcb82ca01674ab9f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1607541
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The glmark2 benchmark score went down (on Android with Pixel devices)
when ANGLE changed VkSwapchainCreateInfoKHR::minImageCount from 3 down
to 2, when using VK_PRESENT_MODE_MAILBOX_KHR.  In experimenting, this
was confirmed.  This CL changes minImageCount back to 3.

Vulkan spec issue #1671 was filed in order to understand whether this
is a good/bad approach for other drivers/platforms.

Test: glmark2 on Pixel2.
Bug: angleproject: 3400
Change-Id: Ia4a72733eb648e4f53feeb8833b174d653fa5766
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610242
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: 962555, 962636
Change-Id: I4a22f83689252b7b7e51bbb3fc80e8f0d601a43f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610701Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>

This should let the Vulkan back-end only need to sync the Image data
once before we use them.

Bug: angleproject:3427
Change-Id: I8c6e8794e861f855bddbf651997351e8415e3479
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1602912
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Removes the EGL 1.5 overrides now that they are upstreamed.

Bug: angleproject:3446
Change-Id: I4b17354518534ea821bba83a4b1e00f83f80ac37
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1605786Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Previously, a pass over the shader was made, converting shared and
packed interface blocks with block storage to std140.  This resulted in
link success between interface blocks with different storage as they
were all translated to std140.

With this change, this pass is removed.  The link step proceeds with the
block storage specifiers as seen by GLES, and only upon Vulkan GLSL
shader generation "shared" and "packed" are converted to std140.

Bug: angleproject:3199
Change-Id: I069415ab9c9b4e1034bc00f64cd2d9e2d73f5956
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1605262
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Bug: angleproject:3198
Change-Id: Icb63d036a756b849c44d36342c7ba2fc2db0f910
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1604069
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

These error strings are stored for recording later we can't depend on them
still being alive so make a copy.

BUG=962439

Change-Id: Ie9156c99b9ce79df4a11087bdcab92d980e959a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610078Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

It's no longer needed.

Bug: chromium:947060
Change-Id: I873f17a4876b9d0fac313740853054b6867afeb9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610077Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/c4f8f65792d4..4b0985f29277


Created with:
  gclient setdep -r ./third_party/spirv-headers/src@4b0985f29277

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=jonahr@google.com

Change-Id: Iae2bdf19c951a5eaa2f53872b85c14370a5de8ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1608833Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f6d9a1784313..2947e88f7938


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@2947e88f7938

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=jonahr@google.com

Change-Id: I748a71d6f3593926babffeb8fa51e28c52564d20
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1608835Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2dd4ab3a4acb..6e384fef6c0f


Created with:
  gclient setdep -r ./third_party/glslang/src@6e384fef6c0f

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=jonahr@google.com

Change-Id: I77af0c451be06bf5965aa44cbbb9040fac0d7742
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1608834Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

It will always return true if all 4 channels of color mask are set
to false.

This should only apply to WebGL. Will fix this in a later patch.

Bug: chromium:958374

Change-Id: I46befaf3ae1b63027dfbb309ac32724c616025d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1594629
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The charts tend to be static for many days in a row, which will now be
filtered to be more succinct.
Also fixes issue parsing when a message interrupts the formatted *RESULT
token.

Bug: angleproject:3435
Change-Id: I9ed213844de469c7a8240ee95aab82451888edf1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1606029Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

This makes the style use CamelCase instead of ALL_CAPS. It also cleans
up some of the naming. It also changes some uses of the messages in
some of the objects to hopefully be more consistent. See the comments
added to the enum SubjectMessage in Observer.h for more details.

Bug: angleproject:3427
Change-Id: I6dff4f6d335ecf1a27e48df65743b1490bd3025a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1600411
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Bug: angleproject:3198
Change-Id: Iac5d1389f4f466b7886246d8ca529e8f26a6a5bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1603629Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>