- 29 Apr, 2021 9 commits
-
-
Geoff Lang authored
Speculative fix for crashes during flush on Mac. Mirrors the flush_on_framebuffer_change workaround in Chrome from http://crbug.com/783979 Bug: chromium:1181068 Change-Id: Ic84b1bfc44babf27016b306393da308d504d7fd9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859984Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
-
Jonah Ryan-Davis authored
Vulkan validation failures are happening on ComputeShaderTest on Linux and Windows with AMD. Suppress for now while the issue is investigated Bug: angleproject:5912 Change-Id: If89f7c85bb311a68d6cab85e397112b4178e34d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2860044Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
John Plate authored
Bug: angleproject:5908 Change-Id: I451e232e545248ff9755cc3f2a4907b8af2fdc2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859742Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
-
Jamie Madill authored
These are necessary to work correctly with swarming. Bug: angleproject:5114 Change-Id: I634e408e523284a935b77f62b95c9bc85e9e997f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859982 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org>
-
Jamie Madill authored
The Mac mixins were updated. Ideally we could do this automatically on Chromium rolls. Bug: angleproject:5114 Change-Id: I412e227193e7a6503c04dee5df6bb2a4cf1cc1f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2857597Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Gert Wollny authored
The test uses Vertex Array Objects, and these are only supported from GLES 3.0 on, or by using the extension OES_vertex_array_object, so make it part of the StateChangeTestES3 set. With that we also enable the test. Bug: angleproject:5855 Change-Id: I0cfb5d23d19e3db8eefffd9d52b744d068666606 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850642 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Gert Wollny authored
When running the test script to capture and replay it is helpful to know the locations of the executables that are run to make it simpler to locate them for debugging. Bug: None Change-Id: Ia43bd9863e94058515d9023981863ad6c711285e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850640 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/112faf441539..484a3e15893c 2021-04-28 sugoi@google.com Silence warning for MacOS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ic9f3324373ebb26930fce0a70eab176aae09adbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859305 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/06f7f05a5f4a..5feb27ec9892 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/94367a1d14..32281a3e42 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f6a8e55d6e..5f51521620 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5f9242e282..a660a95e6f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a26b882fc4..09a1a83d2f * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/a27b4d3b82..c3565d6e1f * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d738a9c39a..db2bba848d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..70ce64f463 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b3c9edb4af..3a56ba9d9c * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/7b4981b650..24e310554f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/91e097a7c7..7247aa6f40 * tools/skia_goldctl/linux: E6CrCAKZ_DKxclAqgBcEt4adU3HaviUwN42S1t3rW5QC..tB-aCGPgfoZoJkUY-FwC5e0McBlS1VYtKsDpf5G42GUC * tools/skia_goldctl/mac: RTGs3s-N45d3AzDXnEKw3kbI0qf8xyS_JYMHo4iRCMIC..010YBDimThQHTBULjf4bYMXghL37h6xogw08_Ij5RrMC * tools/skia_goldctl/win: XXJR8g1yaihqXsw7WodVpgLtZsimS7Cc3yLJI9sJssgC..PtSSNrSR0okAf8Q4RMYxK1dSmKxaw9jqoyxdNvNzOqwC No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: Ic6f6d13e33d9d70ba856b8444a3107a1d00ebdfb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2858285 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 28 Apr, 2021 9 commits
-
-
Charlie Lao authored
When minimize-gpu-work is requested, the idea is to have GPU work reduced to minimum. Without shrink the offscreen window to 1x1, the driver load/store op may still have to load entire surface which could be costly. This CL reduces the offscreen surface size to 1x1 when --minimize-gpu-work is specified. Bug: b/184766477 Change-Id: Ic8d9d4c2fe8295a0a5808dcee35120fdd20e0f56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2840963 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
Includes some stats counter gathering and a few related refactors and cleanups. Also includes a new overlay widget. Bug: angleproject:5736 Change-Id: Ida8d2cd815c5b598c6a442dd9bbfdf51e9c05180 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785431 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jonah Ryan-Davis authored
It looks like this argument doesn't exist anymore. Removing it from the swarming call works fine. Bug: angleproject:5915 Change-Id: I510ef79ae5a540742c3f08c8daa0a14d59d2e60d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855040Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
-
Alexey Knyazev authored
ASTC HDR is a superset of ASTC LDR, so always use HDR enums on supported platforms because there is no such difference in OpenGL ES. Bug: angleproject:2634, angleproject:5672 Change-Id: I19a3212bcb949aa9cdeb682ab000aa03125f04a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848509Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Le Hoang Quyen <le.hoang.q@gmail.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
-
Jamie Madill authored
Bug: angleproject:5736 Change-Id: Ic6046c0b8c5ba9bc2f3bffda2c36eaceb24491ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855601Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Cody Northrop authored
The feature works on Pixel 3 and later, so only disable it on Pixel 2. Bug: angleproject:5143 Change-Id: I824fc9ea71cb612fd99e23b7f37a1a3c278d92aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855218Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Charlie Lao authored
glMapBufferRange call requires CPU and GPU synchronization. Different drivers implement this differently. Some may choose to keep multiple copies of data to reduce the synchronization overhead while others may choose to wait for GPU access to finish to save memory. While this behavior is important, it should be looked under the scope of overall game performance and we can write a standalone test for this. When --minimize-gpu-work is specified, we mainly care about CPU overhead of driver logic of state tracking. For this purpose, we should get this out of picture in order to expose the true picture of what we intended to see. This CL always adds GL_MAP_UNSYNCHRONIZED_BIT to the access bit to avoid driver to do synchronization or make COW. Bug: b/184766477 Change-Id: I36228a4ed9913e26aa9ad4e8446fb42ee0182c18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2847101Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
-
Tim Van Patten authored
This is a reland of 9b4fd545 This fixes the original CL by moving where setCaptureActive() is called to allow the first replay source file to be written. Original change's description: > Capture/Replay: Reset GL Fence Sync objects > > Asphalt 9 uses GL Fence Sync objects during rendering, which results in > Fence Sync objects being created during setup and deleted while > replaying frames. When the replay is restarted, the Fence Sync objects > that were created during setup and deleted during the replay need to be > recreated during the reset phase. > > Bug: angleproject:5883 > Bug: angleproject:4599 > Change-Id: I118f2b7208c4d512ab646b10f52b3a0936895089 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838237 > Commit-Queue: Tim Van Patten <timvp@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5883 Bug: angleproject:4599 Bug: angleproject:5900 Change-Id: I5e1d901d8875007691699b7b973f3fb7db027337 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850758Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/398f0c392ac5..06f7f05a5f4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6273d81b0c..94367a1d14 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f71816594a..5f9242e282 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/79b2765902..d738a9c39a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c5554ea0ab * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c91f5f62e2..b3c9edb4af * tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 * tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 * tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3e7b3b8ccc..91e097a7c7 * tools/skia_goldctl/linux: bNvl5eveNZJzFEWnXEt_ohXLbBA8BSt78S5aHS7rNYMC..E6CrCAKZ_DKxclAqgBcEt4adU3HaviUwN42S1t3rW5QC * tools/skia_goldctl/mac: jWn1_ogilSNdcmHMkXsZTdw5bQ-IDoQ3IifWt1TDv6sC..RTGs3s-N45d3AzDXnEKw3kbI0qf8xyS_JYMHo4iRCMIC * tools/skia_goldctl/win: dP2sgrA7eRtFoLWGRjvQQ4YXhGlwKqsCiqPqPQuY1OgC..XXJR8g1yaihqXsw7WodVpgLtZsimS7Cc3yLJI9sJssgC No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I315893b34682bf861573d2d3e6378004b29342af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2856314 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 27 Apr, 2021 13 commits
-
-
Jamie Madill authored
This reverts commit 281b12d2. Reason for revert: Broke bots. Original change's description: > infra: Add different builder group from ci/try. > > Uses the 'client.angle' and 'tryserver.angle' naming scheme that > both V8 and WebRTC use. Necessary for the scripts to work with > swarming tests. > > Bug: angleproject:5114 > Change-Id: I107cf0018e2173117e1d90e840b8e1419e69ef55 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854277 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5114 Change-Id: I2501f3ad89bc21d80ccdeabd52234a1fc5b39a49 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855594Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
Uses the 'client.angle' and 'tryserver.angle' naming scheme that both V8 and WebRTC use. Necessary for the scripts to work with swarming tests. Bug: angleproject:5114 Change-Id: I107cf0018e2173117e1d90e840b8e1419e69ef55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854277Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Alexis Hetu authored
Vulkan Validation Layers (VVL) automatically rejects and removes any unknown pNext pointer in an pNext chain submitted to the driver. For this purpose, a mechanism was introduced by VVL in order to allow ANGLE to allow some of our custom pNext entries to go through VVL without being removed. This had been used for only 1 of the 3 entries in the VK_EXT_provoking_vertex extension, causing it to be properly exposed, but impossible to use. This CL corrects this by adding the missing entries. Bug: angleproject:5902 Change-Id: If6478b3aa776513b92420736fa1216b014320b02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854815Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
-
Jamie Madill authored
Initially testing will only be on desktop. Bug: angleproject:5114 Change-Id: I384e4f81cee3a810fad42e73711862725e786ef2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854276Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Charlie Lao authored
When --minimize-gpu-work is specified while replaying app traces, the goal is to avoid any GPU work when possible and focus on driver cpu logic overhead. Data copy can be lengthy and each driver optimize it differently for some real world usage scenario. This should be looked along with normal app trace playback performance. When --minimize-gpu-work is specified, we want to leave this out of picture. Previously I have fixed TexImage2D by overwriting pixel pointer with null. But there is a hole here when PBO is used. This CL fix the case that when data is sourced from PBO, we ensure to skip data copy as well. This CL also noops TexSubImage call instead of doing 1x1 copy. Again depends on driver implementation, some may use CPU others use GPU which will have different overhead. We can easily write a test to cover these performance optimizations. By skipping the subImage call here we will have less noise to deal with for CPU overhead investigation. Bug: b/184766477 Change-Id: I84a5d26d2f25f8f0a6c5c9da72737906d6356a53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2847100 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
John Plate authored
Bug: angleproject:5904 Change-Id: If23c7f76013a17c3c67c13194566438035beb3d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2853582 Commit-Queue: John Plate <jplate@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
Jamie Madill authored
Instead of writing the bitset masks, iterate up until the last active buffer. Write zeros instead of skipping spaces. This is a bit simpler to implement and also fixes a bug where empty buffers could cause us to write invalid handles. Bug: angleproject:5736 Change-Id: I785ef18ef5ae45109ec7d6e0b079b79a9984a1f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2837848 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
John Plate authored
Bug: angleproject:5775 Change-Id: Ic3b15efdf602bad8f5f170f03ba24b421a398ca8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848504Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/68b78a05fea2..42d8716d0294 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/bbcef69a45..c624d5387c * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f3c1d9e78e..d0f1abe22e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d15a2436f6..f6b4a3dea4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com,ynovikov@google.com Change-Id: I9e9915f535df93ef0428d63d301225982c29b55c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854414 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
-
Peng Huang authored
Bug: chromium:1202928 Change-Id: I54c4c28c30714fea60b4b6f3dd3ec49101341602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851362Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
-
Jamie Madill authored
The generate_test_spec_json.py file now reads ANGLE's waterfalls.pyl and Chromium's mixins.pyl to find the referenced mixins and copy them into ANGLE's mixins.pyl. This way we can update ANGLE's mixins easily without needing to manually copy them from Chromium's. In a follow-up we could make this run on the Chromium auto-roller. Bug: angleproject:5114 Change-Id: I332b3182732985b261e107dfe9a5c7c413c410a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849184Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Mohan Maiya authored
It is valid to call eglWaitClient, eglWaitGL and eglWaitNative when there is no active context in the current thread. Update code to account for that possibility. Bug: angleproject:5898 Test: EGLSyncTest.WaitClient* EGLSyncTest.WaitGL* EGLSyncTest.WaitNative* Change-Id: I81f05a27f1f641cf8986e2e6c05c183ea8471889 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849587Reviewed-by:Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/cf8ffbca555e..398f0c392ac5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/eae219f9f1..6273d81b0c * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/2f2a4e507a..f6a8e55d6e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cbf481cd42..f71816594a * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e0c163da44..79b2765902 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..00b0b51faf * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61bf6e8d69..c91f5f62e2 * third_party/r8: h1H8tuKYpnoPW2uwLMSaHgD_vVy9_8E6n4UZ5nwbMRkC..9JovxpDv8ZqFl60_eHo4hT-Ez0CelcMCoM9Cv5UJMz4C * tools/luci-go: git_revision:7ad561e001cdb13c858e065ef0bb3019aae49601..git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f * tools/luci-go: git_revision:7ad561e001cdb13c858e065ef0bb3019aae49601..git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f * tools/luci-go: git_revision:7ad561e001cdb13c858e065ef0bb3019aae49601..git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/65be412188..3e7b3b8ccc * tools/skia_goldctl/linux: wdKjv3Lrszkb_s1AF7ZwLf9Og7Y8qk_EIZ6aoNICu0YC..bNvl5eveNZJzFEWnXEt_ohXLbBA8BSt78S5aHS7rNYMC * tools/skia_goldctl/mac: oMHIiIQ0wBDzq1EgmQYV6nFbvCXgLdD0Qyxv_zFy1OsC..jWn1_ogilSNdcmHMkXsZTdw5bQ-IDoQ3IifWt1TDv6sC * tools/skia_goldctl/win: NA-h9VX5yFfBNYZKxKG479VVjEz3iJQ9jhSXBG0Lk1gC..dP2sgrA7eRtFoLWGRjvQQ4YXhGlwKqsCiqPqPQuY1OgC No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: Id865d18480e8c8cc40176cd0f734c745c92a5a8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2853275 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 26 Apr, 2021 8 commits
-
-
Stephen White authored
Bug: angleproject:5734 Change-Id: Ia1af247b45ad51072296f8d197dd4b49526417ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851177Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
-
Josip Sokcevic authored
Bug: 1203009 Change-Id: I3c7745531cca659901be05f7c7c3c89ba8350096 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851902Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
RenderPass2 was used for when a depth/stencil attachment is needed, or the VK_EXT_multisampled_render_to_single_sampled extension. The logic that decided this was "has D/S resolve || has MSRTSS extension", but the function itself asserted that the render pass is using MSRTSS if not D/S resolve. This caused an assertion failure on platforms where MSRTSS is present, but a non-MSRTSS render pass is used. Bug: chromium:1201455 Change-Id: Iefd26a071303c703a322d946f82474f85f5bf767 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849180Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Jamie Madill authored
Includes test specs for Linux/Mac/Win7/Win10. Android is left out for a second pass to keep the changes a bit simpler. Bug: angleproject:5114 Change-Id: I94e7f7f273073f85488ec982e89b4b68f45627ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2805371 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org>
-
Mohan Maiya authored
Addition of the entry points for GL_EXT_primitive_bounding_box extension. Bug: angleproject:5896 Change-Id: I0dce407d2826ce3f730125d7c03f1233420f6780 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849615Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
-
Mohan Maiya authored
On some vendors VVL throws the following error, snippet only - [ VUID-VkImageViewCreateInfo-pNext-01585 ] Validation Error ... image was created with a VkImageFormatListCreateInfo in pNext of vkImageCreateInfo, but none of the formats match the VkImageViewCreateInfo::format ... The Vulkan spec states: If a VkImageFormatListCreateInfo structure was included in the pNext chain of the VkImageCreateInfo structure used when creating image and VkImageFormatListCreateInfo::viewFormatCount is not zero then format must be one of the formats in VkImageFormatListCreateInfo::pViewFormats. It looks like VkImageFormatListCreateInfoKHR::pViewFormats needs to contain all formats including the format of the VkImage itself. Bug: angleproject:5281 Change-Id: I93c6900d99791ef4f9f116cb114f068e0a318bf4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849566Reviewed-by:Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
-
Jamie Madill authored
This reverts commit 9b4fd545. Reason for revert: Breaks capture: INFO:root:Passed: 0, Comparison Failed: 0, Crashed: 0, CompileFailed 0, Skipped: 745, Timeout: 0 Bug: angleproject:5900 Original change's description: > Capture/Replay: Reset GL Fence Sync objects > > Asphalt 9 uses GL Fence Sync objects during rendering, which results in > Fence Sync objects being created during setup and deleted while > replaying frames. When the replay is restarted, the Fence Sync objects > that were created during setup and deleted during the replay need to be > recreated during the reset phase. > > Bug: angleproject:5883 > Bug: angleproject:4599 > Change-Id: I118f2b7208c4d512ab646b10f52b3a0936895089 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838237 > Commit-Queue: Tim Van Patten <timvp@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5883 Bug: angleproject:4599 Change-Id: I56c682e1d90dcdde7b18c941aad976825de3af42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851057Reviewed-by:
Jamie Madill <jmadill@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Cody Northrop authored
Test: angle_perftests --gtest_filter="*candy_crush_soda_saga*" Tbr: jmadill@google.com,timvp@google.com Bug: b/186362192 Change-Id: I9a1f9663541e3b97d437a1803e8fe079a5dbd2b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846187Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
- 24 Apr, 2021 1 commit
-
-
Cody Northrop authored
Test: angle_perftests --gtest_filter="*higgs_domino_island*" Tbr: jmadill@google.com,timvp@google.com Bug: b/186267543 Change-Id: Ic7154337724b075bcad1367a24ae7ebeaf65ce6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848133Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-