Commits · cf80f252436039fcd89fee55f3e743d7fa89dcd2 · Chen Yisong / angle

12 Mar, 2020 5 commits

Remove android:forceQueryable from the ANGLE.apk manifest · cf80f252

authored Mar 12, 2020

This property is not part of AOSP yet.

BUG=b:142320172

Change-Id: I73b0481872096053c6b4b709d15376d82a1a7b02
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2099421
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

cf80f252

Roll third_party/vulkan-validation-layers/src 2ff8b6a6f4d5..be663d752e45 (8 commits) · 40c7a20f

authored Mar 12, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2ff8b6a6f4d5..be663d752e45

git log 2ff8b6a6f4d5..be663d752e45 --date=short --first-parent --format='%ad %ae %s'
2020-03-11 mark@lunarg.com stateless: Removed suboptimal swapchain performance warning
2020-03-11 mark@lunarg.com practices: Add perf warning for suboptimal swapchains
2020-03-11 mark@lunarg.com tests: Added verification for subpass index OOB checks
2020-03-11 mark@lunarg.com stateless: Added checks for OOB subpass indices
2020-03-11 mark@lunarg.com chassis: Remove SetAll function for enables
2020-03-11 attilio.provenzano@arm.com tests: Add BP tests for Arm-specific checks
2020-03-11 attilio.provenzano@arm.com practices: Add a set of Arm-specific checks
2020-03-11 attilio.provenzano@arm.com layers: Add support for vendor-specific checks

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@be663d752e45

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: Ie362875ba46134697d9a5a29bbfbaf4b66b2219a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2100145Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

40c7a20f

Roll third_party/glslang/src e2176c91b23c..9b620aa0c12d (2 commits) · f51dbc28

authored Mar 12, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e2176c91b23c..9b620aa0c12d


Created with:
  gclient setdep -r third_party/glslang/src@9b620aa0c12d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: Ic3355464a505cbc1e04da1dfbfd2bb2ce2afa761
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2100227Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f51dbc28

Roll third_party/vulkan-loader/src 136207a63495..29adf277cb19 (1 commits) · afa2f827

authored Mar 12, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/136207a63495..29adf277cb19

git log 136207a63495..29adf277cb19 --date=short --first-parent --format='%ad %ae %s'
2020-03-11 shannon@lunarg.com build: Update known-good for 1.2.134 header

Created with:
  gclient setdep -r third_party/vulkan-loader/src@29adf277cb19

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I6af6fae3a96abe2629510ebe5d4fcc57b26133d7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2100144Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

afa2f827

Speculative fix: getProgramiv always returns a valid program · 84780f7d

authored Mar 11, 2020

The only possibility with program being nullptr here in the case of GL_LINK_STATUS seems to be if the context gets lost between the validation and usage of `Context::getProgramiv`.

Bug: chromium:991020
Change-Id: I50a77ca4a841dea7324344a71e46d4e0bf72858d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096176Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>

84780f7d

11 Mar, 2020 10 commits

Update SimpleStateChangeTest.DrawRepeatUnalignedVboChange suppression · 2e5bd9b1

authored Mar 11, 2020

Also flaky on Linux (already suppressed on Windows).

Bug: angleproject:4470
Change-Id: I032241a4201dc7883d6107c643cf88c92fb01ba3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2099402
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

2e5bd9b1

Fix SearchProvider · 27f310da

authored Mar 11, 2020

The SearchProvider was attempting to launch ANGLE's MainActivity class
with the wrong fully qualified class name when Google's version
(com.google.android.angle) was installed on the device:

com.google.android.angle/.MainActivity

Instead, the AndroidManifest.xml and SearchProvider need to use the
fully qualified class name for com.android.angle.MainActivity since the
package name will differ between the AOSP (com.android.angle) and Google
(com.google.android.angle) versions.

Bug: b:142320172
Change-Id: Iab6883736be2a21dff64993bcaedbcc4c0cfecf8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2099443Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

27f310da

Refactor ANGLE target to allow GoogleANGLE to override it. · 14aaa1eb

authored Mar 11, 2020

GoogleANGLE will be signed in a different part of Android so it needs to
be able to reference ANGLE's target and defaults to override certain
properties.

Update the manifests to request the needed permissions to use the
developer options.

Bug: b:142320172
Change-Id: Ia47815ab53f8de66332412efa2cc0fca3175e2cc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096815Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

14aaa1eb

Use ANGLE's vulkan-headers dep when rolling ANGLE into Android. · 9e5bbb38

authored Mar 06, 2020

We previously used the existing Android target for vulkan headers but it
does not roll as fast as ANGLE's, possibly causing divergence in test
results.

BUG=angleproject:2344
BUG=b:150892231

Change-Id: Ibef33b266943c040219529f64ea8cd29c8c9bf83
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090394Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

9e5bbb38

Add -rpath entries for non-component builds on Mac · 90a8af38

authored Mar 05, 2020

Mac was unable to find libvulkan.dylib because non-component builds do not
contain these rpath entries.

Bug: angleproject:4455
Change-Id: I7a3c452bd3b32c34b33c75b1456f9efa0d77a4ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090331Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

90a8af38

Relax GL_DEPTH_COMPONENT32_OES format support rules · d6448538

authored Mar 09, 2020

On iOS, GL_OES_depth_texture is supported, which includes the format
GL_DEPTH_COMPONENT32_OES. However, GL_OES_depth32 is not always exposed.
This is causing ANGLE to not expose GL_OES_depth_texture, and
GL_ANGLE_depth_texture.

Bug: angleproject:4451
Change-Id: If9cd782e851e040b1cf24a763dd93e063ebffbc7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095361Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

d6448538

Roll third_party/vulkan-validation-layers/src 014968c3b6b3..2ff8b6a6f4d5 (4 commits) · d0748eb0

authored Mar 11, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/014968c3b6b3..2ff8b6a6f4d5

git log 014968c3b6b3..2ff8b6a6f4d5 --date=short --first-parent --format='%ad %ae %s'
2020-03-10 s.fricke@samsung.com layers: Add VUID for 01759 01760 01761
2020-03-10 s.fricke@samsung.com tests: Add VkMemoryDedicatedAllocateInfo VUIDs
2020-03-10 s.fricke@samsung.com layers: Add VkMemoryDedicatedAllocateInfo VUIDs
2020-03-10 petr_kraus@email.cz tests: Update VkResult strings

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@2ff8b6a6f4d5

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I87f8a04e5531c572a35be00deb5a6f119d4ecbf3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2097915Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d0748eb0

Roll third_party/SwiftShader 8be72df60462..16ae92a4ee52 (1 commits) · 45c53980

authored Mar 11, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/8be72df60462..16ae92a4ee52

git log 8be72df60462..16ae92a4ee52 --date=short --first-parent --format='%ad %ae %s'
2020-03-10 amaiorano@google.com Subzero: fix Call on bool-returning functions

Created with:
  gclient setdep -r third_party/SwiftShader@16ae92a4ee52

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I816d440e9d5aa464efc39f6b4f240f99d1d2db1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2097916Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

45c53980

Roll third_party/glslang/src 343d4f6f1870..e2176c91b23c (2 commits) · 0a4b0da5

authored Mar 11, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/343d4f6f1870..e2176c91b23c


Created with:
  gclient setdep -r third_party/glslang/src@e2176c91b23c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I66fdbbd0052ca4893eab0d5e99c1da094fe0a12c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2097917Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0a4b0da5

Remove MultisampleCompatibilityTest suppression · 1b12f6e5

authored Mar 10, 2020

The failed DrawCoverageAndResolve can pass on 26.20.100.7323 now.

Bug: angleproject:3855
Change-Id: Ia6eb9fef2a57f0bdf52cb2e45c138457f5de88aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096230Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>

1b12f6e5

10 Mar, 2020 8 commits

Vulkan: Use VK_FORMAT_D24_UNORM_S8_UINT for 24 bit depth if available · c5b3cbdb

authored Mar 09, 2020

And if the format we picked has extra bits, try to clear it instead
of load the value. Don't store these extra bits as values as well.

Bug: angleproject:4459
Change-Id: If5d0e31aca1453deab970d0dbcf8886a5e6ed51c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095850
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>

c5b3cbdb

use go swarming client in trigger.py · 05710d54

authored Mar 11, 2020

python client is being deprecated.

Tested by
$ python third_party/angle/scripts/trigger.py --shards=2 -p chromium.tests out/Release base_unittests Ubuntu none

Fixed: chromium:1047115
Change-Id: Id653e2b29e8bf02ab86eaa4c5c767d081fa29dbd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095654
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

05710d54

Enable allowClearForRobustResourceInit for NVidia hardware · 9e263aa8

authored Mar 06, 2020

Intel and AMD drivers have trouble clearing textures without causing
corruption. NVidia, on the other hand, can handle.

Bug: angleproject:1074
Change-Id: Id9d293eba92f80e2af3a0d2e40cbeccb127763b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2092838Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>

9e263aa8

Roll third_party/glslang/src 6861ea4e10a1..343d4f6f1870 (3 commits) · 4f10b113

authored Mar 10, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6861ea4e10a1..343d4f6f1870


Created with:
  gclient setdep -r third_party/glslang/src@343d4f6f1870

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I625957e125e9bc45a44a0fd95a86efceaa134e25
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096202Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4f10b113

Roll third_party/vulkan-validation-layers/src 97484d689869..014968c3b6b3 (11 commits) · 03b6ca69

authored Mar 10, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/97484d689869..014968c3b6b3

git log 97484d689869..014968c3b6b3 --date=short --first-parent --format='%ad %ae %s'
2020-03-09 mark@lunarg.com tests: Rename debug report callback function
2020-03-09 mark@lunarg.com tests: Remove old InitFramework function
2020-03-09 mark@lunarg.com tests: Use newer InitFramework function
2020-03-09 mark@lunarg.com tests: Add structure to use platform-specific debug callbacks
2020-03-09 mark@lunarg.com tests: Skip checking debugutils ext in framework
2020-03-09 mark@lunarg.com tests: Add utils messenger callback function
2020-03-09 mark@lunarg.com tests: Renable tests needing layer-only extensions
2020-03-09 mark@lunarg.com tests: Fix VUID typo in CreatePipelineAttribBindingConflict
2020-03-09 mark@lunarg.com layers: Add utils message type helper
2020-03-09 mark@lunarg.com tests: Use correct VUID for deprecated device exts
2020-03-09 jeremy@lunarg.com tests: Test array dynamic indexing features

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@014968c3b6b3

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I9e8339088ba26c9ecd382b3a44185c463e014c58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096200Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

03b6ca69

Roll third_party/SwiftShader b44162fdbb25..8be72df60462 (1 commits) · e18f749d

authored Mar 10, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/b44162fdbb25..8be72df60462

git log b44162fdbb25..8be72df60462 --date=short --first-parent --format='%ad %ae %s'
2020-03-09 swiftshader.regress@gmail.com Regres: Update test lists @ b44162fd

Created with:
  gclient setdep -r third_party/SwiftShader@8be72df60462

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I00ff324d0ca1307fb7de60259dbc10fc5a3b2186
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096201Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e18f749d

Roll third_party/spirv-tools/src 4c027048d88b..dd3d91691f1e (3 commits) · 25ccd786

authored Mar 10, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4c027048d88b..dd3d91691f1e


Created with:
  gclient setdep -r third_party/spirv-tools/src@dd3d91691f1e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I2b789076094a718893e88de8b773e43ccb06470b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096203Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

25ccd786

Speculative fix for nullptr program in QueryProgramiv · abcc536b

authored Mar 09, 2020

It is reported that an increase crash rate is seen on M81.
This is a speculative fix based on that most crashes have calls from
GrGLProgramBuilder::checkLinkStatus.

Bug: chromium:991020
Change-Id: I549de9e0a0cccde8b9c68d706828963fe3f9bdf2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095596Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>

abcc536b

09 Mar, 2020 11 commits

Revert "Vulkan: Fix store ops with linear command recording." · 5d7ccc30

authored Mar 09, 2020

This reverts commit a61e273a.

Reason for revert: Causes rendering artifacts in "Aztec Ruins".

Bug: angleproject:4444

Original change's description:
> Vulkan: Fix store ops with linear command recording.
> 
> DiscardFramebuffer was being ignored in the new linear path. Fix this
> by using the correct APIs. Also cleans up some of the access to the
> "RenderPassCommandBuffer" struct in ContextVk. Add a new accessor that
> returns the RenderPass without a flush that ensures it is only called
> when a RenderPass is already started.
> 
> Bug: angleproject:4029
> Change-Id: Ibd199f3a371c0f91b448a0b34c8752dc8b76c284
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057329
> Reviewed-by: Charlie Lao <cclao@google.com>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=tobine@google.com,jmadill@chromium.org,cclao@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:4029
Change-Id: I7d925b88c438a20ebe4a48634568addda7a64d60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2093157Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

5d7ccc30

Enabled GL_KHR_no_error · a8c947c7

authored Feb 06, 2020

Enabled GL_KHR_no_error added end2end tests for it
Note that GL_KHR_no_error can only be enabled by setting the EGL
attribute currently. Context flags are not currently supported.

Bug: angleproject:1280
Test: angle_end2end_tests --gtest_filter=ContextNoErrorTest.*
Change-Id: Ib5c73b8e284e3e4e5f800750ad6fcbef77be4285
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068899Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

a8c947c7

use go isolate client in trigger.py · 0837bf75

authored Mar 09, 2020

python client is being deprecated.
I will switch swarming client later.

Tested by
~/chromium/src$ python third_party/angle/scripts/trigger.py -p chromium.tests out/Release base_unittests Ubuntu none

Bug: chromium:1047115
Change-Id: Ibad2bf5ab80b09aadfcd0431fea8c5e97d38655d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095035Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

0837bf75

Allow referencing buganizer issues with ANGLE CLs. · c2d81731

authored Mar 09, 2020

Based on
http://google3/experimental/users/jsharkey/gitwatcher2/configs.py?l=42&rcl=299145346,
chromium CLs with b: should be found by buganizer.

BUG=b:151095080

Change-Id: Iaf4def18dbe52fe87c9e4655f114fac225d429ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095595
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

c2d81731

Generate arch-specific defines in Android.bp · 71903912

authored Mar 06, 2020

ANGLE has a ANGLE_IS_32/64_BIT_CPU define that is based on the gn arg
for "target_cpu". Don't emit this define as is from the gn desc, move
it to an architecture-specific section of the generated blueprint.

BUG=angleproject:2344

Change-Id: Ib6387d5f31b30900b5d3195da6d9b21c48e1e2a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090393Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

71903912

Improve GN args for generating Android rolls. · 8414d962

authored Mar 06, 2020

 - Disable unused backends and shader compilation targets.
 - Build for "arm64" to make sure ANGLE_64_BIT_CPU is defined.
 - Use a better merge command now that the branch histories are related

BUG=angleproject:2344

Change-Id: I33949e701379caacf6a392a3bb0eb3523627be14
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090685Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

8414d962

docs: Document how to use ANGLE on Android · 1cd52d2c

authored Feb 18, 2020

This CL creates a new page that is dedicated to building and using
ANGLE for Android.

With Android 10 released, now anyone can try out ANGLE as their GLES
driver for debuggable apps. It can also be loaded for any app if the
user has root access.

Also migrated existing Android build instructions with updates from
the team.

Bug: angleproject:4347
Change-Id: Iead6a456780aba033a1227605f197a456ad30eb3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063569Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

1cd52d2c

Roll third_party/spirv-tools/src 66a682b6a8f9..4c027048d88b (3 commits) · f77f10f3

authored Mar 09, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/66a682b6a8f9..4c027048d88b


Created with:
  gclient setdep -r third_party/spirv-tools/src@4c027048d88b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I8a6734e9e1cd5f2f531f4bedc1ea7e5401685105
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2094684Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f77f10f3

Roll third_party/vulkan-headers/src 9bd3f561bcee..74556a131735 (1 commits) · c535c7d2

authored Mar 09, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/9bd3f561bcee..74556a131735

git log 9bd3f561bcee..74556a131735 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 oddhack@sonic.net Update for Vulkan-Docs 1.2.134

Created with:
  gclient setdep -r third_party/vulkan-headers/src@74556a131735

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=ianelliott@google.com

Bug: None
Change-Id: I5ad970eb2807053d6e6eded91cdc4ecf045a750f
Tbr: ianelliott@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2094803Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c535c7d2

Roll third_party/glslang/src aa95c80e1a89..6861ea4e10a1 (1 commits) · 0945fd85

authored Mar 09, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/aa95c80e1a89..6861ea4e10a1


Created with:
  gclient setdep -r third_party/glslang/src@6861ea4e10a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I9eb2c38a1e62e07425f48201f62f96aefec914d7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2094688Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0945fd85

Roll third_party/SwiftShader 51b2800bb317..b44162fdbb25 (2 commits) · 717fa7a9

authored Mar 09, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/51b2800bb317..b44162fdbb25

git log 51b2800bb317..b44162fdbb25 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 madesroches@google.com Support for the largePoints feature in Vulkan
2020-03-06 capn@google.com Explicitly compile with warnings-as-errors

Created with:
  gclient setdep -r third_party/SwiftShader@b44162fdbb25

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I1642eeaf1cbf2e9e86db0180ae09db1fb58a3081
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2094683Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

717fa7a9

07 Mar, 2020 1 commit

Skip invalid end2end test for ES2 · 0c9b6abd

authored Feb 06, 2020

Previously, the incomplete framebuffer depth stencil attachment
test would run on ES2 if GL_OES_packed_depth_stencil were present.
This is insufficient since it uses the GL_DEPTH_STENCIL_ATTACHMENT
enum, which is not introduced in any extension prior to ES3. The
test has been disabled on ES2, regardless of extensions.

Bug: angleproject:4454
Test: angle_end2end_tests --gtest_filter=StateChangeTest.FramebufferIncompleteDepthStencilAttachment/*
Change-Id: Ic5a6a521e35b49c5d723b33f588fa608264d6390
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090783
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

0c9b6abd

06 Mar, 2020 5 commits

Revert "Instantiate rx::DisplayEGL when device type EGL is selected" · 03ed5f6c

authored Mar 06, 2020

This reverts commit 7455b544.

Reason for revert: This appears to break the "Linux FYI Ozone (Intel)" bots on the chromium.gpu.fyi waterfall.  Ozone means ChromeOS.

Original change's description:
> Instantiate rx::DisplayEGL when device type EGL is selected
> 
> Define EGL_PLATFORM_ANGLE_DEVICE_TYPE_EGL_ANGLE that should be
> used to request a driver egl-backed implementation with ANGLE.
> 
> Bug: angleproject:4328
> Change-Id: I6871d3a27e2bfc02af9815dcf86ae1cb6524f0cc
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2030038
> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>

TBR=geofflang@chromium.org,syoussefi@chromium.org,jonahr@google.com,julien.isorce@chromium.org

Change-Id: I8aec6c2783b0acb67d3315d351cdc9e526f58d6b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4328
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2091864Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

03ed5f6c

Reland "Vulkan:Include precision qualifier in GLSL" · 1a5c7a16

authored Feb 25, 2020

Currently still ignoring precision qualifiers for Vulkan shaders by
default, but have added feature "enablePrecisionQualifiers" that can be
enabled in order to include precision qualifiers.

With this initial implementation, it's possible to get precision
qualifier mis-matches in the generated GLSL 4.50. According to the
spec this is allowed. From GLSLangSpec 4.50 section 4.7 "Precision and
Precision Qualifiers":

For the purposes of determining if an output from one shader stage
matches an input of the next stage, the precision qualifier need not
match.

However, when converted to SPIR-V and run through the shader validation
any mismatches will cause shader validation errors. Initially just
ignoring those errors with this commit.

Bug: angleproject:3078
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057749Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>
Change-Id: Ieecca604bb2c834c9b1c2bcab85279d1f8755dfa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2086280

1a5c7a16

Instantiate rx::DisplayEGL when device type EGL is selected · 7455b544

authored Mar 03, 2020

Define EGL_PLATFORM_ANGLE_DEVICE_TYPE_EGL_ANGLE that should be
used to request a driver egl-backed implementation with ANGLE.

Bug: angleproject:4328
Change-Id: I6871d3a27e2bfc02af9815dcf86ae1cb6524f0cc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2030038
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

7455b544

Fix GN warning about unused variable when angle_enable_commit_id=false · 20c69733

authored Mar 06, 2020

BUG=angleproject:2344

Change-Id: I3a0c8384d280755557fd425e80877addd756a9ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2091625Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

20c69733

Generate new compiler errors for array-of-arrays · 3797fc85

authored Mar 05, 2020

The GLES GLSL 3.1 spec states that it is an error to use array-of-arrays
in the following cases:

- Vertex shader outputs
- Fragment shader inputs
- Fragment shader outputs

ANGLE currently generates errors in the case of vertex shader inputs.
It needs to add the above cases.

Reproduce by running "angle_deqp_khr_gles31_tests" with:

  --gtest_filter=dEQP.KHR_GLES31/core_arrays_of_arrays_InteractionInterfaceArrays2* --use-angle=swiftshader

Bug: angleproject:4148
Change-Id: I1147fc7d4755e5b6c07d2ab5d14566d919dec530
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2087647Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

3797fc85