Commits · cfd2a5d2235fbb1ab66328892a4664950bb3d6d0 · Chen Yisong / angle

03 Aug, 2020 1 commit

Roll SwiftShader from aa5bd7657e6c to 4568d8587998 (1 revision) · cfd2a5d2

authored Aug 03, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/aa5bd7657e6c..4568d8587998

2020-08-02 swiftshader.regress@gmail.com Regres: Update test lists @ aa5bd765

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I07f9526785ff4147e5915989cc9359fb2c27925e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2334423Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

cfd2a5d2

01 Aug, 2020 1 commit

Autogenerated changes for GL_EXT_multisampled_render_to_texture2 · 41442cce

authored Jul 31, 2020

Bug: angleproject:4836
Change-Id: I86143c6b21ecdbc666ce316b6e4a4b402257f01c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2332957
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

41442cce

31 Jul, 2020 11 commits

Vulkan: Add RenderPass count test. · d04a5593

authored Jul 31, 2020

Bug: angleproject:4911
Change-Id: I4c4e187b6b048118ce1231ae8924340ad382c43f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2331741Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d04a5593

Vulkan: Avoid clearWithClearAttachment if RP command buffer is empty · dae77893

authored Jul 30, 2020

If renderpass has started but no command has been issued, we should
chose to use loadOp to do clear instead of clearWithClearAttachment.

Bug: b/162521656
Change-Id: Ia681fc96442c7916b4b92c48e970d9ed239a28c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2330225
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

dae77893

Fix validation of glFramebufferTexture2DMultisampleEXT · 9b1cab0d

authored Jul 31, 2020

In preparation for GL_EXT_multisampled_render_to_texture2. This makes
the validation reuse what's there for glFramebufferTexture2D in addition
to what GL_EXT_multisampled_render_to_texture requires.

Additionally, it uses packed enums for texture target and id.

Bug: angleproject:4836
Change-Id: Ie778c84e1ff5a0cb6615257f2aff9e04395dd5aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2332956Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

9b1cab0d

Vulkan: Make CommandBufferHelper::empty() logic less obtuse · 38e7f7a6

authored Jul 30, 2020

CommandBufferHelper::empty() logic is simplified and commented to make
it easier to read. Basically empty() means there is no work in the
CommandBufferHelper object. For RenderpassCommands, that is equivalent
to !started().

Bug: b/162521656
Change-Id: Ic9683b392835a677501cb81e5e8a025e031ebf93
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2330379Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

38e7f7a6

Add renderbuffer serialization capability · aca14d47

authored Jul 29, 2020

Serializes renderbuffers' states stored on CPU.
Gets renderbuffers content from GPU then serialize them.

Adds renderbuffers serialization to serializeContext method so that
capture replay regresssion testing now compares the states of
renderbuffers too.

Bug: angleproject:4817
Change-Id: I537b11ee85decb14eea461ebbd62ce6ab0402f85
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2327173
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

aca14d47

Trace Tests: Fix Win/x86 crash. · bd7cef28

authored Jul 31, 2020

A missing KHRONOS_APIENTRY annotation was causing a crash due to
stack corruption in Win/x86 only.

Bug: angleproject:4845
Bug: chromium:1111764
Change-Id: I60b30ce8bc409c71d223eaedd74dc0c1ae034f7a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2331739
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

bd7cef28

Roll SwiftShader from 08a3cc4cfbaa to aa5bd7657e6c (3 revisions) · be774187

authored Jul 31, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/08a3cc4cfbaa..aa5bd7657e6c

2020-07-30 swiftshader.regress@gmail.com Regres: Update test lists @ 08a3cc4c
2020-07-30 capn@google.com Use more inclusive terms
2020-07-30 srisser@google.com Enable occlusionQueryPrecise

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: Ib8dc6730f43faaacc1de89e2181734ff4ef290be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2331733Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

be774187

Roll Vulkan-ValidationLayers from 4400cab64b22 to 71573c7f64cb (8 revisions) · e8af8a18

authored Jul 31, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4400cab64b22..71573c7f64cb

2020-07-30 32918197+jorgep31415@users.noreply.github.com tests: Add renderpass compat tests for FDM and Multiview use
2020-07-30 32918197+jorgep31415@users.noreply.github.com layers: Add renderpass compat checks for FDM and Multiview use
2020-07-30 s.fricke@samsung.com tests: Add protected resource in commands
2020-07-30 s.fricke@samsung.com layers: Add protected resource in commands
2020-07-30 s.fricke@samsung.com tests: Add query protected memory VUID
2020-07-30 s.fricke@samsung.com layers: Add query protected memory VUID
2020-07-30 KTHANGUDU@nvidia.com tests: Add VUID 02722 for VK_NV_coverage_reduction_mode
2020-07-30 KTHANGUDU@nvidia.com layers: Add VUID 02722 for VK_NV_coverage_reduction_mode

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I4bf26f53d52099ccb253ce4a128d44043f3c31b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2331734Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e8af8a18

Roll SPIRV-Tools from c6e6597c4f51 to 2aaa8653da4f (5 revisions) · 07ef703f

authored Jul 31, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c6e6597c4f51..2aaa8653da4f

Also rolling transitive DEPS:
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers from 979924c8bc83 to 5538bf4386f1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I442ae82d3dee6b782d8102c5d703a2a7b33f25e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2331732Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

07ef703f

Disable shader's pre-rotation code on Metal & non-Android. · cbd5bee8

authored Jul 13, 2020

Pre-rotation code were added to transform gl_Position, gl_FragCoords,
gl_PointCoords, dFdX, dFdY in shader. However, it is only useful for
android's surface pre-rotation and completely un-needed in Metal
back-end.

This CL disables these pre-rotation code if the platform is not
android.

Bug: angleproject:4678
Change-Id: I89c42fcf24b49896f4ed9c2f9465da521beaf25f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2295000
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

cbd5bee8

Allow GetSystemInfo to return false in CGL and EAGL backends. · 19a1943b

authored Jul 28, 2020

This API is documented as returning false if information is
incomplete, but this should not cause a failure to initialize ANGLE's
Display. This change is a refinement of one made in WebKit's
downstream copy of ANGLE, likely in support of forthcoming Macs with
Apple Silicon, in https://bugs.webkit.org/show_bug.cgi?id=213479 .

Bug: angleproject:4902
Change-Id: I40a664a5db67b2aa37f15617b1cbcc3119793ee0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2324462Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

19a1943b

30 Jul, 2020 13 commits

Add a custom trace tests loader. · f3a38d97

authored Jul 23, 2020

This custom loader will disambiguate the trace tests gl layer
from the util GL/EGL loader.

Bug: angleproject:4845
Change-Id: I5e8340eb50f736d931302f71f15f556fd9e52081
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315627
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Manh Nguyen <nguyenmh@google.com>

f3a38d97

Batch-compile and batch-run-replay multiple tests · 2c41931c

authored Jul 21, 2020

Multiple tests are batch-compiled into 1 replay application instead of
multiple replay applications. Replay application now runs generated
code of multiple tests instead of 1 test. This reduces overhead cost
and brings down runtime.

Main process now receives messages sent by workers via a message queue
and prints them to the main stdout so that user can know if workers are
hanging.

Add handle for user interrupt (Ctrl-C) so that processes are properly
destroyed and cleaned up.

Trace files now have the option not to be deleted.

Bug: angleproject:4817
Change-Id: Ic90ae0f430e1d3c261ffea5f963be5a4e94b0ad2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310909Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Manh Nguyen <nguyenmh@google.com>

2c41931c

Update inaccurate error string. · d7d79de3

authored Jul 30, 2020

Noticed when working on the traces.

Bug: angleproject:4845
Change-Id: I954851bc739e41ce84047eaf5e0dc4c8bcf57199
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2329832Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d7d79de3

Tests: Add NBA2K20 trace · aed3d65b

authored Jul 29, 2020

Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*"
Bug: b/160014453
Bug: angleproject:4048
Change-Id: I4899af05d48ad2900e6d5e44adc5f5e0bdba157e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2326911
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

aed3d65b

Capture/Replay: Limit string lengths in capture · 248d754a

authored Jul 29, 2020

MSVC can't handle string lengths longer than 16380 according to:
https://docs.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/compiler-error-c2026

Example build failure without this CL:
https://logs.chromium.org/logs/angle/buildbucket/cr-buildbucket.appspot.com/8873410048312858000/+/steps/compile_with_ninja/0/stdout

Test: Compile NBA2K20 MEC with MSVC
Bug: b/160014453
Bug: angleproject:4048
Change-Id: Ie14d40e8c3eea35d08d4be32455b327a311f1bcc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2327702
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

248d754a

Vulkan: ATrace marker fix-ups · a9504808

authored Jul 29, 2020

Fix a couple of mislabled atrace markers and add explicit markers
for inside/outside renderpass flushes.

Bug: b/156403378
Change-Id: I4045846e54ff54bc8fc3dd6ef47339f6f5eb8e87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2327828Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

a9504808

Vulkan: Implement GL_EXT_multisampled_render_to_texture · dcc56215

authored Jul 19, 2020

This change allows the use of resolve attachments in the Vulkan backend.
GL_EXT_multisampled_render_to_texture is implemented using this feature.
The infrastructure for specifying resolve attachments is designed with
eventual support for GL_EXT_multisampled_render_to_texture2 in mind as
well as optimizations to glBlitFramebuffer() and multisampled
backbuffers.

Proper support for glRenderbufferStorageMultisampledEXT is still missing
from this change.  All tests use this for the depth/stencil attachment
and don't read back the data.  Currently, the depth/stencil attachment
is created as a normal multisampled image.

Bug: angleproject:4836
Change-Id: I110a7f63312ae61a657b6094adf7d97c92bd5843
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304170
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

dcc56215

Support EGL_ANGLE_display_semaphore_share_group for DisplayNULL · d56ed7cf

authored Jul 30, 2020

Bug: angleproject:4877
Change-Id: I811ff57625a6bac749a50a1a53da48e62f5b8222
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2329285Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>

d56ed7cf

Vulkan: Remove unnecessary endRenderPass calls. · 19aac801

authored Jul 28, 2020

In both onImageRead and onImageWrite, there's a call to
endRenderPassAndGetCommandBuffer when necessary to record a command.
There was an extraneous call to endRenderPass in both functions for no
good reason.

Bug: angleproject:4882
Change-Id: I8f3b18dbb3cb9a8b92dedcc603eaf44b1e485986
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2323642Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

19aac801

Roll SwiftShader from dc8e77f0e521 to 08a3cc4cfbaa (3 revisions) · 8138cbbd

authored Jul 30, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/dc8e77f0e521..08a3cc4cfbaa

2020-07-29 amaiorano@google.com Add doc for testing with SWANGLE
2020-07-29 amaiorano@google.com Add doc on using ANGLE instead of SwiftShader GL
2020-07-29 swiftshader.regress@gmail.com Regres: Update test lists @ dc8e77f0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I2095ca8e1b7522978836385c37ba49d2ddcfe363
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2328507Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8138cbbd

Roll Vulkan-ValidationLayers from c0bf676837e4 to 4400cab64b22 (7 revisions) · 754562c7

authored Jul 30, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c0bf676837e4..4400cab64b22

2020-07-29 s.fricke@samsung.com tests: Add format check for YCbCr swizzle
2020-07-29 s.fricke@samsung.com tests: Add depth stencil format check
2020-07-29 jzulauf@lunarg.com syncval: Fix typo in usage doc
2020-07-29 locke@lunarg.com syncval: Use floor instead of ceil
2020-07-29 jzulauf@lunarg.com syncval: Correct write_barrier 0 and layout in log
2020-07-29 karen@lunarg.com docs: Reference Vulkan Configurator
2020-07-29 mark@lunarg.com scripts: Remove unmaintained test results script

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: Ie914e610feac8d9cac5e9882b9b1a7fe3ff7e720
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2328508Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

754562c7

Roll SPIRV-Tools from f9b088fe0dbf to c6e6597c4f51 (5 revisions) · 8d09e376

authored Jul 30, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f9b088fe0dbf..c6e6597c4f51

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: Ib5dac3eb3539926325fe19d6a6d4ebe999fea39e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2328506Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8d09e376

Samples: Fix Capture/Replay sample · fd60950e

authored Jul 29, 2020

New header required to compile. It mirrors one used by
our perf tests, but this one will remain basic.

Test: Replay a new trace
Bug: angleproject:4845
Change-Id: If42bba6a91bf37ed063b5828b4cbc80373108b2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2327292Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

fd60950e

29 Jul, 2020 10 commits

Vulkan: Cache/re-use vkImageView's per max level · 1c1c6b4e

authored Jul 29, 2020

For applications that frequently switch a texture's max level, cache
and re-use "read view" vkImageViews per max-level.

Test: NBA 2K20
Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_texture_mipmap_*_max_level_* --use-angle=vulkan
Bug: b/161993151
Change-Id: I9a6a81d5234196040bc6c264ec627a073ba73293
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321370
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

1c1c6b4e

Add extension EGL_ANGLE_display_semaphore_share_group · 4cf2501c

authored Jul 27, 2020

For sharing semaphores globally.

Bug: angleproject:4877
Change-Id: I472e0902fd04ca8350d74e6c0ae6925ee930ccf9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319370
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

4cf2501c

Tests: Update gfxbench traces · 5f6f47f6

authored Jul 29, 2020

Use new capture calls to support offscreen mode.

Test: run_angle_perftests --gtest_filter="*Trace*"
Bug: angleproject:4845
Change-Id: I6d9ea79bd8339b7d5398e34b0407425e80ce1d32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2327699Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

5f6f47f6

Capture/Replay: Fix GetTexImage on Luminance · cc846039

authored Jul 27, 2020

GetTexImageANGLE and GetRenderbufferImageANGLE use ReadPixels to
pull texture data. Luminance is not a renderable format, so it is
not supported by ReadPixels. To support this, override Luminance
formats to their underlying internal format.

Test: angle_end2end_test --gtest_filter="*GetTexImage*"
Bug: b/160014453
Bug: angleproject:4058
Change-Id: Id19344c2e2c06386a871338833e35b7747cb966b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321740Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

cc846039

Capture/Replay: Fix missing header. · d019af80

authored Jul 29, 2020

This was missing from a prior commit.

Bug: angleproject:4845
Change-Id: Iff2b0f300270df4c2e26265c5af81af8ae7e5e54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2325032Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d019af80

Roll Vulkan-ValidationLayers from 171e04fac342 to c0bf676837e4 (3 revisions) · ab07b2be

authored Jul 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/171e04fac342..c0bf676837e4

2020-07-28 jzulauf@lunarg.com syncval: Update 'most recent' explanation
2020-07-28 sam.walls@arm.com tests: add tests for PerfDoc checks 18-20
2020-07-28 sam.walls@arm.com practices: add PerfDoc checks 18-20 with SPIRV analysis

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I6b6b1620925aab4c7cbf35e6b08ef2ba8d6f2420
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2325650Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ab07b2be

Roll glslang from 3ee5f2f1d331 to 7ab4564696a7 (1 revision) · ad3974af

authored Jul 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3ee5f2f1d331..7ab4564696a7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I653f0f3fed6ac56d9310c243c90ee54efb5b8a87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2325567Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ad3974af

Roll Vulkan-Tools from 3b36fdc64014 to a4505d37ffe7 (1 revision) · 020b32e4

authored Jul 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/3b36fdc64014..a4505d37ffe7

2020-07-28 charles@lunarg.com vulkaninfo: fix device ext list having bad items

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I9ca11a039f82712be3d3f8cd65623304bbe92f30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2325569Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

020b32e4

Roll SwiftShader from 12c9d4ac61f2 to dc8e77f0e521 (6 revisions) · affcfa8d

authored Jul 29, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/12c9d4ac61f2..dc8e77f0e521

2020-07-29 sugoi@google.com Work around dEQP-VK output_location test flakiness
2020-07-28 capn@google.com Expose VK_EXT_image_robustness support
2020-07-28 capn@google.com Perform texel replacement on out-of-bounds OpImageFetch accesses
2020-07-28 capn@google.com Perform out-of-bounds checks on texel pointers
2020-07-28 amaiorano@google.com Add CMake script to setup and build ANGLE
2020-07-28 amaiorano@google.com Add ANGLE as submodule

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I14b66c52d2e3bb6c240ffa2eca1b12c5a94a78cc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2325568Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

affcfa8d

Roll SPIRV-Tools from 150be20d4334 to f9b088fe0dbf (1 revision) · 592c94cd

authored Jul 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/150be20d4334..f9b088fe0dbf

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I68a63f4923340c7657055c56e08ae5843b944a11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2325566Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

592c94cd

28 Jul, 2020 4 commits

DEPS: Remove use_relative_hooks. · c20449a8

authored Jul 28, 2020

This flag is deprecated and folded into use_relative_paths.

Bug: chromium:1107325
Change-Id: I2bb185185d2d345d5acb5e51142cde0e2cfee3cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2324601
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

c20449a8

Capture/Replay: Break up SetupContext · e4ceee97

authored Jul 17, 2020

While getting NBA2K20 MEC to work, discovered that
SetupContext was so large, it was causing a stack
overflow. To fix, simply break up the function into
a series of helpers if the number of calls exceeds
a set limit.

Test: NBA2K20 MEC
Bug: b/160014453
Bug: angleproject:4048
Change-Id: I332d5dea5fc4e14700b68150cbe31a4c88cdae89
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321739Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

e4ceee97

Add mac_xcode_version gclient arg to DEPS · 84eb7d87

authored Jul 27, 2020

Chromium's //build/ requires the DEPS file to produce gclient_args.gni
that contains a mac_xcode_version variable

Bug: angleproject:4878
Change-Id: I24421173347e1b508913d49793a065ccd52a47e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321395
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

84eb7d87

Perf Tests: Use timestamp queries for GPU time. · bba8daea

authored Jul 27, 2020

Testing shows that using timestamp queries and deferring the
query get calls until after the frame produces little overhead.
Also this fixes a missing GPU time reset between iterations.

Bug: angleproject:4879
Change-Id: I2a566548add1536aab689cd969594a15f0628da3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321573Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

bba8daea