Commits · chrome_m36 · Chen Yisong / angle

18 Jun, 2014 1 commit

Restrict the size of shader arrays. · b071b0f0

authored Jun 18, 2014

This prevents overflow issues in the HLSL translator and some drivers. The
limit it hard-coded to 65536 to be larger than the Shader Model 5 register
limit (4096) to account for register allocation optimizations and future
hardware.

BUG=379799

Change-Id: I3cd0d8ad2084c3ca675821bfad1fab48f78c76c7
Reviewed-on: https://chromium-review.googlesource.com/204521Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Nicolas Capens <nicolascapens@chromium.org>

b071b0f0

03 Jun, 2014 1 commit

Only add the structure padding when compiling D3D11 shaders. · d3d87064

authored May 28, 2014

BUG=359225

Change-Id: Idc4e2c8631925324a5e7e2a591bd6aa75169817a
Reviewed-on: https://chromium-review.googlesource.com/201890Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/202355

d3d87064

15 May, 2014 4 commits

Attempt skipping D3D11 shader optimization if compilation fails. · 01b4c0a0

authored May 12, 2014

BUG=angle:648,chromium:371868

Change-Id: I1de854aad6e002bd1349f08eb8d6b597c535c90b
Reviewed-on: https://chromium-review.googlesource.com/199354Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

01b4c0a0

Attempt skipping validation if D3D11 shader compilation fails. · d73fe375

authored May 12, 2014

Some shaders fail to compile with validation error messages that make no sense.

BUG=angle:648,chromium:372016

Change-Id: Ief0e28efa6bc7eaa483c95f45c00ce4f9f20e541
Reviewed-on: https://chromium-review.googlesource.com/199353Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d73fe375

Refactor attempting shader compilation with different flags. · 286f54c5

authored May 12, 2014

BUG=angle:648

Change-Id: Ie340eaa708820cc13be6d1f5ba04555b6c1918ea
Reviewed-on: https://chromium-review.googlesource.com/199352Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

286f54c5

Fix D3D11 'units' polygon offset bias. · 0bd27742

authored May 12, 2014

D3D11 DepthBias is an integer corresponding directly to GL polygon offset units.

BUG=371604

Change-Id: I20a126bd9c6298efff95f3edbf1babc0dd495b18
Reviewed-on: https://chromium-review.googlesource.com/199351Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Nicolas Capens <nicolascapens@chromium.org>

0bd27742

09 May, 2014 2 commits

Add padding to HLSL structures to prevent the D3DCompiler from packing them. · 6f182c12

authored May 09, 2014

BUG=359225

Change-Id: I74e7ca2fe931cf9cfe67193d2e805d91713a7e0c
Reviewed-on: https://chromium-review.googlesource.com/199100Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Nicolas Capens <nicolascapens@chromium.org>

6f182c12

Fix D3D11 polygon offset. · 12a3c6bf

authored May 09, 2014

We were not taking the state of GL_POLYGON_OFFSET_FILL into account.

BUG=371604

Change-Id: I9b490ed043faeece86665acaef0b865bf1f7b60d
Reviewed-on: https://chromium-review.googlesource.com/199120Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Nicolas Capens <nicolascapens@chromium.org>

12a3c6bf

11 Apr, 2014 1 commit

Handle an unknown error when exiting fullscreen on Windows 8. · 74697cf2

authored Apr 11, 2014

BUG=361553

Change-Id: I6d3e843a8ae06f1bbd5313ed95e338cb0b74fef3
Reviewed-on: https://chromium-review.googlesource.com/194128Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: John Bauman <jbauman@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

74697cf2

10 Apr, 2014 1 commit

Use shader optimization level 3 selectively. · f3be8481

authored Apr 10, 2014

Revert to HLSL compiler optimization level 1 and work around a compiler bug with break in nested loops by using optimization level 3.

BUG=angle:603

Change-Id: Ib45815ef5bc3f72a3c51c7041c8a77ec573aa9e7
Reviewed-on: https://chromium-review.googlesource.com/194130Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

f3be8481

09 Apr, 2014 2 commits

Use a heap-memory traversal to free compiler resources. · d1234cd5

authored Mar 21, 2014

The stack-memory traversal is prone to stack overflow. See the
WebGL conformance test long-expressions-should-not-crash.

BUG=angle:584

Change-Id: I02d72bc2e4101b7141d609c50303403ea8298e60
Reviewed-on: https://chromium-review.googlesource.com/191034Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

d1234cd5

Fix stack overflow when parsing huge expressions. · d0c82d5e

authored Mar 21, 2014

The expression limit validation check needs to be in front
of other tree traversal to prevent stack overflows. Also,
call depths of sufficient size (80k+) could overflow the
depth check itself, necessitating an upper bound on initial
tree traversal.

This fixes crashes in the WebGL long-expressions bug test.

BUG=angle:584

Change-Id: Ib48294bf77a5923d230f237fbd63a36a5662e317
Reviewed-on: https://chromium-review.googlesource.com/190051Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

d0c82d5e

04 Apr, 2014 2 commits

Revert "Implement EXT_shader_texture_lod" · b16827b0

authored Apr 04, 2014

This reverts commit f561ca40.

Change-Id: Iecd3b9803930d89341ce6785daedf1a8925c3916
Reviewed-on: https://chromium-review.googlesource.com/193310Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

b16827b0

Implement EXT_shader_texture_lod · f561ca40

authored Mar 10, 2014

BUG=angle:551

Change-Id: Iecfa6e265939610fd8d8a54aef022f5d344d1be5
Reviewed-on: https://chromium-review.googlesource.com/185693Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

f561ca40

01 Apr, 2014 1 commit

Revert "Remove the second translator target, only using static." · 5fdb492e

authored Apr 01, 2014

This reverts commit e186c0e4.

Change-Id: If3b84b87f7d4cb9aaa0945ff88b8986a5d9d1d4d
Reviewed-on: https://chromium-review.googlesource.com/192501Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

5fdb492e

28 Mar, 2014 1 commit

Remove the second translator target, only using static. · e186c0e4

authored Mar 28, 2014

Because libGLESv2 needs a static translator to link against
internal types like Attribute and Varying, as well as using
some other internal methods, we can for now disable the
component build for the translator. In the future we can
support a proper component build with exports across library
boundaries.

BUG=angle:568

Change-Id: Ie3efc0a29342d02491e91952c3c2398568f83576
Reviewed-on: https://chromium-review.googlesource.com/191954Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

e186c0e4

25 Mar, 2014 1 commit

Fix RGB TextureStorage11 textures not being initialized. · 740a2f8d

authored Mar 25, 2014

BUG=angle:595

Change-Id: Ib93146a8f9e7234fb2b0684da8ae51ef97c29040
Reviewed-on: https://chromium-review.googlesource.com/191491Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

740a2f8d

24 Mar, 2014 1 commit

Fix incorrect function forward declaration. · 3e65b53b

authored Mar 24, 2014

Change-Id: I14104335e9d02b32a111935351f36facede46a7b
Reviewed-on: https://chromium-review.googlesource.com/191036Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

3e65b53b

17 Mar, 2014 1 commit

Cache bound vertex and index buffers by ID3D11Buffer instead of serial. · 28b47909

authored Mar 13, 2014

Since a DirectBuffer11 may return different buffers from getBuffer
depending on the required buffer type and if the internal buffers are
dirty or not, the current serial is not reliable.  Use the actual buffer
object so that there can be no missmatch.

BUG=350581

Change-Id: I23ead63c2f626fc94ccc216201fa8ddc5b652c1b
Reviewed-on: https://chromium-review.googlesource.com/189538Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

28b47909

11 Mar, 2014 1 commit

Regenerate public projects. · 57f247bd

authored Mar 11, 2014

Change-Id: I84578600524148c9e26d4f71f4e23ab3a95190a5
Reviewed-on: https://chromium-review.googlesource.com/189533Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Zhenyao Mo <zmo@chromium.org>

57f247bd

10 Mar, 2014 2 commits

Don't attempt to perform constant folding with an uninitialized constant variable. · 848de680

authored Mar 04, 2014

BUG=348205

Change-Id: I9be17832b1a35d2995725ab147977992c2732274
Reviewed-on: https://chromium-review.googlesource.com/188711Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

848de680

Remove SH_MAP_LONG_VARIABLE_NAMES · 51b4a07a

authored Mar 07, 2014

We use hashing to map all variables/strcuture field names, etc,
so we no longer need this option.

Checked with Firefox and WebKit, they no longer use this option
either. Time to remove it.

Change-Id: Ie3e79b91a05258b04af419a9c42b2fd1b00e67c4
Reviewed-on: https://chromium-review.googlesource.com/189236Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Zhenyao Mo <zmo@chromium.org>

51b4a07a

06 Mar, 2014 1 commit

Fix incorrect path usage in generate_projects. · 9d30ce3f

authored Mar 06, 2014

We should use the cross-platform os.path.join() to support
platforms other than Windows.

BUG=angle:577

Change-Id: I9d96fc1b13731a57ffcd97469632f0acedb8e5c7
Reviewed-on: https://chromium-review.googlesource.com/188879Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

9d30ce3f

03 Mar, 2014 1 commit

Regenerate public projects. · e49d286e

authored Mar 03, 2014

Change-Id: I99e7af09d3cf1f294372c3d802ec1f5cf678d117
Reviewed-on: https://chromium-review.googlesource.com/188208Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

e49d286e

28 Feb, 2014 1 commit

Improvement on loop unrolling with loops indexing sampler arrays · fa63e947

authored Feb 26, 2014

1) Before this workaround is hardwired on mac, now we move it behind a compil
2) Fix the issue where "break" inside the loop isn't handled while unrolled.

BUG=338474
TEST=webgl conformance test sampler-array-using-loop-index.html

Change-Id: I4996a42c2dea39a8a5af772c256f8e3cb383f59a
Reviewed-on: https://chromium-review.googlesource.com/188079Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Zhenyao Mo <zmo@chromium.org>

fa63e947

26 Feb, 2014 6 commits

Fix HLSL compiler error with else-rewriting in functions. · b75fee4e

authored Feb 26, 2014

In functions with return types where we would use if-else rewriting,
we would potentially generate a spurious HLSL error that warned of
branches with no return value in the function.

This was causing a maps regression where overlays would not draw
in Earth mode.

BUG=346463

Change-Id: Icd53023286dfa43b653fd6e261b1cdb952627706
Reviewed-on: https://chromium-review.googlesource.com/187847Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b75fee4e

Add a new TIntermRaw node type to translator. · 19f0ff5c

authored Feb 26, 2014

This raw node stores text strings that we directly copy to the
output. This allows for more tricky substitutions that don't fit
in to the HLSL/GLSL shared parsing model.

BUG=346463

Change-Id: I83661f7db82336f3817114eec96a98bc2d395b87
Reviewed-on: https://chromium-review.googlesource.com/187846Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

19f0ff5c

Prevent overflow in the variable packer by sanity checking each variable. · 7e7143d7

authored Feb 26, 2014

BUG=346489

Change-Id: I28f5751580729a4d4d77fa6fdee0b4a6628a05de
Reviewed-on: https://chromium-review.googlesource.com/188010Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

7e7143d7

Fix crash on multiple calls to ShInitialize(). · df007eac

authored Feb 26, 2014

The previous fix would allow the calling app to trigger
an ASSERT if it did not first call ShFinalize. Chrome
would do this in some cases, causing a test failure.

BUG=344043

Change-Id: I33fa0c4668dac8750ca949febc7f02cc7d3d95e7
Reviewed-on: https://chromium-review.googlesource.com/187845Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

df007eac

Fix not rewriting else-if blocks. · 6ebf5a36

authored Feb 26, 2014

We would miss expanding the else-if clauses in a chain
of selection statements.

BUG=346463

Change-Id: I8d16b9f25c97b8f6e7e73ad11bf7dae8e8c57ed7
Reviewed-on: https://chromium-review.googlesource.com/187844Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

6ebf5a36

Fix long error messages breaking InfoLog::append. · b716d145

authored Feb 25, 2014

Using two calls to vsnprintf allows us to correctly determine
maximum buffer size as well as fixing garbage characters from
a missing NULL terminator.

Bug report from roland@lagoa.com.

BUG=angle:561

Change-Id: I4eb156342d9106d40783a3cf57c0c1d1889390e2
Reviewed-on: https://chromium-review.googlesource.com/187843Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b716d145

25 Feb, 2014 1 commit

Update codereview.settings to point to gerrit. · 99125692

authored Feb 25, 2014

BUG=angle:570

Change-Id: I89dcb347d0b104219263024e419ff578f8a7aa7f
Reviewed-on: https://chromium-review.googlesource.com/187841Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

99125692

24 Feb, 2014 6 commits

Allow creating fixed-size window surfaces. · 93f01ca0

authored Jan 28, 2014

BUG=320021

Change-Id: I97cdd65ac17ee142700dbf0f363891500e967571
Reviewed-on: https://chromium-review.googlesource.com/184205Reviewed-by: John Bauman <jbauman@chromium.org>
Tested-by: John Bauman <jbauman@chromium.org>

93f01ca0

Use a stable ordering when enumerating files. · cc87b463

authored Feb 24, 2014

Output the enumerated files in sorted order when running enumerate_files.py
from gyp, to prevent unnecessary buildfile churn that makes comparing
revisions noisy.

Change-Id: Ia9f759954ea1ae66628f7b6ef3419c47fe65886e
Reviewed-on: https://chromium-review.googlesource.com/187533Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

cc87b463

Improve the enumerate_files.py script. · 0f8001b5

authored Feb 06, 2014

Cleaned up the agument parsing and added support for excluding files/folders.

BUG=angle:552

Change-Id: I0d59f83fe2e20b8bc23564ecfb1f98c08c70ca94
Reviewed-on: https://chromium-review.googlesource.com/187532Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0f8001b5

Move the enumerate_files script to the build directory. · 823c8cd5

authored Feb 06, 2014

BUG=angle:552

Change-Id: Ie45a38bb26edfe1bf6d12b5d4918110be13acc33
Reviewed-on: https://chromium-review.googlesource.com/187531Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

823c8cd5

Fix typo in Python commit id script. · 2747b9a5

authored Feb 24, 2014

BUG=angle:529

Change-Id: Ife174e3fb4cb32342f519691d1d5d5c015cf2727
Reviewed-on: https://chromium-review.googlesource.com/187541Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

2747b9a5

Re-initialize shader translator properly after one shutdown. · 1aa7f3c1

authored Feb 18, 2014

Because of a local static, we could get stuck and never re-initialize
the translator after calling ShFinalize.

BUG=344043

Change-Id: Ib4d18da886eac28f3e1bc959a7eadf5b34d9410f
Reviewed-on: https://chromium-review.googlesource.com/186975Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

1aa7f3c1

20 Feb, 2014 2 commits

Detect cross-process HWNDs and verify DXGI 1.2 exists in D3D11. · 836bd217

authored Feb 18, 2014

DXGI 1.2 is required to create a swap chain for a HWND owned by another
process.  This fix will allow us to fall back to creating a Renderer9 if
DXGI 1.2 is not available instead of failing to create the swap chain
later.

BUG=angle:562

Change-Id: Iad1b37967e38452cae201a6d6fa621ad66ce5f3c
Reviewed-on: https://chromium-review.googlesource.com/186977Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

836bd217

Fix git call syntax in commit_id.bat · aacedfcf

authored Feb 19, 2014

BUG=angle:566

Change-Id: I437bdec916dbfe12cb310a20d4f38c18072eacd0
Reviewed-on: https://chromium-review.googlesource.com/187210Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

aacedfcf