BUG=angleproject:891

Change-Id: Id61e61a2efff019e92316adbe34fc2378302aff5
Reviewed-on: https://chromium-review.googlesource.com/294600Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Temporarily suppress this test as it might be caused by a dEQP bug.

BUG=angleproject:1128

Change-Id: I9c6f1b95edca55f54f3292227ebc81d4ddc57f0a
Reviewed-on: https://chromium-review.googlesource.com/294580Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Removing dynamic indexing of vectors and matrices will require copying
the indexed nodes in case they are written. Any type of l-value node that
doesn't have side effects may need to be copied. Add a copying function
for all typed node classes so that this copying can be performed.

Private copy constructors are used to implement the deepCopy function in
order to make maintenance easier. With copy constructors, each subclass
only needs to take care of copying its own members, and not the base
class members, which reduces the possibility of errors. Copy constructors
are disabled for all node classes that don't support deep copying by
inheriting TIntermNode from angle::NonCopyable.

Assignment operator is disabled for all node classes through inheriting
angle::NonCopyable. This applies also to classes that now get the private
copy constructor.

Explicit copy constructor and assignment operator declarations are added
to some classes which show up in node member variables to make code
clearer.

BUG=angleproject:1116
TEST=angle_unittests

Change-Id: Ia757b69397837f8309f0e7511c0cd24ca2c7a721
Reviewed-on: https://chromium-review.googlesource.com/293931Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

This test is only used in the D3D code, so we can remove this Impl
method. If we need it in the future we can always support it more
generally from the translator, or handle it differently on each
Renderer.

BUG=angleproject:1123

Change-Id: Ic4a22ad6cec93726195e68200fc25cc2956be44c
Reviewed-on: https://chromium-review.googlesource.com/293822Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Finally we can isolate this method into the D3D-only code, and
remove the interface from ProgramImpl.

BUG=angleproject:1123

Change-Id: I253b15d44d4cf8bbb5dbeaa78bbcc431a5267bf7
Reviewed-on: https://chromium-review.googlesource.com/293765Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Seems to be causing failures on the Mac GPU FYI bots.
SurfaceTest.DestructionDeletesImpl seems to crash.

BUG=angleproject:891
BUG=522557

This reverts commit 264ab56f.

Change-Id: I80aeecb8e191de011d9afe6534d0285dcffa82a3
Reviewed-on: https://chromium-review.googlesource.com/294540Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

The active attributes are used to determine which of the vertex
attributes to enable. Matrices take up several attributes depending on
the number of column they have; this patch marks all the columns of
active matrix attributes as active.

TEST=dEQP-GLES2.functional.shaders.linkage.varying_type_mat*

BUG=angleproject:1127

Change-Id: I82f548f329f872c4e66aa0e4e71c6061a55b9987
Reviewed-on: https://chromium-review.googlesource.com/294261Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Re-landing earlier change with constant signedness fixed (was causing
build issues on Linux).

Line continuation in ESSL 3.00 needs to be processed before tokenization,
since tokens can span the line continuation. On the other hand, ANGLE's
tokenizer keeps track of line numbers, and whenever a line continuation
appears the line number still needs to be incremented by one, just like
on a regular newline.

That's why line continuation is now implemented as follows: when the
shader strings are concatenated in Input, they are also checked for line
continuation. Whenever line continuation is encountered, the string
is cut before that point. When the tokenizer asks for more input, the
string starting from the character after line continuation is passed
to it, and the line number is incremented from Input. This way the
tokenizer can parse tokens that span multiple lines - it never sees the
line continuation - but still keeps track of the line number correctly.

Relevant spec is in ESSL 3.00 section 3.2 "Source strings".

Support for line continuation also applies to ESSL 1.00. ESSL 3.00
spec section 1.5 says that line continuation support is mandated when
an ESSL 1.00 shader is used with the OpenGL ES 3.0 API, and is optional
when ESSL 1.00 is used with the OpenGL ES 2.0 API.

TEST=dEQP-GLES3.functional.shaders.preprocessor.line_continuation.*
     (all pass),
     angle_unittests
BUG=angleproject:1125

Change-Id: Ic086aacac53cd75bf93c0fda782416501d2f842b
Reviewed-on: https://chromium-review.googlesource.com/294200Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

Reland with a fix for SurfaceTest in angle_unittests and fixes for
signed-unsigned warnings

In CGL there is no notion of default Framebuffer and MakeCurrent only
makes a context current but not a drawable. Instead, everything is done
via render to texture. For that reason, different surfaces will have
different FBOs as default framebuffers, which causes that change.

BUG=angleproject:891

Change-Id: I0664896bc335b1a757226aaa212536b8f9d0f08f
Reviewed-on: https://chromium-review.googlesource.com/293752Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

The LinkedVarying structure is a D3D-specific type, and the GL
back-end doesn't need the extra info. Isolate this into the D3D
back-end so we can clean up the Impl inteface.

BUG=angleproject:1123

Change-Id: I76d77ac505876d865e3e02f47acbfd6665a9507e
Reviewed-on: https://chromium-review.googlesource.com/293764Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Compilation warning on Windows

This reverts commit 6cb2ae82.

Change-Id: I4ecadf5d8e909f986da186a7326cfa0922ae8710
Reviewed-on: https://chromium-review.googlesource.com/294241Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Reland with a fix for SurfaceTest in angle_unittests and fixes for
signed-unsigned warnings

In CGL there is no notion of default Framebuffer and MakeCurrent only
makes a context current but not a drawable. Instead, everything is done
via render to texture. For that reason, different surfaces will have
different FBOs as default framebuffers, which causes that change.

BUG=angleproject:891

Change-Id: Ie9a72de01a58e583a1bfa3f4a055debb860b912f
Reviewed-on: https://chromium-review.googlesource.com/293713Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

The D3D-specific code we can split into D3D-only methods, and the
GL-level shared code we can place in Program instead of making Impl
methods. This cleans up the Impl inteface significantly.

BUG=angleproject:1123

Change-Id: Ibcb7d07733eb939adf5bb4f5395a661875a60238
Reviewed-on: https://chromium-review.googlesource.com/293763Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

A device lost event would improperly skip returning an error, which
could lead us down a code path that would read/write to invalid
locations.

BUG=519642

Change-Id: Iba437b9b24cdf44320a944a85146f5f73be9f7a6
Reviewed-on: https://chromium-review.googlesource.com/293903Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

This method previously relied on output from the D3D back-end from
ProgramImpl::link. Split the D3D-specific code into its own method,
and do the linking validation before we call link.

BUG=angleproject:1123

Change-Id: I582671e21af605af9f4451b02fc96ad29c923048
Reviewed-on: https://chromium-review.googlesource.com/293762Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Caused failures in the WebglConformance.conformance_textures_misc_copy_tex_image_2d_formats test on the ATI FYI waterfall bot.
This reverts commit 61f51dc1.

Change-Id: Iddea03d53ae2a9b639e36931f01c1e889e550af4
Reviewed-on: https://chromium-review.googlesource.com/294262Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Change-Id: I691d80deff03b49463b08d093934b44b049a0606
Reviewed-on: https://chromium-review.googlesource.com/294163Reviewed-by: Nico Weber <thakis@chromium.org>
Tested-by: Nico Weber <thakis@chromium.org>

This makes it clear that this is not an attempted override of the
virtual base class's method rx::TextureImpl::setImage().

Do the same for TextureD3D::setCompressedImage().
No intended behavior change.

BUG=angleproject:1083

Change-Id: I874e4101e8138c7c5000f5966afed6a339523c02
Reviewed-on: https://chromium-review.googlesource.com/293865Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Nico Weber <thakis@chromium.org>

Change-Id: I90504b00e8f3af208511ec393ddfb0da267f56bc
Reviewed-on: https://chromium-review.googlesource.com/293341Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Austin Kinross <aukinros@microsoft.com>

BUG=angleproject:1122

Change-Id: Ia6a79ef1b4e94e15830981f0cee6269c9f0c71ca
Reviewed-on: https://chromium-review.googlesource.com/293401Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Call the TextureD3D_2D::redefine member which will not make unnecessary
modifications to the image and lets the member serve as a callback for
redefined images.

BUG=angleproject:970

Change-Id: I511310ebfd4d6133219bbef82c53747f9454aee0
Reviewed-on: https://chromium-review.googlesource.com/293904Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Warnings in 64-bit.

This reverts commit a0633a7e.

Change-Id: I5b3f31b261b947cd295e9f4a9abbbdbc00740183
Reviewed-on: https://chromium-review.googlesource.com/293841Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Call the TextureD3D_2D::redefine member which will not make unnecessary
modifications to the image and lets the member serve as a callback for
redefined images.

BUG=angleproject:970

Change-Id: I280c18b993ef4dfac2efe1b28bf28c34aa4b6bcc
Reviewed-on: https://chromium-review.googlesource.com/293222Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Use R and RG textures with swizzle states to emulate them.

Fixes the following tests when using the core profile:
 * conformance/extensions/oes-texture-float.html
 * conformance/extensions/oes-texture-half-float.html
 * conformance/textures/misc/tex-sub-image-2d.html
 * conformance/textures/misc/texture-formats-test.html
 * conformance/textures/misc/texture-npot.html
 * conformance/more/functions/copyTexImage2D.html
 * conformance/more/functions/copyTexSubImage2D.html

BUG=angleproject:1113

Change-Id: Iaf4b7b2b0000052b1747f46d90ad45d4cb1f6b50
Reviewed-on: https://chromium-review.googlesource.com/293530Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Re-land with a fix for an unitialized variable

Instead the refcount is done via callbacks. This allows Surface to
ignore this refcounting which will be useful in a follow-up CL.

BUG=angleproject:891

Change-Id: I1925ccaa4ce7b502b33088660d31c404b8313cb5
Reviewed-on: https://chromium-review.googlesource.com/293712Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Don't query this as an Impl method, since it exists on the GL level.
Also some related refactorings and cleanups.

BUG=angleproject:1123

Change-Id: I3610bc0db2bcaa96408506e06a65a2f4dab93150
Reviewed-on: https://chromium-review.googlesource.com/293761Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Similar to the Framebuffer and other classes, this gives the Impl
class a read-only view of the object's state.

BUG=angleproject:1123

Change-Id: I580eaebe2de236adf8131d6e3f54633cecce8c25
Reviewed-on: https://chromium-review.googlesource.com/293760Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Warning in the Linux/Mac builders:

In file included from ../../third_party/angle/src/tests/preprocessor_tests/input_test.cpp:7:
In file included from ../../third_party/angle/src/tests/preprocessor_tests/PreprocessorTest.h:7:
../../testing/gtest/include/gtest/gtest.h:1392:16: error: comparison of integers of different signs: 'const int' and 'const unsigned long' [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
../../testing/gtest/include/gtest/gtest.h:1422:12: note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned long>' requested here
    return CmpHelperEQ(expected_expression, actual_expression, expected,
           ^
../../third_party/angle/src/tests/preprocessor_tests/input_test.cpp:171:5: note: in instantiation of function template specialization 'testing::internal::EqHelper<false>::Compare<int, unsigned long>' requested here
    EXPECT_EQ(3, input.read(buf, maxSize, &lineNo));
    ^

BUG=angleproject:1125

This reverts commit c1157d19.

Change-Id: Ic6fa286d190b006cccc5154d86e21ecc03175763
Reviewed-on: https://chromium-review.googlesource.com/294080Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

Line continuation in ESSL 3.00 needs to be processed before tokenization,
since tokens can span the line continuation. On the other hand, ANGLE's
tokenizer keeps track of line numbers, and whenever a line continuation
appears the line number still needs to be incremented by one, just like
on a regular newline.

That's why line continuation is now implemented as follows: when the
shader strings are concatenated in Input, they are also checked for line
continuation. Whenever line continuation is encountered, the string
is cut before that point. When the tokenizer asks for more input, the
string starting from the character after line continuation is passed
to it, and the line number is incremented from Input. This way the
tokenizer can parse tokens that span multiple lines - it never sees the
line continuation - but still keeps track of the line number correctly.

Relevant spec is in ESSL 3.00 section 3.2 "Source strings".

Support for line continuation also applies to ESSL 1.00. ESSL 3.00
spec section 1.5 says that line continuation support is mandated when
an ESSL 1.00 shader is used with the OpenGL ES 3.0 API, and is optional
when ESSL 1.00 is used with the OpenGL ES 2.0 API.

TEST=dEQP-GLES3.functional.shaders.preprocessor.line_continuation.*
     (all pass),
     angle_unittests
BUG=angleproject:1125

Change-Id: I1c1de49602e7cd755d6072c3c0aa5524cd0313b4
Reviewed-on: https://chromium-review.googlesource.com/293721Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

getSwapBehavior was being called in Surface's constructor but masn't
expected, causing a warning. Add it as an expect call.

BUG=angleproject:1126

Change-Id: Idf4a7e0ff66ba5741d3773e09ade4a1335b355ae
Reviewed-on: https://chromium-review.googlesource.com/293902Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

Should be fixed with the Iterator change.

BUG=angleproject:1040

This reverts commit 5b21ed5f.

Change-Id: Ibb77775b6b2ce5a49cee7dd81efc62d8c3ba3c62
Reviewed-on: https://chromium-review.googlesource.com/293901Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

The by-reference method was giving strange problems when using a non-
LValue as argument to IterateBitSet.

BUG=angleproject:1040

Change-Id: Iec10f7256a5b19b239804e0beba4ae675f53f876
Reviewed-on: https://chromium-review.googlesource.com/293840Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Seems to cause an exception in Release, in end2end_tests.

BUG=angleproject:1040

This reverts commit 6d51c70c.

Change-Id: I6548bc68dce07d2d85e40afdb604157e689c1d6c
Reviewed-on: https://chromium-review.googlesource.com/293821Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1040
TEST=angle_end2end_tests,angle_perftests,WebGL

Change-Id: I91d9aea5eefb58ecaf5b1cc95926fddb2aa846ea
Reviewed-on: https://chromium-review.googlesource.com/289570Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1120

Change-Id: If4fba903511dcd57d21f8f8178e772cf3cae4187
Reviewed-on: https://chromium-review.googlesource.com/293750Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Changes since last patch:
- Disable tests on D3D11 Intel

Change-Id: Ie65f56b7ed107f8901ea3be7d96036d7c882d189
Reviewed-on: https://chromium-review.googlesource.com/285218Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Austin Kinross <aukinros@microsoft.com>

BUG=angleproject:1122

Change-Id: I8b7a33fb8e7d1200e655c73c7d1a5502cac955c6
Reviewed-on: https://chromium-review.googlesource.com/293335Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Cooper Partin <coopp@microsoft.com>
Commit-Queue: Cooper Partin <coopp@microsoft.com>

It's cleaner to mark internal functions by using the TName class,
similarly to TIntermSymbol.

TEST=angle_unittests
BUG=angleproject:1116

Change-Id: I12a03a3dea42b3fc571fa25a1b11d0161f24de72
Reviewed-on: https://chromium-review.googlesource.com/291621Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

The AST contains identifiers in a few different places: besides symbols,
there are also function names, which show up in function signatures
and function calls. Any of these can be coming either from the original
shader or from inside ANGLE. A class that encapsulates a string and its
internalness will be useful for implementing a unified way of handling
all names in shader translation. Start implementing this by splitting
the functionality out of TSymbol.

TEST=angle_unittests
BUG=angleproject:1116

Change-Id: I0a1b5936dcccd0d5fc1c0c13c712102fbfff2a79
Reviewed-on: https://chromium-review.googlesource.com/291280Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

BUG=487341
Change-Id: I792e0c9419566facb0bec0ad93f3646294e5a2a7
Reviewed-on: https://chromium-review.googlesource.com/293500Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>