- 30 Oct, 2020 9 commits
-
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/80c364fa8e53..1e88b939ff30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/899545e432..5cdd7aaa22 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e74c871704..98789ba90c * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d24a1910b9..dbf0550693 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..24bd418544 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f9b4a22424..12b3cd36d8 * tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596 * tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596 * tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1d51f2aa14..88a308c1a4 No update to Clang. Bug: angleproject:2930,angleproject:3020,angleproject:3111,angleproject:3481,angleproject:5213,angleproject:5227,angleproject:5259 Tbr: geofflang@google.com Change-Id: I41975759f796173e010b3f986815ff845f3b2da0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508985Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Shahbaz Youssefi authored
Bug: angleproject:4988 Change-Id: I59facc66aaa2af216d3a6c6ef1e4efa934a45cb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506779Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Jamie Madill authored
This changes from returning a vector to directly returning a pointer to the binary data for the serialized state. The second cleanup is to use a ContextID as a wrapped type which simplifies the output formatting code. Bug: angleproject:5247 Change-Id: Ieb8afdb9326a12968dd2d69c05e1ed811b93abff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506198Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Yuly Novikov authored
Bug: angleproject:5271 Change-Id: I644b28670ce0501407797f7ae7e749a66a63d84e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508975Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
-
Yuly Novikov authored
Bug: angleproject:5270 Change-Id: I11ec5f9eef3989ac99a618bf5ab707484710a254 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508972Reviewed-by:
-
Yuly Novikov authored
DepthStencilFormatsTest.DepthStencilReadback_Float/ES2_OpenGL DepthStencilFormatsTest.DepthStencilReadback_UInt/ES2_OpenGL Bug: angleproject:5269 Change-Id: I223c80d8c8ac47176d5a4ecdff34f6ce27286284 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508971Reviewed-by:
-
Yuly Novikov authored
Bug: angleproject:5267 Change-Id: I41a7c7c07701e0236a85becd93f2d23db2cdaa8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508538Reviewed-by:
-
Yuly Novikov authored
Crashes on Mac Mini 8.1 Bug: angleproject:5268 Change-Id: I18cab39a8b6a8703e798cd8fb14d498a3a611eec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508969Reviewed-by:
-
Dirk Pranke authored
In Python 3, you have to be careful to distinguish between bytes and strings when reading from subprocesses; the code to read the commit position was failing to do that in one place. Bug: chromium:1112471 Change-Id: Ifbfba6872f762d7e5d7e356772e93b4a7ee1dfeb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508746 Commit-Queue: Dirk Pranke <dpranke@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
- 29 Oct, 2020 15 commits
-
-
Tim Van Patten authored
Descriptor pools need to live as long as the descriptor sets that are allocated from them. Using Serials while building a command to judge a pool's lifetime is prone to errors, since a command's Serial value isn't known until the command is submitted, leading to deleting pools too early relative to when the descriptor set is actually used. This CL updates DescriptorPoolHelper to inherit from Resource, so the descriptor pools can be retain()'ed. This allows the Resource's counter to indicate that a pool is in use until the command's Serial is known and can be recorded to indicate when the command completes. This prevents descriptor pools from being destroyed before the command completes (while the descriptor sets are still in use), or even before the command has been submitted. Destroying a descriptor pool resets all of the descriptors that were allocated from it, which can trigger a variety of VVL errors depending on when it's erroneously performed. This CL also adds the necessary retain() calls for the descriptor pools. In particular, the pools need to be retained each time a cached descriptor set that was allocated from it is re-used. This is relatively simple with the current design, since we always clear the descriptor set caches whenever a new pool is allocated, so the descriptor pool binding is always accurate. Bug: angleproject:5030 Test: VulkanMultithreadingTest::MultiContextDrawSmallDescriptorPools() Change-Id: Iac9e7efef338f169a6bf8ac3b2140e03dd326641 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2504457Reviewed-by:
-
Yuly Novikov authored
Bug: angleproject:5265 Change-Id: I1d3f1802398472c0da2d00526bd7eb52f6596bea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508532Reviewed-by:
-
Jamie Madill authored
This will force "GN analyze" to pick up changes in the gold tests when all that GN sees is a new SHA1 file. In effect a SHA1 change means all the sources in a trace have changed. Bug: chromium:1143507 Change-Id: Idf44045ebd5d2bda9380b339e95d336b6804ce8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508530 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Mohan Maiya authored
Add support for shader builtins and enable the extension. Bug: angleproject:3578 Tests: dEQP-GLES31.functional.*image_atomic* Change-Id: Idd45b2ee62efe1474c6c5947c77da64ff2221bf6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2505540 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
-
Tim Van Patten authored
The definition _LIBCPP_ABI_UNSTABLE breaks std::string in Android AOSP builds, starting with GetHelperExecutableDir(), but others fail later if that's worked around. Instead, we'll disable that flag with a GN arg for AOSP rolls. Bug: angleproject:5263 Test: Build on AOSP and launch Cuttlefish Change-Id: Ia4b293a5ce0b09206f4ed87a5a442e544e2021c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508529Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
Prior changes had made it so we no longer were spacing out the output correctly. Bug: None Change-Id: Icf81b579271f2b4c8fa5a1d90d323dc062f23585 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507635Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/87b0951f8dba..a72e7b987746 2020-10-28 mark@lunarg.com tests: Add invalid stride test for GetQueryPoolResults 2020-10-28 mark@lunarg.com corechecks: Added 4519 vuid for GetQueryPoolResults stride 2020-10-28 krzysio.kurek@wp.pl stateless: Add a missing "not" to ValidateGreaterThan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I3c1003765bf75b46f22781458a81e13378ebe451 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507093Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/8308d6744d50..428654245ad3 2020-10-28 xantares09@hotmail.com Configure vulkan.pc when pkg-config is available If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ic3137a446d4e977d94168c2e9abb1fc23d49974b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507094Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/483a71c5130e..e69b9b7294af 2020-10-25 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master 2020-10-25 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master 2020-10-24 alexander.galazin@arm.com Notice of withdrawal of Vulkan CTS 1.1.6.x 2020-10-24 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/master 2020-10-23 mika.vainola@siru.fi ANGLE waiver for GLES XFB array element capture 2020-10-23 siglesias@igalia.com Fix depth/stencil resolve compatibility tests 2020-10-23 ari.suonpaa@siru.fi Fix validation errors in AHB tests 2020-10-23 zzyiwei@google.com Add create and destroy object tests for the VK_EXT_device_memory_report extension 2020-10-23 mikko.tiusanen@siru.fi Add tests for clamping of depth values 2020-10-23 joshua@froggi.es Implement custom border color tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com,angle-bots+autoroll-info@google.com Change-Id: I2cd46cab1b48ccd22233cf4ea938590bab4d0945 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507709Reviewed-by:
-
Jonah Ryan-Davis authored
This would include "angle:angle_common" which is not a directory. Bug: b/171848471 Change-Id: Ic4f03b174a4cd4b81470862b3ed79a58b415ad04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507630Reviewed-by:
-
Jamie Madill authored
A recent change in Chromium broke how we were parsing stdout for capturing system info on Android. Fix the break and also update some helper scripts to work better when run manually. Bug: angleproject:5261 Change-Id: Iecc00bbe540461ab50ea31b5245b8b38a7250956 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507633Reviewed-by:
-
Geoff Lang authored
This reverts commit e70f6aa6. Reason for revert: dEQP failures: dEQP.EGL/functional_get_frame_timestamps_rgb565_no_depth_no_stencil dEQP.EGL/functional_get_frame_timestamps_rgb565_no_depth_stencil dEQP.EGL/functional_hdr_metadata_cta861_3 dEQP.EGL/functional_hdr_metadata_smpte2086 dEQP.EGL/functional_mutable_render_buffer_basic dEQP.EGL/functional_swap_buffers_with_damage_resize_after_swap_buffer_age_clear dEQP.EGL/functional_swap_buffers_with_damage_resize_after_swap_buffer_age_clear_clear dEQP.EGL/functional_swap_buffers_with_damage_resize_after_swap_buffer_age_render dEQP.EGL/functional_swap_buffers_with_damage_resize_before_swap_buffer_age_clear dEQP.EGL/functional_swap_buffers_with_damage_resize_before_swap_buffer_age_clear_clear dEQP.EGL/functional_swap_buffers_with_damage_resize_before_swap_buffer_age_render Original change's description: > ANGLE_platform_angle_device_context_volatile_* extensions > > Change from Kimmo Kinnunen downstream: > https://bugs.webkit.org/show_bug.cgi?id=216106 > > Add two extensions for EAGL and CGL backends to declare the > underlying platform context being "volatile". It means that > the thread-global current context is being modified behind > ANGLE. If ANGLE context is marked volatile for a particular > API, it will sync the underlying context for every EGL > function that needs the context. Most intuitive use is > for the client to call eglMakeCurrent before calling any > gl function if the client knowns the platform state might > be dirty. > > Implement eglReleaseThread for EAGL and CGL backends. > Releasing thread will unset the platform current context. > > Fix a bug of omitting EGL_ANGLE_device_eagl from being > advertised. > > Bug: angleproject:5104 > Change-Id: I1ec98ad35bc0caada23556ae8697fdef20f65b1a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2486548 > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> TBR=geofflang@chromium.org,kbr@chromium.org,jdarpinian@chromium.org,jonahr@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:5104 Change-Id: Ib683625a55a582c39e5a4a0466038cfa6e782e6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507260Reviewed-by:
-
Shahbaz Youssefi authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/8e2b7d03ccfd..8308d6744d50 2020-10-28 shabbyx@gmail.com Generate libvulkan.so.1 on Linux instead of libvulkan.so 2020-10-27 shannon@lunarg.com build: Update known-good files for 1.2.158 header Bug: angleproject:5216 Change-Id: I74e10c44950f3be05cc12f22b44f1627af08ca81 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506196Reviewed-by:
-
Jamie Madill authored
This reverts commit 8442ea94. Reason for revert: GN messed up and missed the build. Gold wasn't run so this is likely breaking stuff. Original change's description: > Tests: Update COD:Mobile trace > > Updates to reflect changes in the application. > > Test: angle_perftests --gtest_filter="*cod_mobile*" > Bug: b/164426913 > Change-Id: I207102c10578abe8eb02fe5ce22aef10b6b1d6f9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506076 > Commit-Queue: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> TBR=cnorthrop@google.com,courtneygo@google.com,jmadill@chromium.org Change-Id: I70fec773b7ff3b20eb4ce9d7545f1dc54233e8ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/164426913 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506501Reviewed-by:
-
Ian Elliott authored
Bug: b/170249632 Change-Id: Ie71a2e9699c3da88dd7e285177bb0ce1520f5bbc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506420 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
-
- 28 Oct, 2020 16 commits
-
-
Ian Elliott authored
As seen on Android, when PUBG MOBILE rebuilds all of its shaders, it: - Disables validation - Tries to link two shaders that can't be linked - Calls glUseProgram() for the un-linked program - Never uses the program Because validation was disabled, the appropriate error isn't produced and ANGLE ASSERT's in the post-validation code. For application-compatibility, this case is recognized and avoided. Bug: b/168839960 Change-Id: I521785c741d57d6c228bb60c81abe638d95e8d2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2505547 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:
-
Cody Northrop authored
Updates to reflect changes in the application. Test: angle_perftests --gtest_filter="*cod_mobile*" Bug: b/164426913 Change-Id: I207102c10578abe8eb02fe5ce22aef10b6b1d6f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506076 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
-
Cody Northrop authored
Test: angle_perftests --gtest_filter="*pubg_mobile_lite*" Bug: b/165824228 Change-Id: Iaa95b560da7834ff982bc29a2db22f3582d05513 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2504827 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
-
Geoff Lang authored
Some Mac GL drivers fail to generate mipmaps if level zero is not set before the texture is first used, all mipmap data is black. To work around this, whenever a texture level is allocated, ensure that level zero is also allocated with at least a 1x1 image. Bug: angleproject:5223 Change-Id: If1a728e017dec600c77a54f7ae185b719aaaae84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497569Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
-
Cody Northrop authored
Test: Capture PUBG Mobile Lite Bug: b/159238311 Bug: b/165824228 Change-Id: Idb9c29a963585c2f56e2fd134d77ee72bd2c53cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2504826 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
-
Cody Northrop authored
Test: Capture PUBG Mobile Bug: b/159238311 Bug: b/165824228 Change-Id: I7bbc7a80ade4df6b191cbe62e9badac1066ab246 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2503474 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
-
Jamie Madill authored
This new script runs the ANGLE trace tests with capture enabled to generate updated replay cpp files. This allows us to update our traces files to a new file format in one step. Trace metadata (currently only the default FBO format) is preserved between re-traces. Currently only desktop-based retracing is supported. This means a couple traces that require specific extensions don't run on all platforms. Bug: angleproject:5134 Change-Id: I7c923d89e33c18285ab36a7cee91f2fb735758eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2488130 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
The test was initializing an extra element at the end of a vertex buffer and never initializing it. I fixed this for one test but the bug was actually replicated into several. This fixes the bug by inializing the last vertex to the zero vertex value. Bug: angleproject:3951 Bug: angleproject:4163 Bug: angleproject:4258 Bug: angleproject:4269 Bug: angleproject:5258 Change-Id: I226406475340d756bfb7624d163abeca7b807f20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2505551Reviewed-by:
-
Cody Northrop authored
Test: Capture PUBG Mobile Bug: b/159238311 Bug: b/165824228 Change-Id: I3d76e0ccd641616ba971f15ed6ea280c4905fe18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2503473 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/03f6ffd1dc46..87b0951f8dba 2020-10-27 s.fricke@samsung.com tests: Add VUID 02502 and 02503 2020-10-27 s.fricke@samsung.com layers: Label VUID 02502 and 02503 2020-10-27 nathbappai@gmail.com cmake: Check MSVC instead of WIN32 for MSVC compiler options 2020-10-27 s.fricke@samsung.com tests: Add drm format aspect planes 2020-10-27 s.fricke@samsung.com layers: Add drm format aspect planes 2020-10-26 tony@lunarg.com layers: Tune image layout loop 2020-10-25 shannon@lunarg.com build: Update known-good files for 1.2.158 header 2020-10-24 mikes@lunarg.com scripts: Rework PV array length handling 2020-10-24 mikes@lunarg.com scripts: Escape backslashes in C strings 2020-10-23 mark@lunarg.com tests: Create DisplayKHR objs with GetPDDisplayPlaneProps APIs 2020-10-23 mark@lunarg.com lifetimes: Created GetPDDisplayPlaneProperties display objs 2020-10-23 mark@lunarg.com threading: Created GetPDDisplayPlaneProperties display objs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I53fda47a4a5bc13bfa4ad982003402e85f1585b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2505121Reviewed-by:
-
Jamie Madill authored
No functional change. When we trigger a capture at frame X, the value of X is not important. Instead we'll record the frames as 1,2,3,etc. Helps keep the traces more consistent and re-trace the same way as they are captured. Bug: angleproject:5134 Change-Id: Icd8654d509423edcc74cd0ef694795a787f5cc05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2500602 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
This reverts commit 21add124. Reason for revert: Fails on Windows 7 x64 Chromium config. https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/73194 Original change's description: > Re-enable crash testing in angle_unittests. > > This is an experimental test to see if this works now. > Disabled on Win/ASAN because of conflicts with the > crash callback. > > Bug: angleproject:5239 > Change-Id: I280b18ab8846de79b561f26716df9ba374cfd9a5 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2496040 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=ynovikov@chromium.org,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:5239 Change-Id: I83c150c2c2090b7d1aeb78e53e96115a167a7491 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2505479 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Geoff Lang authored
VertexAttributeTest.DrawArraysWithAlignedAndUnalignedBufferOffset/ES2_D3D11 flakes on all Windows platforms. Supressing the failure while we investigate. Bug: angleproject:5258 Change-Id: I25dbdd4201d02fe32d37c4ca9527f86093f1c243 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2505480Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/e56348f0e1a6..80c364fa8e53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/929bcdbb5f..899545e432 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/eb50e105b7..e74c871704 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..15be7eb5cb * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/cf34aa637c..f9b4a22424 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d259f028e6..1d51f2aa14 * tools/skia_goldctl/linux: rALC7IKLCr-2-9WUqGWz2IrPRRzQggKc8OVxFYyzFSIC..TzGLaAGOIbgS9g3WS2NIL32_zXI1HeLIIIuDk25O4kwC * tools/skia_goldctl/mac: 8gYcmJrEd6YDf04LEGeNfEk7A2KHXEEMWeovQZ5gTE0C..Yf-uk3I5Yz6gjKV3mct2yoXT580dpRG4hwbIx8CpW5MC * tools/skia_goldctl/win: SzWAsWkD4L0lMv-gdLIdN18zHBh_mkAxsGDyzRNwwsgC..6OGcfUna6B3W4PwFB6GuIVRffBaiDQ1HHaOxlOn9FvgC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ia1c6a06d182aac252e895dea16072423ffae08b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2504205Reviewed-by:
-
Tim Van Patten authored
Add descriptor set allocation counters for the following: - ContextVk - Driver uniform allocations for graphics and compute pipelines. - ProgramExecutableVk - ANGLE driver uniforms - Uniforms - Textures - Other shader resources - UtilsVk - All of the UtilsVk::Function types increment the same counter Each object's counters live within the object itself and the cumulative total is output as part of that object's destruction. On Present, all of the descriptor set counts are collected into a single total which is used to update the overlay each frame. In order to see the cumulative total output for each object, the following GN args must be enabled: is_debug = true angle_enable_perf_counter_output = true To see the descriptor set allocation overlay: ANGLE_OVERLAY=VulkanDescriptorSetAllocations Bug: angleproject:5067 Test: Manual verification with angle_perftests Change-Id: Ie45fda56ade3e68bfba7bf6da9554eb05a02c6b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2429487 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Charlie Lao <cclao@google.com>
-
Jamie Madill authored
SwiftShader can allow for a platform-indendent replay. This is useful for re-tracing. By default disable the SwiftShader test configs unless we pass in --enable-all-trace-tests. Also disable the mock ICD trace tests by default. Bug: angleproject:5134 Change-Id: Ibf1f3ebd6c17f15123705b7d4d9ddd6308f873f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2502311 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
