Adds the ability to serialize GL context states.
Adds serialization of GL context states to serializeContext method so
that capture replay regression testing now compares the GL context
states.

Reformats frame_capture_utils to make most serialization methods
private, except for the ones called by other classes and template
methods.

Bug: angleproject:4817
Change-Id: I2d53c88be3d503268bd6e2e5058b5fabe0644f67
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314829
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

Adds considerable overhead to wall time on Adreno. Not tested on
other platforms.

Bug: angleproject:4879
Change-Id: Ib219f14162fb5768e484f717ed2a870478bd1c86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321404Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

As we have done for default uniforms and textures, we should cache
descriptorset for driver uniforms to avoid repeatedly create them.

Bug: b/161750230
Change-Id: I0afabb226d5a8e8c7838fa2484ec7f9689ed5fa0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309349Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>

Imagine the following scenario:

1. Clear draw framebuffer
2. Invalidate draw framebuffer
3. Update texture attached to draw framebuffer
4. Draw again into draw framebuffer

Step 3 could be a number of things, such as glCopyTex[Sub]Image,
glBlitFramebuffer, glTex[Sub]Image2D, glGenerateMipmap etc.

In the above scenario, at step 2, the framebuffer's render target
remembers it being invalidated (mContentDefined = false).  This is used
to set the loadOp of the next render pass to DONT_CARE.

However, mContentDefined was implemented for a very specific
optimization regarding the swapchain's depth buffer.  The reuse of this
variable for glInvalidateFramebuffer was erroneous as this variable
didn't track whether the contents are defined for the general case.

With this change, mContentDefined is set to true during
FramebufferVk::syncState for each render target whose contents are
marked dirty.

This change additionally makes glBlitFramebuffer signal the contents of
the blit targets as dirty, as well as textures that are used as storage
images.

Bug: angleproject:4859
Change-Id: I68c829f75ff4a3d03bb293ec72c609384983026d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309110
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

Don't assume support for VK_KHR_get_memory_requirements2,
enable the extension, if supported, during device creation.

Bug: angleproject:4830
Change-Id: I0faf955aac8a2ae4dea636f349225672e6717662
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319079Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

Since these are per context, we can increase it (and subject to the
driver maxUniformBufferRange limit) to reduce the amount of descriptor
set allocated.

Bug: b/161391337
Change-Id: I89e5cf16ee377735c412e9a9a22c651e1c677ded
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310910
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

This will allow the Trace tests to load a custom GL after the GL
window has already loaded the default entry points.

Bug: angleproject:4845
Change-Id: Ic1b65b6cf1a582ea7c2f58a9f76077760e5cf0d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315626Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

When Vulkan Validation layers are enabled, also enable the
validation best practices layer which includes ARM's perfdoc
layer. Initially adding skips for all of the best practices
errors that are triggered so that these can be enabled by default.

Bug: b/156661359
Change-Id: I7eab9710bf9632d07ff6b80375d3ad1789d58f7c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2202634
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

Right now the dynamic buffer for default uniform is per program. Most of
time the buffer is unused. That is a huge waste of memory (and these
memory are wired memory). This CL moves the mDefaultUniformStorage from
per ProgramVk to ContextVk so that we all share with each other.

Bug: b/161391337
Change-Id: I1fe8523b2b2dbc39bec3509a3432e38e34bd5713
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2274870Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

Bug: angleproject:4874
Change-Id: I0a497719b00330407b5755d64153315115a95b48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2318047Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This is required to have use_x11 && use_ozone builds at the same time.

Bug: chromium:1085700
Change-Id: I3d4cdf590e1ecf79af9e2d4bd585955c3f1b7af6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315031Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Links to the Python script in CaptureAndReplay.md
Links to CaptureAndReplay.md's testing section in the Python script

Bug: angleproject:4817
Change-Id: I584f8508661950e4907dae1adb8f0fe300387198
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309226
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/6a8a74986c35..3b2cd31c7400

2020-07-26 capn@google.com Update Vulkan headers to version 1.2.148
2020-07-26 capn@google.com Refactor native instruction intrinsics
2020-07-24 amaiorano@google.com Delete third_party/llvm-7.0
2020-07-23 sugoi@google.com Add basic support for VK_EXT_debug_utils
2020-07-23 srisser@google.com Add support for depthBiasClamp
2020-07-23 spang@chromium.org Silence warnings on dedicated external memory allocations
2020-07-23 capn@google.com Regres: Roll dEQP to 1.2.3
2020-07-23 amaiorano@google.com Fix CMake failure on MacOS when PowerVR submodule is checked out
2020-07-23 capn@google.com Don't update CMake for Windows Kokoro builds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I51df404988b223be4c2e2a3d30891c86797e4b8f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319979Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/adf938680697..361fb5311b9b

2020-07-24 jzulauf@lunarg.com syncval: Update ordering/most recent hazard checks
2020-07-24 mikes@lunarg.com build: Handle glslang static lib dependency cycles
2020-07-23 christophe@lunarg.com doc: Highlight Vulkan Configurator
2020-07-23 christophe@lunarg.com doc: Fix links on LunarXchange
2020-07-23 jeremyk@lunarg.com tests: Add test for corner sampled with CtE
2020-07-23 jeremyk@lunarg.com layers: Add check for corner sampled with CtE
2020-07-23 jeremy@lunarg.com tests: Fix push-constant test
2020-07-23 s.fricke@samsung.com tests: Add export AHB positive tests
2020-07-23 s.fricke@samsung.com layers: Fix exported AHB checking allocationSize
2020-07-23 s.fricke@samsung.com tests: AHB test for bindBufferMemory
2020-07-23 s.fricke@samsung.com layers: Remove AHB bindBuffer VUs
2020-07-23 mark@lunarg.com chassis: Move layer option handling into separate files
2020-07-23 mark@lunarg.com chassis: Localize config and env settings handling

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ibb4a62f4c004feb6aaac60e9612c33d7c78205d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319980Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/83825d55c7d5..a0f1f5149d91

2020-07-23 git@haasn.xyz Fix enum order for backwards compatibility

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I25985607c096ddf8f17736410e7224a805f2b0e4
Bug: None
Tbr: timvp@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2319864Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

The value is capped to INT_MAX to avoid overflow when queried with
glGetIntegerv().

Bug: angleproject:4554
Bug: angleproject:4788
Change-Id: I36d52fc608ef5adc2bc0b73e379db66cbfd9bb54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2318046Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Instead of including "angle_trace_gl.h" in shared capture header
we can include it in each cpp file. This prevents a header conflict
with the "old" way of using the util GL loader.

Bug: angleproject:4845
Change-Id: Ia00a2beffc77446c779ceec8995fce9704e7b8af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315625Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

An initial implementation based on AMD's FFX SPD (Single Pass
Downsampler).

Apart from requiring STORAGE_IMAGE support for the image format, the
following limitations are in place due to FFX SPD:

- Image must be 2D or 2D array (including cube maps)
- Image must be single-sampled

The following _can_ be supported, but not yet implemented:

- sRGB formats
- Integer formats
- depth/stencil formats

Bug: angleproject:4551
Change-Id: Ibc4d5cea701cca31e55e3d651540872bbd3b473f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2278713Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

The KHR GLES31 tests disabled and marked with Issue 4146 are passing,
likely due to the work for Issue 3570: Vulkan: Implement separate
shader objects or program pipeline objects. This CL re-enables the
tests.

Bug: angleproject:4146
Bug: angleproject:3570
Test: KHR-GLES31.core.shader_storage_buffer_object.basic-syntaxSSO
Test: KHR-GLES31.core.vertex_attrib_binding.advanced-bindingUpdate
Test: KHR-GLES31.core.vertex_attrib_binding.advanced-largeStrideAndOffsetsNewAndLegacyAPI
Change-Id: I4e42129c873604c937cf03412a105170755413e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2318265Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

Android builds are failing due to .git/HEAD being listed in the
Android.bp, which generate_android_bp.py is supposed to remove. The
problem is that the blacklist contains '//third_party/angle/.git/HEAD'
rather than '//.git/HEAD', due to generating the GN files from
chromium/src/ rather than angle/. This CL cleans this up.

Bug: b/160727922
Test: Manual script execution and building in AOSP
Change-Id: Ia1682605097791d20b28686f3043ddc08d49ca52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310960Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d92ddcef72ef..adf938680697

2020-07-22 jeremy@lunarg.com layers: Improve push constant error logging
2020-07-22 jzulauf@lunarg.com syncval: Cleanup of extraneous tags, user doc revs
2020-07-22 jzulauf@lunarg.com syncval: Style cleanup design/add user doc
2020-07-22 jakub@okonski.org Revert "Simplify the guard around ValidateMaxTimelineSemaphoreValueDifference"
2020-07-22 jakub@okonski.org Add a test for binary semaphore value difference checks
2020-07-22 jakub@okonski.org Simplify the guard around ValidateMaxTimelineSemaphoreValueDifference
2020-07-22 jakub@okonski.org Fix timeline semaphore value difference validations on binary semaphores
2020-07-22 christophe@lunarg.com doc: Add links to per-feature docs
2020-07-22 tony@lunarg.com tests: Skip test if limits are very large

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ie3197c42fb6e55018ec373f6851424596ba03252
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315295Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/11fa4d0d5694..3ee5f2f1d331

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I659c87076350acbd56ccbfdcb0751bb152fa72d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315294Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/f272427bda39..6a8a74986c35

2020-07-22 amaiorano@google.com Fix ReactorDebugInfo off by one line issues
2020-07-22 amaiorano@google.com Fix GN debug builds of SwiftShader on LLVM 10
2020-07-22 tommek@google.com Fix copying between images and buffers with padding

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: angleproject:4861
Tbr: timvp@google.com
Change-Id: I4a7da511bda78aa04b627cb3ba3ac79bc74a0c48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315293Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

We should explicitly set EGL_SURFACE_TYPE to EGL_DONT_CARE.
Otherwise, it's default value is EGL_WINDOW_BIT. However,
on some platforms, only EGL_PBUFFER_BIT is supported.
In this case, no matching config is found. So mWindowSurface
and mPbufferSurface will be nullptr. That's why we see
the bot failed.

Bug: chromium:1105208
Change-Id: I8ee2487fd24bab86a5ec22fbe7b8ff68081bc15c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2304429
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Bug: chromium:1096442
Change-Id: I79722073bd1f2674b40e7eaa8d5311a09bc36416
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309636
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

Migrate from traces recorded on desktop to traces recorded
on a Pixel 4 XL. This impacts the resolution and framebuffer
config used for the tests. They now more accurately reflect
the numbers seen from running the benchmark directly.

Test: angle_perftests --gtest_filter=TracePerfTest.Run/*
Bug: angleproject:4048
Change-Id: Ib013dfb35c32c6f97bcae76a74cc16d9a5d1a369
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314896Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

Implemented parameter capture functions for:
    glGetActiveUniformsiv
    glGetActiveUniformBlockName
    glGetActiveUniformBlockiv

Added a check for bound unused locations when capturing glLinkProgram

Changed CaptureGetParameter to always request a gReadBuffer allocation
of the maximum reported possible array size needed to query
GL_COMPRESSED_TEXTURE_FORMATS. Recording the value on the capturing
device would previously have buffer overflow issues when the replaying
the capture on a device with more formats available.

Changed VertexAttribType::UnsignedInt2101010's string to reflect the
correct type

Bug: angleproject:4834
Change-Id: Icd1ff404369ae9f18cad7cd4f56fbcccc89e7e98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2306735Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

This moves the trace header inclusion to the cpp file so that the
test itself doesn't need to look at the individual trace headers.
This fixes an include directory dependency. Also removes the FBO
change callback from the generated traces.

Bug: angleproject:4845
Change-Id: I019f0d347a62a81b92bf32110572911111212689
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2314217Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This will let us override the util loader for all new traces. It will
also be easier to maintain going forward if we have to change the
header again.

The end goal is to run the trace tests with a custom GL layer that can
intercept certain API calls.

Bug: angleproject:4845
Change-Id: I028a1afdadf638998805d7b9a2cc6717cf5f0148
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2308029
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

Chrome still tends to use ES2 contexts for most rasterization. This is a
problem when trying to use FP16 IOSurfaces for rendering HDR because
GL_RGBA16F is not renderable in ES2. Since a surface is always
renderable, allow rendering to any textures with a bound surface.

Update the tests to verify that ES3 formats can be used with ES2
contexts.

Add tests for RGBA16F IOSurfaces.

BUG: chromium:1103112
Change-Id: I9e8c082fc97a0e072289b097e71fc944988d4872
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2307454Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

A few files inside the D3D11 tree are used by D3D9 and WGL backends. We
add these files to the build system even when D3D11 is disabled.

Also, we fix the use the of ANGLE_DEFAULT_D3D11 symbol.

Bug: angleproject:4839
Change-Id: I981f4bfc60d973c02549caa737c5aed5ccf31282
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2298143Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b99a6a727318..11fa4d0d5694

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ic08523541b7efe21d00e2b410ca014cc18f6f661
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311940Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/50e737c82347..3b36fdc64014

2020-07-20 shannon@lunarg.com build: Update known-good files for 1.2.148 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I34c9270fdfc6581e546f7861cd7294e0213d45ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311941Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/97f9923235cf..f272427bda39

2020-07-21 capn@google.com Eliminate dead host/target feature code for Subzero
2020-07-21 amaiorano@google.com Fix ENABLE_RR_DEBUG_INFO on LLVM 10
2020-07-21 amaiorano@google.com Remove support for LLVM < 10
2020-07-21 amaiorano@google.com Delete LLVM 7 Kokoro configs
2020-07-21 amaiorano@google.com Fix LLVM-10 CMake build
2020-07-21 swiftshader.regress@gmail.com Regres: Update test lists @ 97f99232
2020-07-21 capn@google.com Regres: Don't test changes with negative scores

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I7a23451d6fef9da2f33b5d62b078ce9b0072ac27
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311730Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7cc0ead05174..d92ddcef72ef

2020-07-21 jzulauf@lunarg.com syncval: Cleanup document from autogeneration
2020-07-21 mark@lunarg.com tests: Add test for non-device concurrent buffer qfamily
2020-07-21 mark@lunarg.com corechecks: Check CONCURRENT_MODE against ALL pdev qfamilies

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Id0295628171dae6f3198bbe1dcb5fa55496ad115
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2311731Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Imagine the following scenario:

1. Clear draw framebuffer
2. Invalidate draw framebuffer
3. Copy from read framebuffer into texture that is attached to draw
   framebuffer
4. Draw again into draw framebuffer

At step 2, FramebufferVk::syncState is called which extracts the clear
and stores it in mDeferredClears, but since the framebuffer description
hasn't changed, a new render pass is not started.

At step 3, the texture attached to the draw framebuffer is used as copy
destination, but its clear which is stored in the (apparently
irrelevant) draw framebuffer is not flushed.

At step 4, a new render pass is started which clears the draw
framebuffer, trampling the copy in step 3.

This change makes sure invalidate results in a flushDeferredClears().
With glInvalidateFramebuffer() (not glInvalidateSubFramebuffer()), the
deferred clears for invalidated framebuffers are discarded first.

It is unknown whether there are similar situations where syncState
gathers deferred clears, but they are not flushed before the attachments
are updated outside the framebuffer.  To catch similar bugs in the
future, assertions are added to FramebufferVk::syncState such that if a
dirty bit is set for the contents of an attachment, we can make sure
there are no prior deferred clears stored for that attachment.

Bug: angleproject:4862
Change-Id: Idb1a08b53e7f011f0fc9a54d478289030b6d77a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2308034Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Imagine the following situation:

1. Clear draw framebuffer
2. Noop operation on the framebuffer (Clear, ClearBuffer,
   BlitFramebuffer with flags specifying non-existing attachments)
3. Change framebuffer's attachment
4. Draw into framebuffer

At step 2, FramebufferVk::syncState was called before noop-ing the
operation.  During syncState, deferred clears were stored in the
framebuffer and weren't flushed because the actual operation was not
performed.

At step 4, the deferred clear meant for the prior attachment gets
applied to the new attachment.

Bug: angleproject:4865
Change-Id: I5b096bacf00356b4dccd4cbc9561b87b1bb557d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2309224Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Some apps have a pattern where they clear the depth & stencil buffers
in the middle of the frame which causes the Vulkan backend to stop the
existing render pass and start a new one. This causes more loads &
stores of buffer contents than if we inline that clear with a draw.

Bug: b/159808300
Bug: angleproject:4695
Change-Id: I7a15af22f47a81051fa33fa19eaa123d8b66597c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2289945
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

This variable tracks the index range of color attachments.  A previous
change (d8ce865b) made the range
inclusive so it can fit in 3 bits, but that's incorrect as it's no
longer possible to specify a range where no color attachments are
present.

This change partially reverts d8ce865b
to restore the previous semantics of
RenderPassDesc::mColorAttachmentRange.

Bug: chromium:1107884
Change-Id: I08da2568b5e63a48a672edd499a8b6653060eadb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2310578Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This will facilitate intercepting the GL calls and implementing
emulation paths for offscreen redering. Or other EGL/GL features.
It does not yet override the GLES loader and uses the shared
'angle_util' loader as it did before.

Bug: angleproject:4845
Change-Id: I68806c307f59e1852999299e88dc358781817f12
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2305042
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>