- 13 Feb, 2021 5 commits
-
-
Mohan Maiya authored
Add support for more unary and binary operators. In order to support setLaterBit and resetLaterBit in BitSetArray::Iterator there were 2 choices - 1. Make a copy of BitSetArray only if it is a mutating usecase 2. Always perform a copy in the constructor BitSetIteratorPerfTest was run with both patches - 1) Copy only when necessary - RESULT BitSetIteratorPerf.wall_time: run = 116.1067374961 ns 2) Copy always - RESULT BitSetIteratorPerf.wall_time: run = 242.7446459439 ns We settled on the copy only when necessary path. Bug: angleproject:3877 Change-Id: If1d3cc428c68c84857952b46237aa5f206f080cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690912 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Austin Sullivan authored
This problem was discovered by attempting to roll googletest past CL 315255779, which causes test binaries to fail when they include test suites / parametrized tests that are not instantiated, and when they include empty test suites. This CL uses the GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST() macro to annotate the suites / tests that are causing test failures. This is necessary to get googletest rolled past CL 315255779. Bug: chromium:1163396 Change-Id: I17c7cae1121079219f632cbbcf8cfc65a27bfdb7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2691459Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Brian Salomon authored
Bug: skia:11223 Change-Id: Ia634bf0bf7a157c759ae192501ff763a1baa8d2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2650986Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/764e5b48c0ab..59663a6eb4d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/fd66250b4d..3696926416 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/7e85fef7d9..228b1c1883 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/086ae0a486..d2a884ad6d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e4328db483 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/35e7868383..fea4246907 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/84eb9fba67..106e9dfc90 * tools/skia_goldctl/linux: FnrTtCqUzIkttLMcUafQ-E14XeYY8Yg79UKi-yF4k-gC..IY5qc7Fm3l7ofSvX0tx81d_UYTMJ1cVFlXp3beXxGacC * tools/skia_goldctl/mac: 33D5pMUWm9PcQ9nzgMNc-cv9Y67SNea1XX9S3h0q0zoC..sThAFNVmUGB1KLYyFvxlfBZgrQvQm8C1jpik4b8Eq6QC * tools/skia_goldctl/win: pjN_saVBekGyLe4KBiQ_-ZjYGUfDR6X9O33jfnvsZOwC..AshRD0sQsymS9bHa8cDgrecFq4NCi98zUJ9TNnD054AC No update to Clang. Bug: angleproject:4483 Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: I600b3b598c79f1b023bd31106625b530ff4d3d50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2694097Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Tim Van Patten authored
Update ValidateCopyImageSubDataBase() to take into consideration if the entire mip level is being written, even if the size of the mip level is smaller than the compressed block size. This also uncovered a bug in ImageHelper::initializeNonZeroMemory() where the image extents are not at least as large as the compressed format block size: VUID-vkCmdCopyBufferToImage-imageExtent-00207 This CL adds isAllocateNonZeroMemoryEnabled() to allow skipping the test when that feature is enabled while that bug is chased. Bug: angleproject:5592 Bug: angleproject:5634 Bug: angleproject:5643 Test: Texture2DTestES3.CopyCompressedImageMipMaps Change-Id: I0381e0d3490fb148604b61dc3bae8f96ba8b5f8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673069 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:Cody Northrop <cnorthrop@google.com> Reviewed-by:
-
- 12 Feb, 2021 6 commits
-
-
Tim Van Patten authored
The default uniform descriptor set is reset while recreating the pipeline layout during handling of immutable samplers and then is never re-allocated and bound before the next draw. The call stack to allocate the program uniforms descriptor set: ProgramExecutableVk::allocUniformAndXfbDescriptorSet ProgramVk::updateUniforms ContextVk::setupDraw ContextVk::drawArrays Context::drawArrays Unfortunately, this occurs before the pipeline layout is reset (and the descriptor sets are reset) due to the presence of an immutable sampler: ProgramExecutableVk::reset <<---- mDescriptorSets.fill(VK_NULL_HANDLE); ProgramExecutableVk::createPipelineLayout ContextVk::updateActiveTextures ContextVk::invalidateCurrentTextures ContextVk::syncState Context::syncDirtyBits Context::prepareForDraw Context::drawArrays This CL calls setAllDefaultUniformsDirty() for the Program/PPO to ensure the default uniforms descriptor sets are re-allocated and re-bound before the next draw command. Bug: b/178424566 Bug: angleproject:5624 Test: CtsCameraTestCases Change-Id: If54a9f2cc09809a5103bc3eac641c77f56362229 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2677385Reviewed-by: -
Peng Huang authored
Bug: chromium:1171371 Change-Id: I8c2e13f3f35bf1f780526ad1d9d483226ce5ea34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2688901 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
-
Yuly Novikov authored
In https://chromium-review.googlesource.com/c/angle/angle/+/2690142 https://github.com/KhronosGroup/VK-GL-CTS/commit/7630a653d152f5da673e3992c0a1597d605c955f Bug: angleproject:5648 Bug: angleproject:3466, angleproject:3317, angleproject:4235 Change-Id: Ic4ee1d8b69319e839dbed192ce74811d0281b60e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2692513Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
-
Alexey Knyazev authored
Enable ETC2/EAC formats on newer Intel GPUs. Bug: angleproject:1552 Change-Id: I240b07d6d81d48e1e03dfcd56aad6fa9f1d7817f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690952Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/d671c89249af..764e5b48c0ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5088ad39f5..fd66250b4d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c9a2320aee..086ae0a486 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b4dd2a2f6c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f33f4c53ae..35e7868383 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3294cf7fc4..84eb9fba67 * tools/skia_goldctl/win: xC87Xnbi3y7b2aSw2voaEk8MtTPrvU1peyj7NfC6ZtIC..pjN_saVBekGyLe4KBiQ_-ZjYGUfDR6X9O33jfnvsZOwC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I72988210207ef16e3f17fe4c982028fd1dda591c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2691274Reviewed-by:
-
Shahbaz Youssefi authored
Allows setting/resetting multiple bits to be coalesced into one operation. Bug: angleproject:5528 Change-Id: Ibf2dff8c81441a75c268d95066d23da1b2a3c810 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2678885 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
-
- 11 Feb, 2021 16 commits
-
-
Jamie Madill authored
StateChangeTest.DrawAfterFlushWithNoStateChange/* Bug: angleproject:5530 Change-Id: I8e9365219a617b8c6dd6d5c767e40ecde100a76d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689378Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fd70e387953e..d8a8a5c337df 2021-02-05 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master 2021-02-05 dneto@google.com Update README for GL/glx.h dependency on Linux If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC syoussefi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com,angle-bots+autoroll-info@google.com Change-Id: I55bf4df6b634b3d6e80b196f60b51fc3f249d93c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689309Reviewed-by:
-
Yuly Novikov authored
Otherwise ANativeActivity_onCreate is not found in component build. Bug: angleproject:4483 Change-Id: Ic4a9f66e5b7d150a3740529f866de9995550ea68 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689370 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
Austin Sullivan authored
The EXTClipCullDistanceForVertexShaderCompileFailureTest and EXTClipCullDistanceForFragmentShaderCompileFailureTest test suites each contain only one test, which is defined iff ANGLE_ENABLE_VULKAN is defined. This results in UNINSTANTIATED_PARAMETERIZED_TEST errors. This problem was discovered by attempting to roll googletest past CL 315255779, which causes test binaries to fail when they include test suites / parametrized tests that are not instantiated, and when they include empty test suites. Bug: chromium:1163396 Change-Id: Ie1837bc2879c14ad9f51a4a757ee1edc7e603c61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686377Reviewed-by:
-
Shahbaz Youssefi authored
This reverts commit 27906e9c. Reason for revert: Causes failures in mac_optional_gpu_tests_rel Original change's description: > GL: Cache the results of glGetString > > To reduce the amount of queries to the driver, we can cache the > results of glGetString. On Mac, we need to invalidate this cache > on GPU switch. > > Bug: chromium:1173672 > Change-Id: I039172068aec35034a87881a8804f52c080ce4ce > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676882 > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> TBR=geofflang@chromium.org,jonahr@google.com,jmadill@chromium.org Change-Id: I5799c5d287dd01b946446bd66d4c89aef6756d3a Bug: chromium:1173672 Bug: angleproject:5639 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690145Reviewed-by:
-
Jamie Madill authored
This ensures we will force the CQ to verify the trace tests before changes to the capture test script itself, or the test expectations. Bug: angleproject:5530 Change-Id: I7d9d04a14ae0525a6ff59681216abbdb85b72c78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689365Reviewed-by:
-
Jamie Madill authored
Bug: angleproject:5530 Change-Id: Ibbabab2bcc03c196c6c51e5bf67d81df8bad4925 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689364Reviewed-by:
-
Jonah Ryan-Davis authored
As pointed out in WebGL issue 3014, ANGLE has been exposing ETC1 texture support on desktop GL when GL_ARB_ES3_compatibility or GL 4.3+ is available. However, it is very likely that none of these platforms actually have hardware support for this format, and are only supporting it for compatiblity with ES3. We shouldn't expose this so that desktop clients can use a better format instead. Bug: chromium:1048244 Change-Id: I53837a05719d0ca3ff390b5b45b61a1f9c72a535 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2687466Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/4dc6ccfad74a..c409714366e9 2021-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d1bfbcd594d6 to 01c9ae9b47e5 (1 revision) 2021-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from ff6a9e31358a to a66ceba27225 (2 revisions) 2021-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f0c96f40c79d to cfa1dadb1e62 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I312c5f0aca5df7fcaa469b3ea1336b4df946c36a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690016Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/95cbe3e024b0..d671c89249af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a8f1167b05..5088ad39f5 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/bd12831a6f..7e85fef7d9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4ff3b79a9a..c9a2320aee * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7ce745057e..b33c25cc0b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b013189435 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8f265d6ddf..f33f4c53ae * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a33116a559..3294cf7fc4 * tools/skia_goldctl/linux: lenVc-lo77pTtOxFWjwWnArJLXKHftA-J-nOq_0W8EMC..FnrTtCqUzIkttLMcUafQ-E14XeYY8Yg79UKi-yF4k-gC * tools/skia_goldctl/mac: n5BYBVoiLzVMumXdheNmsUhTHYTpm2CAcb9W2KcPZA8C..33D5pMUWm9PcQ9nzgMNc-cv9Y67SNea1XX9S3h0q0zoC * tools/skia_goldctl/win: Evb_hYwKX21F3mSBdnoPa1gPiJlejpLrfECXIpdrrqgC..xC87Xnbi3y7b2aSw2voaEk8MtTPrvU1peyj7NfC6ZtIC No update to Clang. Bug: angleproject:5499 Tbr: syoussefi@google.com Change-Id: I15aa82ee87912270d98bc82342f6c94483924ef9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690011Reviewed-by:
-
Le Hoang Quyen authored
The correct metal layer's drawable size should be calculated after mMetalLayer.get().contentsScale is set during initialization to allow initial viewport to be computed properly on front-end side. Bug: angleproject:2634 Change-Id: If278f40c0b6800bbe12fb5ea94986f728381bc00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2687300 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/28d3d98b040d..fd70e387953e 2021-02-05 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC syoussefi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Change-Id: I8f160df11b65f88e79010c37aeb7a89aa70b84e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690142Reviewed-by:
-
Ian Elliott authored
After changes to the GN arg "angle_enable_trace" were done, other GN args are now needed. Bug: b/170249632 Change-Id: Ib5e703434cb580aa838ef8632b271f5f20554f42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2684933Reviewed-by:
-
Ian Elliott authored
Use "org.chromium.angle.agi" for the specially-built ANGLE APK for Android Graphics Inspector (AGI). This will allow AGI to work with a version of ANGLE that is built for it regardless of what other version(s) of ANGLE are or aren't installed on the device. Continue to use "org.chromium.angle" for developer builds. Bug: b/168745566 Change-Id: I4610d3b1eec6b0564d020dca7bd1f9e9d6532a64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2684920Reviewed-by:
-
Shahbaz Youssefi authored
Some dirty bits need to run before the render pass starts. An upcoming change for example needs to break the render pass when the program pipeline is changed while transform feedback is active. Another upcoming change may need to do the same based on a preceding glMemoryBarrier. This change adds a new dirty bit to start the render pass after some dirty bits have already been processed. Bug: angleproject:5528 Change-Id: I993c9efefed4c8fee268b218a8dd66a582d4e7cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2678863 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Tim Van Patten authored
Set mCurrentGraphicsPipeline = nullptr when the pipeline layout is recreated if immutable samplers are used to prevent a use-after-free. For a fuller discussion on why this is necessary, see: Vulkan: clear mCurrentGraphicsPipeline during invalidate | https://chromium-review.googlesource.com/c/angle/angle/+/2647746 Bug: b/178424566 Bug: angleproject:5624 Change-Id: I70679bda85cd587dbd8893a4576ee5d33aee2b70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683041 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
-
- 10 Feb, 2021 13 commits
-
-
Geoff Lang authored
ANGLE requests a config with several uneccessary parameters. I suspect these parameters are causing issues in the wild where eglChooseConfig fails. Try requesting ES3 then fall back to ES2 configs. Skip config caveats, floating point configs and multisample configs, we provided the default parameters. The resulting config is very similiar to the one Chrome requests in gl_surface_egl.cc Bug: chromium:1173161 Change-Id: Ifa78ff8081e3d86e823036981e1e2b5f8f751fed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2665888 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org>
-
Jamie Madill authored
This will add the trace tests with the "libANGLE/capture/" folder changes. This will prevent slow trace tests from clogging the CQ on unrelated changes, while still providing some regression testing. Bug: angleproject:5530 Change-Id: I76361aaa51c49c84dab8be7d74f4bad0db7d2419 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686438 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Peng Huang authored
gl::Context's ctor may need to create a native EGL context and it can fail. If it fails, the context->mImplementation will be nullptr, and it will cause crash elsewhere. Fix the problem by checking it after create a gl::Context instance. Bug: chromium:1171371 Change-Id: Ic57f088dcbf9716b85fee92bf54d557eb94642d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686439Reviewed-by:
-
Jamie Madill authored
This will make it easier to trigger the trace tests when these files are modified. Bug: angleproject:5530 Change-Id: I5f0c450595b380cd91b20c1477dc1845bee35dd9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686120 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
- Includes the missing logo - Adds presubmit builder to the try list view - Sorts the ci console view more consistently - Adds ynovikov to OWNERS - Updates documentation Also removes the old handwritten cfg files. Bug: angleproject:5559 Change-Id: I7d0ad4bd4d0afb56e114107b6a14718b384f9b37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686630 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jonah Ryan-Davis authored
To reduce the amount of queries to the driver, we can cache the results of glGetString. On Mac, we need to invalidate this cache on GPU switch. Bug: chromium:1173672 Change-Id: I039172068aec35034a87881a8804f52c080ce4ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676882 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
-
Jamie Madill authored
We can reuse the surface rotation matrix code to do the y-flip. This requires the SPIR-V transformation support. Because not all rotations are encoded into the table we can only support rotation with the driver support for y-flip (currently). Includes some very minimal regression testing. This work is targeted towards supporting vk-portability implementations which are not as up-to-date with Vulkan features. Bug: angleproject:5596 Change-Id: I270fa1efc03267551d28df33ddac9972e1343d60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2665892Reviewed-by:
Ian Elliott <ianelliott@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9d35d544ce96..673a7fe5c3ff 2021-02-10 capn@google.com Unify load/store operand accessors 2021-02-10 capn@google.com Discern between load and store addresses 2021-02-10 capn@google.com Rename InstIntrinsicCall to InstIntrinsic 2021-02-10 capn@google.com Eliminate the InstIntrinsicCall Target parameter 2021-02-10 capn@google.com Eliminate Subzero profiling support 2021-02-10 capn@google.com Regres: Remove GLES tests from CI test runs 2021-02-09 capn@google.com Benchmark time spent by all threads 2021-02-09 natsu@google.com Ignore two unused variables in llvm 2021-02-09 natsu@google.com Revert "Enable named mmap usage on Android" 2021-02-09 amaiorano@google.com VulkanWrapper: fix loading driver when lib path can be resolved by dlopen If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I867da2c4d62c19ba711b7923fb3d1d2632854a3e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2687120Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/f640b7005a0c..4dc6ccfad74a 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from a03938051ff6 to 6952dfcc1df5 (1 revision) 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7b727b773d50 to d1bfbcd594d6 (1 revision) 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 64ffe55c3bf6 to 7b727b773d50 (2 revisions) 2021-02-09 jmadill@chromium.org Add script for formatting commit messages. 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 6fcd515be5b3 to ff6a9e31358a (1 revision) 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 386b4fcb28e5 to 4afd69177258 (1 revision) 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from b2c81e3615bf to 64ffe55c3bf6 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I4eb306a46fa934c46fa2903c111b97b73306af8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686911Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/02dbd1fa1c75..95cbe3e024b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/44961f39c0..a8f1167b05 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fc5af1ac75..bd12831a6f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dfd112748a..4ff3b79a9a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/73458740c0..7ce745057e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b013189435 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/de0632cfad..a33116a559 * tools/skia_goldctl/linux: RCW4v6H43n2nkU3V54jWsXz5Q1h_OZaV_DcRQNXMV4sC..lenVc-lo77pTtOxFWjwWnArJLXKHftA-J-nOq_0W8EMC * tools/skia_goldctl/mac: hwxykGQN8q1I4nBPA93MSwNqdynaW_gYQ3CJwZJLyngC..n5BYBVoiLzVMumXdheNmsUhTHYTpm2CAcb9W2KcPZA8C * tools/skia_goldctl/win: XMdzQyfm6ZBS1E6dZSblabBo-_I49Cf38UhKjkyukC8C..Evb_hYwKX21F3mSBdnoPa1gPiJlejpLrfECXIpdrrqgC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ifd38d1b95e4f511ac795f946879774aa624dfd03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686684Reviewed-by:
-
Tim Van Patten authored
VkSamplerCreateInfo.magFilter and minFilter must match VkSamplerYcbcrConversionCreateInfo.chromaFilter. VkSamplerYcbcrConversionCreateInfo.chromaFilter is currently hard-coded to VK_FILTER_NEAREST in HardwareBufferImageSiblingVkAndroid(), so force magFilter and minFilter to VK_FILTER_NEAREST in SamplerDesc::init() if an externalFormat is being used. Bug: b/178424566 Change-Id: Ia1f7fc21e3faa4e57f837ed3ae70608134150aea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683038 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
-
Shahbaz Youssefi authored
If glBufferSubData results in a new vk::BufferHelper allocation, VertexArrayVk::mCurrentElementArrayBuffer needs to be updated. VertexArrayVk::syncState was working under the assumption that DIRTY_BIT_ELEMENT_ARRAY_BUFFER_DATA cannot result in a vk::BufferHelper pointer change. This assumption was broken in https://chromium-review.googlesource.com/c/angle/angle/+/2204655. Bug: b/178231226 Change-Id: I969549c5ffec3456bdc08ac3e03a0fa0e7b4593f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2685439Reviewed-by:
-
Tim Van Patten authored
Special Forces Group 2 issues invalid OpenGL ES commands, which are currently captured by ANGLE's frame capture. These invalid commands generate errors on both ANGLE and the native driver, causing the test to be marked as "failed". This CL updates FrameCapture::captureCall() to not capture invalid commands, which prevents replay errors. However, the other work related to the call is still performed, including: - maybeOverrideEntryPoint() - maybeCapturePreCallUpdates() - maybeCapturePostCallUpdates() This work is necessary, otherwise calls that update necessary members like FrameCapture::mClientArraySizes may be missed, causing leading to compilation failures related to missing symbols. For example, mClientArraySizes is updated via the following call stack: captureClientArraySnapshot() maybeCaptureDrawArraysClientData() maybeCapturePreCallUpdates() It's necessary for mClientArraySizes to contain non-zero values, so that the variable gClientArrays[] is output by WriteCppReplayIndexFiles(). Otherwise a compilation error will occur when it's referenced by a glVertexAttribPointer() call in the capture. Bug: angleproject:5592 Change-Id: I625a074e035eb75267d8384dc61ce6de1717af91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673068 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
-
