- 11 Feb, 2021 12 commits
-
-
Shahbaz Youssefi authored
This reverts commit 27906e9c. Reason for revert: Causes failures in mac_optional_gpu_tests_rel Original change's description: > GL: Cache the results of glGetString > > To reduce the amount of queries to the driver, we can cache the > results of glGetString. On Mac, we need to invalidate this cache > on GPU switch. > > Bug: chromium:1173672 > Change-Id: I039172068aec35034a87881a8804f52c080ce4ce > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676882 > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> TBR=geofflang@chromium.org,jonahr@google.com,jmadill@chromium.org Change-Id: I5799c5d287dd01b946446bd66d4c89aef6756d3a Bug: chromium:1173672 Bug: angleproject:5639 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690145Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Jamie Madill authored
This ensures we will force the CQ to verify the trace tests before changes to the capture test script itself, or the test expectations. Bug: angleproject:5530 Change-Id: I7d9d04a14ae0525a6ff59681216abbdb85b72c78 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689365Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
Bug: angleproject:5530 Change-Id: Ibbabab2bcc03c196c6c51e5bf67d81df8bad4925 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689364Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jonah Ryan-Davis authored
As pointed out in WebGL issue 3014, ANGLE has been exposing ETC1 texture support on desktop GL when GL_ARB_ES3_compatibility or GL 4.3+ is available. However, it is very likely that none of these platforms actually have hardware support for this format, and are only supporting it for compatiblity with ES3. We shouldn't expose this so that desktop clients can use a better format instead. Bug: chromium:1048244 Change-Id: I53837a05719d0ca3ff390b5b45b61a1f9c72a535 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2687466Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/4dc6ccfad74a..c409714366e9 2021-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d1bfbcd594d6 to 01c9ae9b47e5 (1 revision) 2021-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from ff6a9e31358a to a66ceba27225 (2 revisions) 2021-02-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from f0c96f40c79d to cfa1dadb1e62 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I312c5f0aca5df7fcaa469b3ea1336b4df946c36a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690016Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/95cbe3e024b0..d671c89249af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a8f1167b05..5088ad39f5 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/bd12831a6f..7e85fef7d9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4ff3b79a9a..c9a2320aee * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7ce745057e..b33c25cc0b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b013189435 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/8f265d6ddf..f33f4c53ae * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a33116a559..3294cf7fc4 * tools/skia_goldctl/linux: lenVc-lo77pTtOxFWjwWnArJLXKHftA-J-nOq_0W8EMC..FnrTtCqUzIkttLMcUafQ-E14XeYY8Yg79UKi-yF4k-gC * tools/skia_goldctl/mac: n5BYBVoiLzVMumXdheNmsUhTHYTpm2CAcb9W2KcPZA8C..33D5pMUWm9PcQ9nzgMNc-cv9Y67SNea1XX9S3h0q0zoC * tools/skia_goldctl/win: Evb_hYwKX21F3mSBdnoPa1gPiJlejpLrfECXIpdrrqgC..xC87Xnbi3y7b2aSw2voaEk8MtTPrvU1peyj7NfC6ZtIC No update to Clang. Bug: angleproject:5499 Tbr: syoussefi@google.com Change-Id: I15aa82ee87912270d98bc82342f6c94483924ef9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690011Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Le Hoang Quyen authored
The correct metal layer's drawable size should be calculated after mMetalLayer.get().contentsScale is set during initialization to allow initial viewport to be computed properly on front-end side. Bug: angleproject:2634 Change-Id: If278f40c0b6800bbe12fb5ea94986f728381bc00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2687300 Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/28d3d98b040d..fd70e387953e 2021-02-05 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC syoussefi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Change-Id: I8f160df11b65f88e79010c37aeb7a89aa70b84e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2690142Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Ian Elliott authored
After changes to the GN arg "angle_enable_trace" were done, other GN args are now needed. Bug: b/170249632 Change-Id: Ib5e703434cb580aa838ef8632b271f5f20554f42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2684933Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Ian Elliott authored
Use "org.chromium.angle.agi" for the specially-built ANGLE APK for Android Graphics Inspector (AGI). This will allow AGI to work with a version of ANGLE that is built for it regardless of what other version(s) of ANGLE are or aren't installed on the device. Continue to use "org.chromium.angle" for developer builds. Bug: b/168745566 Change-Id: I4610d3b1eec6b0564d020dca7bd1f9e9d6532a64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2684920Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Shahbaz Youssefi authored
Some dirty bits need to run before the render pass starts. An upcoming change for example needs to break the render pass when the program pipeline is changed while transform feedback is active. Another upcoming change may need to do the same based on a preceding glMemoryBarrier. This change adds a new dirty bit to start the render pass after some dirty bits have already been processed. Bug: angleproject:5528 Change-Id: I993c9efefed4c8fee268b218a8dd66a582d4e7cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2678863 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Tim Van Patten authored
Set mCurrentGraphicsPipeline = nullptr when the pipeline layout is recreated if immutable samplers are used to prevent a use-after-free. For a fuller discussion on why this is necessary, see: Vulkan: clear mCurrentGraphicsPipeline during invalidate | https://chromium-review.googlesource.com/c/angle/angle/+/2647746 Bug: b/178424566 Bug: angleproject:5624 Change-Id: I70679bda85cd587dbd8893a4576ee5d33aee2b70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683041 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
- 10 Feb, 2021 15 commits
-
-
Geoff Lang authored
ANGLE requests a config with several uneccessary parameters. I suspect these parameters are causing issues in the wild where eglChooseConfig fails. Try requesting ES3 then fall back to ES2 configs. Skip config caveats, floating point configs and multisample configs, we provided the default parameters. The resulting config is very similiar to the one Chrome requests in gl_surface_egl.cc Bug: chromium:1173161 Change-Id: Ifa78ff8081e3d86e823036981e1e2b5f8f751fed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2665888 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Peng Huang <penghuang@chromium.org>
-
Jamie Madill authored
This will add the trace tests with the "libANGLE/capture/" folder changes. This will prevent slow trace tests from clogging the CQ on unrelated changes, while still providing some regression testing. Bug: angleproject:5530 Change-Id: I76361aaa51c49c84dab8be7d74f4bad0db7d2419 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686438 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org>
-
Peng Huang authored
gl::Context's ctor may need to create a native EGL context and it can fail. If it fails, the context->mImplementation will be nullptr, and it will cause crash elsewhere. Fix the problem by checking it after create a gl::Context instance. Bug: chromium:1171371 Change-Id: Ic57f088dcbf9716b85fee92bf54d557eb94642d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686439Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
-
Jamie Madill authored
This will make it easier to trigger the trace tests when these files are modified. Bug: angleproject:5530 Change-Id: I5f0c450595b380cd91b20c1477dc1845bee35dd9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686120 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
Jamie Madill authored
- Includes the missing logo - Adds presubmit builder to the try list view - Sorts the ci console view more consistently - Adds ynovikov to OWNERS - Updates documentation Also removes the old handwritten cfg files. Bug: angleproject:5559 Change-Id: I7d0ad4bd4d0afb56e114107b6a14718b384f9b37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686630 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org>
-
Jonah Ryan-Davis authored
To reduce the amount of queries to the driver, we can cache the results of glGetString. On Mac, we need to invalidate this cache on GPU switch. Bug: chromium:1173672 Change-Id: I039172068aec35034a87881a8804f52c080ce4ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676882 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Jamie Madill authored
We can reuse the surface rotation matrix code to do the y-flip. This requires the SPIR-V transformation support. Because not all rotations are encoded into the table we can only support rotation with the driver support for y-flip (currently). Includes some very minimal regression testing. This work is targeted towards supporting vk-portability implementations which are not as up-to-date with Vulkan features. Bug: angleproject:5596 Change-Id: I270fa1efc03267551d28df33ddac9972e1343d60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2665892Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9d35d544ce96..673a7fe5c3ff 2021-02-10 capn@google.com Unify load/store operand accessors 2021-02-10 capn@google.com Discern between load and store addresses 2021-02-10 capn@google.com Rename InstIntrinsicCall to InstIntrinsic 2021-02-10 capn@google.com Eliminate the InstIntrinsicCall Target parameter 2021-02-10 capn@google.com Eliminate Subzero profiling support 2021-02-10 capn@google.com Regres: Remove GLES tests from CI test runs 2021-02-09 capn@google.com Benchmark time spent by all threads 2021-02-09 natsu@google.com Ignore two unused variables in llvm 2021-02-09 natsu@google.com Revert "Enable named mmap usage on Android" 2021-02-09 amaiorano@google.com VulkanWrapper: fix loading driver when lib path can be resolved by dlopen If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I867da2c4d62c19ba711b7923fb3d1d2632854a3e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2687120Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/f640b7005a0c..4dc6ccfad74a 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from a03938051ff6 to 6952dfcc1df5 (1 revision) 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7b727b773d50 to d1bfbcd594d6 (1 revision) 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 64ffe55c3bf6 to 7b727b773d50 (2 revisions) 2021-02-09 jmadill@chromium.org Add script for formatting commit messages. 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 6fcd515be5b3 to ff6a9e31358a (1 revision) 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 386b4fcb28e5 to 4afd69177258 (1 revision) 2021-02-09 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from b2c81e3615bf to 64ffe55c3bf6 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I4eb306a46fa934c46fa2903c111b97b73306af8d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686911Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/02dbd1fa1c75..95cbe3e024b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/44961f39c0..a8f1167b05 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fc5af1ac75..bd12831a6f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dfd112748a..4ff3b79a9a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/73458740c0..7ce745057e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b013189435 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/de0632cfad..a33116a559 * tools/skia_goldctl/linux: RCW4v6H43n2nkU3V54jWsXz5Q1h_OZaV_DcRQNXMV4sC..lenVc-lo77pTtOxFWjwWnArJLXKHftA-J-nOq_0W8EMC * tools/skia_goldctl/mac: hwxykGQN8q1I4nBPA93MSwNqdynaW_gYQ3CJwZJLyngC..n5BYBVoiLzVMumXdheNmsUhTHYTpm2CAcb9W2KcPZA8C * tools/skia_goldctl/win: XMdzQyfm6ZBS1E6dZSblabBo-_I49Cf38UhKjkyukC8C..Evb_hYwKX21F3mSBdnoPa1gPiJlejpLrfECXIpdrrqgC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ifd38d1b95e4f511ac795f946879774aa624dfd03 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686684Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Tim Van Patten authored
VkSamplerCreateInfo.magFilter and minFilter must match VkSamplerYcbcrConversionCreateInfo.chromaFilter. VkSamplerYcbcrConversionCreateInfo.chromaFilter is currently hard-coded to VK_FILTER_NEAREST in HardwareBufferImageSiblingVkAndroid(), so force magFilter and minFilter to VK_FILTER_NEAREST in SamplerDesc::init() if an externalFormat is being used. Bug: b/178424566 Change-Id: Ia1f7fc21e3faa4e57f837ed3ae70608134150aea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683038 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
If glBufferSubData results in a new vk::BufferHelper allocation, VertexArrayVk::mCurrentElementArrayBuffer needs to be updated. VertexArrayVk::syncState was working under the assumption that DIRTY_BIT_ELEMENT_ARRAY_BUFFER_DATA cannot result in a vk::BufferHelper pointer change. This assumption was broken in https://chromium-review.googlesource.com/c/angle/angle/+/2204655. Bug: b/178231226 Change-Id: I969549c5ffec3456bdc08ac3e03a0fa0e7b4593f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2685439Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Tim Van Patten authored
Special Forces Group 2 issues invalid OpenGL ES commands, which are currently captured by ANGLE's frame capture. These invalid commands generate errors on both ANGLE and the native driver, causing the test to be marked as "failed". This CL updates FrameCapture::captureCall() to not capture invalid commands, which prevents replay errors. However, the other work related to the call is still performed, including: - maybeOverrideEntryPoint() - maybeCapturePreCallUpdates() - maybeCapturePostCallUpdates() This work is necessary, otherwise calls that update necessary members like FrameCapture::mClientArraySizes may be missed, causing leading to compilation failures related to missing symbols. For example, mClientArraySizes is updated via the following call stack: captureClientArraySnapshot() maybeCaptureDrawArraysClientData() maybeCapturePreCallUpdates() It's necessary for mClientArraySizes to contain non-zero values, so that the variable gClientArrays[] is output by WriteCppReplayIndexFiles(). Otherwise a compilation error will occur when it's referenced by a glVertexAttribPointer() call in the capture. Bug: angleproject:5592 Change-Id: I625a074e035eb75267d8384dc61ce6de1717af91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2673068 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
Mohan Maiya authored
ActiveTextureMask and ImageUnitMask need more than 64bits. We can now use the BitSetArray datatype and avoid the perf penalty of using std::bitset Bug: angleproject:3877 Tests: angle_perftests.exe --gtest_filter=TexturesBenchmark* Change-Id: Ic82e09d1aa2c1904d06ad48ba6200f35896665ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2664734 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Mohan Maiya authored
When retrieving BitSet masks return a const reference of the mask to avoid invoking the copy-constructor. Bug: angleproject:3877 Change-Id: I9f724a4864f3db17aa6f1ab74b81053c65313764 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2681767Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
-
- 09 Feb, 2021 12 commits
-
-
Jamie Madill authored
Makes a number of small configuration changes. Notable the "try" console view is replaced with a list view. Bug: angleproject:5559 Change-Id: Id3c4cb28fe9d456f8b79ed740f978b72e2ffcdd0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2677903 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org>
-
Stephen White authored
Bug: angleproject:5632 Change-Id: Id470993a01609ace851372b1bbe01fee8cde274b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2684635 Commit-Queue: Stephen White <senorblanco@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Yuly Novikov authored
Keeping only CI testing due to lack of phone capacity. Bug: angleproject:5633 Change-Id: I9b41d86630ce6a6647fb058cd70382f1cb9a938f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2686116Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
-
Tim Van Patten authored
Bug: angleproject:5612 Test: angle_perftests --gtest_filter=TracePerfTest.Run/*bus_simulator_indonesia* Change-Id: I067795b237fc32406d63785e347324b423978768 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2674305 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b29bf0434c16..28d3d98b040d 2021-02-05 alexander.galazin@arm.com Remove GLES-only tests from the GL 4.5 package 2021-02-05 alexander.galazin@arm.com Support GL 4.5 in the Separate shader tests 2021-02-04 alanbaker@google.com VK_KHR_zero_initialize_workgroup_memory tests 2021-02-04 alexander.galazin@arm.com Update Vulkan headers 2021-02-03 alexander.galazin@arm.com Update glslang 2021-02-03 ari.suonpaa@siru.fi Change gradient generator for pipeline image tests 2021-02-03 gleese@broadcom.com Add tests for multisample texture size 2021-02-03 piotr.byszewski@mobica.com Fix memory scope in OpControlBarrier tests 2021-02-03 marcin.kantoch@amd.com VK_KHR_fragment_shading_rate pixel consistency 2021-01-29 ruoyu@amd.com Adjust texture data and threshold 2021-01-29 rgarcia@igalia.com Fix validation in mismatched format tests 2021-01-29 venni.ihanakangas@siru.fi Test descriptor set layout binding ordering 2021-01-29 ari.suonpaa@siru.fi Add descriptor update stress test 2021-01-29 antto.makinen@siru.fi Coverage tests for undefined values 2021-01-29 rgarcia@igalia.com Test attributes beyond static vertex stride 2021-01-28 gleese@broadcom.com Check for astc_sliced_3d extension in negative API tests 2021-01-28 rgarcia@igalia.com Disable dithering in nearest edge test cases 2021-01-28 rgarcia@igalia.com Check sparse image format support before creation 2021-01-28 rgarcia@igalia.com Additional conditional rendering tests 2021-01-28 estea@igalia.com Expand tests for image queries of null descriptors 2021-01-22 gleese@broadcom.com Stop dEQP-GL45 tests falling back to ES3.1 2021-01-22 apinheiro@igalia.com Add VariablePointerFeatures requirement for amber test requiring it 2021-01-22 apinheiro@igalia.com Avoid querying YCbCr combined sampler count in RGBA 2021-01-22 rgarcia@igalia.com Check unsupported formats with sparse AMD bias/lod 2021-01-22 mika.vainola@siru.fi Add command line option for filtering by runner 2021-01-22 antto.makinen@siru.fi Fix a Graphicsfuzz coverage test not to depend on an undefined value 2021-01-22 antto.makinen@siru.fi dEQP-VK.graphicsfuzz.cov-tail-duplicator-infinite-loops 2021-01-22 mika.vainola@siru.fi Add FrexpStruct comparison tests 2021-01-22 ari.suonpaa@siru.fi Use target environment for Amber shaders 2021-01-22 alexander.galazin@arm.com Add gitattributes 2021-01-22 piotr.byszewski@mobica.com Test negative depthBiasClamp values 2021-01-21 Kyle.Griffiths@imgtec.com Threshold Consistency for ES2 FBO Tests 2021-01-21 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-01-21 alexander.galazin@arm.com Support GL 4.5 in the GetTexLevelParameter tests 2021-01-21 alexander.galazin@arm.com Support GL 4.5 in the multisample interpolation states tests 2021-01-21 alexander.galazin@arm.com Support GL 4.5 in the Shader state query tests 2021-01-21 alexander.galazin@arm.com Support GL 4.5 in the Stencil texturing tests 2021-01-21 alexander.galazin@arm.com Support GL 4.5 in the Synchronization tests 2021-01-21 alexander.galazin@arm.com Support GL 4.5 in various multisample tests 2021-01-21 cheryl.wei@arm.com Fix ReadPixels format 2021-01-20 alexander.galazin@arm.com Support GL 4.5 in the Texture buffer syncronization tests 2021-01-20 alexander.galazin@arm.com Support GL 4.5 in the Texture Specification Tests 2021-01-20 alexander.galazin@arm.com Support GL 4.5 in the Query vertex attribute binding state tests 2021-01-20 greg@lunarg.com Add minimum nonUniform tests to descriptor indexing texts 2021-01-19 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Texture size tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Shader Image Load & Store Tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the gl_HelperInvocation tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the GL_EXT_shader_framebuffer_fetch tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Common function tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Opaque Type Indexing Tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Internal format queries tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Layout binding tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Integer state query tests 2021-01-19 alexander.galazin@arm.com Suppotr GL 4.5 in the sRGB write control tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Cube map array texture tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the base vertex extension drawing tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the indexed draw buffers tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the default vertex array object test 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the Boolean State Query tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the atomic operation with image tests 2021-01-19 alexander.galazin@arm.com Support GL 4.5 in the draw_indirect tests 2021-01-17 alexander.galazin@arm.com Notice of withdrawal of Vulkan CTS 1.2.1.x 2021-01-13 Alexander.Galazin@arm.com Merge "Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master" 2021-01-13 thomas.spurden@broadcom.com Add --force option to fetch_sources.py 2021-01-13 estea@igalia.com Fix checks for conditional rendering support 2021-01-13 slawomir.cygan@intel.com Check for VK_KHR_portability_subset extension before checking it's features 2021-01-13 estea@igalia.com Add striped 3D blitting tests 2021-01-11 estea@igalia.com Add tests for logical operations 2021-01-08 ruoyu@amd.com Disable-SeamlessCubeMap-In-Reference-ES2Context 2021-01-08 gleese@broadcom.com Test invalid Lods in the textureSize tests 2021-01-08 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2021-01-07 rgarcia@igalia.com Fix sync problems in conditional_rendering.draw_clear tests 2021-01-07 cwabbott0@gmail.com Don't access arrays out-of-bounds in robustness2 tests 2021-01-07 anholt@google.com pipeline statistics test: Fix compute shader setup in !GL4.3 case. 2021-01-06 rgarcia@igalia.com Clarify depth/stencil resolve write access sync 2020-12-29 alexander.galazin@arm.com Support GL 4.5 in the texture test utils 2020-12-29 alexander.galazin@arm.com Support GL 4.5 in the blend_equation_advanced tests 2020-12-29 alexander.galazin@arm.com Support GL 4.5 in the 'negative' tests 2020-12-29 alexander.galazin@arm.com Support GL 4.5 in geometry/tesselation shader tests 2020-12-29 alexander.galazin@arm.com Support GL 4.5 context in the precision and draw tests 2020-12-29 alexander.galazin@arm.com First steps towards running ES3.1 functional tests on GL4.5 drivers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC geofflang@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:3687 Bug: angleproject:3688 Change-Id: I8de830ec9f56ab6a29218f83caaf96b86ceba648 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679296Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Mohan Maiya authored
For usecases that needed more than 64bits we were using std::bitset container. This has slower perf compared to the BitSetT container. Add a new class that can support large bitsets by wrapping an array of BitSet32/BitSet64 objects, depending on CPU bitness, as the container. Bug: angleproject:3877 Tests: angle_unittests.exe --gtest_filter=BitSetArrayTest* angle_white_box_perftests.exe --gtest_filter=BitSetIteratorPerfTest* Change-Id: I3f4a635f9e6974a99db7a4b592ab206aad754760 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2664733 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Mohan Maiya authored
Expand ExtendedDirtyBitType to include bit for clip distance, mipmap generation hint and shader derivative hint. Handle these dirty bits in ContextVk::syncState Bug: angleproject:5611 Change-Id: If8d1646334e737f81ac72cdddb8fe3ba613b4b94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676173 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Jamie Madill authored
This mirrors the version used in Chromium. Bug: angleproject:5559 Change-Id: Ie1702281ce88fef00bf46079ae76477d33207dfd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2679298Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Cody Northrop authored
Remove some tests that no longer fail to compile. Test: capture_replay_tests.py --gtest_filter=*ES2_Vulkan_SwiftShader Bug: angleproject:5630 Change-Id: If04787494e58afad0a98d0ee7f37e00d2e77ec1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683543Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/d6c9a9f3f705..f640b7005a0c 2021-02-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from db287d4ad474 to b2c81e3615bf (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ifd3d52b5f8828aa3d1f8cf3be6d4aecec0adfb82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683856Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/266614a36dbd..9d35d544ce96 2021-02-08 amaiorano@google.com Make vk-unittests use VulkanWrapper If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I1a87604249b72aab496adfef32e05ef29cd5aba0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683822Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/82fe35376dee..02dbd1fa1c75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a2a134032e..44961f39c0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f86e30675a..dfd112748a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cf4c59a332 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fae3adcf16..8f265d6ddf No update to Clang. Bug: angleproject:5499 Tbr: syoussefi@google.com Change-Id: I8edd0b6d67fd6c01cad722ebc0a719ef44cb3c0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2683547Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 08 Feb, 2021 1 commit
-
-
Jonah Ryan-Davis authored
The other backend description strings are in DisplayImpl. This will help with caching the result of glGetString in the GL backend. Also Update the getters to not be const in order to allow caching. Bug: chromium:1173672 Change-Id: I43df35688762b23429f47f169c04482cf4cd089a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2676881Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
-