ESSL 1.00.17 section 6.1 forbids this. Returning arrays was already
covered by the checks that disallow declaring array types in ESSL
1.00.

BUG=angleproject:1015
TEST=dEQP-GLES2.functional.shaders.functions.* (2 new tests pass)
     dEQP-GLES3.functional.shaders.functions.* (no regression)

Change-Id: Iaffa1631c0c940afb57819221e7e8603b2305021
Reviewed-on: https://chromium-review.googlesource.com/352920Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

BUG=angleproject:1388

Change-Id: Ia9befba0c915c087f2fe0557d91060256f6d4950
Reviewed-on: https://chromium-review.googlesource.com/348955Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

WebGL test: textures/misc/tex-new-formats

BUG=angleproject:1407
BUG=chromium:616176

Change-Id: I7b557587c1ea0861bcac327a370480b36f679794
Reviewed-on: https://chromium-review.googlesource.com/351170Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1407
BUG=chromium:616176

Change-Id: I2b88616b6b72dd9caf07fac8ebba9a065cf2983f
Reviewed-on: https://chromium-review.googlesource.com/350907Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1407
BUG=chromium:616176

Change-Id: I663d265abfabb88a5aca8ca0002d2cbc29f6b069
Reviewed-on: https://chromium-review.googlesource.com/350906Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Takes care of non-component Clank build and 64 bit.

BUG=angleproject:1362
TEST=angle_end2end_tests

Change-Id: Ib338734960c6ac378ae49028ae30416bff31ac2a
Reviewed-on: https://chromium-review.googlesource.com/352710Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

BUG=angleproject:1407
BUG=chromium:616176

Change-Id: Ibb7c5e71b4cf8afe7b7d0092e7d019b87d507ba6
Reviewed-on: https://chromium-review.googlesource.com/350905Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This perf test focuses on the hotspot we have in Framebuffer::
checkStatus. It's exactly the same as the standard draw call
benchmark, but binds a Framebuffer before rendering.

BUG=angleproject:1388

Change-Id: Icc7a99e399f469d765bf1ac6abe0562977b9a39d
Reviewed-on: https://chromium-review.googlesource.com/348956Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Move function header parsing code to ParseContext instead of having
it in the grammar file. This commit is pure refactoring. This code
needs to be changed later to detect returning arrays containing
structs.

This commit also disables clang format for glslang.cpp generated by
bison.

TEST=angle_unittests
BUG=angleproject:1015

Change-Id: If60848ca32da6b98ea8bcd95bba8c3f831634b51
Reviewed-on: https://chromium-review.googlesource.com/352480Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

These methods can obviate the need for glGen/Delete calls in tests.

BUG=angleproject:1407

Change-Id: Ied571e48db92bd1d4f4089d91a95e7c7fafcfcaf
Reviewed-on: https://chromium-review.googlesource.com/350904Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This will preserve layering - the API layer doesn't mutate the state
directly, it passes the API call through to the Context. Is also
removes the possiblity of any shenanigans of the Validation layer
changing the GL state.

Also, this CL refactors a few validation entry points to take
ValidationContext instead of Context. ValidationContext will be the
correct way to interact with the gl::Context in the Validation code.

Finally, additional refactorings make ContextState a proper class with
private data. This allows the ContextState itself to keep a mutable
pointer to the gl::State, so ValidationContext can modify it if
necessary (and it will be necessary for Framebuffer completeness
caching).

BUG=angleproject:1388

Change-Id: I86ab3561573caa9535c8d1b8aad4ab3d0e7cd470
Reviewed-on: https://chromium-review.googlesource.com/348954Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1405
BUG=angleproject:1265

Change-Id: I823e1393943f7531374c094ce590fa0a6f49d213
Reviewed-on: https://chromium-review.googlesource.com/351776Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

In the next CL, the Context is going to remove the mutable getter
for the gl::State. This means we can only mutate the state inside
Context. So, we need to move all the state mutating GL command
implementations to gl::Context.

BUG=angleproject:747
BUG=angleproject:1388

Change-Id: I9ed351d08611934bf708781c6af3948396921593
Reviewed-on: https://chromium-review.googlesource.com/351171Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Add virtual destructor to SignalReceiver.

class angle::SignalReceiver has virtual functions
and accessible non-virtual destructor.
This generates a compile error.

Change-Id: Iced2ee94ad9268ab5c1d00ab336ab2cc98385afc
Reviewed-on: https://chromium-review.googlesource.com/351930Reviewed-by: Sami Väisänen <svaisanen@nvidia.com>
Commit-Queue: Sami Väisänen <svaisanen@nvidia.com>

Resubmitted with test skip added for Intel OpenGL.

GLES 3.0.4 section 3.8.3:

"For the purposes of decoding the texture image, TexImage2D is
equivalent to calling TexImage3D with corresponding arguments and
depth of 1, except that UNPACK_SKIP_IMAGES is ignored."

An "applySkipImages" boolean parameter is added to the functions in
the D3D backend that apply skip offset to the unpack pointer. In case
2D texture data is uploaded, the parameter is set to false and
UNPACK_SKIP_IMAGES is not applied.

BUG=angleproject:1406
TEST=angle_end2end_tests

Change-Id: I5878439e3d38dbae89cc2452a056c2d6bbf9e0b3
Reviewed-on: https://chromium-review.googlesource.com/351330Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

The Windows Intel GPU FYI bot started failing the Texture2DTestES3.UnpackSkipImages2D/ES3_OPENGL test after this CL. Example: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28New%20Intel%29/builds/866

This reverts commit ac3575b2.

Change-Id: I5120261f5cf1ece9b21e4a94f63f85e014d2d8e4
Reviewed-on: https://chromium-review.googlesource.com/351280Reviewed-by: Geoff Lang <geofflang@chromium.org>

Dependent state changes happen when the user calls TexImage
on a Texture attached to a Framebuffer. The Framebuffer should be
told 'hey, you should know about this'. Other objects also have
dependent relationships, like VertexArrays and Buffers.

This refactoring uses a binding pointer design, similar to the type
'RefCountObject'. This design fixes the need for manual decoupling
when one or the other is destroyed. The pointers are cleaned up in
destructors, and do no-ops when either the source or dest is missing.

Also move these new classes to a location where they are accessible to
the GL layer; they will be important for framebuffer completeness.

BUG=angleproject:1388

Change-Id: I92610acb85dae6f9c009b8f071e121fde53782ae
Reviewed-on: https://chromium-review.googlesource.com/348953Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

These routines were pretty much duplicated between D3D9 and D3D11.
Since I was going to have to rewrite them again for Vulkan, I
figured it would be best to move them into a common location and
clean them up a bit.

BUG=angleproject:1319

Change-Id: I15d39b052daf3e1020dbd0880f01ae84f3686a0a
Reviewed-on: https://chromium-review.googlesource.com/349630Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Now that C++11 constructor syntax is allowed, we can use a much
simpler scheme.

BUG=angleproject:1407
BUG=chromium:616176

Change-Id: Ida5f235c3ed1429564af5213a5fead6c3b896080
Reviewed-on: https://chromium-review.googlesource.com/350903Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=None

Change-Id: I6fdcb8c436f35b9e3aa284760063f27e04e15a48
Reviewed-on: https://chromium-review.googlesource.com/350902Reviewed-by: Corentin Wallez <cwallez@chromium.org>

GLES 3.0.4 section 3.8.3:

"For the purposes of decoding the texture image, TexImage2D is
equivalent to calling TexImage3D with corresponding arguments and
depth of 1, except that UNPACK_SKIP_IMAGES is ignored."

An "applySkipImages" boolean parameter is added to the functions in
the D3D backend that apply skip offset to the unpack pointer. In case
2D texture data is uploaded, the parameter is set to false and
UNPACK_SKIP_IMAGES is not applied.

BUG=angleproject:1406
TEST=angle_end2end_tests

Change-Id: Iedc2b05377adee8d5c2504511a87421f4b1db18d
Reviewed-on: https://chromium-review.googlesource.com/350465Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This reverts commit 8b8d0432.

Change-Id: I25726642d066ca322830d1f5a4327f4e7e551fa6
Reviewed-on: https://chromium-review.googlesource.com/350870Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1397

Change-Id: Icdfc99eefcfad730ec887b82ec0758a6d6c0b9a7
Reviewed-on: https://chromium-review.googlesource.com/348064Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This reverts commit c88d8354.

Likely causing failures on Linux webgl tests:
http://build.chromium.org/p/chromium.gpu.fyi/waterfall?builder=Linux%20Release%20(New%20Intel)

Change-Id: I0294f7f544c666ee7db13c4f7acae868c6bd2240
Reviewed-on: https://chromium-review.googlesource.com/350530Reviewed-by: Geoff Lang <geofflang@chromium.org>

EGLAttrib can be a 64-bit type on some configurations, in which case
it needs an explicit cast to be converted to EGLint.

TEST=standalone MSVS 2015 x64 debug build

Change-Id: I6b3e0ae705e8862e079e81e516d6bf99409732e7
Reviewed-on: https://chromium-review.googlesource.com/350411Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

This fixes a bug preventing Cherry from running on Windows.

BUG=None

Change-Id: I0049005093e5abb7a7fd2c5b125e8133c0e0cab5
Reviewed-on: https://chromium-review.googlesource.com/350402Reviewed-by: Geoff Lang <geofflang@chromium.org>

GL_ARB_draw_buffers adds special semantics when writing to gl_FragData even
if multiple renderbuffers is part of the core spec so it needs to be declared
in the translated shader.

BUG=617410

Change-Id: Id5524634c278ba303413b11251d560744f2517ca
Reviewed-on: https://chromium-review.googlesource.com/350121Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Just the bare minimum implementation for end2end tests to run.

BUG=angleproject:1362
TEST=angle_end2end_tests on Nexus 5X

Change-Id: I92293e0f8bdc2ffaa5d4661927750d7cb3d931e6
Reviewed-on: https://chromium-review.googlesource.com/349353Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Do this in a separate CL to preserve the renderer generation.

BUG=angleproject:1319

Change-Id: I6d5768f199f6aabff747b3708c0625ff78e1ceb0
Reviewed-on: https://chromium-review.googlesource.com/349424Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Requested in https://chromium-review.googlesource.com/349353

BUG=angleproject:1362

Change-Id: I989757c2fb8f65d5afcfb177b7f8da1414871e6f
Reviewed-on: https://chromium-review.googlesource.com/349694Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Change-Id: Icb15891d4325ad1724647f5d6faf0d17fbb50269
Reviewed-on: https://chromium-review.googlesource.com/349470Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Otherwise, end2end tests crash on Nexus 5X,
because Adreno driver doesn't provide glMapBuffer.

BUG=angleproject:1362
TEST=angle_end2end_tests on Nexus 5X and Linux

Change-Id: I6207eca2d0e03eee957bb612271a66016fd562bb
Reviewed-on: https://chromium-review.googlesource.com/349421Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Change-Id: I387249d29822d91a6126f6c25cb35e8b80cb4c36
Reviewed-on: https://chromium-review.googlesource.com/349460Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Otherwise, end2end tests crash on Nexus 5X,
since the underlying EGL surface doesn't exist
at the time of getSwapBehavior call.

BUG=angleproject:1362
TEST=angle_end2end_tests on Nexus 5X

Change-Id: I550e46ee82592b9d1ea49a3c968d7ffad3ab06f7
Reviewed-on: https://chromium-review.googlesource.com/349430Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Otherwise, running end2end tests on Nexus 5X crashes.

BUG=angleproject:1362
TEST=angle_end2end_tests on Nexus 5X

Change-Id: I063d9f9836a1575cbf0abe361dbf8b2c1492105d
Reviewed-on: https://chromium-review.googlesource.com/349420Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This was very wrong for 3D textures.

BUG=angleproject:1384

Change-Id: I7f042449e30e1e909778c0524d1ce99d20ddfd65
Reviewed-on: https://chromium-review.googlesource.com/348063Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This replaces are "IsUnsignedXXXSafe" family of methods.
Also add overflow checks to unpack block sizes.

BUG=angleproject:1397

Change-Id: Ib47be149b0486c70f795b0d0f8899441faac9340
Reviewed-on: https://chromium-review.googlesource.com/348062Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1401

Change-Id: I5d08ecb2d4090e4be049dc6d25fc2ea17911ff2c
Reviewed-on: https://chromium-review.googlesource.com/349011Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

Change-Id: I2b87e0b60f40d345388562e33ed8eb7010adf186
Reviewed-on: https://chromium-review.googlesource.com/349040Reviewed-by: Jamie Madill <jmadill@chromium.org>

This will include a new clang-format for standalone ANGLE.

BUG=None

Change-Id: Ia4a888c77487d03c2c83989c5f565dea993d5a06
Reviewed-on: https://chromium-review.googlesource.com/348374Reviewed-by: Geoff Lang <geofflang@chromium.org>