Commits · e2a8a69ade47c3c23f7ebc46dd7bbf785541edd6 · Chen Yisong / angle

07 Jan, 2021 4 commits

Vulkan: Move xfb emulation offset calculation to translator · e2a8a69a

authored Jan 04, 2021

A new function is added by the translator to calculate the transform
feedback offsets in the emulation path.  This function makes the
generated code for transform feedback smaller.

Bug: angleproject:3606
Change-Id: I01460f907e20e2887cb720bddad96697fdcb0cf3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607492
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e2a8a69a

Vulkan: Fix missing xfb buffer rebind on new command buffer · 07d619cb

authored Jan 06, 2021

When a command buffer is ended, bindings are lost.  This adds a dirty
bit to `mNewGraphicsCommandBufferDirtyBits` to make sure transform
feedback buffers are bound again on the new command buffer.

Bug: angleproject:5428
Change-Id: I7733c93b1eb5d33a77cbee231a83199be950e19f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611552
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

07d619cb

Move RegenerateStructNames AST transformation to gl/ · 5e280545

authored Jan 06, 2021

This AST transformation is used by the chromium validating command
decoder on Linux/AMD/GL as well as MacOS.

Bug: chromium:1161513
Change-Id: I67e40215ae5576819ba5a58987ceb1776c86c731
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613195
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

5e280545

Vulkan: Refactor generated code in xfb emulation path · ca94d1da

authored Jan 04, 2021

The index expression was regenerated for every component written to the
output.  This change refactors the generated code such that common
values are calculated once.

This is in preparation for moving some of this code to the translator
and reducing the amount of code generated at link time.

Bug: angleproject:3606
Change-Id: Ib180d245218f8f6f18c57c0ea092e8c45cbffd1a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607490
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

ca94d1da

06 Jan, 2021 16 commits

Suppress dEQP.KHR_GLES31/core_vertex_attrib_binding_basicinputcase5 · 46d3f02a

authored Jan 05, 2021

on Vulkan Pixel2 and SwiftShader.

Ignore device and vendor in test config
if we are running on SwiftShader.

Bug: angleproject:5500
Change-Id: Ib07240dfe1c2ae1d6d081ffa389d041d97b22b36
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611309Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

46d3f02a

angle_end2end_tests passes on iOS! · ebf00703

authored Dec 29, 2020

Miscellaneous test skips and fixes for iOS.

Bug: angleproject:5417
Bug: angleproject:5491
Change-Id: Id0785e6243949fc756e4d7923dbbe77a411052f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606656Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>

ebf00703

Use is_apple instead of is_mac and is_ios everywhere · 2762641a

authored Jan 05, 2021

Bug: chromium:1161513
Change-Id: Id7d582f127f4b79ea6fc5b8ad39fff768c45f477
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611312Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

2762641a

Update auto-roller docs with vulkan-deps repo. · 1d6329b3

authored Jan 06, 2021

Bug: angleproject:5390
Change-Id: If5edba51b0fdbaee36e0ab31a176f809b1ace38a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613196Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1d6329b3

Tests: Add FIFA Mobile trace · 56479b06

authored Dec 21, 2020

Test: angle_perftests --gtest_filter=TracePerfTest.Run/*fifa_mobile*
Bug: angleproject:4048
Change-Id: I5cc731ada3ddd9adcb247d7c6f8cf5d823bdc2a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600098Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

56479b06

GL: Add function pointers for EXT/NV_framebuffer_blit · 956a358d

authored Dec 23, 2020

Allow the GL backend to call BlitFramebuffer through these
extensions.

Bug: angleproject:5474
Change-Id: Ic19b0535056c3e2b098dedc60e2eb8da5f862433
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602702
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

956a358d

Roll third_party/vulkan-deps/ b08eace32..cbab63796 (17 commits; 1 trivial rolls) · dc2cf6fc

authored Jan 06, 2021

https://chromium.googlesource.com/vulkan-deps/+log/b08eace32e9c..cbab637962d0

$ git log b08eace32..cbab63796 --date=short --no-merges --format='%ad %ae %s'
2021-01-06 chromium-autoroll Roll SPIRV-Tools from d630e5f8c10c to 37c03859de9e (1 revision)
2021-01-06 chromium-autoroll Roll Vulkan-ValidationLayers from 2468aa9630c2 to 98382948dfea (1 revision)
2021-01-06 chromium-autoroll Roll SPIRV-Tools from 1bb80d2778a3 to d630e5f8c10c (1 revision)
2021-01-06 chromium-autoroll Roll glslang from 9325cc013e3d to f77085c307fc (1 revision)
2021-01-05 chromium-autoroll Roll Vulkan-ValidationLayers from 57255a663ed9 to 2468aa9630c2 (1 revision)
2021-01-05 chromium-autoroll Roll Vulkan-Loader from 1f0c7868a438 to 9ba835885ffe (1 revision)
2021-01-05 chromium-autoroll Roll Vulkan-ValidationLayers from 56a96658b750 to 57255a663ed9 (3 revisions)
2021-01-05 chromium-autoroll Roll Vulkan-Loader from 294480cb7f3e to 1f0c7868a438 (1 revision)
2021-01-05 chromium-autoroll Roll Vulkan-Tools from 7554321b88ae to 4cc0932495ec (2 revisions)
2021-01-05 chromium-autoroll Roll Vulkan-Loader from 66a23ac8c566 to 294480cb7f3e (1 revision)
2021-01-05 chromium-autoroll Roll Vulkan-Headers from 85470b32ad5d to 9efc4a631161 (1 revision)
2021-01-05 chromium-autoroll Roll Vulkan-ValidationLayers from aa076dae88e2 to 56a96658b750 (25 revisions)
2021-01-05 chromium-autoroll Roll glslang from f426f652299d to 9325cc013e3d (1 revision)
2021-01-05 chromium-autoroll Roll SPIRV-Cross from e50f7d1ce8e1 to 7b7a21c4058c (3 revisions)
2021-01-05 chromium-autoroll Roll SPIRV-Tools from 17ffa89097b2 to 1bb80d2778a3 (1 revision)
2020-12-21 jmadill Rolling 8 dependencies

Created with:
roll-dep third_party/vulkan-deps

Bug: angleproject:5390
Change-Id: I6f4a499099211e8990ed038984f41bc5f881c71f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601340
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

dc2cf6fc

Remove "init" from VaryingPacking. · d9669322

authored Dec 30, 2020

Instead we can pass the pack mode and size to the collectAndPack
method. This cleans up the interface and also allows us to merge
two separate code blocks in Program and ProgramPipeline.

Bug: angleproject:5496
Change-Id: I390b5d2e8a3b033374ccc5a250597be1f03dec96
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606531
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

d9669322

Organize VaryingPacking methods. · d33ffb22

authored Dec 30, 2020

This clarifies the difference between "collect" and "pack" methods.
Previously the naming was overlapping between the two. Also makes
the "packUserVaryings" method private.

Refactoring change only. Will enable further improvements for
capturing varyings with multiple shader stages.

Bug: angleproject:5496
Change-Id: I854590ceab39f3a0e7a785516e0d1fd44e4ccc98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606529
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

d33ffb22

Remove ProgramLinkedResources from ProgramExecutable. · 92e7bc89

authored Dec 23, 2020

Instead of storing the entire LinkedResources struct, we can keep it
only for the duration of the linking calls. Refactoring change only.
It sets the stage for more refactoring. This change also switches the
link call to use LinkingState's ProgramLinkedResources directly to
avoid the need to copy the varying packing or use a pointer.

Bug: angleproject:4514
Bug: angleproject:5496
Change-Id: Iefea3c16a33213dc338cc54efaa7c3064ea6ae08
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601403Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

92e7bc89

Capture/Replay: Don't force built-in attribs to have a location · e09e947d

authored Dec 29, 2020

CaptureMidExecutionSetup() hits an assert while capturing "World War
Doh":

  ANGLE   : FATAL: FrameCapture.cpp:2876 (CaptureMidExecutionSetup):
    ! Assert failed [[[...]]] attrib.location != -1

This is due to CaptureMidExecutionSetup() enforcing that all attributes,
including built-ins, have a location. However, in the case of "World War
Doh", the built-in 'gl_GlobalInvocationID' does not have a location.

Moving the assert to after the gl::IsBuiltInName() check allows the
capture to complete without hitting any asserts.

Bug: angleproject:4048
Test: Capture "World War Doh"
Change-Id: Ice96dec629b1477b11a710283c4ec4bf1c95c6e2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606807Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

e09e947d

Vulkan: Remove duplicate shaderType parameter to SPIR-V transformer · bf6cc88a

authored Jan 05, 2021

The passed-in GlslangSpirvOptions already has the shaderType, so this
extra parameter was not necessary.

Bug: angleproject:4524
Change-Id: Ibbc7442b3173b26825f3cb9e2365789fade92cfc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611311Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

bf6cc88a

Roll Chromium from 481852c5d89b to 38610c881952 (120 revisions) · a8b962b7

authored Jan 06, 2021

https://chromium.googlesource.com/chromium/src.git/+log/481852c5d89b..38610c881952

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/505140eae0..65cd1b9efa
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/c83cdcc501..3c84fe5c3f
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6c876045de
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1c129d6fca..77a111142a
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ia2de17b882601cc3c149466df58c8537df335e38
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2612765Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a8b962b7

Roll SwiftShader from ff29e249d317 to b9e179f1f239 (1 revision) · 8ef86071

authored Jan 06, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/ff29e249d317..b9e179f1f239

2021-01-05 capn@google.com Clarify 3-level caching of sampling routines

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I480ec54ea1275dd8f0285dd05aa432dfe30e2219
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2612812Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8ef86071

Organize AST transforms per backend · 382bf288

authored Dec 24, 2020

Most of the AST transforms are written as a workaround to an issue that
affects a single backend.  This change identifies such transforms and
organizes them by backend.  They are then only built if the respective
backend is.

Additionally, about half of the GL transforms are due to mac
workarounds, including the large RewriteRowMajorMatrices transform.
Mac-specific workarounds are additionally only built on said platform.

This change reduces the ANGLE binary size:

- 106KB in a Vulkan-only build on Linux
- 27KB in a GL-only build on Android (60KB on Linux)

Bug: chromium:1084580
Bug: chromium:1161513
Change-Id: I64b334332c0d4f848756c6538af0d8d96864c7e9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601346
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

382bf288

Roll chromium_revision b5dfde1f4d..481852c5d8 (840075:840387) · b590fd1b

authored Jan 05, 2021

Change log: https://chromium.googlesource.com/chromium/src/+log/b5dfde1f4d..481852c5d8
Full diff: https://chromium.googlesource.com/chromium/src/+/b5dfde1f4d..481852c5d8

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc0b854645..505140eae0
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f7473fcfe3..c83cdcc501
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6c876045de
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7316ebd31b..e8d041d679
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bd7d73d146..1c129d6fca
* tools/skia_goldctl/linux: h8KxWs4p5Ox0HAM1_xkOEZT6ctPb1Rfi3qeXr_mmL2YC..CQ5a33Wu9Sm6bRTrd26RFsJVr42IoKD4Ediyp7eyuwwC
* tools/skia_goldctl/mac: LNZgcy3MnDuxTfNU14P35CMe60eSA5owlqW81AdRROIC..AXBg8ZzAzlIdv0U_KR8dr92w1szmAp-MB0Z9ZYBmFy4C
* tools/skia_goldctl/win: uyDrAODdxxnyC-OmE4swqMJGVNnO4tK6XpC4VfbZf-gC..slJNuZyzBI9lNI9Uje1a2fiVtubv8LEBgUZLFdHZjssC
DEPS diff: https://chromium.googlesource.com/chromium/src/+/b5dfde1f4d..481852c5d8/DEPS

No update to Clang.

TBR=ynovikov@chromium.org,
BUG=angleproject:4483

Change-Id: If6d8f6765fa8c886f10b69759d1086925bc87847
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611310
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

b590fd1b

05 Jan, 2021 5 commits

Vulkan: Clean up "actual"/"intended" naming. · e91097bf

authored Dec 29, 2020

Clarifies that the GL internal format is an "intended" format
and the Vulkan formats are "actual" formats. This makes all the format
fields use the same consistent naming pattern.

Bug: angleproject:5438
Change-Id: I935a49895109e9e06eae5ef98d5614dfd1128ff8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2605728Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e91097bf

Complete I/O block GLSL tests · 973bd4ba

authored Dec 21, 2020

The tests meant to perform a draw call and validate the correctness of
the shaders.

Bug: angleproject:3580
Change-Id: I3a008d204ae3d7dceb731ba7a815ab54f38c2920
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2599938Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

973bd4ba

Vulkan: Directly capture non-gl_Postion builtins · aff17499

authored Dec 23, 2020

Building on support for transform feedback capture of I/O block members,
this change optimizes capture of builtins other than gl_Position by
directly decorating members of gl_PerVertex. Most importantly, this
allows us to reserve only one varying for transform feedback, instead of
as many builtins there could be (up to 4).

Bug: angleproject:3606
Change-Id: Ie0957802c657ed6c5aac538d92b860582ed6da45
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601072Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

aff17499

Remove tabs from volk.c/h · b6ea6edc

authored Dec 29, 2020

WebKit's SVN continues to abhor tabs.

Bug: angleproject:3439
Change-Id: Ib97fc97c0eb7401f73ea493a7b679f78afc1a8c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606658Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>

b6ea6edc

Roll Chromium from 094b96f7f336 to b5dfde1f4de5 (71 revisions) · 07dea837

authored Jan 05, 2021

https://chromium.googlesource.com/chromium/src.git/+log/094b96f7f336..b5dfde1f4de5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/46adc39ea7..dc0b854645
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/2f17932ea4..f7473fcfe3
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1283870fa3..7316ebd31b
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ib53d1864759822c3338b6be8e442f041eb1a8aeb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2610343Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

07dea837

04 Jan, 2021 1 commit

Roll Chromium from c95903c7ee26 to 094b96f7f336 (125 revisions) · 026a067c

authored Jan 04, 2021

https://chromium.googlesource.com/chromium/src.git/+log/c95903c7ee26..094b96f7f336

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/5e2e476cc1..46adc39ea7
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/84cd1053bd..2f17932ea4
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b
No update to Clang.

Bug: None
Tbr: jonahr@google.com
Change-Id: I89ba42868c659dcf92312baef029f13fec941489
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2609813Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

026a067c

01 Jan, 2021 1 commit

Roll Chromium from 9642fd0da169 to c95903c7ee26 (32 revisions) · bf02c31b

authored Jan 01, 2021

https://chromium.googlesource.com/chromium/src.git/+log/9642fd0da169..c95903c7ee26

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/2f9b06d9ef..5e2e476cc1
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/77dd9d2973..84cd1053bd
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b
No update to Clang.

Bug: None
Tbr: jonahr@google.com
Change-Id: Ib06c560e55e19f3a088cb20a448e5e2646d938eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2608526Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

bf02c31b

31 Dec, 2020 2 commits

Roll SwiftShader from 1cc5b3357d2f to ff29e249d317 (1 revision) · 2cbcb18e

authored Dec 31, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/1cc5b3357d2f..ff29e249d317

2020-12-30 srisser@google.com Add support for Vulkan12Properties

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: Ieec6bb7458ee0764b75ea507e510a19e04f4dfb9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607999Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2cbcb18e

Roll Chromium from 03e3aa54c18c to 9642fd0da169 (135 revisions) · 022b0026

authored Dec 31, 2020

https://chromium.googlesource.com/chromium/src.git/+log/03e3aa54c18c..9642fd0da169

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/1016d674b3..2f9b06d9ef
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/c98004c99f..77dd9d2973
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ea63baff14..78f99e18e9
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b
* tools/skia_goldctl/linux: Ac-h0vLh65FkA8CAYh5B6yg9X0l3cJFf5XCZkVByG1AC..h8KxWs4p5Ox0HAM1_xkOEZT6ctPb1Rfi3qeXr_mmL2YC
* tools/skia_goldctl/mac: NYEeKAWq6p8n1jHl0h3emCE3hdfWkaYbeoEPrnFO5dEC..LNZgcy3MnDuxTfNU14P35CMe60eSA5owlqW81AdRROIC
* tools/skia_goldctl/win: HHMFtoVyIQfQIhJgSOb5RkIHwzApVNZXRtDNjBCx3tEC..uyDrAODdxxnyC-OmE4swqMJGVNnO4tK6XpC4VfbZf-gC
No update to Clang.

Bug: None
Tbr: jonahr@google.com
Change-Id: Ia03ced387f7d03292955339b7b8d073877ddb10a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607780Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

022b0026

30 Dec, 2020 5 commits

Disable null backend on Android · 2ec7d750

authored Dec 30, 2020

This change saves 6.6KB on Android

Bug: angleproject:5490
Bug: chromium:1161513
Change-Id: I14636694ed7bff61accfac934fbbf6f619d2f6b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606528
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

2ec7d750

iOS sRGB mipmap generation is broken too · 6c608e94

authored Dec 29, 2020

Enable the encodeAndDecodeSRGBForGenerateMipmap workaround for iOS.

Bug: angleproject:5417
Change-Id: I39d9e7c371f0ee5ec5119669f3b855251691f9e2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606657Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>

6c608e94

GL: Expose NV_framebuffer_blit for ES2 contexts when available · fb35201a

authored Dec 22, 2020

ANGLE_framebuffer_blit is already exposed but has restrictions on
scaling/flipping and mismatched color buffer formats. When
NV_framebuffer_blit, EXT_framebuffer_blit, or an ES3 context is
available we can expose a less restrictive BlitFramebuffer.

Bug: angleproject:5474
Bug: chromium:1157057
Change-Id: I916ee39c8d6120216f91461080eb3ee9ca777e29
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601165
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

fb35201a

Roll Chromium from aba6331a18cb to 03e3aa54c18c (163 revisions) · 93839986

authored Dec 30, 2020

https://chromium.googlesource.com/chromium/src.git/+log/aba6331a18cb..03e3aa54c18c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/7dcf5f0e82..1016d674b3
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/767dddd781..c98004c99f
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b
No update to Clang.

Bug: None
Tbr: jonahr@google.com
Change-Id: I48bc7af0fc75d2c76ead9205ad34421c239e3b95
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606402Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

93839986

Make sure the queried resources are active · de62b251

authored Dec 29, 2020

In GLES 3.1 spec, sesion 7.3.1 program interfaces, it says that
'Resources referenced in shader code are considered active unless the
compiler and linker can conclusively determine that they have no
observable effect on the results produced by the executable code of the
program.'. Variables might be considered inactive if they are used only
in computations of temporary variables having no effect on any shader
output. So we should use atomicCounterIncrement instead of atomicCounter
in case the resources are marked as inactive on some platforms.

Bug: angleproject:5494
Change-Id: Ic04bd4a2936e97776fc680b5ef8273f0944d7480
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2605917Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

de62b251

29 Dec, 2020 4 commits

Add build flags to disable desktop gl backend · 47ee6a7b

authored Dec 23, 2020

This change saves about 100KB on Android

Bug: angleproject:5490
Change-Id: Ieca0e597423f74a917197f381560af5409a9e874
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601341Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>

47ee6a7b

Vulkan: Make shader variable info maps a class. · 093250e0

authored Dec 23, 2020

Instead of using a map type directly we abstract the info maps into an
encapsulated class. We can enforce a specific API set instead of using
the same API as the map class. This also cleans up a few of the APIs
related to these maps.

This change will allow future changes to the way the variables are
stored in the class without drastically changing the interface.

Bug: angleproject:3572
Bug: angleproject:4524
Change-Id: Ic1a63e1776c39f49b895a1274bae8282d7a6b9b5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600080
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

093250e0

[GLX] Don't request exposure events for child windows · c2847bbc

authored Dec 23, 2020

After [1], Chrome and ANGLE use separate X11 connections, so in order
for Chrome to receive exposure events, it must select for them its own
connection, which is done in [2].

The events selected by ANGLE's connection are never dispatched, so
they queue up indefinitely and leak until the connection is closed
(when happens when Chrome closes).  This change removes the request
to receive exposure events.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2492177
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2602441

Change-Id: Ie47c3700855aeeecc8efa1b379df60c344b1b70a
Bug: chromium:1158170
R=jonahr
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602705Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

c2847bbc

Roll Chromium from e02e8b371308 to aba6331a18cb (134 revisions) · 095fd1d3

authored Dec 29, 2020

https://chromium.googlesource.com/chromium/src.git/+log/e02e8b371308..aba6331a18cb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/ffd4756efa..7dcf5f0e82
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/cba08c42d7..767dddd781
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b
No update to Clang.

Bug: None
Tbr: jonahr@google.com
Change-Id: I1aafc49da55631bc5ade1dc673a5ac50015bc3bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2605988Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

095fd1d3

28 Dec, 2020 2 commits

Allow Drawing with Immutable Persistent Mapped Buffers · 220642a9

authored Dec 16, 2020

From the EXT_buffer_storage overview:

    The GL_EXT_texture_storage extension added immutable storage for
    texture objects (and was subsequently incorporated into OpenGL ES
    3.0). This extension further applies the concept of immutable
    storage to buffer objects.

    [T]his extension introduces the concept of persistent client
    mappings of buffer objects, which allow clients to retain pointers
    to a buffer's data store returned as the result of a mapping, and to
    issue drawing commands while those mappings are in place.

The initial implementation of EXT_buffer_storage didn't enable this
portion of the extension, so ANGLE is generating errors while attempting
to draw with an immutable buffer mapped with the GL_MAP_PERSISTENT_BIT
flag.

This CL enables that functionality, since apps (e.g., FIFA Soccer) rely
on it.

Bug: angleproject:5473
Change-Id: Icf1c0597156044a342aac5e4d2abbc29b34f46b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2596957Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

220642a9

Roll Chromium from abaaee149813 to e02e8b371308 (106 revisions) · bc06d145

authored Dec 28, 2020

https://chromium.googlesource.com/chromium/src.git/+log/abaaee149813..e02e8b371308

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/ff0b5c1349..ffd4756efa
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ea9f1f7375..2277272f7a
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/38dfc9d41a..cba08c42d7
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b
No update to Clang.

Bug: None
Tbr: ynovikov@google.com
Change-Id: Idbdd8032cf051b2f5b8f33af16338be8d36b43e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2604769Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

bc06d145