Commits · e5c2e047eea2afb41c23b61c3fa058eed2446c7a · Chen Yisong / angle

18 Dec, 2019 2 commits

Roll third_party/vulkan-tools/src 0c2618b2c31e..9c5719ab7149 (1 commits) · e5c2e047

authored Dec 18, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/0c2618b2c31e..9c5719ab7149

git log 0c2618b2c31e..9c5719ab7149 --date=short --first-parent --format='%ad %ae %s'
2019-12-17 charles@lunarg.com vulkaninfo: safely handle device groups not supported

Created with:
  gclient setdep -r third_party/vulkan-tools/src@9c5719ab7149

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: Idca41eac95939e072b5e9317ffbfbcce57646ff6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1973466Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e5c2e047

Update with official gl.xml and re-sort added formats · 751e7888

authored Dec 16, 2019

Use latest Khronos gl.xml file and re-sort format
enums that angle had already added to this file

Bug: angleproject:4093
Change-Id: Ic5c1abc2a79fec14f3c53856a429c9b2489e3275
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972199
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

751e7888

17 Dec, 2019 12 commits

Vulkan: Update expectations for newly-passing tests · c3f833f3

authored Dec 17, 2019

Bug: angleproject:4101
Bug: angleproject:4105
Change-Id: Ida462f69660a55e13b48ebea22ffc2a6b6bfe867
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972202Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

c3f833f3

Vulkan: Fix layers being disabled in tests. · 17217c6e

authored Dec 17, 2019

The ANGLE_ENABLE_VULKAN_VALIDATION_LAYERS_BY_DEFAULT define shouldn't
be being checked in tests. Enable the debug layers by default.

Bug: angleproject:4227
Bug: angleproject:4229
Change-Id: I9717cb1c611ebd585a5c03ba2057036e1b086001
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972497
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

17217c6e

Pass GLImplFactory to Query constructor. · d205ee3a

authored Dec 16, 2019

This makes the code more consistent and allows for the Query
constructor to generate a Serial.

Bug: angleproject:4223
Change-Id: I6cc683b11ed364f13d303f97aa0984e63260953e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969061Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d205ee3a

Vulkan:Lazily link libvulkan · 545c6142

authored Dec 17, 2019

Move libvulkan to a data_dep as we no longer statically
link it.

Bug: angleproject:4225
Change-Id: I96458d4727d2d47d8c259ec51d91fd852067c059
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1972192
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

545c6142

Move Serial utils to their own file. · d50151d3

authored Dec 17, 2019

This will let the front-end access them without pulling in the rest
of renderer_utils. The Serial class in particular will be useful for
capture/replay.

Also adds a very minimal unit test.

Bug: angleproject:4223
Change-Id: I9e63b8a8227a245b20a8f024b960fcf60c7840db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954611
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

d50151d3

Make Sync constructors take GLImplFactory. · e60d05b2

authored Dec 17, 2019

Makes them consistent with the rest of the code. Will allow
the Sync class to call methods in GLImplFactory to generate
a resource Serial.

Also updates the unit test to the new design.

Bug: angleproject:4223
Change-Id: Ic5ba69c3a6a51d4b51d876c3b5e7eb7bc44a9ae8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969060
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

e60d05b2

Vulkan: Enable inactive SSBO with unsized array tests · 44722daa

authored Dec 06, 2019

The change introduced in
https://chromium-review.googlesource.com/c/angle/angle/+/1951523
removes inactive shader interface declarations.  That automatically
resolves an issue where glslang wrapper doesn't handle inactive SSBO
declarations with unsized arrays, by removing those declarations at
translation time altogether.

Bug: angleproject:3714
Change-Id: I710d59546d716bfb5bc0112b5152fed20a810a52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954615
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

44722daa

Vulkan: Fix SwiftShader disabled build. · 7e19e25e

authored Dec 16, 2019

Disabling SwiftShader in the GN build led to a compile error
when trying to use ANGLE_VK_SWIFTSHADER_ICD_JSON.

Bug: angleproject:4223
Change-Id: I076a88e6bc58adf1e34bbb7286b1f46028cd021a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969059
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

7e19e25e

Vulkan: EXT_gpu_shader5: non-const offset in textureGatherOffset · d674e1e5

authored Dec 12, 2019

This change includes preparatory work for textureGatherOffsets as well,
though that requires special handling which is addressed in a follow-up
change. This special handling is due to the fact that this family of
functions is the only built-in with an array parameter, and our built-in
table generation doesn't handle it correctly.

Bug: angleproject:3569
Change-Id: Ic1c8dd03878a184be00f578ab9fc42af8f6e47ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965435Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

d674e1e5

Improve presubmit's Bug: tag check · 634ee434

authored Dec 16, 2019

Specifying the project name is now mandatory. This helps avoid
accidentally referring to chromium bugs by forgetting the project name.
At the same time, it ensures the project name is not misspelled.

Bug: angleproject:4184
Change-Id: I6bbfe1751e2fd0baf424be38018374cce360df5d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969067Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

634ee434

Vulkan: fix handling of inactive atomic counters · a5dd3888

authored Dec 04, 2019

The translator emulates atomic counters with a storage buffer array
during translation to Vulkan GLSL.  Glslang wrapper then should assign
set/binding to this buffer.  However, if the atomic counters are
actually unused in the shader, this assignment is never done.

This change adds a small tree transformation for Vulkan that removes any
uniform or interface block declaration that's not active.  In
particular, this makes atomic counter emulation a no-op if no atomic
counters are used.  It also has the benefit of not requiring glslang
wrapper to remove such inactive resources.

Bug: angleproject:4190
Change-Id: I286c199854ec2379558ad1ec48b4d2c4bf5544d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1951523
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

a5dd3888

Roll third_party/spirv-tools/src 96354f5047bf..38d7fbaad0a3 (2 commits) · 0c14e233

authored Dec 17, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/96354f5047bf..38d7fbaad0a3


Created with:
  gclient setdep -r third_party/spirv-tools/src@38d7fbaad0a3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I81d302d7aaf865489f50fa722791efdb5fbb6a05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1971254Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0c14e233

16 Dec, 2019 11 commits

Re-land "Add new test runner harness." (#2) · 5407aaa0

authored Dec 16, 2019

Re-land #2 changes:

 * export labels are fixed for the CFI build
 * crash test disabled because of flakiness and issues with asan

Re-land changes:

 * Unit test is suppressed in ASAN
 * --deqp-case is fixed
 * Debug layer errors should correctly work with failure expectations

Original message:

The ANGLE test harness is a harness around GoogleTest that provides
functionality similar to the Chromium test harness. It supports:

 * splitting a test set into shards
 * catching and reporting crashes and timeouts
 * outputting to the Chromium JSON test results format
 * multi-process execution

Unit tests are added in test_utils_unittest.cpp.

Bug: angleproject:3162
Bug: chromium:1030192
Change-Id: I71d66a407ea0e53d73cbe75b5b4bfb9e73791534
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965091
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

5407aaa0

Vulkan: Add test that logs supported texture formats · 5cfab195

authored Oct 28, 2019

Add a whitebox test to log all supported GLES formats
for the active Vulkan ICD. The test object is
dependent on libANGLE's gl_enum_util.* files as
we need it to print out human readable values in
the PrintAllFormatSupport test.

Test: angle_white_box_tests --gtest_filter=*PrintAllSupportedFormats*
Bug: angleproject:4093
Change-Id: I99d74935b705b2984f6320ed80a0e977c8fcd4be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1930607
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

5cfab195

GN: Make new angle_test_utils target. · 9190f49c

authored Dec 16, 2019

This source set target lets other targets import the test utils without
needing to export them. They get built into angle_util. They also get
compiled into the various tests and samples. The change also fixes
export issues.

Moves some of the GN logic into the util/ subfolder.

Bug: angleproject:3162
Bug: chromium:1030192
Change-Id: If99d201092ad8541c0de60b3bd893ac9b5875270
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1968259Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9190f49c

Adds missing extensions to registry_xml.py · 390c4952

authored Dec 10, 2019

Bug: angleproject:4093
Change-Id: I979b54e12c1e897ccfa116f332bf9146dcd00cae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965644
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

390c4952

Vulkan: Fix failed assert when unbinding texture · ce41a43c

authored Dec 16, 2019

We were hitting onImageStateChange with no texture active and hitting
the assert in that function for needing a texture.
There are times when we call onImageStateChange where there is no
texture bound, early exit in those cases.

Test:
  angle_deqp_khr_gles31_tests --user-angle=swiftshader --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_image2D_layout_binding_imageLoad_*
  also:
  --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_atomic_uint_layout_binding_atomic_ComputeShader
  --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_buffer_layout_binding_atomicAdd_ComputeShader
  --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_block_layout_binding_block_ComputeShader
  --gtest_filter=dEQP.KHR_GLES31/core_layout_binding_sampler2D_layout_binding_texture_ComputeShader

Bug: angleproject:4124
Change-Id: I027cf4ecb6a5d6aea874c306bf3e67b95a75af62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965027
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

ce41a43c

Vulkan: Use volk to load vk* func ptrs · 5fd73782

authored Aug 09, 2019

Thanks to Jamie Madill for some fixes to get all CI test passing w/ volk.

This change updates all ANGLE targets that use Vulkan to dyanmically
link all of the VK entrypoints using the volk OSS library from
https://github.com/zeux/volk.

It's only two source files so baking them directly into ANGLE repo.
Also it's used in both the tests and libANGLE trees so added to
src/common/third_party/volk dir.

Updated volk and the renderer to track latest instance and device
that were loaded and renderer will refresh vk* function pointers if
the current and previous device and/or instance don't match. This
prevents errors in the test framework as we transition between
backends, especially between VK HW & SwiftShader ICDs.

This change rolls the Vulkan Loader forward to use the latest loader
version which no longer allows static linking but requires dynamic
linking.

Bug: angleproject:3740
Bug: angleproject:4092
Bug: angleproject:4162
Bug: angleproject:4210
Bug: angleproject:4225
Change-Id: I8a0b7d24c9545bbfdfaa4b9357a9bfe6793e0140
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965640
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5fd73782

Added enums to InternalFormat and PixelType groups in gl.xml · 2eeb980e

authored Dec 10, 2019

Bug: angleproject:4093
Change-Id: Ib69f0553f79d0e5dfbcc9165ad71a42be3e6d55d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965643
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

2eeb980e

Validate uniform location size, fix unlink cleanup · 06cbb283

authored Dec 11, 2019

Also cleanup shader storage blocks.

Test: angle_deqp_khr_gles31_tests --use-angle=swiftshader --gtest_filter=dEQP.KHR_GLES31/core_explicit_uniform_location_uniform*

Bug: angleproject:4132
Bug: angleproject:4217
Change-Id: Ie0375ab9226f3f49cb0c0d208ac08f99d98dad8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1963139Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

06cbb283

Roll third_party/SwiftShader ebb0bec91552..fbbfeb700295 (2 commits) · 8f619682

authored Dec 16, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/ebb0bec91552..fbbfeb700295

git log ebb0bec91552..fbbfeb700295 --date=short --first-parent --format='%ad %ae %s'
2019-12-13 chrisforbes@google.com Add missing source file to android build
2019-12-13 swiftshader.regress@gmail.com Regres: Update test lists @ ebb0bec9

Created with:
  gclient setdep -r third_party/SwiftShader@fbbfeb700295

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: I93e47bb372477b074173951ded4f0af35269e206
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969219Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8f619682

Roll third_party/vulkan-tools/src c1a7421f0f93..0c2618b2c31e (1 commits) · d5914d97

authored Dec 16, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/c1a7421f0f93..0c2618b2c31e

git log c1a7421f0f93..0c2618b2c31e --date=short --first-parent --format='%ad %ae %s'
2019-12-13 jeremyk@lunarg.com build: Update glslang version in known_good.json

Created with:
  gclient setdep -r third_party/vulkan-tools/src@0c2618b2c31e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: Iaddfe799d5fb0e3e444eea4cc3cf4a3852be7f1c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969218Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d5914d97

Roll third_party/vulkan-validation-layers/src d2c3daeb56e9..2b19f3916726 (10 commits) · 14820b1e

authored Dec 16, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d2c3daeb56e9..2b19f3916726

git log d2c3daeb56e9..2b19f3916726 --date=short --first-parent --format='%ad %ae %s'
2019-12-13 mark@lunarg.com tests: Add tests for DescTemplates fixes and new VUIDs
2019-12-13 mark@lunarg.com objlifetimes: Fix CreateDescUpdateTemplates object val
2019-12-13 mark@lunarg.com build: Update glslang & VulkanTools known-good IDs
2019-12-13 geecandrey@gmail.com corechecks: Invalid error message in vkCmdPipelineBarrier
2019-12-13 mark@lunarg.com tests: Add positive test for tooling ext query
2019-12-13 mark@lunarg.com chassis: Support tooling queries in khronos layer
2019-12-13 mark@lunarg.com chassis: Add physicaldevice support for tools info API
2019-12-13 mark@lunarg.com stateless: Update for new struct_type_array case
2019-12-13 mark@lunarg.com chassis: Implement GetPhysicalDeviceProcAddr layer func
2019-12-13 jeremyk@lunarg.com layers: Fix issue 1416

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@2b19f3916726

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: Idadb73efcc3bdf73f0dfd41d4f1793eb93e3b0b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969220Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

14820b1e

15 Dec, 2019 1 commit

Metal: support OES_depth_texture · d1860ea1

authored Nov 19, 2019

Also added Depth32 & Depth16 texture data upload tests.

Bug: angleproject:2634
Change-Id: I103f1cda1dc915f0dc8b04f7aaa2d8c0f9220cda
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919281
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d1860ea1

14 Dec, 2019 4 commits

Metal: Fix glDisable(GL_DEPTH_TEST) didn't disable depth write · 75875885

authored Nov 20, 2019

Per standard glDisable(GL_DEPTH_TEST) will disable depth write
also regardless of the value of glDepthMask()

Tests done:
- dEQP.GLES2/functional_fragment_ops_depth_stencil_stencil_*_no_depth

Bug: angleproject:2634
Change-Id: I3b101b8c0b3060f5ddbb18d3f97d7d6889cdec01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966184
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

75875885

Metal: Update spirv-cross from upstream to fix mat2 issues · 5245de82

authored Nov 20, 2019

Previously spirv-cross had problems translate mat2 to equivalent
Metal type. See the reported issue:
https://github.com/KhronosGroup/SPIRV-Cross/issues/1200

It has been fixed on upstream repo.
DEQP tests using mat2 should pass now.

Bug: angleproject:2634
Change-Id: I68e871965c7004ae34dc0fa92c926905cb0c14cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966183
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5245de82

Vulkan: remove unnecessary transition of external images · 92ba377f

authored Dec 10, 2019

Since semaphore has been supported, the code for changing
external texture layout and queue family is not necessary
anymore. So remove them.

Bug: angleproject:3289
Change-Id: I5470fa4bf7db7ee4c68f157674cf907a8e455d75
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1964655
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>

92ba377f

[Fuchsia] Update FIDL library target names in ANGLE · 7718c952

authored Dec 13, 2019

The SDK has renamed some targets, so update to the new names.

Bug: chromium:1033597
Change-Id: Id346f5fb0094e4b71f8ec3b8c302eaa362529c06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1967958
Commit-Queue: Michael Spang <spang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7718c952

13 Dec, 2019 10 commits

Vulkan: Refactor glslang wrapper's varying location assignment · 8b74bdc2

authored Dec 10, 2019

Instead of multiple ifs that test for various combination of shader
stages and calling AssignVaryingLocations for the appropriate pairs,
that function loops over all stages and assigns a location to the
varying in any stage it is active.

This change will help keep this code simpler with the introduction of
tessellation shaders.

Bug: angleproject:3571
Change-Id: Iaf3ee67990bd219080314237b314bd2770a43085
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961096Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

8b74bdc2

Restructure textureGatherOffset* builtin declarations · 19868b7e

authored Dec 13, 2019

This is in preparation of textureGatherOffsets support.

Bug: angleproject:3569
Change-Id: I4ce5a1e102790181c8f843735961b9c249a69221
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965720Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

19868b7e

Vulkan: Have the translator output in/out qualifiers · b8e056dd

authored Dec 11, 2019

Currently, when assigning varying locations, we assign in/out qualifiers
based on whether the varying name is present between different shader
stages.

This is broken for separate shader objects as there is possibly no pair
of shaders to be able to tell which is input and which is output (by
trying to find the same varying in a stage before or after the shader).

Bug: angleproject:3571
Change-Id: Id928a3eaa16e917c81bae0b3414c41842eb2b664
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961993
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

b8e056dd

Validate that image array indices are constant · e181f2f7

authored Dec 10, 2019

Also adds compiler tests for dynamic indexing of SSBOs and images.

Bug: angleproject:3569
Change-Id: I84b90813840ffad5a9a3cd8e7f12bd637a57b327
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1961095Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

e181f2f7

Fix GGP build · bf47a17e

authored Dec 13, 2019

Bug: angleproject:4221
Change-Id: I625b78795dbc826d176660e47af9b51d3f8d417b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966410Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

bf47a17e

Roll third_party/vulkan-validation-layers/src 6a35bc9967d9..d2c3daeb56e9 (3 commits) · e1822727

authored Dec 13, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6a35bc9967d9..d2c3daeb56e9

git log 6a35bc9967d9..d2c3daeb56e9 --date=short --first-parent --format='%ad %ae %s'
2019-12-12 jzulauf@lunarg.com layers: Improve const shared pointer handling
2019-12-12 mark@lunarg.com corechecks: Correct swapchain validation error text
2019-12-12 tony@lunarg.com gpu: Add validation for VK_KHR_buffer_device_address

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@d2c3daeb56e9

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: Iafb69556fd7a48e7df8e1f08d8f38fd23a659f9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966026Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e1822727

Roll third_party/SwiftShader 07958d452f93..ebb0bec91552 (4 commits) · f139f976

authored Dec 13, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/07958d452f93..ebb0bec91552

git log 07958d452f93..ebb0bec91552 --date=short --first-parent --format='%ad %ae %s'
2019-12-12 sergeyu@chromium.org Use allocateExecutable() in LLVMReactor
2019-12-12 sugoi@google.com Fix BCn related SwANGLE test failure
2019-12-12 capn@google.com Prevent clang-format from splitting shift operator
2019-12-12 sugoi@google.com Support for BC1, BC2, BC3, BC4 and BC5

Created with:
  gclient setdep -r third_party/SwiftShader@ebb0bec91552

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: If0eb478a35cabd6c09007f70a75dad0757749605
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966024Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f139f976

Roll third_party/spirv-tools/src 5c019b5923c1..96354f5047bf (1 commits) · 06db147e

authored Dec 13, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5c019b5923c1..96354f5047bf


Created with:
  gclient setdep -r third_party/spirv-tools/src@96354f5047bf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: Ia02eda3a904131e1efa5f401e6259e09bf9848a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966023Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

06db147e

Roll third_party/glslang/src 6c479796f6e4..ebf634bcaa3e (1 commits) · ef11f849

authored Dec 13, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6c479796f6e4..ebf634bcaa3e


Created with:
  gclient setdep -r third_party/glslang/src@ebf634bcaa3e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: ianelliot@google.com
Change-Id: I5d36e291b54c1d57688e413a9b8e6a794b15277f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1966025Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ef11f849

Add flag to label captures · 1d77542f

authored Dec 03, 2019

Add an optional parameter (ANGLE_CAPTURE_LABEL) to
ANGLE frame capture that tags files and functions
uniquely, allowing multiple frame captures to be
replayed by a test harness.

Example:

  ANGLE_CAPTURE_LABEL=foo

Results in filenames like this:

  foo_capture_context1.cpp
  foo_capture_context1.h
  foo_capture_context1_files.txt
  foo_capture_context1_frame000.angledata
  foo_capture_context1_frame000.cpp
  foo_capture_context1_frame001.angledata
  foo_capture_context1_frame001.cpp
  ...

Functions wrapped in namespaces like this:

  namespace foo
  {
      void ReplayContext1Frame0();
      void ReplayContext1Frame1();
  }

For use like this:

  foo::SetupContext1Replay();
  for (...)
  {
      foo::ReplayContext1Frame(i);
  }

Bug: angleproject:3630
Change-Id: Ibe27dc4d40a36606ee40678a9e4d43b5a4baf976
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1949603
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

1d77542f