Commits · e70f6aa679dd72eca5c88c71b0932928e92d6067 · Chen Yisong / angle

28 Oct, 2020 1 commit

ANGLE_platform_angle_device_context_volatile_* extensions · e70f6aa6

authored Oct 19, 2020

Change from Kimmo Kinnunen downstream:
https://bugs.webkit.org/show_bug.cgi?id=216106

Add two extensions for EAGL and CGL backends to declare the
underlying platform context being "volatile". It means that
the thread-global current context is being modified behind
ANGLE. If ANGLE context is marked volatile for a particular
API, it will sync the underlying context for every EGL
function that needs the context. Most intuitive use is
for the client to call eglMakeCurrent before calling any
gl function if the client knowns the platform state might
be dirty.

Implement eglReleaseThread for EAGL and CGL backends.
Releasing thread will unset the platform current context.

Fix a bug of omitting EGL_ANGLE_device_eagl from being
advertised.

Bug: angleproject:5104
Change-Id: I1ec98ad35bc0caada23556ae8697fdef20f65b1a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2486548
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

e70f6aa6

27 Oct, 2020 13 commits

Enable debug-util markers with an env var/property · 45881ab3

authored Oct 26, 2020

Enable the Vulkan debug-util markers by setting the
ANGLE_ENABLE_DEBUG_MARKERS" environment variable to any 1+-character
value.  On Android, this is set with the "debug.angle.markers" Android
property.

Bug: b/170249632
Change-Id: I66503fac71397c59cc641dd903faad152e0ec449
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2500186Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

45881ab3

Vulkan: Remove VVL warning suppression for push constants · 94900b69

authored Oct 24, 2020

Bug: angleproject:5191
Change-Id: Ic4a64ad0bf4cdf6b3ed8677dd45ee940d0da30d9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2496245Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

94900b69

Capture/Replay: Move exported data to start of header. · 78c5b83d

authored Oct 27, 2020

This will make scripts have an easier time parsing metadata.

Bug: angleproject:5134
Change-Id: I4ee32374c8d54d8f91e7f5b8c69b4085e43d1832
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2500601Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

78c5b83d

Fix extension requirement for "World of Tanks". · 85782968

authored Oct 27, 2020

GL_EXT_disjoint_timer_query was missing the "GL_".

Bug: b/171446929
Change-Id: I6e11f18bfa3da18efc65691a94a6290fbcf16777
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2502309Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

85782968

Roll SPIRV-Tools from abe2eff36f3c to 34ae8a475754 (1 revision) · e875208d

authored Oct 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/abe2eff36f3c..34ae8a475754

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: Ie6ba5047b5d7975b38c0e9058da2d186f3bffb8e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2501725Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e875208d

Roll Vulkan-Loader from 91ce213a1d88 to 8e2b7d03ccfd (2 revisions) · 2acbd48a

authored Oct 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/91ce213a1d88..8e2b7d03ccfd

2020-10-27 xantares09@hotmail.com tests: Use cmake -E copy instead of xcopy
2020-10-26 cstout@google.com Add support for VK_FUCHSIA_imagepipe_surface

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I0475510ebb49568e0a79402b9342206c7e4bfa63
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2501724Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2acbd48a

Roll SwiftShader from bb66fa41a163 to c1839ee3cedd (1 revision) · 6ddecb94

authored Oct 27, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/bb66fa41a163..c1839ee3cedd

2020-10-26 amaiorano@google.com Apply google3 upstream fixes for latest LLVM

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I7f9e9e5d025230e67d5814905f8faa91a0e0cca1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2501726Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

6ddecb94

Roll glslang from 3b334b2b8e1a to 740ae9f60b00 (1 revision) · c1f0b62b

authored Oct 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3b334b2b8e1a..740ae9f60b00

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I31033e9ebc1ebb8fe129a77b1e8da007f41eaf47
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2501723Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c1f0b62b

Refactor uniform block test cases · 59df1545

authored Oct 21, 2020

The patch refactors cases that test a uniform block only containing
a large array member, which will be translated to StructuredBuffer
on D3D backend.

Bug: angleproject:3682
Change-Id: I3170a4c82896ce8895909db87c70b80656300383
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2489482
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>

59df1545

Increase MAX_UNIFORM_BUFFER_BINDINGS to 72 · bd966253

authored Oct 22, 2020

This is the minimum Vulkan limit.

Bug: angleproject:5212
Change-Id: I627a1446434c7abc2f53525cb71cb40a4927461c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2491937Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

bd966253

Vulkan: Initial emulated prerotation support · b0db7cca

authored Oct 23, 2020

This is currently only supported for end2end tests (those which use
ANGLETestBase, excluding those that use WithNoFixture) and Vulkan.  Use
WithEmulatedPreoration(*_VULKAN(), degree) where degree is either 90,
180 or 270.

With emulated prerotation, the window dimensions are physically swapped
if 90 and 270 degrees, while the width and height is still reported as
requested by the test.  In the Vulkan backend, the width and height are
swapped after getting queried from the surface, and prerotation is
assumed.

Bug: angleproject:4901
Change-Id: I294436be4c7015d2a63463c4d61de7b67f38c95d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495544
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

b0db7cca

Roll Chromium from 5f7e3cf264a2 to e56348f0e1a6 (434 revisions) · 04294e68

authored Oct 27, 2020

https://chromium.googlesource.com/chromium/src.git/+log/5f7e3cf264a2..e56348f0e1a6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/6da208edba..929bcdbb5f
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4be464e050..98881a1297
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3a9713b0fd..eb50e105b7
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4f6c1bb419
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7371bff096..cf34aa637c
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9fb31b93b1..d259f028e6
* tools/skia_goldctl/linux: STGouE9nmPhPvUv1KVauwIovsjIba4yq1HobYOsm2moC..rALC7IKLCr-2-9WUqGWz2IrPRRzQggKc8OVxFYyzFSIC
* tools/skia_goldctl/mac: zglqXfuaXqShJjRK_8fR8Fo2N-hczeJASDUh4Vy2s4gC..8gYcmJrEd6YDf04LEGeNfEk7A2KHXEEMWeovQZ5gTE0C
* tools/skia_goldctl/win: uchtgU5o7fKP3pU3wO7xE_MCNW7vkUEfaG4V2ehVOv4C..SzWAsWkD4L0lMv-gdLIdN18zHBh_mkAxsGDyzRNwwsgC
No update to Clang.

Bug: angleproject:5221,angleproject:5222,angleproject:5223,angleproject:5224,angleproject:5225,angleproject:5226,angleproject:5227
Tbr: geofflang@google.com
Change-Id: I034a1111afcfb59fcd5cecbcba33f00b603bdf52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2500474Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

04294e68

Use 4 colors in Checkered test shader · 9a47fe71

authored Oct 26, 2020

This shader previously output red and green in a checkered pattern (with
four regions).  This makes it hard to verify that the output is not
rotated / flipped.

This change makes the shader output:

    +--------+--------+
    |  red   |  blue  |
    +--------+--------+
    | green  | yellow |
    +--------+--------+

Bug: angleproject:4901
Change-Id: I02723306dec17d1419f11d9f76e96b1cefc3bf06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2498261Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

9a47fe71

26 Oct, 2020 16 commits

BinaryStream: Preserve 64-bit integer data. · 98c5ff6b

authored Oct 25, 2020

Previously the code would truncate 64-bit data to fit in 32-bits.
This ran into a serialization bug when expanding a 64-bit mask.
The new blend state masks for extended range were out of range for
the 32-bit promotion that was happening before.

Also refactors how we capture bools and enums to be more consistent.

size_t is now correctly saved and loaded as 64-bits.

Bug: angleproject:5247
Change-Id: I452a98c1b0add4c0cf45493032e9310e7d8321b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497561Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

98c5ff6b

Vulkan: Fix exposure requirements for EXT_texture_format_sRGB_override · 5cbf54da

authored Oct 18, 2020

Previously we were not checking for the correct format support
to expose this extension. This change fixes that, and disables
the extension if we do not support the formats we need for our
implementation to function. This also adds an end2end test to
check each possible format that can be used with this extension.

Update GLES major version to 3 for TextureSampling perf benchmark

Bug: angleproject:4561
Change-Id: Ic81bb28f02f9f36e1bc83a8eea376169de9e7735
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2359482Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

5cbf54da

Capture/Replay Tests: Expand suppressions. · 1c53df78

authored Oct 26, 2020

Updates the suppression list to include Linux tests and other new
failures. Also sort the test list output to make it more readable.

Bug: angleproject:5134
Change-Id: I38b5d95ceab3270d1cab13e3fb3c19d3137d10dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497568Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1c53df78

Vulkan: Add OES_shader_multisample_interpolation support · 5d0458fa

authored Oct 23, 2020

Support OES_shader_multisample_interpolation extension if
maxInterpolationOffset >= 0.5

Bug: angleproject:3589
Tests: dEQP-GLES31.functional.shaders.multisample_interpolation.*
       dEQP-GLES31.functional.state_query.multisample_interpolation.*
Change-Id: I42997f10be82e3be8b63c56833cbbf791bf4be9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2477905
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

5d0458fa

Capture/Replay: Test improvements. · 5c4c37dc

authored Oct 25, 2020

Streamlines some arguments.
Use a common subdirectory in out/.
Show process name when logging.
Clean up environment variable handling.

Bug: angleproject:5247
Change-Id: I85eb5b8194a64f90691c4d03db3ee65c5e9b2313
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497560Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

5c4c37dc

Roll Vulkan-ValidationLayers from 7d11021098f2 to 03f6ffd1dc46 (27 revisions) · 218a939e

authored Oct 26, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7d11021098f2..03f6ffd1dc46

2020-10-22 s.fricke@samsung.com layers: Label copy2 00212
2020-10-22 s.fricke@samsung.com tests: Check clearAttachment implict VUs
2020-10-22 s.fricke@samsung.com layers: Remove redundant implicit check
2020-10-22 locke@lunarg.com layers: Pref improvement
2020-10-22 locke@lunarg.com layers: Bug fixed
2020-10-21 locke@lunarg.com tests: VerifyDynamicStateSettingCommands
2020-10-21 locke@lunarg.com layers: VUID 02859
2020-10-21 locke@lunarg.com tests: Test Vertex Binding
2020-10-21 locke@lunarg.com layers: VUID-02721
2020-10-20 jbauman@google.com Revert "layers: Fix wrong if statement"
2020-10-20 locke@lunarg.com tests: Remove VUID-02686
2020-10-20 locke@lunarg.com layers: Remove VUID-02686
2020-10-20 s.fricke@samsung.com layers: Label VUID 04477
2020-10-20 s.fricke@samsung.com layers: Improve ValidateCmdQueueFlags message
2020-10-20 s.fricke@samsung.com tests: Remove clang 10 warning for string copy
2020-10-20 locke@lunarg.com tests: Push constant update
2020-10-20 locke@lunarg.com layers: VUID-vkCmdDraw-None-02698
2020-10-19 mark@lunarg.com stateless: Changed bool checks from warnings to errors
2020-10-19 jleger@qti.qualcomm.com layers: Remove unneeded validation checks
2020-10-17 locke@lunarg.com tests: Fixed 02686 bug
2020-10-17 locke@lunarg.com layers: Fixed 02686 bug
2020-10-16 mail@maltekliemann.com build: Fix Vulkan header/registry detection for SDK
2020-10-16 mark@lunarg.com corechecks: Fix QueryPoolIndex bug and remove query func
2020-10-16 mark@lunarg.com test: Added tests for QueryPoolResults VUIDs
2020-10-16 mark@lunarg.com layers: Added some QueryPoolResults VUID checks
2020-10-16 mark@lunarg.com tests: Add multiViewport/ViewportWithCount positive test
2020-10-16 mark@lunarg.com stateless: Account for DynStateWithCount for multiViewport

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC geofflang@google.com,syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com,syoussefi@google.com
Change-Id: I3a54b8d0e0bef06297a04f90001343dbc4f7fe10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2499261Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

218a939e

GL: Use ANGLE_GL_TRY for draw calls. · a12072ca

authored Apr 03, 2020

Bug: angleproject:3020
Change-Id: Id3ff1828a9a63f4efe6e85dc938a22dc6a782a88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2135926Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

a12072ca

Output nullptr pointer parameters correctly. · 5dafe107

authored Oct 25, 2020

Fix by piping all pointer value parameter output to const
void *, which has a custom handler.

This fixes a case where non-void pointers were being output
as (nil) or other values. Fixes the Capture/Replay tests for
many cases.

Bug: angleproject:5249
Change-Id: I20c9e605d9c5a36e36e7a3d6c753a4e0de94ac4c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497563
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

5dafe107

Re-enable crash testing in angle_unittests. · 21add124

authored Oct 25, 2020

This is an experimental test to see if this works now.
Disabled on Win/ASAN because of conflicts with the
crash callback.

Bug: angleproject:5239
Change-Id: I280b18ab8846de79b561f26716df9ba374cfd9a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2496040Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

21add124

Fix uninitialize state in ProgramState. · d6d07359

authored Oct 25, 2020

The variable mLocationsUsedForXfbExtension was never initialized
which would give it an undefined value for the lifetime of a
Program. This was causing the capture replay tests to be very
flaky.

Bug: angleproject:5248
Change-Id: Id8d61b88fb2ca2c6340acfe9d6e3720378528987
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497562Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d6d07359

Roll SPIRV-Tools from 69f07da41b3b to abe2eff36f3c (3 revisions) · dd2b644a

authored Oct 26, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/69f07da41b3b..abe2eff36f3c

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I542d49c1c7327849f25f8d0cd5d35dc20986cecb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2498124Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

dd2b644a

Roll SwiftShader from 8012e62471be to bb66fa41a163 (3 revisions) · b5ba6933

authored Oct 26, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/8012e62471be..bb66fa41a163

2020-10-24 amaiorano@google.com LLVMJIT: fix asserts in latest LLVM
2020-10-24 capn@google.com Support MemorySanitizer builds with CMake
2020-10-23 srisser@google.com Implement VK_KHR_shader_subgroup_extended_types

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: Id7a486cea4f2bfed1766d952ccad394389f53cba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2498125Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b5ba6933

Roll Chromium from 4787c9ad2595 to 5f7e3cf264a2 (303 revisions) · 08c34aef

authored Oct 26, 2020

https://chromium.googlesource.com/chromium/src.git/+log/4787c9ad2595..5f7e3cf264a2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/41d615a966..6da208edba
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/36edd70447..3a9713b0fd
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/fde3620a8a..d24a1910b9
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7874beb5c5
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/151bbd685f..7371bff096
No update to Clang.

Bug: None
Tbr: jonahr@google.com
Change-Id: Ic50fa1ff5494279e23ff70a55a692bf6040e436b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2498005Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

08c34aef

Tests: Add Fate/Grand Order trace · 0cec8f74

authored Oct 23, 2020

TBR: jmadill@chromium.org,courtneygo@google.com
Test: angle_perftests --gtest_filter="*fate_grand_order*"
Bug: b/171582504
Change-Id: I09b421ee5a245474ed1c797e9049a2f379d8dc11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495542Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

0cec8f74

Tests: Add Dragon Ball Legends trace · 29ca7186

authored Oct 25, 2020

TBR: jmadill@chromium.org,courtneygo@google.com
Test: angle_perftests --gtest_filter="*dragon_ball_legends*"
Bug: b/171652453
Change-Id: I668232f3a1e7ca9663f481fb4246b44fb9333b4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497104
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

29ca7186

Tests: Add World of Tanks Blitz trace · 258f17d6

authored Oct 23, 2020

Test: angle_perftests --gtest_filter="*world_of_tanks_blitz*"
Bug: b/171446929
Change-Id: I028bfde50baa583f1ff7bf30ad77fe40026c7ca7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495486
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

258f17d6

25 Oct, 2020 7 commits

Revert "Vulkan: Make DescriptorPoolHelper a Resource" · 9e3eec54

authored Oct 25, 2020

This reverts commit 5dcd29a6.

Reason for revert: Breaking the ANGLE -> Chromium roller:

https://chromium-review.googlesource.com/c/chromium/src/+/2496281

Original change's description:
> Vulkan: Make DescriptorPoolHelper a Resource
>
> Descriptor pools need to live as long as the descriptor sets that are
> allocated from them. Using Serials while building a command to judge a
> pool's lifetime is prone to errors, since a command's Serial value
> isn't known until the command is submitted, leading to deleting pools
> too early relative to when the descriptor set is actually used.
>
> This CL updates DescriptorPoolHelper to inherit from Resource, so the
> descriptor pools can be retain()'ed. This allows the Resource's counter
> to indicate that a pool is in use until the command's Serial is known
> and can be recorded to indicate when the command completes. This
> prevents descriptor pools from being destroyed before the command
> completes (while the descriptor sets are still in use), or even before
> the command has been submitted. Destroying a descriptor pool resets all
> of the descriptors that were allocated from it, which can trigger a
> variety of VVL errors depending on when it's erroneously performed.
>
> This CL also adds the necessary retain() calls for the descriptor pools.
> In particular, the pools need to be retained each time a cached
> descriptor set that was allocated from it is re-used. This is relatively
> simple with the current design, since we always clear the descriptor set
> caches whenever a new pool is allocated, so the descriptor pool binding
> is always accurate.
>
> Bug: angleproject:5030
> Test: MultithreadingTest::MultiContextDrawSmallDescriptorPools()
> Change-Id: I5fdeeb46159448dfd679d7169e423048348be5ab
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2437609
> Commit-Queue: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

TBR=courtneygo@google.com,timvp@google.com,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:5030
Change-Id: I0fd6d9a0e1b0989b22368ef98652281288699deb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497222
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

9e3eec54

Skip flaky tests on Win7/NVIDIA/GLES. · 2d6b6026

authored Oct 25, 2020

CopyTextureVariationsTest.CopyTexture/ES2_OpenGLES__AToRGBFlipYUnmultiplyAlpha
CopyTextureTest.CopyOutsideMipmap/ES2_OpenGLES

Bug: angleproject:5246
Change-Id: I388df27c690d2a082741f2018690bf2fa24a7594
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497224Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2d6b6026

Adjust TestSuite test timeout values. · 4968245c

authored Oct 25, 2020

This should prevent flakiness in this test.

Bug: angleproject:5245
Change-Id: I841de2cee093ea04b35763314f0a4f5497bcf778
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497223Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

4968245c

Re-land "Link C++ histogram support into angle_perftests." · acd15cae

authored Oct 11, 2020

This is the first step in uploading histogram data instead of a gtest
special format. We  importing several new libraries:

- tools/protoc_wrapper
- third_party/protobuf
- third_party/catapult (was already used for Android)

No functional change. Only affects compilation. Protobuf support is
disabled when not available.

Bug: angleproject:5161
Change-Id: I64be0977648993b1012ff0d9e0439c5876697e36
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497221Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

acd15cae

Metal: Fix 2D array texture's robust resource init · 6422d3b4

authored Oct 25, 2020

2D array texture's robust resource init didn't work due to
mtl::InitializeTextureContents() expects one slice at a time, however
TextureMtl::initializeContents() created entire layers index via
GetZeroLevelIndex() before passing to mtl::InitializeTextureContents().
Fixed by changing to GetLayerMipIndex() instead.

Bug: angleproject:2634
Change-Id: Ie8d80d927a987c2b393d913fda8288b6e06e97d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494527Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>

6422d3b4

Metal: Implement sampler object & shadow compare mode · 9ff58e26

authored Sep 27, 2020

Note: GL_TEXTURE_COMPARE_MODE=GL_NONE is not supported on shadow sampler
for now.

Bug: angleproject:2634
Change-Id: I470bad6322e78ef1408e4334e1e778821df7cbf1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2433332
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

9ff58e26

Check for precision match of uniforms only if there is static use · f037cdc4

authored Oct 23, 2020

There are legacy apps that have uniforms declared with
different precisions across shaders. There is some wiggle
room in the ESSL spec to accommodate such cases as long as
the uniforms are not statically used in shaders. We choose
this lenient interpretation since it allows for more apps
to be compatible with ANGLE.

This change allows BADLANDS to progress past a black screen.

Bug: angleproject:4971
Tests: angle_end2end_tests
           --gtest_filter=GLSLTest_ES31.UniformPrecisionMatchValidation*
Change-Id: Icdd2056c8415803eb34f2840b0758e1acf53c23a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495493
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

f037cdc4

24 Oct, 2020 3 commits

Expand Mac XFB suppression. · 23c12db2

authored Oct 24, 2020

TransformFeedbackTest.RecordAndDraw/ES3_OpenGL

Bug: angleproject:4992
Change-Id: I42118bba63e32901c3213f9a4ac5b87f2ab209f0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495698Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

23c12db2

Suppress failing Windows 7 test. · 9990a814

authored Oct 24, 2020

ClearTestES3.ScissoredClearHeterogeneousAttachments/ES3_D3D11

Bug: angleproject:5237
Change-Id: I3f3c062e23d77b4621df13ea75f7910ed22ab983
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2496144Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9990a814

Disable timing out Vulkan GLES 1 test. · 259d14e5

authored Oct 24, 2020

This test is timing out on a Windows 7 config.

Test: GLES1ConformanceTest.AmbLight/ES1_Vulkan
Bug: angleproject:5234
Change-Id: I4c3ccdeb58d793952aaa44d4902dedf7ce192ec3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2496142Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

259d14e5