If we update the texture data between two dispatch calls, ReadPixels can't
get right result after the second dispatch call. The failure reason is
that after the first dispatch, ReadPixels will sync framebufer state which
will update color render target. Finally, TextureD3D::ensureRenderTarget
is reached. However, we are in compute pipeline.
mTexStorage->isRenderTarget() will be false. That results the current
texture will create a new render target storage. But the UAV is still
bound with the previous texture storage. If there is no texture dirty bit
between these two dispatch calls, applyTexturesForCompute won't be called.
After the second dispatch, readPixels will read data from the new texture
storage which is not updated.

Bug: angleproject:3015

Change-Id: Ib2494ab8bf6e12faefc0a7370719d383526c36ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1390710Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

Mac OPENGL/AMD dEQP test suppressions were being ignored because in
SystemInfo the activeGPUIndex was used when the primaryGPUIndex should
have been used.

Bug: angleproject:3373
Change-Id: I2664049b956bf8903c6d7094ec27646766e7ce16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565056
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

The test claimed to be drawing an hourglass followed by a square.  That
is:

    ----
     \/
     /\
    ----

followed by:

    ----
    |  |
    |  |
    ----

With the end result being:

    ----
    |\/|
    |/\|
    ----

However, in reality it was drawing two hour glasses with the same
result.  That is:

    ----
     \/
     /\
    ----

followed by:

    |\/|
    |/\|

Bug: angleproject:3361
Change-Id: I59a2930f78e6e448b6ccb2e5f70c73ff0f15a2ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1561650
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Related to:
https://chromium-review.googlesource.com/c/angle/angle/+/1520988
The program uniform buffers were dirtied for this edge case, but it
should have been the driver uniform buffers. This CL fixes this and adds
a tests case which catches this.

Bug: 945903
Change-Id: I6142771e200513ed0251fc97cec68d371d39ec1a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565059
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shrek Shao <shrekshao@google.com>

Similarly to how the subImage calls were corrected. glTexImage and the
family of related functions apply to a single texture target. This
means we need a different TexImage call for each cube face. This is
distinct from TexStorage calls which take a Cube map directly.

Note this is mostly a refactoring change. But it does increase code
consistency and should allow for more efficient code reuse.

Bug: angleproject:3356
Change-Id: I252f8983cdda3a8f0223c44cbbe8d8e2dd319a88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558673
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

BUG=angleproject:1944

Change-Id: I17becf44a86969c0929e51b548cf90220027fb75
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565060
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/98b3f26c2f1f..102e430a88db


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@102e430a88db

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: I367824273259bd2a34cce14d89d67354496b9c15
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1567286Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

The Khronos conformance tests only test configs that have the conformant
bit set. ANGLE is currently targetting OpenGL ES 2.0 conformance, so this
change is setting the EGL_OPENGL_ES2_BIT bit to indicate this.

ES 2.0 conformance reporting is being restricted by
ANGLE_VULKAN_CONFORMANT_CONFIGS_ONLY for official builds, but ES 3.0
conformance will be reported for builds without
ANGLE_VULKAN_CONFORMANT_CONFIGS_ONLY enabled.

Bug: angleproject:3374
Test: CQ Dry Run
Change-Id: Ie31f63c3ea3b7bddfceec80ebc28f079ffd363df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564717Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

Vulkan natively supports non power-of-two textures so indicate
that support for front-end.

Bug: angle-project:3239
Test: angle_deqp_gles2_tests --gtest_filter=dEQP.GLES2/functional_texture_completeness_2d_npot_t_repeat --use-angle=vulkan
Change-Id: Id9058b6e9afd1d43e5d74612f808ce39beafd35f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1561963
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:3356
Change-Id: I9831b2035bc1e887c6d5a68a444e69e2bf5aa60a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565055
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

* prints lines for total, passed, failed, not supported, skipped, and
  exception results.
* prints unexpected passed and failed tests each individually using the
  dEQP name of the test.
* moves skipped test detection into the test loop. skipped tests will
  now print a message that they've been skipped.

Bug: angleproject:3369
Change-Id: Idbfc0154a658eda3f52b5bfd30fbff0860a00133
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1561970Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This will allow mac_angle_rel_ng and linux_angle_rel_ng to be removed.

Bug: chromium:822310
Change-Id: I259f84c195ed4cfde17a441bf13d812a477537d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565053Reviewed-by: Jamie Madill <jmadill@chromium.org>

Also adds a test contributed by jgilbert@mozilla.com.

Bug: angleproject:3375
Change-Id: Ibd52daa074bf53b2b213193ccf5a612705a89c67
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565052Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The docs are based on an internal google document available at
go/vangle-line-rasterization. The link won't work for non-Googlers.

Also cleans up the format of the markdown file somewhat.

Bug: angleproject:3344
Change-Id: Ic466c44099e25f12b9afc4565bbd0fe37097af9f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1561969Reviewed-by: Kenneth Russell <kbr@chromium.org>

The two-pass approach first uses ANGLE's shader translator followed by
glslang. The doc explains it in more detail with links.

Bug: angleproject:3345
Change-Id: I04fd31993e3cd62ac409f2696e18f7ec39e5c6ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1560252Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

functional.shaders.builtin_functions.uniform.findLSBMinusOne.highp_compute
on D3D11

Bug: angleproject:2619
Change-Id: Ia7a83429d03b871967d2d6c5ecd3ce82111b98fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565427Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

The ESSL 1.00 spec states "...the extension directives must occur before
any non-preprocessor tokens." This change makes the occurance of an
extension directive after non-preprocessor tokens a compilation error.

Bug: angleproject:3285
Change-Id: I9f8631366151c92fb6d8b4408596917012d9a3e9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565411Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>

They're  enabled via the chromium_code config already these days.
No intended behavior change.

Bug: chromium:926235,chromium:428099

Change-Id: I6927d6e3ec85f40454da61969d7a22dfabef1bde
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564781Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/82ebbbba15c2..98b3f26c2f1f


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@98b3f26c2f1f

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: I6b754fbe2656eca4ceb730919a47206fb7eb5b60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565771Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Texture "types" are the same as texture "targets" except for cube maps.
Cube map targets specify a single face. Cube map types specify a whole
cube map. The subImage functions should take a target instead of a
type. We were using both in different places. This CL corrects all uses
in subImage calls to "target". It also adds a helper for getting a
target texture from a target. And clarifies the naming of the texture
query methods.

Bug: angleproject:3356
Change-Id: I06eb5c5666eec9b8934becf2ba57a066d5cdabde
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558672
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Flaky on Win NVIDIA D3D11

Bug: angleproject:3359
Change-Id: I56a0e4266f1cd0913852a43852666dee055a8e00
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564562Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This partially reverts the following change:

60ec8f576 Vulkan: break dependency to the depthClamp feature

The feature is no longer necessary, and simplifies the usage of
utility shaders.

Bug: angleproject:2361
Change-Id: I1e87ac8d2517c5a3b50e3d0cddd55c852e0e3e7d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1555313
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

At this point, every clear is done through render pass loadOp, except
masked color or stencil clears.  The only fallback is clearWithDraw,
that can clear both color and stencil at the same time.

Bug: angleproject:2361
Change-Id: I805fc12475e832ad2f573f665cdfeb766e61a6d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553740
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

Follow up to c02ef98f.

Bug: angleproject:2546
Change-Id: Ibad7befc5bed95544c0cf15a79d25b47ec8a00bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564710Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:3371
Change-Id: I7601e6b658835b9c948acab98491f5bd01ea9497
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1562517Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

3. Remove gpu_info.h and gpu_info.cc and use ANGLE's own gpu_info_util to to
gather device info instead.
- Support collecting info for and parsing expectations of specific Android
devices such as Nexus 5X and Pixel 2.
- Change parser behavior to more closely follow:
bit.ly/chromium-test-list-format

Bug: angleproject:2677
Change-Id: I4c0b9342142b718e884484a6bcaac2dff3ac575a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553822
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:3364
Change-Id: I51dd45cfcd1c548266712b71eac0dca60574e69e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558960
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:1944
Change-Id: I06e613f002d390e85faadc9bec903e83fdd9fdec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1560596Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Few GLES3 expectations were updated in preparation for running those
tests on the bots (one change on Linux, a handful on Android).

A number of EGL tests were discovered to crash on Android.  They are
suppressed as well.  Note that most of these tests were previously
marked as failing or flaky on the GLES backend as well, and they are
marked as SKIP everywhere instead.

Bug: angleproject:2341
Bug: angleproject:2546
Bug: angleproject:2950
Bug: angleproject:3186
Change-Id: If52d5faeea994c8b6200b713b3c2f1b1a1aeff92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1560251
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

If the vulkan driver has support for VK_KHR_external_memory_fd or
VK_KHR_external_semaphore_fd, add the GL versions of these to the vulkan
renderer's extensions.

Bug: angleproject:3289

Change-Id: I7f04b5cf883f93f6ccd579c2b75d6831b854bfd0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1552027
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d90aae9a5a6c..82ebbbba15c2


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@82ebbbba15c2

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: I834daaff382898fee3733d3f05054421b4af6deb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1560892Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

This is to remove the workaround introduced by anglebug.com/2599 since
Nexus 5x devices aren't in the farm anymore and the tests pass on Pixel
devices.

Bug: angleproject:2599
Test: angle_deqp_gles2_tests
Test: angle_end2end_tests
Change-Id: I14f724494909486a2164ddd734a95b6980429f29
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1559202
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: chromium:951049

Change-Id: I4e9e2cfe3c287fcb6e536ec20c20acbfda1d8405
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1559203Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>

Two bugs were present in our implementation. We were using the y offset
for z in ensureSubImageInitialized. And for our D3D back-end we were
potentially reading from the wrong image index.

Bug: chromium:947342
Change-Id: If39671a911e08fcc641b9ba6f5910e3a2c16eb5d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558671
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

There is always only one display that can be associated with a context,
so get*Current*Display is confusing.

Bug: None
Change-Id: Iff3a9fc5ad1154b046bb30d7f46a468802ba7fcc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558958Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Previously, the CPU was throttled to be at most N frames ahead, N being
the number of swapchain images.  N is now fixed to 2, regardless of the
number of swapchain images.  If N < 2, we would be stalling the CPU
unnecessarily, and if N > 2, the CPU could get too far ahead.

Effectively, here is how the throttling plays out with this commit:

Submit (Fence 1) + Present
Submit (Fence 2) + Present
Wait Fence 1
Submit (Fence 3) + Present
Wait Fence 2
Submit (Fence 4) + Present
Wait Fence 3
Submit (Fence 5) + Present
Wait Fence 4
...

Bug: angleproject:2942
Change-Id: I3b8c3bb88e52d62231306ec84aad50d2bf472d8c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558681Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

If TextureImpl sets a local dirty bit and signals gl::Texture of it, the
dirtyness is not propogated to context.  This can result in draw calls
with textures that are not synchronized

BUG=949985

Change-Id: I9baf82c96598265a6a4850f1fd48e213b5e98ab5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1556699
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

The test MipmapTest.TextureCubeGeneralLevelZero/ES2_VULKAN was disabled
for Vulkan Android due to Nexus 5x and Pixel 2 issues.   The Nexus 5x
has been removed from the test infrastructure and the Pixel 2 issue
seems to have sorted itself out.

Bug: angleproject:2817
Test: angle_end2end_tests MipmapTest.TextureCubeGeneralLevelZero/ES2_VULKAN
Change-Id: I85bb56707def2906194c34942fcd74a811255abc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558293Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

As glslang is rolling frequently now, internal shaders frequently
require recompilation.  This change parallelizes shader compilation to
speed up this process.

Bug: angleproject:3333
Change-Id: Icace083559bff73dfb9b5fe7cc2c59ce8137a2dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558680
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This documents the discussion and conclusion on preferring to bake
generated code into the repository.

Bug: angleproject:3333
Change-Id: I1afc338c59d5bcb2a64f843081aba5120820e9ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558676Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>