Commits · eaa759c46fbbe331cbb04ee70babd464fdd02f7a · Chen Yisong / angle

11 May, 2015 4 commits

Remove Texture serials and Texture::INCOMPLETE_TEXTURE_ID. · eaa759c4

authored Apr 02, 2015

Texture serials were not used in any place that pointers could not be used
and Texture::INCOMPLETE_TEXTURE_ID was only referenced by RendererD3D.

This was the last place that serials are used in the gl layer.

BUG=angleproject:681

Change-Id: Iad24321fba57db8ade3c9eb8f04cc20e98ded1b0
Reviewed-on: https://chromium-review.googlesource.com/263659Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

eaa759c4

Move unsupported depth stencil check to FramebufferD3D. · c2520564

authored Apr 29, 2015

BUG=angleproject:885

Change-Id: I0abc674e365d2b5b65d23e2abf741a02a1146cdd
Reviewed-on: https://chromium-review.googlesource.com/268311Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

c2520564

Roll googletest. · 440e5d4f

authored May 08, 2015

This also moves us to the Chromium googletest mirror. It may cause
conflicts with developer setups if they have the folder open when
they try to gclient sync.

BUG=angleproject:997

Change-Id: I94a629c50cb6ea6fc0020e3ec9ee93b7088d964b
Reviewed-on: https://chromium-review.googlesource.com/270108Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

440e5d4f

Optimize Texture binding by only applying referenced textures. · f51bc795

authored May 04, 2015

Update ProgramGL to track which the current values of sampler uniforms so
that only the currently applied texture units have to be bound for the
draw call.

BUG=angleproject:882

Change-Id: I280aa106172b13a5fbb31cdefba27b6691c0a0e4
Reviewed-on: https://chromium-review.googlesource.com/264803Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

f51bc795

08 May, 2015 6 commits

Add GLX EGL implementation stubs · 9477dc94

authored May 06, 2015

BUG=angleproject:892

Change-Id: I1ef1bd0ce60f4585e473f9750c748a1b41c09da2
Reviewed-on: https://chromium-review.googlesource.com/269741Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

9477dc94

Roll dEQP. · d5008157

authored May 08, 2015

BUG=angleproject:998

Change-Id: I35067bd5ed2919f918a1f1b93bef0feb934c838d
Reviewed-on: https://chromium-review.googlesource.com/270120Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

d5008157

Use value-paramaterized tests instead of by type. · fa05f607

authored May 07, 2015

This should fix our non-standard template use, which causes compile
errors for the tests on GCC/Clang.

BUG=angleproject:997

Change-Id: Id1bb15231eda445f37e53a5b33d4684ec6618d8e
Reviewed-on: https://chromium-review.googlesource.com/269858Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

fa05f607

Fix issues with ProgramGL. · 0ca53786

authored May 07, 2015

 * Don't re-create the native GL program every link, some program state should
   persist between re-linking such as bound attribute locations.
 * Forward glBindAttribLocation calls to the ProgramImpl, fixes some chromium
   rendering issues because chromium always binds attribute locations,
   sometimes with gaps.
 * Query the real attrib location before inserting it into the list of attribs.
   It was unsafe to rely on the attrib having the same location as its index
   into the active attributes.

BUG=angleproject:882

Change-Id: If14b4c4c2f5ebcdaa4f7c5a890b9519d6d4e6e43
Reviewed-on: https://chromium-review.googlesource.com/269991Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0ca53786

Use a D3D11 renderer by default, when available. · 98e7d071

authored May 07, 2015

Also update SampleApplication to request the default
renderer instead of explicitely asking for d3d11

BUG=angleproject:892

Change-Id: I70c431b3c1ba78c3ce7844d7f276cc19ac17d7f5
Reviewed-on: https://chromium-review.googlesource.com/269999Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

98e7d071

Fix GetExecutablePath on Linux · 2cf30bd0

authored May 07, 2015

It was using lstat to get the size of /proc/self/exe but
it always returns 0, so we just use a big buffer on the
stack instead.

BUG=angleproject:892

Change-Id: I6d88efeb4ec5de7a78cb3668e3d78520203ad1d5
Reviewed-on: https://chromium-review.googlesource.com/269990Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

2cf30bd0

07 May, 2015 20 commits

Load the blit framebuffer extension entry points. · 0e201cb7

authored May 04, 2015

Change-Id: I654f944aea25661d3fb1e2381b93780771300f32
Reviewed-on: https://chromium-review.googlesource.com/269144Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0e201cb7

eglGetPlatformDisplayEXT: validate device types are set only on d3d · 6db6e0ae

authored May 06, 2015

BUG=angleproject:892

Change-Id: I0fa089f299abaab406384a05b096de19f04f3a5e
Reviewed-on: https://chromium-review.googlesource.com/269771Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/269829

6db6e0ae

EGLSurfaceTest: specify the device type only on d3d platform · 06394f66

authored May 07, 2015

BUG=angleproject:892

Change-Id: If09cf30122d97590f07447147e6d54c2e4157f9e
Reviewed-on: https://chromium-review.googlesource.com/269828Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

06394f66

EGLWindow: specify the device type only on d3d platform · bf9e4050

authored May 06, 2015

BUG=angleproject:892

Change-Id: I0406e26910f5a012ccb9e533af18e831522161b1
Reviewed-on: https://chromium-review.googlesource.com/269666Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/269827

bf9e4050

Make util/win32 follow ANGLE conventions better · ec0b1362

authored May 06, 2015

BUG=angleproject:892

Change-Id: I1ad366e16b135649fe1b0351081f9971db84df50
Reviewed-on: https://chromium-review.googlesource.com/269665Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

ec0b1362

Use stream operators for appending to InfoLog. · f611316b

authored May 07, 2015

Also add a helper class to keep the previous behaviour of
automatically appending a newline after every new message.

BUG=angleproject:992

Change-Id: I0ff5d2846175cf19de7a6af295af24a92451456f
Reviewed-on: https://chromium-review.googlesource.com/268744Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

f611316b

Use a std::stringstream for Program's InfoLog. · 71c3b2c7

authored May 07, 2015

This should help WebKit avoid needing to apply a local patch.
Also clean up the style in this file a bit.

BUG=angleproject:307,angleproject:992

Change-Id: I41ecf7cbfa20b469b3731215ef28cb36253ba186
Reviewed-on: https://chromium-review.googlesource.com/269849Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

71c3b2c7

Add test for HLSL "pow" constant folding bug. · 4052dfc8

authored May 06, 2015

This covers 'pow-of-small-constant-in-user-defined-function' from
the WebGL CTS. Leave disabled until we have a proper fix.

BUG=angleproject:851

Change-Id: I41a4ad9354e32bb2d48894d75676a9dfe226e9d8
Reviewed-on: https://chromium-review.googlesource.com/269747Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

4052dfc8

Revert "EGLWindow: specify the device type only on d3d platform" · 4ea209f1

authored May 07, 2015

Causing failures in EGLSurfaceTest.MakeCurrentTwice on Windows

BUG=angleproject:892

This reverts commit 118e7195.

Change-Id: Ifbb17d1c9bc0390abadbfb8f78cf14dbf1bb8e83
Reviewed-on: https://chromium-review.googlesource.com/269950Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

4ea209f1

Revert "eglGetPlatformDisplayEXT: validate device types are set only on d3d" · 4c825e68

authored May 07, 2015

Depends on patch which is causing a failure in EGLSurfaceTest.MakeCurrentTwice

BUG=None

This reverts commit 0e7ee498.

Change-Id: I7d11900c784bdb2a8963a824e89019b39a184cbe
Reviewed-on: https://chromium-review.googlesource.com/269856Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

4c825e68

EGLWindow: specify the device type only on d3d platform · 118e7195

authored May 06, 2015

BUG=angleproject:892

Change-Id: I2dda3a8d15e58d15a401258a5a64c5783ea1a132
Reviewed-on: https://chromium-review.googlesource.com/269666Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

118e7195

Add a basic support for Linux for utils/ · fe2f3d63

authored May 05, 2015

* Timer and path utils are done.
* Window only implements initialize and setVisible

BUG=angleproject:892

Change-Id: I3f49b68ef9ec5be324b25e211199bac2953ae11e
Reviewed-on: https://chromium-review.googlesource.com/269520Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

fe2f3d63

eglGetPlatformDisplayEXT: validate device types are set only on d3d · 0e7ee498

authored May 06, 2015

Change-Id: I15f0651fbe90b3572ea6b62f804492fbe100e591
Reviewed-on: https://chromium-review.googlesource.com/269771Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

0e7ee498

Revert "Use a std::stringstream for Program's InfoLog." · 3c74e772

authored May 07, 2015

Missing one character for the log length.

BUG=angleproject:307,angleproject:992

This reverts commit 8ae74e11.

Change-Id: Ifb3658c324cb0aa56ee31352a0fc0e6759979f7b
Reviewed-on: https://chromium-review.googlesource.com/269848Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

3c74e772

Sync the generic vertex attribute data. · 27464aa9

authored May 01, 2015

BUG=angleproject:883

Change-Id: If5616bf24c1ac5477ae80cf1d25efa70b62edea1
Reviewed-on: https://chromium-review.googlesource.com/268750Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

27464aa9

Clear cached state when deleting GL objects. · 1eb708e1

authored May 04, 2015

Change-Id: I84eac9b3796858e5e19e26851ad83baa1f9b6af2
Reviewed-on: https://chromium-review.googlesource.com/269142Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1eb708e1

Always sync writemasks and front face. · 716cc88e

authored May 04, 2015

BUG=angleproject:883

Change-Id: Ie1d544c8f30472238d859d8fd7f553a73b066802
Reviewed-on: https://chromium-review.googlesource.com/269145Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

716cc88e

Add support for parsing ESSL3 invariant qualifiers · 37ad4744

authored Apr 27, 2015

The parser recognizes ESSL3 invariant variable declaration syntax and
marks the variables as invariant.

In ESSL3, invariant out variables can be linked to non-invariant
in variables, so linking checks should now be different depending on
shading language version. A shading language version dependent varying
matching check is added to the translator API to facilitate this.

Tested by deqp/data/gles3/shaders/qualification_order.html after patching
Chrome to use the new linking check API.

A previous revision of this change that broke API compatibility was
reverted since it broke Chromium FYI bots. This revision keeps deprecated
API functionality around for now so that changes can be rolled
step-by-step to Chromium without breakage.

TEST=WebGL 2 conformance tests, angle_unittests
BUG=angleproject:987

Change-Id: Iecb64e3afd23e267ba999bc17f44390affcdfc13
Reviewed-on: https://chromium-review.googlesource.com/269940Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

37ad4744

Revert "Add support for parsing ESSL3 invariant qualifiers" · 9e64edce

authored May 07, 2015

Build breaks in GPU FYI bots.

BUG=angleproject:987

This reverts commit 40088793.

Change-Id: Ia88ad302c403c65516c050eb7741316b5097bcfb
Reviewed-on: https://chromium-review.googlesource.com/269847Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

9e64edce

Add support for parsing ESSL3 invariant qualifiers · 40088793

authored Apr 27, 2015

The parser recognizes ESSL3 invariant variable declaration syntax and
marks the variables as invariant.

In ESSL3, invariant out variables can be linked to non-invariant
in variables, so linking checks should now be different depending on
shading language version. The varying matching check in the translator
API is changed to be shading language version dependent to facilitate
this.

Tested by deqp/data/gles3/shaders/qualification_order.html after patching
Chrome to use the new linking check API.

TEST=WebGL 2 conformance tests, angle_unittests
BUG=angleproject:987

Change-Id: I3982feff7380c4dfc647940ee03a020692dd0c59
Reviewed-on: https://chromium-review.googlesource.com/267663Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

40088793

06 May, 2015 7 commits

Add a Buffer::getIndexRange function. · 520c4ae2

authored May 05, 2015

Instead of exposing the index range cache, add a more generic method that
allows the buffers to handle their own caching of index ranges.
BufferImpl::getData can be hard to implement for BufferGL because there
isn't a way to tell the buffer to unmap and glGetBufferSubData can be very
expensive, requiring an extra copy of the data.

BUG=angleproject:881

Change-Id: Idec645219056132e0d72a410fbe7b971fa02c9e9
Reviewed-on: https://chromium-review.googlesource.com/261892Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Geoff Lang <geofflang@chromium.org>

520c4ae2

Move the IndexRangeCache and Range types to the gl namespace. · 831b1953

authored May 05, 2015

BUG=angleproject:881

Change-Id: Ib05149facee9fcc7714cb957ca8647b3498a36b6
Reviewed-on: https://chromium-review.googlesource.com/269254Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

831b1953

Factor GL extension parsing in renderergl_utils.cpp · 94b3a078

authored May 05, 2015

DisplayGLX will use it for the GLX extensions too.

BUG=angleproject:892

Change-Id: I5e4f80776a558fcdcc7e7b83767145112bcfee98
Reviewed-on: https://chromium-review.googlesource.com/269461Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

94b3a078

Track if a non-preprocessor token has been seen and validate #extension with it. · 06e24a7e

authored Apr 27, 2015

Reland: Only report a warning instead of an error.

BUG=angleproject:989
BUG=483252

Change-Id: Ife3e7759cdef6bc0f41cae3c58c307682b608279
Reviewed-on: https://chromium-review.googlesource.com/269404Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

06e24a7e

Make build/gyp_angle executable · 5adf8182

authored May 06, 2015

BUG=angleproject:892

Change-Id: I88c2724150142415cebf9e45e5747fe2c4889c91
Reviewed-on: https://chromium-review.googlesource.com/269760Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

5adf8182

Refactor egl::Surface constructors. · 443e1d9b

authored May 05, 2015

We can reduce the code in these classes quite a bit by calling
the common code in egl::Display.

BUG=angleproject:994

Change-Id: Idf0ffa054fc6a70cf8c65a0b98fd963911715591
Reviewed-on: https://chromium-review.googlesource.com/269258Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

443e1d9b

Update WebGL CTS expectations. · 9ff785ee

authored May 06, 2015

Change-Id: If07442b45d97f259e5a2ebda3dbfee3c11618499
Reviewed-on: https://chromium-review.googlesource.com/269664Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

9ff785ee

05 May, 2015 3 commits

Add missing includes in samples/sample_util/ · cf9dfa49

authored May 04, 2015

BUG=angleproject:892

Change-Id: Ia718306226ce6cfcf91f74947a7775b1439e4fab
Reviewed-on: https://chromium-review.googlesource.com/268995Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

cf9dfa49

Revert "Track if a non-preprocessor token has been seen and validate #extension with it." · 4b6bfe10

authored May 05, 2015

Causing failures in the GLES2 CTS "build", related to extensions.

BUG=483252
BUG=angleproject:989

This reverts commit bbdb9e22.

Change-Id: I3e1ad989af645194c8ee9b9847b2131e289d09e1
Reviewed-on: https://chromium-review.googlesource.com/269403Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

4b6bfe10

Move comments next to their code block in FunctionsGL · fee03501

authored May 05, 2015

BUG=angleproject:892

Change-Id: I7b47e26c81dc91900b17a2062bef0ee10c3290aa
Reviewed-on: https://chromium-review.googlesource.com/269209Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

fee03501