Skip to content

A
angle
Switch branch/tag
  1. 05 Apr, 2021 1 commit
  3. 03 Apr, 2021 2 commits
    • Validate PPO sampler uniforms · 323c5f24
      Tim Van Patten authored 
      "Command & Conquer: Rivals" uses PPOs and was hitting the following
assert:

    angle::Result ContextVk::updateActiveTextures(const gl::Context *context)
    {
    ...
        for (size_t textureUnit : activeTextures)
        {
            gl::Texture *texture        = textures[textureUnit];
            gl::TextureType textureType = textureTypes[textureUnit];
            ASSERT(textureType != gl::TextureType::InvalidEnum);

This is the same assert that is generated by the test
ProgramPipelineTest31.DifferentTextureTypes which is currently being
skipped since it's known to fail.

This CL refactors sampler validation into the ProgramExecutable to allow
PPOs to take advantage of the shared code and behave correctly, since
the necessary data is already copied into the PPO's ProgramExecutable
via ProgramExecutable::updateActiveSamplers(). This also takes advantage
of the subject/observer pattern that's already established between
programs and PPOs to ensure only the PPOs that the program is a part of
are updated when a program's sampler uniforms are updated.

Bug: angleproject:3570
Bug: b/182409935
Test: ProgramPipelineTest31.DifferentTextureTypes
Change-Id: I3d34efd66dc85e7ff23a8422cb14d5f90a5f7085
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2792862
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>
    • Add GL_ANGLE_get_serialized_context_string. · 9b0911a0
      Jamie Madill authored 
      This will provide a front-door entry point where we can get
a serialized string representing the context state. Previously
we would have to call ANGLE internal directly.

This will enable a refactor of the replays to work more like
standalone plugin libraries.

Bug: angleproject:5811
Change-Id: I5a97d7aa3cd70c49199264c2eb7ca953943ac3c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2803391
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>
Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
  5. 02 Apr, 2021 14 commits
  7. 01 Apr, 2021 8 commits
  9. 31 Mar, 2021 12 commits
  11. 30 Mar, 2021 3 commits