Commits · fede5cb664d96da6ea6acc0bc208d32a14431f32 · Chen Yisong / angle

13 Oct, 2019 1 commit

Vulkan: Remove resource destruction layer suppressions. · fede5cb6

authored Oct 12, 2019

Bug: angleproject:3925
Change-Id: Ic2bda7daf67c6fa735c15735dcb60c5f9a203fc0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1857895Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

fede5cb6

12 Oct, 2019 4 commits

Add sampler array index validation for ESSL 3.00 onwards · a2f89c00

authored Oct 12, 2019

In Section 12.30 of the ESSL 3.00 spec on p143-144:

  Indexing of arrays of samplers by constant-index-expressions is
  supported in GLSL ES 1.00. A constant-index-expression is an
  expression formed from constant-expressions and certain loop indices,
  defined for a subset of loop constructs. Should this functionality be
  included in GLSL ES 3.00?

  RESOLUTION: No. Arrays of samplers may only be indexed by constant-
  integral-expressions.

Bug: chromium:985032
Change-Id: Iad9e4b8000b442a6631e1d2295c2670c4a79d486
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1849452
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

a2f89c00

Roll chromium_revision 43eb5958f7..9325340209 (704334:704874) · 130fdbcc

authored Oct 10, 2019

Change log: https://chromium.googlesource.com/chromium/src/+log/43eb5958f7..9325340209
Full diff: https://chromium.googlesource.com/chromium/src/+/43eb5958f7..9325340209

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/fd0d28db80..592281c03c
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/9d2d0dad36..6752fa027a
* third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk.git/+log/5fd29151cf..1785f0ac8e
* third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/cd17fa2abd..f2fb48c3b3
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/6dcdade882..9d3bf3e968
DEPS diff: https://chromium.googlesource.com/chromium/src/+/43eb5958f7..9325340209/DEPS

No update to Clang.

Bug: angleproject:3986
Change-Id: I38b789bea72b140191888ae20e8fff9b892108bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1854681Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

130fdbcc

Add a roll_deps script based on WebRTC. · 1948af38

authored Oct 11, 2019

Should make the process of rolling Chromium DEPS into ANGLE easier.
Eventually we could set up an auto-roller.

Original:

https://webrtc.googlesource.com/src/+/master/tools_webrtc/autoroller/roll_deps.py

Modified to include ANGLE's Chromium DEPS only. We will continue to use
Skia's auto-roller for more one-off DEPS.

Also adds a 'chromium_revision' DEPS custom variable that we could
potentially use for other things like pinning a Chromium version on our
testers.

Sample usage:

python scripts/roll_deps.py -v --clean -i

-v : verbose
--clean : cleans previous roll branch
-i : ignore dirty tree

Bug: angleproject:3986
Change-Id: I7289cf76eb5635a286c20453e846d4ff9a0481b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1852707
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

1948af38

Extend ANGLE_request_extension with DisableExtension · c42da4e5

authored Oct 03, 2019

ARB_texture_rectangle is the only currently supported disablable
extension. This allows us to use ARB_texture_rectangle in WebGL
implementations without exposing it to WebGL user shaders.

Bug: angleproject:3956
Bug: angleproject:3770
Change-Id: I80b10d2e9c9feebe545ce15195721487165ecc51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1838418
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

c42da4e5

11 Oct, 2019 14 commits

Metal implementation pt 1: autogen resources · 25301999

authored Oct 11, 2019

Autogen format table and internal shaders for Metal.

Bug: angleproject:2634
Change-Id: I4d81fcd17a0e9959ba9c38a250acc7abb168f54c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1855067
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

25301999

Vulkan: Support binding texture levels as a rendertarget · d192e933

authored Sep 27, 2019

This CL refactors how TextureVk handles rendertargets.  It removes
the single rendertarget that previously supported 2D, and expands
the layer/level list of rendertargets to handle all cases.

Bug: angleproject:3184
Bug: angleproject:3996
Test: Texture2DTestES3.FramebufferTextureChangingBaselevel/ES3_Vulkan
Test: FramebufferRenderMipmapTest.RenderToMipmap/ES2_Vulkan
Test: FramebufferRenderMipmapTest.RenderToMipmap/ES3_Vulkan
Test: ComputeShaderTest.ImageStoreMipmapSlice/ES3_1_Vulkan
Change-Id: I466d0389cc6744994f88c40cc388fca694b53a99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1854895Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

d192e933

Vulkan:Add support to stage D or S textures · bbf0ce28

authored Oct 11, 2019

Correctly set image aspect for depth or stencil texture staging.
This fixes 6 failing dEQP 3.0 tests and an end2end test.
Note that DS combined aspect textures will need special handling
to read each aspect separately which is not included in this fix.

Bug: angleproject:3949
Change-Id: I8e3f8166bdd31e2c002752b2f5c107ba411b2b0d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1855964
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

bbf0ce28

Vulkan: Update GLES 3.0 expectations files · 741c0aa6

authored Oct 10, 2019

Helping team understand what's still crashing/failing within the 3.0
expectations files.

Bug: angleproject:2950
Change-Id: I63f1d05ae60e34d423fd4b962a79c21ae813e335
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1854015Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

741c0aa6

Vulkan: finishToSerial only if the buffer is in use · 4398b2b6

authored Oct 10, 2019

The call to flushImpl() was conditioned on the buffer
being used but the call to finishToSerial() was outside.
This caused an unconditional wait and unnecessary pipeline
stall. The fix is to make sure to perform a flush and
wait only when the buffer is in use.

Bug: angleproject:3994
Change-Id: I1b297cf11a67f7611d37808cb111d6b52ac16f90
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1854881
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

4398b2b6

Vulkan: Handle 2Darray base/max level change · f912b294

authored Oct 10, 2019

When staging updates to the vkImage based on texture base/max level
change, we weren't properly handling texture 2Darray.

This CL changes several helpers to explicitly accept Vulkan extents
and offsets so it is clear how things should be treated.

Bug: angleproject:3991
Test: dEQP-GLES3.functional.shaders.texture_functions.texturesize.*sampler2darray*
Change-Id: Iae80ce7201180224fc3bb7823f21a360950c515d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1854020Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

f912b294

GL: Missing check for texture format sample counts · a21362f5

authored Oct 10, 2019

ANGLE was hitting an issue running on llvmpipe because llvmpipe doesn't
properly implement texture formats with multisampling, but claims
otherwise to be OpenGL 3.3 compliant. ANGLE did not validate the claim
on the backend, so the frontend was hitting an ASSERT that failed.
This patch makes sure to validate this part of the spec, and limits the
driver to OpenGL 2 if it's not conformant.

Bug: 976382
Change-Id: I6ad6d757e26f90068df83aeb3caf7685aa2f1c07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1853889
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

a21362f5

Roll ./third_party/spirv-tools/src 82f84c4b8f19..feb154921397 (3 commits) · 67486ec2

authored Oct 11, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/82f84c4b8f19..feb154921397


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@feb154921397

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=geofflang@google.com
Change-Id: I634d8c04a62c67f257422f23cb3d8e518db3891b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1854940Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

67486ec2

Roll ./third_party/glslang/src 4b97a1108114..1ff0c181bb37 (1 commits) · 3a1e314b

authored Oct 11, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4b97a1108114..1ff0c181bb37


Created with:
  gclient setdep -r ./third_party/glslang/src@1ff0c181bb37

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=geofflang@google.com
Change-Id: I5eb0a962ce4b62241f604ae17c6494faa01185fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1854939Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

3a1e314b

D3D11: Fix warning that showed up in VS2019. · a5f5e777

authored Oct 10, 2019

Was related to the new D3D11on12 code.

Bug: angleproject:3986
Change-Id: I801b816c620a7307ee5a236856949866a8daf747
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1854720Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

a5f5e777

[Fuchsia] Exclude libvk_swiftshader.so on Fuchsia · 6950a87f

authored Oct 10, 2019

libvk_swiftsahder.so was pulled on web_engine package after swiftshader
was enabled in Angle. We don't need it so it can be excluded.

This is a reland of
https://chromium-review.googlesource.com/c/angle/angle/+/18228630 .

Bug: fuchsia:37278
Change-Id: I4de8c7fe4706104791dfe5fc9b4e021db9f2948b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1854883Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

6950a87f

Vulkan: Prevent Creating ES 3.0 Context if Min. Caps. Not Met · d37992d1

authored Oct 04, 2019

ANGLE should not allow creating an ES 3.0 context if the device's
maxPerStageDescriptorUniformBuffers or maxVertexOutputComponents
values are too low to support the necessary minimums for GLES 3.0.

Bug: angleproject:3938
Test: CQ
Change-Id: I4fce841d1f364c1aef1a883fa5edb64a4b93f08e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1841971Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

d37992d1

Fix the missing global memory barriers · 8896e18e

authored Oct 08, 2019

This adds the transtlations of GL_SHADER_IMAGE_ACCESS_BARRIER_BIT, and
GL_FRAMEBUFEER_BARRIER_BIT to the vulkan backend.

Bug: angleproject:3934
Change-Id: I2bd86a16b461cf7dc01d0d4386f49365a5292446
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1847172
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

8896e18e

Vulkan: Enable GL_OES_EGL_image_external_essl3 · ee08d924

authored Oct 10, 2019

GL_OES_EGL_image_external_essl3 support was added a while back.
This patch just enables it for the Vulkan backend

Bug: angleproject:2668
Test: ./angle_end2end_tests --gtest_filter=ImageTestES3*Vulkan
Change-Id: I6b8b1f63ed6e9faafe668ad9a73fc7fbc9c17670
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1852190
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ee08d924

10 Oct, 2019 13 commits

Use relative paths/hooks in DEPS. · 8ba50490

authored Oct 10, 2019

Should work now that infra changes landed some time ago. Will make it
easier to use an auto-roller for Chromium DEPS.

Bug: angleproject:3986
Change-Id: I73ab20b516c4b9105bb4854549dcadb1892f3de9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1852708
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

8ba50490

Vulkan: Base max renderbuffer size on max framebuffer size · cea73963

authored Oct 10, 2019

maxRenderbufferSize was based on max2DTextureSize, which is
larger in SwiftShader than maxFramebufferX. This was causing
the dEQP-GLES3.functional.shaders.builtin_functions.precision.*
tests to create rendertargets that were too large for what
SwiftShader supports. Adding checks for maxFramebufferX values
on top of the max2DTextureSize check fixes all the tests.

Bug: angleproject:3990
Change-Id: I006d2ddeb0f7e582d6aef88457cfb292efd5a05c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1852709
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

cea73963

Checkout GLES 1.1 conformance from DEPS. · 67a017f4

authored Oct 10, 2019

This follows a pattern in Chromium where they are slowly removing
src-internal and moving to the public DEPS. Also removes the
angle-internal dependency and removes the folder from .gitignore so
developers can clean it up.

Bug: angleproject:3993
Change-Id: I51a169fbff5bf629f03038c0870873cf9f5e3863
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1853888
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

67a017f4

Fix debug layers being disabled everywhere. · 32bee0fd

authored Oct 10, 2019

The define that controlled the debug layer preference was mistakenly
checking a Vulkan define. When the Vulkan define was moved into the
Vulkan back-end then the layers became disabled for all back-ends.

Fix this by using a layered check in the Vulkan back-end and restoring
the asserts enabled check to ShouldUseDebugLayers.

Suppresses some tests that regressed the layers after they were broken.

Bug: angleproject:3987
Bug: angleproject:3991
Change-Id: I6aafcff6d9e19866c2324663ef4d4550e97fcfb8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1852706Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

32bee0fd

Correct presubmit error for missing Bug ID · 4210e49b

authored Oct 10, 2019

Having a Bug ID is not enough to silence this error,
the Bug ID must be on the line directly above the
Change ID line to prevent getting this error.

Bug: angleproject:3992
Change-Id: I90ec1169efb77c1be6a1004e579f16e89115be50
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1853604Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

4210e49b

Update some implementation limits to match modern drivers. · 73872582

authored Oct 10, 2019

Raise the implementation limits for some caps that should not affect
performance and add a logging mode to print when caps have been limited.

Fix missing caps limitation of max texture sizes.

BUG=angleproject:2915

Change-Id: I51bd9544e1e1a9582e2beed61c624ef2b7079e99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1852705Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

73872582

Metal backend skeleton implementation. · d200a77a

authored Oct 10, 2019

Bug: angleproject:2634
Change-Id: I34be82f4a80a6851fecb53a51e069b134d82613a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1849079
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d200a77a

Generate GLES 3.2 entry points · aa292a59

authored Oct 10, 2019

This is a combination of:

- Changing the "scripts/generate_entry_points.py" script to tell it to
  also auto-generate GLES 3.2.  Also changing "scripts/gen_proc_table.py".

- Generating new and modified files needed to add GLES 3.2 to the
  ANGLE front-end.  This is done by running the following command:
  "python scripts/run_code_generation.py".

- Creating the following files:

  - src/libANGLE/validationES32.h
  - src/libANGLE/validationES32.cpp
  - src/libANGLE/capture_gles_3_2_params.cpp

- Hand-editing the following files:

  - src/libGLESv1_CM/libGLESv1_CM.cpp
  - include/GLES2/gl2ext_angle.h
  - src/libGLESv2.gni
  - src/libANGLE/Context.h
  - src/libANGLE/Context.cpp
  - src/libANGLE/Context_gl.cpp
  - src/libANGLE/ErrorStrings.h
  - src/libANGLE/State.h
  - src/libANGLE/validationES1.cpp
  - src/libANGLE/validationGL3.cpp
  - src/libANGLE/validationGL31.cpp
  - src/libANGLE/validationGL32.cpp
  - src/libANGLE/validationGL33.cpp
  - src/libANGLE/validationGL4.cpp
  - src/libANGLE/validationGL43.cpp
  - src/libANGLE/validationGL45.cpp

Bug: angleproject:3649
Change-Id: I5b67f72e3e3b55e74039ec3e28aa8d399ec08cf2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1850231Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

aa292a59

Added PVRTC compression extension needed for Metal on iOS. · 6e653981

authored Oct 09, 2019

Bug: angleproject:2634
Change-Id: I413f754fe5551b1e248bc2b824b327b92d8c70f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1849076
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

6e653981

Roll ./third_party/spirv-tools/src 3c7ff8d4f0a1..82f84c4b8f19 (10 commits) · ad5f7164

authored Oct 10, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3c7ff8d4f0a1..82f84c4b8f19


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@82f84c4b8f19

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=geofflang@google.com
Change-Id: I1a8f90754220f9a42b1eb72c61c2d9fe34933502
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1851685Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ad5f7164

Conditionalize DeviceCGL implementation. · c5e0ac75

authored Oct 09, 2019

Needed in order to build in WebKit.

Bug: angleproject:3973
Tbr: geofflang@chromium.org
Tbr: jmadill@chromium.org
Change-Id: I9818a2f74d07daa4709892c1cfa81670e5f80617
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1851245Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

c5e0ac75

Add D3D11on12 device option · 5d9c4ee3

authored Sep 17, 2019

This CL adds a new D3D11on12 device option which runs the D3D11
API on top of D3D12. This is done to aid in preliminary
investigations into the feasibility of creating a full D3D12
backend implementation.

Bug: angleproject:3919
Change-Id: I0ad4250eb3c93b0b74274c904aac74f03753c7ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1814404
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5d9c4ee3

Fix a warning with VS2019. · d7323cf7

authored Oct 09, 2019

Popped up when testing with the new compiler.

Bug: angleproject:3986
Change-Id: I2c0f838941b133e0d7785f1ba62b5e7d02d89bd4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1849986Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d7323cf7

09 Oct, 2019 8 commits

Roll Chromium DEPS (October 2019). · 9c2df983

authored Oct 09, 2019

Several child repos. In preparation for rolling MSVC 2019 in build/.

Bug: angleproject:3986
Change-Id: I4207b39ab11f84a7b109462606ffa1b76278bfe3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1849977Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9c2df983

Vulkan: Get rid of "TextureVkViews". · 28ff9922

authored Oct 09, 2019

This struct was used to implement different views for stencil mode. It
is replaced with a single stencil mode view for sampling.

We shouldn't be using a stencil-specific view for our render view. In
cases where we're attaching a Depth/Stencil texture to a Framebuffer's
special depth/stencil attachment point we will still need to use a
single 'Draw' view attached to depth/stencil. So there's no need for a
separate 'Draw' view for stencil.

Also there's no current support for a separate 'Fetch' view for
stencil textures. There may not be any easy way to trigger this path as
it's only used in seamful cube map emulation and image copy. Seamful
emulation is ES 2.0 only while stencil textures are ES 3.1 so that's
not a possible use. Image copy doesn't seem to be possible either as it
stands right now.

Bug: angleproject:3975
Change-Id: Ic999f9471ea533d1184a364732c569124aa802bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1842230
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

28ff9922

Partially Revert "Convert DXT1 RGB data to DXT3 RGBA when uploading to the GPU." · 2fa9d734

authored Oct 07, 2019

This reverts commit e6582161.

Remove the DXT1->DXT3 transcoding but leave in the MacOS workarounds for fixing
the alpha channel of DXT1 textures.

BUG=angleproject:3729

Change-Id: Ib276c1e4a58155866da8c661cba2063a4e4304fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1846015Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

2fa9d734

Vulkan: Fix off by one when flushing staged texture updates · 2d5c8d31

authored Oct 08, 2019

When updating ImageHelper::flushStagedUpdates to handle base and
max texture level, we got off by one when deciding if an update
landed in in the range of the current vkImage. When there are 8
mipLevels and we see an update for level 8, that should not be
applied, and should be preserved in updatesToKeep.

Bug: angleproject:3950
Test: MipmapTest.DefineValidExtraLevelAndUseItLater/ES2_Vulkan
Change-Id: I63e0c24f7885f8b0580ce212b531711aebcf0e01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1848933Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

2d5c8d31

Make sure all extension strings start with GL_ · d0cf5579

authored Oct 07, 2019

BUG=angleproject:3974

Change-Id: I01bb5e6f7dec800ac36464a7d64c26998a0b087f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1845473
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d0cf5579

Add ANGLE Platform Metal extension. · 09495f87

authored Oct 09, 2019

EGL_ANGLE_platform_angle_metal is the new extension name.

Bug: angleproject:2634
Change-Id: I6ebffbd4f6d7974bc5ef6d48849e985ee83e9808
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1848793Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

09495f87

GL: Skip buffer validation for transform feedback buffers. · ef4c25e7

authored Oct 08, 2019

Transform feedback buffer state is managed by TransformFeedbackGL, the
state tracked in StateManagerGL is not correct.

BUG=angleproject:3900

Change-Id: I73f7b9b1c8d3b4087e25eb4cf3844faf210793a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1848392Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

ef4c25e7

Add EGL_ANGLE_device_cgl extension. · 8e7d9d6c

authored Oct 04, 2019

Supports querying the CGLContextObj and CGLPixelFormatObj associated
with ANGLE's underlying OpenGL context on macOS.

Minor refactorings to implementation of device attribute queries on
all platforms.

Bug: angleproject:3973
Change-Id: I24341668be4cbfed0b7f2df4c1402df1effe275e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1846733
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

8e7d9d6c