GL allows reads beyond the defined pixel rectangle, although their resultant values are undefined. D3D11 gives an error when reading out-of-bounds, hence clamping the area satisfies both APIs. This fixes a Renderer crash in our ReadPixels out of bounds test, and also fixes the test to test the correct area of pixels. BUG=angle:590 Change-Id: I12439c22d53ec6a2d69e1b8cf80f53e9c18e11f7 Reviewed-on: https://chromium-review.googlesource.com/191080Reviewed-by:Shannon Woods <shannonwoods@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Tested-by:
Jamie Madill <jmadill@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| d3d | Loading commit data... | |
| d3d11 | Loading commit data... | |
| d3d9 | Loading commit data... | |
| BufferStorage.cpp | Loading commit data... | |
| BufferStorage.h | Loading commit data... | |
| FenceImpl.h | Loading commit data... | |
| Image.cpp | Loading commit data... | |
| Image.h | Loading commit data... | |
| IndexBuffer.cpp | Loading commit data... | |
| IndexBuffer.h | Loading commit data... | |
| IndexDataManager.cpp | Loading commit data... | |
| IndexDataManager.h | Loading commit data... | |
| IndexRangeCache.cpp | Loading commit data... | |
| IndexRangeCache.h | Loading commit data... | |
| QueryImpl.h | Loading commit data... | |
| RenderTarget.h | Loading commit data... | |
| Renderer.cpp | Loading commit data... | |
| Renderer.h | Loading commit data... | |
| ShaderExecutable.h | Loading commit data... | |
| SwapChain.h | Loading commit data... | |
| TextureStorage.cpp | Loading commit data... | |
| TextureStorage.h | Loading commit data... | |
| VertexBuffer.cpp | Loading commit data... | |
| VertexBuffer.h | Loading commit data... | |
| VertexDataManager.cpp | Loading commit data... | |
| VertexDataManager.h | Loading commit data... | |
| copyimage.cpp | Loading commit data... | |
| copyimage.h | Loading commit data... | |
| copyvertex.h | Loading commit data... | |
| generatemip.h | Loading commit data... | |
| imageformats.h | Loading commit data... | |
| loadimage.cpp | Loading commit data... | |
| loadimage.h | Loading commit data... | |
| loadimageSSE2.cpp | Loading commit data... | |
| vertexconversion.h | Loading commit data... |