When a valid program is given instead of a shader, an INVALID_OPERATION is returned rather than INVALID_VALUE when a shader related function is called. The reverse happens when a program related function is called and a valid shader program is given to it. This commit also refactors other places that requires a similar check to use the same validation function and error message. BUG=angleproject:1029 dEQP-GLES2.functional.negative_api.state.get_shader_info_log dEQP-GLES2.functional.negative_api.state.get_shader_source dEQP-GLES2.functional.negative_api.state.get_programiv dEQP-GLES2.functional.negative_api.state.get_program_info_log BUG=angleproject:1101 dEQP-GLES3.functional.negative_api.state.get_shader_info_log dEQP-GLES3.functional.negative_api.state.get_shader_source dEQP-GLES3.functional.negative_api.state.get_programiv dEQP-GLES3.functional.negative_api.state.get_program_info_log Change-Id: I707b6ba10da0288128af185ce8dfb906fca0f766 Reviewed-on: https://chromium-review.googlesource.com/298604Reviewed-by:Zhenyao Mo <zmo@chromium.org> Tryjob-Request: Dian Xiang <dianx@google.com> Tested-by:
Dian Xiang <dianx@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| entry_points_egl.cpp | Loading commit data... | |
| entry_points_egl.h | Loading commit data... | |
| entry_points_egl_ext.cpp | Loading commit data... | |
| entry_points_egl_ext.h | Loading commit data... | |
| entry_points_gles_2_0.cpp | Loading commit data... | |
| entry_points_gles_2_0.h | Loading commit data... | |
| entry_points_gles_2_0_ext.cpp | Loading commit data... | |
| entry_points_gles_2_0_ext.h | Loading commit data... | |
| entry_points_gles_3_0.cpp | Loading commit data... | |
| entry_points_gles_3_0.h | Loading commit data... | |
| entry_points_gles_3_0_ext.cpp | Loading commit data... | |
| entry_points_gles_3_0_ext.h | Loading commit data... | |
| global_state.cpp | Loading commit data... | |
| global_state.h | Loading commit data... | |
| libGLESv2.cpp | Loading commit data... | |
| libGLESv2.def | Loading commit data... | |
| libGLESv2.rc | Loading commit data... | |
| resource.h | Loading commit data... |