Commits · 2b835a6f41a53b5e5da1fbc42e5ac3c049398fc8 · Chen Yisong / angle

11 Sep, 2015 5 commits

Call the correct vertex attrib function for stream integer attribs. · 2b835a6f

authored Sep 10, 2015

Fixes tests related to integer attributes in
dEQP-GLES3.functional.shaders.builtin_functions.*

BUG=angleproject:880

Change-Id: I107c5c9fd1adc29f58617fab095374daa74a0da1
Reviewed-on: https://chromium-review.googlesource.com/298970Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

2b835a6f

Implement EGL image classes for the D3D renderers. · 362c0a79

authored Aug 12, 2015

BUG=angleproject:970

Change-Id: I24d393fcd75dd4ee510785e8475b093868701c77
Reviewed-on: https://chromium-review.googlesource.com/295152Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tryjob-Request: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

362c0a79

Re^5-land "Move Uniform and UBO info to the gl::Program layer." · 78d35692

authored Sep 11, 2015

This data was previously stored entirely in the Impl level. Move
as much as possible to the GL level, using a read-only view in the
Impl level. Some information in D3D-specific, and should be stored
separately in the Impl.

This patch has a lot of refactoring that splits the D3D and GL info,
and moves as much validation as possible to the GL layer, where it
is shared between the back-ends.

Re-land with fix for dEQP unused uniforms. The fix involves storing
a local copy of all uniform data in the GL layer. This will also
let us validate sampler indexes during draw calls at the GL layer.

Re-re-land with a fix for multiply defined symbols on Clang.

Re-re-re-land with a fix for boolean uniforms and Uniform{1234}f.

Re^4-land with a fix for boolean uniform arrays and UBO uniforms.

Re^5-land with a fix for a test warning on Linux.

BUG=angleproject:1123
TEST=end2end_tests, bots, dEQP GLES3.ubo and GLES2.uniform_api

Change-Id: I03afcd446d9e74573c4d4c712ed7407b91d8001c
Reviewed-on: https://chromium-review.googlesource.com/299180Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

78d35692

Revert "Re^4-land "Move Uniform and UBO info to the gl::Program layer."" · a2eb02c9

authored Sep 11, 2015

Test has a warning on Linux:

In file included from ../../third_party/angle/src/tests/test_utils/ANGLETest.h:13:
../../testing/gtest/include/gtest/gtest.h:1392:16: error: comparison of integers of different signs: 'const int' and 'const unsigned int' [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
../../testing/gtest/include/gtest/gtest.h:1422:12: note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned int>' requested here
    return CmpHelperEQ(expected_expression, actual_expression, expected,
           ^
../../third_party/angle/src/tests/gl_tests/UniformBufferTest.cpp:357:5: note: in instantiation of function template specialization 'testing::internal::EqHelper<false>::Compare<int, unsigned int>' requested here
    EXPECT_EQ(GL_FLOAT, type);
    ^

BUG=angleproject:1123

This reverts commit 2ae1ee61.

Change-Id: Ic3dabea54068377d1f2c5f722ba52966cf1a0491
Reviewed-on: https://chromium-review.googlesource.com/299170Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

a2eb02c9

Re^4-land "Move Uniform and UBO info to the gl::Program layer." · 2ae1ee61

authored Sep 10, 2015

This data was previously stored entirely in the Impl level. Move
as much as possible to the GL level, using a read-only view in the
Impl level. Some information in D3D-specific, and should be stored
separately in the Impl.

This patch has a lot of refactoring that splits the D3D and GL info,
and moves as much validation as possible to the GL layer, where it
is shared between the back-ends.

Re-land with fix for dEQP unused uniforms. The fix involves storing
a local copy of all uniform data in the GL layer. This will also
let us validate sampler indexes during draw calls at the GL layer.

Re-re-land with a fix for multiply defined symbols on Clang.

Re-re-re-land with a fix for boolean uniforms and Uniform{1234}f.

Re^4-land with a fix for boolean uniform arrays and UBO uniforms.

BUG=angleproject:1123
TEST=end2end_tests, bots, dEQP GLES3.ubo and GLES2.uniform_api

Change-Id: I4c9f5ed31b81380507bef7981f97086d642801ae
Reviewed-on: https://chromium-review.googlesource.com/298451
Tryjob-Request: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

2ae1ee61

10 Sep, 2015 5 commits

Adding in checks for program and shader names to return INVALID_OPERATION · 769769a7

authored Sep 09, 2015

When a valid program is given instead of a shader, an INVALID_OPERATION
is returned rather than INVALID_VALUE when a shader related function is
called. The reverse happens when a program related function is called and
a valid shader program is given to it.

This commit also refactors other places that requires a similar check to
use the same validation function and error message.

BUG=angleproject:1029
dEQP-GLES2.functional.negative_api.state.get_shader_info_log
dEQP-GLES2.functional.negative_api.state.get_shader_source
dEQP-GLES2.functional.negative_api.state.get_programiv
dEQP-GLES2.functional.negative_api.state.get_program_info_log

BUG=angleproject:1101
dEQP-GLES3.functional.negative_api.state.get_shader_info_log
dEQP-GLES3.functional.negative_api.state.get_shader_source
dEQP-GLES3.functional.negative_api.state.get_programiv
dEQP-GLES3.functional.negative_api.state.get_program_info_log

Change-Id: I707b6ba10da0288128af185ce8dfb906fca0f766
Reviewed-on: https://chromium-review.googlesource.com/298604Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tryjob-Request: Dian Xiang <dianx@google.com>
Tested-by: Dian Xiang <dianx@google.com>

769769a7

Work around depth texture sampling differences in GL versions. · e8f47137

authored Sep 09, 2015

ES3 requires that only the red channel has data when sampling from depth
textures while desktop GL treats them as luminance textures.  Set the
swizzle state of the texture to sample 0 from the blue and green channels
in TextureGL.

Passes 75 new tests in dEQP-GLES3.functional.texture.format and
dEQP-GLES3.functional.texture.specification.

BUG=angleproject:884

Change-Id: I863472961dcbbf8af864f5e1d85a4aea41f47bda
Reviewed-on: https://chromium-review.googlesource.com/298481Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

e8f47137

Fix the named parameter for the IndexConversion perftest · 4a693565

authored Sep 10, 2015

It seems that the compiler didn't resolve the overloaded operator<< with
the structure's grandparent structure. Fix it by explicitely casting to
the grandparent before calling operator<<. Also provides slightly more
information on the number of iterations/triangles.

This wasn't caught with local testing as IndexConversion isn't compiled in
angle_perftests on Linux.

BUG=angleproject:1153
BUG=530226

Change-Id: Ifa602eb0728d052bc651f0dd030f9f880c00dc51
Reviewed-on: https://chromium-review.googlesource.com/298860Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

4a693565

Revert "Added support for premultiplied alpha mode for composition swapchains" · 2aa3b436

authored Sep 10, 2015

Unused member warning:

..\..\third_party\angle\src\libANGLE/renderer/d3d/d3d11/NativeWindow.h(68,24) :  error: private field 'mConfig' is not used [-Werror,-Wunused-private-field]
    const egl::Config *mConfig;
                       ^
BUG=None

This reverts commit 98233372.

Change-Id: I8ed41770eb3fe70ab7e32ba9a0860e2c397e22c5
Reviewed-on: https://chromium-review.googlesource.com/298830Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

2aa3b436

Implement a minimal EGL -> CGL backend · 86f8dd7c

authored Aug 12, 2015

This succesfully renders HelloTriangle and some samples but fails on a
lot of tests. In particular it doesn't handle resizing the window and
doesn't have depth or stencil buffers.

BUG=angleproject:891

Change-Id: I16356471b470f764acb38e8dd3589e9c0129829d
Reviewed-on: https://chromium-review.googlesource.com/290770Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

86f8dd7c

09 Sep, 2015 12 commits

Returning INVALID_OPERATION when a valid program is passed to getShaderiv · 5cf466d3

authored Sep 08, 2015

BUG=angleproject:1147

Change-Id: I7f3e77f8f5f55887fe03172eadce78129ffeb10f
Reviewed-on: https://chromium-review.googlesource.com/298064Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tryjob-Request: Dian Xiang <dianx@google.com>
Tested-by: Dian Xiang <dianx@google.com>

5cf466d3

win clang build fix · 54c311fc

authored Sep 09, 2015

BUG=
TEST=win clang bots build

Change-Id: I802be2e72a884e50cf13120d3cd9c76a8f8eb86f
Reviewed-on: https://chromium-review.googlesource.com/298253Tested-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

54c311fc

Support ETC2 texture formats with RendererGL. · 0d8b7247

authored Sep 09, 2015

400 tests in dEQP-GLES3.functional.texture go from unsupported to passing.

BUG=angleproject:884

Change-Id: I51927dffbc5931c7d1b80e72f55c620197736724
Reviewed-on: https://chromium-review.googlesource.com/298484Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0d8b7247

Add LUMA format entries into the tables in formatutilsgl. · df2572c3

authored Sep 09, 2015

BUG=angleproject:884

Change-Id: Ie4f378bc18cda57a91c16832c33f0ddc81f9c105
Reviewed-on: https://chromium-review.googlesource.com/298483Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

df2572c3

Pass the texture unit to TextureGL::syncSamplerState. · a6c95fc6

authored Sep 09, 2015

When syncing the texture's sampler state, make sure the correct texture
unit is active.  When StateManagerGL syncs the textures, it may not set
the active texture if the texture ID has not changed.

BUG=angleproject:884
BUG=angleproject:883
BUG=angleproject:1051

Change-Id: Ib22874c22a12b1b9bd68887ac5a449c507e7bdc6
Reviewed-on: https://chromium-review.googlesource.com/298482Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

a6c95fc6

Don't sync the multisample state in StateManagerGL. · add8d031

authored Sep 09, 2015

GL_MULTISAMPLE is not a real state in GLES but existed for the D3D
renderers to sync the rasterizer state more easily.  Instead of syncing it
in StateManagerGL, rely on the default value of GL_TRUE in Desktop GL.

All tests in dEQP-GLES3.functional.multisample.* now pass.

BUG=angleproject:885
BUG=angleproject:883

Change-Id: Idbe5fbc1b43a6e66008fe87da41601277dbe7311
Reviewed-on: https://chromium-review.googlesource.com/298441Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

add8d031

Revert "Re-re-re-land "Move Uniform and UBO info to the gl::Program layer."" · 61b8dd97

authored Sep 09, 2015

Seems to be failing the dEQP-GLES2.functional.uniform_api tests relating to boolean arrays.

BUG=angleproject:1123

This reverts commit 892a6a4b.

Change-Id: Ifc4ce3ca806ef88a02ac6f693334ac37ce098a88
Reviewed-on: https://chromium-review.googlesource.com/298520Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

61b8dd97

Re-re-re-land "Move Uniform and UBO info to the gl::Program layer." · 892a6a4b

authored Sep 09, 2015

This data was previously stored entirely in the Impl level. Move
as much as possible to the GL level, using a read-only view in the
Impl level. Some information in D3D-specific, and should be stored
separately in the Impl.

This patch has a lot of refactoring that splits the D3D and GL info,
and moves as much validation as possible to the GL layer, where it
is shared between the back-ends.

Re-land with fix for dEQP unused uniforms. The fix involves storing
a local copy of all uniform data in the GL layer. This will also
let us validate sampler indexes during draw calls at the GL layer.

Re-re-land with a fix for multiply defined symbols on Clang.

Re-re-re-land with a fix for boolean uniforms and Uniform{1234}f.

BUG=angleproject:1123
TEST=end2end_tests,Canary WebGL (D3D11/GL), dEQP-GLES2+3.functional.uniform_api

Change-Id: Ia40820a5ce2f34ec2d27648b1dc940a8955e9999
Reviewed-on: https://chromium-review.googlesource.com/298440Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

892a6a4b

Fix compilation on Mac · dd5262eb

authored Sep 08, 2015

BUG=angleproject:891

Change-Id: I2b787778268e8c29f0cf36d91520a04e92208f6f
Reviewed-on: https://chromium-review.googlesource.com/298030Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

dd5262eb

Suppress two failing end2end_tests on Intel. · 0962fc36

authored Sep 09, 2015

The UniformTest suppression we can work around with a patch to handle
GetUniform queries entirely in ANGLE. The suppression for BlendMinMax
is a long-standing failure for an unknown reason.

BUG=angleproject:809

Change-Id: Ib89af1579a74dc5065f169b31307678429724a7c
Reviewed-on: https://chromium-review.googlesource.com/298450Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

0962fc36

Fix preprocessor macro replacement list location · e6432c85

authored Sep 08, 2015

According to the dEQP tests, a macro replacement list generated by a
function-like macro invocation should get its location from the closing
parenthesis of the invocation. The tests check this by using __LINE__ in
a macro with a multi-line invocation. It's not quite clear from the spec
that the enforced behavior is expected as opposed to the replacement
list getting its location from the macro name, but a minor correction to
the preprocessor makes the dEQP tests pass.

Newlines in the preprocessor unit tests are generated according to the
source locations in the token list produced by the preprocessor, so the
expectations of a few tests also need to be updated.

BUG=angleproject:989
TEST=dEQP-GLES3.functional.shaders.preprocessor.predefined_macros.*
     (2 start passing with this change),
     angle_unittests

Change-Id: I4cc9da09bd0985310a05ebf6def680916a46308a
Reviewed-on: https://chromium-review.googlesource.com/297990Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

e6432c85

Don't split the file into two chunks in shader_translator · 0304d2fe

authored Sep 07, 2015

Splitting the file into two strings in shader_translator complicated
testing line/file numbering related functionality with it, since each
chunk passed to ShCompile has its own file number and line numbering.
These are exposed to the preprocessor in __FILE__ and __LINE__ predefined
macros.

Just supply the file to ShCompile in a single string. Also, since the
original motivation for splitting the string seems to have been to
exercise ShCompile with multiple strings, add a new unit test that
ensures that ShCompile handles multiple strings as expected.

BUG=angleproject:989
TEST=angle_unittests

Change-Id: I31d24925ec85ca3411e537df25a985f09737403e
Reviewed-on: https://chromium-review.googlesource.com/297251Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

0304d2fe

08 Sep, 2015 11 commits

Revert "Re-re-land "Move Uniform and UBO info to the gl::Program layer."" · b654f659

authored Sep 08, 2015

Failes the gles2_conform_test:

GLES2ConformTest.GL2Tests_glGetUniform_input_run

Possibly also WebGL failures, will investigate.

BUG=angleproject:1123

This reverts commit 10750cb9.

Change-Id: I1ae59325e1831589019bc5a27ffc2091d3994a65
Reviewed-on: https://chromium-review.googlesource.com/298200Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b654f659

Re-re-land "Move Uniform and UBO info to the gl::Program layer." · 10750cb9

authored Sep 04, 2015

This data was previously stored entirely in the Impl level. Move
as much as possible to the GL level, using a read-only view in the
Impl level. Some information in D3D-specific, and should be stored
separately in the Impl.

This patch has a lot of refactoring that splits the D3D and GL info,
and moves as much validation as possible to the GL layer, where it
is shared between the back-ends.

Re-land with fix for dEQP unused uniforms. The fix involves storing
a local copy of all uniform data in the GL layer. This will also
let us validate sampler indexes during draw calls at the GL layer.

Re-re-land with a fix for multiply defined symbols on Clang.

BUG=angleproject:1123
TEST=end2end_tests,Canary WebGL (D3D11/GL), dEQP-GLES2+3.functional.uniform_api

Change-Id: I7b55e4964fbe64e0106c37928c894146937a2476
Reviewed-on: https://chromium-review.googlesource.com/298110Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

10750cb9

Revert "Re-land "Move Uniform and UBO info to the gl::Program layer."" · 2119dd05

authored Sep 08, 2015

Problems with multiply defined symbols in the Linux builder.

BUG=angleproject:1123

This reverts commit ff1abe63.

Change-Id: Ifcb2ad885d0841c128ffd69afb6594e37eba17fc
Reviewed-on: https://chromium-review.googlesource.com/298100Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

2119dd05

Re-land "Move Uniform and UBO info to the gl::Program layer." · ff1abe63

authored Sep 04, 2015

This data was previously stored entirely in the Impl level. Move
as much as possible to the GL level, using a read-only view in the
Impl level. Some information in D3D-specific, and should be stored
separately in the Impl.

This patch has a lot of refactoring that splits the D3D and GL info,
and moves as much validation as possible to the GL layer, where it
is shared between the back-ends.

Re-land with fix for dEQP unused uniforms. The fix involves storing
a local copy of all uniform data in the GL layer. This will also
let us validate sampler indexes during draw calls at the GL layer.

BUG=angleproject:1123
TEST=end2end_tests,Canary WebGL (D3D11/GL), dEQP-GLES2+3.functional.uniform_api

Change-Id: I9074c057c2c67d4d3221ec11c5556a26e07c7ceb
Reviewed-on: https://chromium-review.googlesource.com/297070
Tryjob-Request: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

ff1abe63

Set seamless cubemap filtering in StateManagerGL. · 7bd13082

authored Sep 08, 2015

Cubemap filtering is supposed to be seamless for ES3+ contexts.

Fixes 298 failures in dEQP-GLES3.functional.texture, mostly in
dEQP-GLES3.functional.texture.filtering and
dEQP-GLES3.functional.texture.shadow.

BUG=angleproject:986
BUG=angleproject:1149

Change-Id: I6054365086bb3b9d9b085c260f88e2c43eb75bfe
Reviewed-on: https://chromium-review.googlesource.com/296966Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

7bd13082

Added support for premultiplied alpha mode for composition swapchains · 98233372

authored Aug 28, 2015

Change-Id: Iee1d327a03469d7daf6cc412709c0a36e1c83e32
Reviewed-on: https://chromium-review.googlesource.com/296721Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Cooper Partin <coopp@microsoft.com>
Tryjob-Request: Jamie Madill <jmadill@chromium.org>

98233372

Use named value-parameterized tests for angle_end2end_tests · 33585c71

authored Sep 03, 2015

This replace the non-descriptive digit at the end of the test name by
the name of the configuration being tested.

Reland with a fix for gtest initialization on Windows caused by
ProgramBinaryTest having the same parameter name twice.

BUG=angleproject:1153

Change-Id: I9b0f661a535b760793d9d87ef0c8298f6b83830d
Reviewed-on: https://chromium-review.googlesource.com/297701Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

33585c71

Mark GL_RGB10_A2UI as a renderable format. · 9bbad18e

authored Sep 04, 2015

dEQP-GLES3.functional.fbo.color.tex3d.rgb10_a2ui was already failing but
because the framebuffer was marked as unsupported, dEQP considers the test to
be passing.

BUG=angleproject:1149
BUG=angleproject:1097

Change-Id: I82223e8e927d1fd6d66f75b5fdea7989c92d706d
Reviewed-on: https://chromium-review.googlesource.com/298031Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

9bbad18e

Don't evaluate short-circuited preprocessor expressions · 809ec546

authored Aug 26, 2015

Resubmit with clang build issue fixed. The result of a short-circuited
operation is now either 0 or 1.

ESSL 3.00 spec section 3.4 mentions that the second operand in a logical
&& or || preprocessor operation is evaluated only if the first operand
doesn't short-circuit the expression. The non-evaluated part of a
preprocessor expression may also have undefined identifiers.

Make the expression parser follow the spec by ignoring errors that are
generated inside short-circuited expressions. This includes undefined
identifiers and divide by zero.

BUG=angleproject:347
TEST=dEQP-GLES3.functional.shaders.preprocessor.undefined_identifiers.*
     angle_unittests

Change-Id: I4163f96ec46d40ac859ffb39d91b89490041e44d
Reviewed-on: https://chromium-review.googlesource.com/297252Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

809ec546

Revert "Don't evaluate short-circuited preprocessor expressions" · 9a1b49f7

authored Sep 08, 2015

Build break on Clang:

FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/angle/src/compiler/preprocessor/preprocessor.ExpressionParser.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=245965-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA -DDCHECK_ALWAYS_ON=1 -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O2 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch x86_64 -Wendif-labels -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-unused-function -Wno-unused-variable -std=c++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/GPU_Mac_Builder/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics -fno-strict-aliasing  -c ../../third_party/angle/src/compiler/preprocessor/ExpressionParser.cpp -o obj/third_party/angle/src/compiler/preprocessor/preprocessor.ExpressionParser.o
../../third_party/angle/src/compiler/preprocessor/ExpressionParser.cpp:1372:35: error: use of logical '||' with constant operand [-Werror,-Wconstant-logical-operand]
            (yyval) = (yyvsp[-3]) || 0;
                                  ^  ~
../../third_party/angle/src/compiler/preprocessor/ExpressionParser.cpp:1372:35: note: use '|' for a bitwise operation
            (yyval) = (yyvsp[-3]) || 0;
                                  ^~
                                  |
../../third_party/angle/src/compiler/preprocessor/ExpressionParser.cpp:1406:35: error: use of logical '&&' with constant operand [-Werror,-Wconstant-logical-operand]
            (yyval) = (yyvsp[-3]) && 0;
                                  ^  ~
../../third_party/angle/src/compiler/preprocessor/ExpressionParser.cpp:1406:35: note: use '&' for a bitwise operation
            (yyval) = (yyvsp[-3]) && 0;
                                  ^~
                                  &
../../third_party/angle/src/compiler/preprocessor/ExpressionParser.cpp:1406:35: note: remove constant to silence this warning
            (yyval) = (yyvsp[-3]) && 0;
                                 ~^~~~

BUG=angleproject:347

This reverts commit 6ffe6135.

Change-Id: I6d81666cca573f320bfb1164a6c794b6f75f7463
Reviewed-on: https://chromium-review.googlesource.com/298020Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

9a1b49f7

Revert "Mark GL_RGB10_A2UI as a renderable format." · 47f730fa

authored Sep 08, 2015

Fails the dEQP test:

dEQP-GLES3.functional.fbo.color.tex3d.rgb10_a2ui

BUG=angleproject:1149

This reverts commit d0f9fdc7.

Change-Id: I5b76255be3fc1f0734395dac609e2949fc8c8185
Reviewed-on: https://chromium-review.googlesource.com/298010Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

47f730fa

07 Sep, 2015 1 commit

Don't evaluate short-circuited preprocessor expressions · 6ffe6135

authored Aug 26, 2015

ESSL 3.00 spec section 3.4 mentions that the second operand in a logical
&& or || preprocessor operation is evaluated only if the first operand
doesn't short-circuit the expression. The non-evaluated part of a
preprocessor expression may also have undefined identifiers.

Make the expression parser follow the spec by ignoring errors that are
generated inside short-circuited expressions. This includes undefined
identifiers and divide by zero.

BUG=angleproject:347
TEST=dEQP-GLES3.functional.shaders.preprocessor.undefined_identifiers.*
     angle_unittests

Change-Id: Ieed02a71298af838f784a5d1197d4f4a9ba0e3c8
Reviewed-on: https://chromium-review.googlesource.com/295033Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

6ffe6135

04 Sep, 2015 6 commits

Suppress failing Uniform test on AMD. · 3910ca93

authored Sep 04, 2015

This test exposes a driver bug in state query, where the AMD
driver does not cast state values correctly. Suppress this for now
but we can quickly turn it on with the Uniforms refactor, which
does all of the necessary state retrieval within ANGLE without
consulting the driver.

BUG=angleproject:1123

Change-Id: I5c1f1c16e3a59582267de3365e388ffef4d57467
Reviewed-on: https://chromium-review.googlesource.com/296667Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

3910ca93

Fix GetUniform rounding in D3D. Also add a test. · 6ba5d4dd

authored Sep 04, 2015

The test will help cover a bug that I found when doing the refactor
of gl::Program.

BUG=angleproject:1123

Change-Id: Id353ffaffef83ad1538580ad01668c915bf9853f
Reviewed-on: https://chromium-review.googlesource.com/297031Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

6ba5d4dd

Revert "Use named value-parameterized tests for dEQP gtests" · 6026538a

authored Sep 04, 2015

This reverts commit 0db7b155.

BUG=

Change-Id: Ia2de8268bd51d865ad87875c55cb5bfcc51e29f6
Reviewed-on: https://chromium-review.googlesource.com/297760Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

6026538a

Don't use the mip level to validate the 2D texture depth parameter. · b92c133e

authored Sep 04, 2015

BUG=angleproject:1149

Change-Id: I5dd45c99b373d480814c9fbdbe0abd419a270c89
Reviewed-on: https://chromium-review.googlesource.com/297052Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

b92c133e

Fix typo when syncing GL_UNPACK_SKIP_ROWS and GL_PACK_SKIP_ROWS. · ed1e0ad9

authored Jul 23, 2015

Causes crashes in the dEQP ReadPixels test.

BUG=angleproject:1149
BUG=angleproject:883

Change-Id: I090e21ebd7781ce3372b8842421e7da3e4bedbac
Reviewed-on: https://chromium-review.googlesource.com/287629Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

ed1e0ad9

Apply the pixel pack state before ReadPixels in FramebufferGL. · da34d002

authored Sep 04, 2015

This ensures that the PBO is bound because it does not have a dirty bit
yet.

BUG=angleproject:1149
BUG=angleproject:885

Change-Id: Iad96abc4dec4e6ac8187975c7638dfd7f18951e7
Reviewed-on: https://chromium-review.googlesource.com/296963Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

da34d002