This reverts commit e416c92a. Reason for revert: Reverted parent: https://chromium-review.googlesource.com/c/angle/angle/+/2481612 Original change's description: > Vulkan: Fold deferred clears into current clears > > If there are clears prior to a glClear() call, those clears were > flushed (starting a new render pass) and then the clear call's clears > would be applied (essentially modifying the loadOps of said render > pass). > > The main downside of the above is that the current glClear() clears > don't get a chance to be deferred. This was observed in Chrome which > clears an attachment with an emulated format, then switches > framebuffers. > > Additionally, if the render pass had already been started, the deferred > clears could have become inlined instead of breaking the render pass. > Although, it's unlikely for there to be deferred clears when the render > pass is already open. > > This change first identifies which clears need to go through the draw > path (scissored, masked or as workaround for driver bug). It merges the > rest of the clears (that don't need the draw path) with the deferred > clears. It then checks deferred clears and applies them by either: > > - vkCmdClearAttachments if mid RP > - Start a new render pass and use loadOps, if any draw-based clear needs > to follow. > - Modify current RP loadOps / defer the clear > > Afterwards, the draw-based clears are applied. > > Bug: angleproject:4836 > Change-Id: Id4992c78983b199734508c9d4bb18ed3195c91ec > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2455167 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> TBR=syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com Change-Id: I85733b3594409df9b96e3d5b34933522c97c42cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:4836 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2481613Reviewed-by:Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| d3d | Loading commit data... | |
| gl | Loading commit data... | |
| metal | Loading commit data... | |
| null | Loading commit data... | |
| vulkan | Loading commit data... | |
| BufferImpl.cpp | Loading commit data... | |
| BufferImpl.h | Loading commit data... | |
| BufferImpl_mock.h | Loading commit data... | |
| CompilerImpl.h | Loading commit data... | |
| ContextImpl.cpp | Loading commit data... | |
| ContextImpl.h | Loading commit data... | |
| DeviceImpl.cpp | Loading commit data... | |
| DeviceImpl.h | Loading commit data... | |
| DisplayImpl.cpp | Loading commit data... | |
| DisplayImpl.h | Loading commit data... | |
| EGLImplFactory.h | Loading commit data... | |
| EGLSyncImpl.h | Loading commit data... | |
| FenceNVImpl.h | Loading commit data... | |
| Format.h | Loading commit data... | |
| FormatID_autogen.h | Loading commit data... | |
| Format_table_autogen.cpp | Loading commit data... | |
| FramebufferAttachmentObjectImpl.h | Loading commit data... | |
| FramebufferImpl.h | Loading commit data... | |
| FramebufferImpl_mock.h | Loading commit data... | |
| GLImplFactory.h | Loading commit data... | |
| ImageImpl.h | Loading commit data... | |
| ImageImpl_mock.h | Loading commit data... | |
| MemoryObjectImpl.h | Loading commit data... | |
| OverlayImpl.h | Loading commit data... | |
| ProgramImpl.h | Loading commit data... | |
| ProgramImpl_mock.h | Loading commit data... | |
| ProgramPipelineImpl.cpp | Loading commit data... | |
| ProgramPipelineImpl.h | Loading commit data... | |
| QueryImpl.cpp | Loading commit data... | |
| QueryImpl.h | Loading commit data... | |
| RenderTargetCache.h | Loading commit data... | |
| RenderbufferImpl.h | Loading commit data... | |
| RenderbufferImpl_mock.h | Loading commit data... | |
| SamplerImpl.h | Loading commit data... | |
| SemaphoreImpl.h | Loading commit data... | |
| ShaderImpl.cpp | Loading commit data... | |
| ShaderImpl.h | Loading commit data... | |
| StreamProducerImpl.h | Loading commit data... | |
| SurfaceImpl.cpp | Loading commit data... | |
| SurfaceImpl.h | Loading commit data... | |
| SyncImpl.h | Loading commit data... | |
| TextureImpl.cpp | Loading commit data... | |
| TextureImpl.h | Loading commit data... | |
| TextureImpl_mock.h | Loading commit data... | |
| TransformFeedbackImpl.h | Loading commit data... | |
| TransformFeedbackImpl_mock.h | Loading commit data... | |
| VertexArrayImpl.h | Loading commit data... | |
| angle_format.py | Loading commit data... | |
| angle_format_data.json | Loading commit data... | |
| angle_format_map.json | Loading commit data... | |
| copyvertex.h | Loading commit data... | |
| copyvertex.inc.h | Loading commit data... | |
| d3d_format.cpp | Loading commit data... | |
| d3d_format.h | Loading commit data... | |
| driver_utils.cpp | Loading commit data... | |
| driver_utils.h | Loading commit data... | |
| driver_utils_mac.mm | Loading commit data... | |
| dxgi_format_data.json | Loading commit data... | |
| dxgi_format_map.h | Loading commit data... | |
| dxgi_format_map_autogen.cpp | Loading commit data... | |
| dxgi_support_data.json | Loading commit data... | |
| dxgi_support_table.h | Loading commit data... | |
| dxgi_support_table_autogen.cpp | Loading commit data... | |
| gen_angle_format_table.py | Loading commit data... | |
| gen_dxgi_format_table.py | Loading commit data... | |
| gen_dxgi_support_tables.py | Loading commit data... | |
| gen_load_functions_table.py | Loading commit data... | |
| glslang_wrapper_utils.cpp | Loading commit data... | |
| glslang_wrapper_utils.h | Loading commit data... | |
| load_functions_data.json | Loading commit data... | |
| load_functions_table.h | Loading commit data... | |
| load_functions_table_autogen.cpp | Loading commit data... | |
| renderer_utils.cpp | Loading commit data... | |
| renderer_utils.h | Loading commit data... | |
| serial_utils.h | Loading commit data... | |
| serial_utils_unittest.cpp | Loading commit data... |