The PVRTC format, as pointed out by Le Hoang Quyen and Geoff Lang, uses 4x4 or 8x4 blocks, but due to sampling from adjacent blocks, requires a minimum size of 2x2 blocks per the OpenGL extension: https://www.khronos.org/registry/OpenGL/extensions/IMG/IMG_texture_compression_pvrtc.txt . Thanks to Quyen and Geoff for pointing out the intricacies. Add a helper function to formatutils.cpp which returns the minimum number of blocks (width and height) for a given compressed texture format, and incorporate this into the compressed texture size computation. This patch makes WebKit on ANGLE pass WebGL's PVRTC compressed texture test on iOS hardware. Bug: angleproject:4652 No-Presubmit: True Change-Id: I1046a091321b7948d712d16686ee0cb8795b8c99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2213676 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:Geoff Lang <geofflang@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| code_generation_hashes | Loading commit data... | |
| apply_clang_format_on_all_sources.py | Loading commit data... | |
| bmp_to_nv12.py | Loading commit data... | |
| bootstrap.py | Loading commit data... | |
| egl.xml | Loading commit data... | |
| egl_angle_ext.xml | Loading commit data... | |
| entry_point_packed_gl_enums.json | Loading commit data... | |
| export_targets.py | Loading commit data... | |
| file_exists.py | Loading commit data... | |
| gen_angle_gn_info_json.py | Loading commit data... | |
| gen_gl_enum_utils.py | Loading commit data... | |
| gen_proc_table.py | Loading commit data... | |
| gen_vk_gl_cts_build.py | Loading commit data... | |
| generate_android_bp.py | Loading commit data... | |
| generate_entry_points.py | Loading commit data... | |
| generate_loader.py | Loading commit data... | |
| generate_new_renderer.py | Loading commit data... | |
| generate_stats.py | Loading commit data... | |
| gl.xml | Loading commit data... | |
| gl_angle_ext.xml | Loading commit data... | |
| msvs_projects.py | Loading commit data... | |
| perf_test_runner.py | Loading commit data... | |
| registry_xml.py | Loading commit data... | |
| remove_files.py | Loading commit data... | |
| roll_aosp.sh | Loading commit data... | |
| roll_deps.py | Loading commit data... | |
| run_code_generation.py | Loading commit data... | |
| trigger.bat | Loading commit data... | |
| trigger.py | Loading commit data... | |
| update_canary_angle.py | Loading commit data... | |
| vk_mandatory_format_support_capture_to_json.js | Loading commit data... | |
| wgl.xml | Loading commit data... |