Remove redundant MSVC++ /W3 triggering warnings

This change looks for CMake's default setting for MSVC++, /W3 (and any other level should that change in the future), and removes it before adding /W4. This stops the build for MSVC++ emitting warnings about /W4 overriding /W3 earlier on the command line.

Remove redundant MSVC++ /W3 triggering warnings
60b59217 · Billy Robert O'Neal III · fa8b2d61 · 60b59217
Commit 60b59217 authored Apr 27, 2016 by Billy Robert O'Neal III
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

CMakeLists.txt CMakeLists.txt +2 -1

No files found.
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -33,7 +33,8 @@ include(CXXFeatureCheck)

 if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
  # Turn compiler warnings up to 11
-  add_cxx_compiler_flag(-W4)
+  string(REGEX REPLACE "[-/]W[1-4]" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4")
  add_definitions(-D_CRT_SECURE_NO_WARNINGS)

  # Link time optimisation