Fix MSVC warning. (#935)

This fixes the Visual Studio 2019 warning: `C4244: '=': conversion from 'int' to 'char', possible loss of data` When implicitly casting the return value of tolower() (int) to char. Fixes: #932

Fix MSVC warning. (#935)
8982e1ee · Ben Clayton · GitHub · e5ea03ce · 8982e1ee
Unverified Commit 8982e1ee authored Feb 07, 2020 by Ben Clayton Committed by GitHub Feb 08, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

commandlineflags.cc src/commandlineflags.cc +2 -2

No files found.
--- a/src/commandlineflags.cc
+++ b/src/commandlineflags.cc
@@ -217,8 +217,8 @@ bool IsTruthyFlagValue(const std::string& value) {
           !(v == '0' || v == 'f' || v == 'F' || v == 'n' || v == 'N');
  } else if (!value.empty()) {
    std::string value_lower(value);
-    std::transform(value_lower.begin(), value_lower.end(),
+    std::transform(value_lower.begin(), value_lower.end(), value_lower.begin(),
-                   value_lower.begin(), ::tolower);
+                   [](char c) { return static_cast<char>(::tolower(c)); });
    return !(value_lower == "false" || value_lower == "no" ||
             value_lower == "off");
  } else