Skip to content

B
benchmark
Commit 94c512c0 by Eric Committed by GitHub
Options

Replace int64_t usages with 'int' instead. (#359)

Previously the constants used for converting between different units of time were declared using int64_t. However we should only use explicitly sized integer types when they are required, and should use 'int' everwhere else, and there is no good reason to use int64_t here. For that reason this patch changes the type of the constants. This should help address issue #354 as well.
parent 9b92ed76
Showing with 6 additions and 8 deletions
src/sleep.cc
...@@ -41,7 +41,7 @@ void SleepForMicroseconds(int microseconds) { ...@@ -41,7 +41,7 @@ void SleepForMicroseconds(int microseconds) {
} }
void SleepForMilliseconds(int milliseconds) { void SleepForMilliseconds(int milliseconds) {
SleepForMicroseconds(static_cast<int>(milliseconds) * kNumMicrosPerMilli); SleepForMicroseconds(milliseconds * kNumMicrosPerMilli);
} }
void SleepForSeconds(double seconds) { void SleepForSeconds(double seconds) {
......
src/sleep.h
#ifndef BENCHMARK_SLEEP_H_ #ifndef BENCHMARK_SLEEP_H_
#define BENCHMARK_SLEEP_H_ #define BENCHMARK_SLEEP_H_
#include <cstdint>
namespace benchmark { namespace benchmark {
const int64_t kNumMillisPerSecond = 1000LL; const int kNumMillisPerSecond = 1000;
const int64_t kNumMicrosPerMilli = 1000LL; const int kNumMicrosPerMilli = 1000;
const int64_t kNumMicrosPerSecond = kNumMillisPerSecond * 1000LL; const int kNumMicrosPerSecond = kNumMillisPerSecond * 1000;
const int64_t kNumNanosPerMicro = 1000LL; const int kNumNanosPerMicro = 1000;
const int64_t kNumNanosPerSecond = kNumNanosPerMicro * kNumMicrosPerSecond; const int kNumNanosPerSecond = kNumNanosPerMicro * kNumMicrosPerSecond;
void SleepForMilliseconds(int milliseconds); void SleepForMilliseconds(int milliseconds);
void SleepForSeconds(double seconds); void SleepForSeconds(double seconds);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment