- 23 Nov, 2020 1 commit
-
-
John Kessenich authored
-
- 16 Nov, 2020 1 commit
-
-
Shahbaz Youssefi authored
Fixes a crash in ANGLE. Closes: #2452
-
- 12 Nov, 2020 3 commits
-
-
Malcolm Bechard authored
no longer causes an incorrect error if the current unit has local_size set, but the incoming unit does not
-
David Neto authored
Use of gl_Layer and gl_ViewportIndex in tessellation and vertex shaders should not trigger the addition of the Geometry capability. Fixes #2461 Added tests for use of gl_Layer and gl_ViewportIndex in a tessellation evaluation shader. Several tests for NVIDIA features for tessellation, vertex, or mesh shaders now lose the Geometry or MultiViewport capabilities. This is ok because the functionality is already covered by the ShaderViewportIndexLayerNV capability. The spv.meshShaderPerViewBuiltins.mesh test now fails validation because the validator does not know that PrimitiveId (and possibly other) builtins are enabled by the MeshShadingNV capability. I filed https://github.com/KhronosGroup/SPIRV-Headers/issues/179 to fix the grammar upstream.
-
greg-lunarg authored
This implements a new nonunifom analysis suggested by @jbolz. This change generates nonUniform decorations that were previously missing and avoids generation of incorrect decorations. Most notably, it now generates decorations for nonuniform functions and out params. It avoids generating decorations for lvalues which themselves are not nonuniform.
-
- 09 Nov, 2020 1 commit
-
-
Jesse Hall authored
* Implement GL_EXT_terminate_invocation. * terminateInvocation: declare the SPV extension * Update test results for spirv-tools and bison version bumps Co-authored-by:John Kessenich <cepheus@frii.com>
-
- 06 Nov, 2020 1 commit
-
-
rdb authored
Fixes #2443
-
- 05 Nov, 2020 1 commit
-
-
Chow authored
ATT.
-
- 04 Nov, 2020 1 commit
-
-
Tobski authored
-
- 03 Nov, 2020 2 commits
-
-
Chow authored
* Code refine and adding missing features 1. Add new level for built in symbols. 2. Fix issues for structure members' qualifiers. 3. Global qualifier fix. 4. IO Mapper refine. Add support for checking with mangle names. * Additional missing features * Invariant member. (Only check non-interface). * Split block nesting level and struct nesting level. To fix issues of checking 'invariant' qualifier. Current grammar would check block/struct member without its parent class's information. So we split nesting level, and 'invariant' would only be checked within a struct. * Format anonymous block names. Refine codes for symbols from all kinds of resouces. * Fix writeonly check. * Use LValueBase to find operator. * Fix random null ptr issue. * invariant check, stage in io mapping, reference parameter should be used and remove wrong codes introduced with ordering vector. * Remained: to be fixed with double check link.vk.multiblocksValid * Fix version error. invariant * Revert loc modification.
-
Courtney Goeltzenleuchter authored
Getting error about undefined symbol (include_dir) at line 320. Was trying to append to a non-existant variable. Bug #2445
-
- 02 Nov, 2020 3 commits
-
-
pheonix authored
* Add new SpirvToolsDisassemble API interface + Improve Doc on existing API interface (#2408) * Add more flexible SpirvToolsDisassemble interface to allow specifying spv_target_env for disassembly output. Improve documentation on existing SpirvToolsDisassemble interface. * Update pre-processor check - following existing ENABLE_OPT checks. * Fix not-found header paths for glslangValidator and glslangtests. * Add spirv_tools/include path where there is an ENABLE_OPT=1 in the BUILD.gn configuration.
-
Sidney Just authored
* When targeting SPIR-V 1.5, using gl_ViewportIndex will emit OpCapability ShaderViewportIndex and using gl_Layer will emit OpCapability CapabilityShaderLayer. OpCapability ShaderViewportIndexLayerEXT will only get emitted if the target < SPIR-V 1.5 * When using one of the viewport/layer arrays extensions, fallback to OpCapability ShaderViewportIndexLayerEXT, even when targeting SPIR-V 1.5 * Revert "When using one of the viewport/layer arrays extensions, fallback to OpCapability ShaderViewportIndexLayerEXT, even when targeting SPIR-V 1.5" This reverts commit dccca82f4076ea6e2bc01dd6d1e5d290c59fab20. * Using gl_Layer and gl_ViewportIndex outside of the geometry shader stage still requires one of the viewport extensions even when targeting SPIR-V 1.5 (Fixes a problem introduced by 670536b663f396815645b2f907f0ee92117b44f0)
-
Jaebaek Seo authored
* Do not use PropagateLineInfoPass and RedundantLineInfoElimPass Since spirv-opt will remove PropagateLineInfoPass and RedundantLineInfoElimPass, glslang should not use it. spirv-opt will propagate the line instructions and eliminate the redundant lines by default in IR loading/emission. * Update known_good.json for spirv-tool
-
- 30 Oct, 2020 1 commit
-
-
John Kessenich authored
NonUniform SPIR-V fixes.
-
- 26 Oct, 2020 1 commit
-
-
John Kessenich authored
HLSL: Add support for printf().
-
- 24 Oct, 2020 1 commit
-
-
Rex Xu authored
Translate printf() to what GL_EXT_debug_printf has done. HLSL could define non-constant string variable and we don't have such features in SPIR-V, so just support constant string variable.
-
- 22 Oct, 2020 1 commit
-
-
John Kessenich authored
Fix GN build and presubmits
-
- 21 Oct, 2020 1 commit
-
-
Ben Clayton authored
Add missing `.cfg` files for GN presubmit. Add missing `recursedeps` in the `DEPS` file. Call `./update_glslang_sources.py` before attempting to build. Add more GN spew to the `.gitignore` file.
-
- 20 Oct, 2020 5 commits
-
-
John Kessenich authored
Kokoro: Add configurations for GN presubmit
-
John Kessenich authored
Add GL_EXT_fragment_shading_rate
-
John Kessenich authored
-
Chow authored
-
Ben Clayton authored
Issue: #2421
-
- 19 Oct, 2020 2 commits
-
-
John Kessenich authored
Add basic GN configurations
-
Ben Clayton authored
TIntermediate was constructed without initializing any of the `resources` fields, and `TProgram::linkStage()` was not calling `TIntermediate::setLimits()` after constructing new `TIntermediate`s for non-first stages. Fields of `resources` were then read in `TIntermediate::finalCheck()` triggering undefined behavior. This CL makes three changes: (1) `TIntermediate::setLimits()` is now called for non-first stages by copying the `firstIntermediate`'s limits. This ensures that the `resources` fields is initialized, fixing the bug. (2) `TIntermediate::resources` is now wrapped in a `MustBeAssigned<>` helper struct, asserting in non-release builds that this field is always initialized before reading. (3) `TIntermediate::resources` is now zero-initialized, so that if the `TIntermediate::resources` field is not set in a release build (and so the `assert()` will be disabled) behavior is still deterministic. Fixes #2423
-
- 16 Oct, 2020 2 commits
-
-
Ben Clayton authored
-
Ben Clayton authored
This allows glslang to be build standalone using the gn build system. To build with gn: ``` gclient sync --gclientfile=standalone.gclient gn gen out/default cd out/default ninja ```
-
- 12 Oct, 2020 2 commits
-
-
Triang3l authored
disassemble.cpp appears not to be using anything from SpvTools.h, but the inclusion of it prevents standalone building of the SPIR-V portion (for instance, when needed purely for generation and disassembly) without SPIRV-Tools dependency.
-
Rémi Verschelde authored
-
- 07 Oct, 2020 2 commits
-
-
David Neto authored
This is based on spv.paramMemory.frag.out which exercises the writeonly storage image case. This appears to need desktop GLSL. The generated SPIR-V fails validation because the image_write function takes a parameter which is pointer to an OpTypeImage with Unknown format. But the parameters passed in are pointer to OpTypeImage with formats Rgba32f and Rgba16f. The validator rejects this, saying the parameter types must match.
-
jonahryandavis authored
-
- 05 Oct, 2020 2 commits
-
-
John Kessenich authored
Revert "Add new SpirvToolsDisassemble API interface + Improve Doc on existing API interface (#2408)" See issue #2413. This reverts commit d1929f35.
-
pheonix authored
* Add more flexible SpirvToolsDisassemble interface to allow specifying spv_target_env for disassembly output. Improve documentation on existing SpirvToolsDisassemble interface. * Update pre-processor check - following existing ENABLE_OPT checks. * Fix not-found header paths for glslangValidator and glslangtests.
-
- 28 Sep, 2020 1 commit
-
-
John Kessenich authored
Revert "Add more flexible SpirvToolsDisassemble interface to allow specifying spv_target_env for disassembly output. (#2406)" This reverts commit 2eed8236.
-
- 27 Sep, 2020 2 commits
-
-
pheonix authored
Add more flexible SpirvToolsDisassemble interface to allow specifying spv_target_env for disassembly output. (#2406) Improve documentation on existing SpirvToolsDisassemble interface. Fix cmake build scripts to account for `spirv-tools` external when -DENABLE_OPT=ON
-
craig stout authored
There's a statement that intends to generate a 32-bit hashcode, but due to integer promotion, the intermediate values can trigger signed integer overflow, which is undefined behavior. To avoid this, cast at least one operand to unsigned int before multiplying, which will cause the result to be promoted to unsigned int instead of signed int. With this patch, I'm able to build core for qemu-x64 with host_asan-ubsan. Fixed: 60128 Change-Id: Idd644e534116bf29dca8013936ac39901bbe68fc Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/glslang/+/428254Reviewed-by:
John Bauman <jbauman@google.com> Co-authored-by:
Drew Fisher <zarvox@google.com>
-
- 26 Sep, 2020 1 commit
-
-
craig stout authored
The glslang public includes dir contains headers with implicit conversion issues. Add -Wno-conversion to glslang's public config. Bug: 60140 Bug: 58162 Change-Id: Iec27cb4242e9fdceddd6a3e02044a0bccfa0ce36 Reviewed-on: https://fuchsia-review.googlesource.com/c/third_party/glslang/+/429054Reviewed-by:
Petr Hosek <phosek@google.com> Co-authored-by:
Shai Barack <shayba@google.com>
-
- 25 Sep, 2020 1 commit
-
-
greg-lunarg authored
-
- 18 Sep, 2020 1 commit
-
-
Rex Xu authored
Add more builder functions to OpExecutionMode, OpExecutionModeId, OpDecorateString, OpMemberDecorateString. According to SPIR-V, OpExecutionMode and OpExecutionModeId could take variable extra operands. Current implementation doesn't support this and assumes at most 3 operands are extra operands. It is not true. Similarly, OpDecorateString and OpMemberDecorateString could support multiple strings either as literal strings or as string operands. Further, OpDecorate and OpDecorateId have the same problem, taking variable extra operands.
-