1. 07 Feb, 2020 1 commit
    • Googletest export · 22397f28
      Abseil Team authored
      Add missing explicit keyword for gmock_Impl constructor.
      
      When switching to using GMOCK_PP in ACTION* macroses `explicit` keyword was
      missed in gmock_Impl constructor causing ClangTidy warnings in ACTION_P macro.
      
      PiperOrigin-RevId: 291159975
  2. 21 Jan, 2020 5 commits
  3. 16 Jan, 2020 6 commits
    • Googletest export · 8b4817e3
      Abseil Team authored
      Correct the spelling of PARAMETERIZED.
      
      PiperOrigin-RevId: 289897278
    • Googletest export · 5336106b
      Abseil Team authored
      Use GMOCK_PP to create GMOCK_INTERNAL_ACTION macro.
      
      Create GMOCK_INTERNAL_ACTION macro that generates ACTION_P* macroses using
      GMOCK_PP.
      
      PiperOrigin-RevId: 289815906
    • Googletest export · 3e79d366
      Abseil Team authored
      Wire up things to support marking a type paramaterized test as allowed to be un-instantiated.
      
      PiperOrigin-RevId: 289699939
    • Googletest export · 7a8591e6
      Abseil Team authored
      Use GMOCK_PP to generate args boilerplate.
      
      Move common args describing part to separate macroses that uses GMOCK_PP to
      generate sequences.
      
      PiperOrigin-RevId: 289655624
    • Googletest export · 0b024bd9
      Abseil Team authored
      Add GTEST_ALLOW_UNINSTANTIATED_PARAMTERIZED_TEST to mark a paramaterized test as allowed to be un-instantiated.
      
      This allows test suites, that are defined in libraries and, for other reasons, get linked in (which should probably be avoided, but isn't always possible) to be marked as allowed to go uninstantiated.
      
      This can also be used to grandfather existing issues and expedite adoption of the checks with regards to new cases before they can be fixed.
      
      PiperOrigin-RevId: 289581573
    • Googletest export · ed16134f
      Abseil Team authored
      Change testing::TempDir() return value for Android
      
      PiperOrigin-RevId: 289102017
  4. 15 Jan, 2020 1 commit
  5. 13 Jan, 2020 1 commit
  6. 12 Jan, 2020 1 commit
  7. 09 Jan, 2020 4 commits
    • Googletest export · d854bd6a
      Abseil Team authored
      Removing GTEST_API from TrueWithString.
      This type is only used in test code on one side of a DLL boundary so it is not
      necessary.
      
      PiperOrigin-RevId: 288927929
    • Googletest export · c901f67d
      Abseil Team authored
      Move part of functionality of Action* class to the base one. Reduce copypaste.
      
      Make constructor and conversion operator of Action* class independent of pump.
      
      PiperOrigin-RevId: 288907005
    • Googletest export · 8417b733
      Abseil Team authored
      Close #2658
      Mark test case destrucors as override.
      
      PiperOrigin-RevId: 288507991
    • Googletest export · 4b9c1691
      Abseil Team authored
      Use C++11 variadic templates for Invoke in gmock-generated-actions.h.
      
      Replace InvokeArgumentAdl with Invoke that uses C++11 variadic templates.
      
      PiperOrigin-RevId: 288449236
  8. 02 Jan, 2020 9 commits
    • Googletest export · 306f3754
      Abseil Team authored
      Explicitly default copy constructor in BoundSecondMatcher
      
      Since C++11, implicit defaulting of copy constructors is deprecated for types
      with user-defined copy assignment operators, so we should explicitly default the
      copy constructor of BoundSecondMatcher.
      
      PiperOrigin-RevId: 287587847
    • Merge pull request #2632 from Kravlalala:cmake/mingw_msys_build · 07ab939a
      Andy Soffer authored
      PiperOrigin-RevId: 287587126
    • Googletest export · 0d98d87e
      Abseil Team authored
      Add missing period.
      
      PiperOrigin-RevId: 287553550
    • Googletest export · 153909f0
      Abseil Team authored
      Fix typo in example.
      
      PiperOrigin-RevId: 287212448
    • Merge pull request #2639 from trzecieu:trzeci/move_ctor_assign · fbe34cec
      Andy Soffer authored
      PiperOrigin-RevId: 286896167
    • Googletest export · a13a0626
      Abseil Team authored
      Add option (default to disabled) to make C++ type parameterized tests (TYPED_TEST_P) fail when they're not instantiated.
      
      When an un-instantiated TYPED_TEST_P is found, a new test will be inserted that emits a suitable message. For now, that is just a notice, but the hope it to flip the bit to make it fail by default.
      
      PiperOrigin-RevId: 286408038
    • Merge pull request #2624 from ShabbyX:master · 008629ae
      Andy Soffer authored
      PiperOrigin-RevId: 286397298
    • Googletest export · d0a52125
      Abseil Team authored
      Use C++11 variadic templates for InvokeArgumentAdl in gmock-generated-actions.h.
      
      Make InvokeArgumentAdl use variadic templates to generate its overloads instead
      of using pump.py syntax.
      
      PiperOrigin-RevId: 286267615
    • Googletest export · 6f1a8ffd
      Abseil Team authored
      Use C++11 variadic templates for InvokeArgumentAdl in gmock-generated-actions.h.
      
      Make InvokeArgumentAdl use variadic templates to generate its overloads instead
      of using pump.py syntax.
      
      PiperOrigin-RevId: 286148805
  9. 20 Dec, 2019 4 commits
  10. 17 Dec, 2019 1 commit
  11. 16 Dec, 2019 5 commits
    • Merge pull request #2590 from kuzkry:remove-workaround_g++-stale-comments · d166e094
      CJ Johnson authored
      PiperOrigin-RevId: 285812343
    • Googletest export · 0a0c8266
      krzysio authored
      Don't use fully qualified ::std types in code examples.
      
      Having a nested user-defined 'std' namespace anywhere in a program is a minefield and shouldn't be either explicitly supported or implicitly condoned.
      
      PiperOrigin-RevId: 285790182
    • Revert "Googletest export": disallow empty prefix · 1800a38f
      Shahbaz Youssefi authored
      This reverts commit 20b5b8ec.
      Reason for revert: Breaks existing applications, such as ANGLE
      (angleproject.org), requires adding an extra prefix that needs to be
      typed for no reason (when testing from command line) and increases the
      logs' sizes by a non-trivial amount due to the very large number of
      tests ANGLE runs.
      
      Original commit message:
      
          Add a compile time check to ensure that the parameters to TEST_P and
          INSTANTIATE_TEST_SUITE_P are not empty. Some compilers already fail
          in that case and, even where it works, it's likely to result in
          technically invalid code by virtue of creating reserved identifiers:
          https://en.cppreference.com/w/cpp/language/identifiers
      
      First, every project is perfectly capable of adding a prefix if they
      want to support such a compiler. This change penalizes every
      project.
      
      Second, using a prefix such as `_p` also results in reserved
      identifiers, so this change is not really solving the problem.  For that
      matter, instead of generating `gtest_##prefix##...`, you can generate
      `gtest_x##prefix##...` to correctly fix the issue, including when empty
      prefixes are used.
    • Revert "Googletest export": Remove test for empty prefix · 4b7809c2
      Shahbaz Youssefi authored
      This reverts commit 4c25e2b8.
      Reason for revert: Reverting the commit that disallows empty prefixes.
      
      Original commit message:
      
          Remove a test case rendered obsolete by disallowing empty argument for INSTANTIATE_TEST_SUITE_P.
          Remove the code that it was testing.
    • Workaround VS bug w.r.t empty arguments to macros · d2016469
      Shahbaz Youssefi authored
      Empty arguments can be passed to macros per C99 and C++11 specs, which
      can then be forwarded to other macros.
      
      Visual Studio's compiler has a bug in the following situation:
      
          #define A(x) #x
          #define B(x, y) A(x)
          B(, b)
      
      In the above case, Visual Studio first expands x to nothing, then
      complains that A is not invoked with the right amount of arguments.
      However, x in A(x) is still one argument, even if it expands to no
      preprocessing tokens.  See also https://stackoverflow.com/a/7674214.
  12. 13 Dec, 2019 2 commits