commands: don't fail if unfreeze fails

We can e.g. fail the unfreeze because the freezer cgroup is not available and then we erronously report that stopping the container failed. Closes: #3471. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

commands: don't fail if unfreeze fails
422820d5 · Christian Brauner · f59f2f9e · 422820d5
Unverified Commit 422820d5 authored Sep 17, 2020 by Christian Brauner
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 5 deletions

commands.c src/lxc/commands.c +4 -5

No files found.
--- a/src/lxc/commands.c
+++ b/src/lxc/commands.c
@@ -894,12 +894,11 @@ static int lxc_cmd_stop_callback(int fd, struct lxc_cmd_req *req,
 		else
 			TRACE("Sent signal %d to pidfd %d", stopsignal, handler->pid);

-		rsp.ret = cgroup_ops->unfreeze(cgroup_ops, -1);
-		if (!rsp.ret)
-			return 0;
+		ret = cgroup_ops->unfreeze(cgroup_ops, -1);
+		if (ret)
+			WARN("Failed to unfreeze container \"%s\"", handler->name);

-		ERROR("Failed to unfreeze container \"%s\"", handler->name);
-		rsp.ret = -errno;
+		return 0;
 	} else {
 		rsp.ret = -errno;
 	}