Skip to content

L
lxc
Unverified Commit 422820d5 by Christian Brauner
Options

commands: don't fail if unfreeze fails

We can e.g. fail the unfreeze because the freezer cgroup is not available and then we erronously report that stopping the container failed. Closes: #3471. Signed-off-by: 's avatarChristian Brauner <christian.brauner@ubuntu.com>
parent f59f2f9e
Showing with 4 additions and 5 deletions
src/lxc/commands.c
...@@ -894,12 +894,11 @@ static int lxc_cmd_stop_callback(int fd, struct lxc_cmd_req *req, ...@@ -894,12 +894,11 @@ static int lxc_cmd_stop_callback(int fd, struct lxc_cmd_req *req,
else else
TRACE("Sent signal %d to pidfd %d", stopsignal, handler->pid); TRACE("Sent signal %d to pidfd %d", stopsignal, handler->pid);
rsp.ret = cgroup_ops->unfreeze(cgroup_ops, -1); ret = cgroup_ops->unfreeze(cgroup_ops, -1);
if (!rsp.ret) if (ret)
return 0; WARN("Failed to unfreeze container \"%s\"", handler->name);
ERROR("Failed to unfreeze container \"%s\"", handler->name); return 0;
rsp.ret = -errno;
} else { } else {
rsp.ret = -errno; rsp.ret = -errno;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment