Merge pull request #2358 from brauner/2018-05-28/do_not_init_ns_clone_flags

src/lxc/conf.c

@@ -968,6 +968,8 @@ int lxc_allocate_ttys(const char *name, struct lxc_conf *conf)
 	for (i = 0; i < ttys->max; i++) {
 		struct lxc_terminal_info *tty = &ttys->tty[i];
 
+		tty->master = -EBADF;
+		tty->slave = -EBADF;
 		ret = openpty(&tty->master, &tty->slave,
 			      tty->name, NULL, NULL);
 		if (ret) {
@@ -1004,11 +1006,21 @@ void lxc_delete_tty(struct lxc_tty_info *ttys)
 {
 	int i;
 
+	if (!ttys->tty)
+		return;
+
 	for (i = 0; i < ttys->max; i++) {
 		struct lxc_terminal_info *tty = &ttys->tty[i];
 
-		close(tty->master);
-		close(tty->slave);
+		if (tty->master >= 0) {
+			close(tty->master);
+			tty->master = -EBADF;
+		}
+
+		if (tty->slave >= 0) {
+			close(tty->slave);
+			tty->slave = -EBADF;
+		}
 	}
 
 	free(ttys->tty);

src/lxc/start.c

@@ -619,8 +619,6 @@ void lxc_zero_handler(struct lxc_handler *handler)
 
 	memset(handler, 0, sizeof(struct lxc_handler));
 
-	handler->ns_clone_flags = -1;
-
 	handler->pinfd = -1;
 
 	handler->sigfd = -1;