coverity: Check fcntl return value

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com> Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>

coverity: Check fcntl return value
71b2940d · Stéphane Graber · acd4922e · 71b2940d
Commit 71b2940d authored Feb 14, 2014 by Stéphane Graber
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

attach.c src/lxc/attach.c +5 -2

No files found.
--- a/src/lxc/attach.c
+++ b/src/lxc/attach.c
@@ -1026,8 +1026,11 @@ static int attach_child_main(void* data)
 		flags = fcntl(fd, F_GETFL);
 		if (flags < 0)
 			continue;
-		if (flags & FD_CLOEXEC)
-			fcntl(fd, F_SETFL, flags & ~FD_CLOEXEC);
+		if (flags & FD_CLOEXEC) {
+			if (fcntl(fd, F_SETFL, flags & ~FD_CLOEXEC) < 0) {
+				SYSERROR("Unable to clear CLOEXEC from fd");
+			}
+		}
 	}

 	/* we're done, so we can now do whatever the user intended us to do */