Commits · 2caf13c3ffca4caabd04cdb2f312a5dd56c2c8ca · Chen Yisong / lxc

19 Oct, 2018 10 commits
- parse: fix uninitialized value · 2caf13c3
  2xsec authored Oct 19, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
  2caf13c3
- parse: protect against config updates during parse · d2757b4e
  Christian Brauner authored Oct 17, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  d2757b4e
- confile: fix append_unexp_config_line() · b9144ed2
  Christian Brauner authored Oct 17, 2018
```
Reported-by: 2xsec dh48.jeong@samsung.com
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  b9144ed2
- raw_syscalls: ensure function always returns value · f50a0b96
  Christian Brauner authored Oct 18, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  f50a0b96
- include: simplify strlcpy() · 2dd96b2d
  Christian Brauner authored Oct 18, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  2dd96b2d
- string_utils: fix global buffer overflow issue · 84f69331
  2xsec authored Oct 18, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
  84f69331
- autotools: fix --disable-commands builds · 6ca9fedb
  Christian Brauner authored Oct 17, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  6ca9fedb
- lxc-init: log to /dev/console · 40611df4
  Christian Brauner authored Oct 14, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  40611df4
- checkconfig: Handle missing kernel version · 4102a24f
  Stéphane Graber authored Oct 12, 2018
```
https://github.com/lxc/lxd/issues/5151Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
```
  4102a24f
- autools: use -fno-strict-aliasing · 501636c9
  Christian Brauner authored Oct 12, 2018
```
The gcc implementation and the C standard are not to be considered sane
in this respect. We don't want to risk reordering of writes when the
compiler incorrectly *thinks* two types do not alias each other.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  501636c9
12 Oct, 2018 11 commits

monitor: fix coding standard · 97e7f575
2xsec authored Oct 12, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
97e7f575
commands_utils: improve code redundancy to make abstract unix socket name · c8b502f0
2xsec authored Oct 12, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
c8b502f0
monitor: checking name too long to make monitor sock name · 4409a533
2xsec authored Oct 12, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
4409a533
monitor: log cleanups · 05ba40f0
2xsec authored Oct 12, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
05ba40f0

checkpoint: fix running do_dump() · e2965240

authored Oct 11, 2018

Testing 'lxc <container> stop --stateful' crashed LXD:

fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x1 addr=0xe8 pc=0x7f3198ff0592]

runtime stack:
runtime.throw(0x117fe4a, 0x2a)
	/opt/rh/go-toolset-1.10/root/usr/lib/go-toolset-1.10-golang/src/runtime/panic.go:616 +0x81
runtime.sigpanic()
	/opt/rh/go-toolset-1.10/root/usr/lib/go-toolset-1.10-golang/src/runtime/signal_unix.go:372 +0x28e

goroutine 375 [syscall]:
runtime.cgocall(0xef38e3, 0xc420731630, 0x29)
	/opt/rh/go-toolset-1.10/root/usr/lib/go-toolset-1.10-golang/src/runtime/cgocall.go:128 +0x64 fp=0xc4207315f0 sp=0xc4207315b8 pc=0x410fc4
gopkg.in/lxc/go-lxc%2ev2._Cfunc_go_lxc_migrate(0x7f316c001220, 0xc400000001, 0xc420302460, 0xc4205d6080, 0x0)
	_cgo_gotypes.go:752 +0x4d fp=0xc420731630 sp=0xc4207315f0 pc=0x909d7d
gopkg.in/lxc/go-lxc%2ev2.(*Container).Migrate.func4(0x7f316c001220, 0xc400000001, 0xc420302460, 0xc4205d6080, 0x0)
	/share/go/src/gopkg.in/lxc/go-lxc.v2/container.go:1798 +0x160 fp=0xc420731668 sp=0xc420731630 pc=0x91b970
gopkg.in/lxc/go-lxc%2ev2.(*Container).Migrate(0xc4207a52f0, 0x1, 0xc42051ec00, 0x20, 0x0, 0x0, 0x0, 0x0, 0x101, 0x10000000, ...)
	/share/go/src/gopkg.in/lxc/go-lxc.v2/container.go:1798 +0x29f fp=0xc420731760 sp=0xc420731668 pc=0x9160ef

The commit 5a087e05 introduced a second parameter (conf) to the
cgroup escape() function which was never set in do_dump(). Instead of
taking it from opts->handler->conf it is now used from c->lxc_conf.

Fixes: 5a087e05 ("cgroups: don't escape if lxc.cgroup.keep is true")
Suggested-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>

e2965240

conf: verify_start_hooks() after lxc.mount.entry · 427fe98a

authored Oct 10, 2018

Fixes: https://discuss.linuxcontainers.org/t/are-lxc-mount-entry-available-when-lxc-hook-start-is-validated/2906/3Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

427fe98a

conf: log prlimit setup · e0af2046
Christian Brauner authored Oct 10, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
e0af2046
fix post section script error for rpm install · ff69eaad
2xsec authored Oct 10, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
ff69eaad
fix rpm packaging error for static library · 6fc19f8a
2xsec authored Oct 10, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
6fc19f8a
parse: fix uninitialized pointer access · 8edd79b1
2xsec authored Oct 10, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
8edd79b1
confile: remove unused variable · d2af43e5
2xsec authored Oct 10, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
d2af43e5

08 Oct, 2018 8 commits

test: test invalid config keys · 491b2304
Christian Brauner authored Oct 08, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
491b2304
parse: do not mask failed parse · a284d9d5
Christian Brauner authored Oct 08, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
a284d9d5

netns_ifaddrs: check for NETLINK_DUMP_STRICT_CHK · 929a141a

authored Oct 08, 2018

Make use of the new socket option, NETLINK_DUMP_STRICT_CHK, that
userspace can use via setsockopt to request strict checking of headers
and attributes on dump requests.

To get dump features such as kernel side filtering based on data in
the header or attributes appended to the dump request, userspace
must call setsockopt() for NETLINK_DUMP_STRICT_CHK and a non-zero
value. This is necessary to make use of the IFA_TARGET_NETNSID property.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

929a141a

macro: add SOL_NETLINK · fb824214

authored Oct 08, 2018

This allows to set netlink socket properties.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

fb824214

macro: add NETLINK_DUMP_STRICT_CHK · d69f3f4f

authored Oct 08, 2018

This adds support for the new socket option, NETLINK_DUMP_STRICT_CHK,
that userspace can use via setsockopt to request strict checking of
headers and attributes on dump requests.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

d69f3f4f

attach: fix missing pthread.h include · 69fdc46b
Christian Brauner authored Oct 08, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
69fdc46b
file_utils: fix too wide or inconsistent non-owner permissions · 445b885f
2xsec authored Oct 08, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
445b885f
start: change log level · 8e5264e8
2xsec authored Oct 08, 2018
```
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
```
8e5264e8

07 Oct, 2018 11 commits
- attach: reset signal mask · 8f03ee12
  Christian Brauner authored Oct 07, 2018
```
Since we introduced clean exit from the mainloop when SIGTERM is sent we
changed the signal mask of the parent process but we never reset the
signal mask for the actual attached process.

Closes #399.

Fixes: 1349e92e ("console: exit mainloop on SIGTERM")
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  8f03ee12
- tools: s/MAXPATHLEN/PATH_MAX/g · 1141d9fe
  Christian Brauner authored Oct 07, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1141d9fe
- storage: s/MAXPATHLEN/PATH_MAX/g · dc815306
  Christian Brauner authored Oct 07, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  dc815306
- utils: s/MAXPATHLEN/PATH_MAX/g · 3e2f74b7
  Christian Brauner authored Oct 07, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  3e2f74b7
- terminal: s/MAXPATHLEN/PATH_MAX/g · 1d11cb68
  Christian Brauner authored Oct 07, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1d11cb68
- start: s/MAXPATHLEN/PATH_MAX/g · 1963eb8a
  Christian Brauner authored Oct 07, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  1963eb8a
- pam: s/MAXPATHLEN/PATH_MAX/g · 09c4da07
  Christian Brauner authored Oct 07, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  09c4da07
- network: s/MAXPATHLEN/PATH_MAX/g · 9f423d09
  Christian Brauner authored Oct 07, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  9f423d09
- macro: s/MAXPATHLEN/PATH_MAX/g · bb2249df
  Christian Brauner authored Oct 07, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  bb2249df
- lxccontainer: s/MAXPATHLEN/PATH_MAX/g · 22601d54
  Christian Brauner authored Oct 07, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  22601d54
- log: s/MAXPATHLEN/PATH_MAX/g · 309ba3c8
  Christian Brauner authored Oct 07, 2018
```
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
```
  309ba3c8